René's URL Explorer Experiment


Title: feat(modals): Enable modal dialog chaining in IOS by vakrilov · Pull Request #6637 · NativeScript/NativeScript · GitHub

Open Graph Title: feat(modals): Enable modal dialog chaining in IOS by vakrilov · Pull Request #6637 · NativeScript/NativeScript

X Title: feat(modals): Enable modal dialog chaining in IOS by vakrilov · Pull Request #6637 · NativeScript/NativeScript

Description: What is the current behavior? The closeCallback for modals in IOS is fired before the dialog is closed. If you try to open another dialog in the callback - it fails because the previous dialog is s...

Open Graph Description: What is the current behavior? The closeCallback for modals in IOS is fired before the dialog is closed. If you try to open another dialog in the callback - it fails because the previous dialog is s...

X Description: What is the current behavior? The closeCallback for modals in IOS is fired before the dialog is closed. If you try to open another dialog in the callback - it fails because the previous dialog is s...

Opengraph URL: https://github.com/NativeScript/NativeScript/pull/6637

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:a5d89ebc-51eb-0e0d-153b-429e90ddd6da
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA1C2:14965D:297A9CE:3964CF7:69729F7C
html-safe-nonce81df8fd78d1582c7cd51fd2e2ae410f5fa2f6afe439d872993cb3675610ddfc7
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMUMyOjE0OTY1RDoyOTdBOUNFOjM5NjRDRjc6Njk3MjlGN0MiLCJ2aXNpdG9yX2lkIjoiNjg3MTY5Mzk1NDQ3MTA3NTcwOCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmaceed3d4244eb956dc0796bd5ed6cf7516eb50d6af8c2cebd123faf774ca3a1987
hovercard-subject-tagpull_request:234413776
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/NativeScript/NativeScript/6637/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/9603a6325bdff7d8ebbb53f126330b7a7afa5091c81cb018b6f31777c8aafcf9/NativeScript/NativeScript/pull/6637
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/9603a6325bdff7d8ebbb53f126330b7a7afa5091c81cb018b6f31777c8aafcf9/NativeScript/NativeScript/pull/6637
og:image:altWhat is the current behavior? The closeCallback for modals in IOS is fired before the dialog is closed. If you try to open another dialog in the callback - it fails because the previous dialog is s...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamevakrilov
hostnamegithub.com
expected-hostnamegithub.com
None72bb1c46bb1ebdc0dc83a0a57b64c3b4d668c125d1125d94898213a4c9db8da2
turbo-cache-controlno-preview
go-importgithub.com/NativeScript/NativeScript git https://github.com/NativeScript/NativeScript.git
octolytics-dimension-user_id7392261
octolytics-dimension-user_loginNativeScript
octolytics-dimension-repository_id31492490
octolytics-dimension-repository_nwoNativeScript/NativeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id31492490
octolytics-dimension-repository_network_root_nwoNativeScript/NativeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasee746f1a3ddb5c0a91290ff3d5889b5247e0e519e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/NativeScript/NativeScript/pull/6637#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNativeScript%2FNativeScript%2Fpull%2F6637
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNativeScript%2FNativeScript%2Fpull%2F6637
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=NativeScript%2FNativeScript
Reloadhttps://github.com/NativeScript/NativeScript/pull/6637
Reloadhttps://github.com/NativeScript/NativeScript/pull/6637
Reloadhttps://github.com/NativeScript/NativeScript/pull/6637
NativeScript https://github.com/NativeScript
NativeScripthttps://github.com/NativeScript/NativeScript
Please reload this pagehttps://github.com/NativeScript/NativeScript/pull/6637
Notifications https://github.com/login?return_to=%2FNativeScript%2FNativeScript
Fork 1.7k https://github.com/login?return_to=%2FNativeScript%2FNativeScript
Star 25.4k https://github.com/login?return_to=%2FNativeScript%2FNativeScript
Code https://github.com/NativeScript/NativeScript
Issues 869 https://github.com/NativeScript/NativeScript/issues
Pull requests 59 https://github.com/NativeScript/NativeScript/pulls
Discussions https://github.com/NativeScript/NativeScript/discussions
Actions https://github.com/NativeScript/NativeScript/actions
Projects 0 https://github.com/NativeScript/NativeScript/projects
Wiki https://github.com/NativeScript/NativeScript/wiki
Security 0 https://github.com/NativeScript/NativeScript/security
Insights https://github.com/NativeScript/NativeScript/pulse
Code https://github.com/NativeScript/NativeScript
Issues https://github.com/NativeScript/NativeScript/issues
Pull requests https://github.com/NativeScript/NativeScript/pulls
Discussions https://github.com/NativeScript/NativeScript/discussions
Actions https://github.com/NativeScript/NativeScript/actions
Projects https://github.com/NativeScript/NativeScript/projects
Wiki https://github.com/NativeScript/NativeScript/wiki
Security https://github.com/NativeScript/NativeScript/security
Insights https://github.com/NativeScript/NativeScript/pulse
Sign up for GitHub https://github.com/signup?return_to=%2FNativeScript%2FNativeScript%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FNativeScript%2FNativeScript%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/NativeScript/NativeScript/pull/6637#issue-comment-box
dtopuzovhttps://github.com/dtopuzov
masterhttps://github.com/NativeScript/NativeScript/tree/master
async-modalshttps://github.com/NativeScript/NativeScript/tree/async-modals
feat(modals): Enable modal dialog chaining in IOS https://github.com/NativeScript/NativeScript/pull/6637#top
dtopuzovhttps://github.com/dtopuzov
masterhttps://github.com/NativeScript/NativeScript/tree/master
async-modalshttps://github.com/NativeScript/NativeScript/tree/async-modals
Conversation 3 https://github.com/NativeScript/NativeScript/pull/6637
Commits 4 https://github.com/NativeScript/NativeScript/pull/6637/commits
Checks 0 https://github.com/NativeScript/NativeScript/pull/6637/checks
Files changed https://github.com/NativeScript/NativeScript/pull/6637/files
Please reload this pagehttps://github.com/NativeScript/NativeScript/pull/6637
https://github.co/hiddenchars
https://github.com/NativeScript/NativeScript/pull/{{ revealButtonHref }}
https://github.com/vakrilov
vakrilovhttps://github.com/vakrilov
Nov 28, 2018https://github.com/NativeScript/NativeScript/pull/6637#issue-385443856
#5744https://github.com/NativeScript/NativeScript/issues/5744
#6370https://github.com/NativeScript/NativeScript/pull/6370
Please reload this pagehttps://github.com/NativeScript/NativeScript/pull/6637
feat(modals): fire close callback after close in IOShttps://github.com/NativeScript/NativeScript/pull/6637/commits/7da5aeb56b2a1053d36dbae74b24ee78757c7a95
7da5aebhttps://github.com/NativeScript/NativeScript/pull/6637/commits/7da5aeb56b2a1053d36dbae74b24ee78757c7a95
https://github.com/vakrilov
vakrilovhttps://github.com/vakrilov
e2e test needed https://github.com/NativeScript/NativeScript/issues?q=state%3Aopen%20label%3A%22e2e%20test%20needed%22
Nov 28, 2018https://github.com/NativeScript/NativeScript/pull/6637#event-1993514555
vakrilovhttps://github.com/vakrilov
Nov 28, 2018https://github.com/NativeScript/NativeScript/pull/6637#event-1993514626
in progress https://github.com/NativeScript/NativeScript/issues?q=state%3Aopen%20label%3A%22in%20progress%22
Nov 28, 2018https://github.com/NativeScript/NativeScript/pull/6637#event-1993514631
https://github.com/vakrilov
vakrilovhttps://github.com/vakrilov
MartoYankovhttps://github.com/MartoYankov
November 28, 2018 20:29https://github.com/NativeScript/NativeScript/pull/6637#event-1993514667
https://github.com/ns-bot
ns-bothttps://github.com/ns-bot
cla: yes https://github.com/NativeScript/NativeScript/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
Nov 28, 2018https://github.com/NativeScript/NativeScript/pull/6637#event-1993515055
Merge branch 'master' into async-modalshttps://github.com/NativeScript/NativeScript/pull/6637/commits/9968bfa67f0c192377f056d33d6dfc25c889b475
9968bfahttps://github.com/NativeScript/NativeScript/pull/6637/commits/9968bfa67f0c192377f056d33d6dfc25c889b475
https://github.com/dtopuzov
dtopuzovhttps://github.com/dtopuzov
Nov 29, 2018https://github.com/NativeScript/NativeScript/pull/6637#issuecomment-442767564
Please reload this pagehttps://github.com/NativeScript/NativeScript/pull/6637
https://github.com/MartoYankov
MartoYankovhttps://github.com/MartoYankov
Nov 29, 2018 https://github.com/NativeScript/NativeScript/pull/6637#pullrequestreview-179748913
View reviewed changes https://github.com/NativeScript/NativeScript/pull/6637/files/9968bfa67f0c192377f056d33d6dfc25c889b475
November 29, 2018 16:18https://github.com/NativeScript/NativeScript/pull/6637#commits-pushed-aad90fd
chore(tests): Fix some test depending on the order of eventshttps://github.com/NativeScript/NativeScript/pull/6637/commits/aad90fddeac9bba8189b0430042f45acbcea9949
aad90fdhttps://github.com/NativeScript/NativeScript/pull/6637/commits/aad90fddeac9bba8189b0430042f45acbcea9949
Merge branch 'master' into async-modalshttps://github.com/NativeScript/NativeScript/pull/6637/commits/b6f782d7f3f532346db38c06727d9ab75b057e31
b6f782dhttps://github.com/NativeScript/NativeScript/pull/6637/commits/b6f782d7f3f532346db38c06727d9ab75b057e31
https://github.com/dtopuzov
dtopuzovhttps://github.com/dtopuzov
64bccb9https://github.com/NativeScript/NativeScript/commit/64bccb9bbc675b8932499cb0b3a3aa49fd21ef80
Nov 30, 2018https://github.com/NativeScript/NativeScript/pull/6637#event-1997529909
in progress https://github.com/NativeScript/NativeScript/issues?q=state%3Aopen%20label%3A%22in%20progress%22
Nov 30, 2018https://github.com/NativeScript/NativeScript/pull/6637#event-1997530025
dtopuzovhttps://github.com/dtopuzov
Nov 30, 2018 https://github.com/NativeScript/NativeScript/pull/6637#ref-commit-f87c136
https://github.com/dtopuzov
chore: tests for modal dialog chaininghttps://github.com/NativeScript/functional-tests/commit/f87c136a20d22dff2aaa01ff69877067f062c79b
f87c136https://github.com/NativeScript/functional-tests/commit/f87c136a20d22dff2aaa01ff69877067f062c79b
NativeScript/NativeScript#6637https://github.com/NativeScript/NativeScript/pull/6637
https://github.com/vakrilov
vakrilovhttps://github.com/vakrilov
Dec 4, 2018 https://github.com/NativeScript/NativeScript/pull/6637#ref-pullrequest-387180157
fix(modals): regression with modals in angular #6655 https://github.com/NativeScript/NativeScript/pull/6655
https://github.com/SvetoslavTsenov
SvetoslavTsenovhttps://github.com/SvetoslavTsenov
e2e test needed https://github.com/NativeScript/NativeScript/issues?q=state%3Aopen%20label%3A%22e2e%20test%20needed%22
Mar 8, 2019https://github.com/NativeScript/NativeScript/pull/6637#event-2190147899
https://github.com/manoldonev
manoldonevhttps://github.com/manoldonev
March 22, 2019 09:38https://github.com/NativeScript/NativeScript/pull/6637#event-2222096364
https://github.com/two-bridges
two-bridgeshttps://github.com/two-bridges
Apr 28, 2019https://github.com/NativeScript/NativeScript/pull/6637#issuecomment-487332641
#5744https://github.com/NativeScript/NativeScript/issues/5744
#5744https://github.com/NativeScript/NativeScript/issues/5744
Please reload this pagehttps://github.com/NativeScript/NativeScript/pull/6637
https://github.com/MartoYankov
MartoYankovhttps://github.com/MartoYankov
Aug 6, 2019 https://github.com/NativeScript/NativeScript/pull/6637#ref-pullrequest-474150217
feat: add CSS classes to app/modal root views to target platform/device/orientation/type #7606 https://github.com/NativeScript/NativeScript/pull/7606
vchimevhttps://github.com/vchimev
Aug 18, 2019 https://github.com/NativeScript/NativeScript/pull/6637#ref-commit-417a999
https://github.com/vchimev
test(iOS): remove an unnecessary verificationhttps://github.com/NativeScript/NativeScript/commit/417a999cbbdeb2547d69ee9b58589673947d5105
417a999https://github.com/NativeScript/NativeScript/commit/417a999cbbdeb2547d69ee9b58589673947d5105
#6637https://github.com/NativeScript/NativeScript/pull/6637
https://github.com/apps/lock
lockhttps://github.com/apps/lock
May 5, 2020https://github.com/NativeScript/NativeScript/pull/6637#issuecomment-624340821
Please reload this pagehttps://github.com/NativeScript/NativeScript/pull/6637
https://github.com/apps/lock
lockhttps://github.com/apps/lock
May 5, 2020https://github.com/NativeScript/NativeScript/pull/6637#event-3306253938
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNativeScript%2FNativeScript%2Fpull%2F6637
https://github.com/MartoYankov
MartoYankov https://github.com/MartoYankov
https://github.com/NativeScript/NativeScript/pull/6637/files/9968bfa67f0c192377f056d33d6dfc25c889b475
https://github.com/vakrilov
vakrilov https://github.com/vakrilov
cla: yes https://github.com/NativeScript/NativeScript/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
iOS: issue when trying to chain modal pages within promise https://github.com/NativeScript/NativeScript/issues/5744
Please reload this pagehttps://github.com/NativeScript/NativeScript/pull/6637
https://github.com/vakrilov
https://github.com/dtopuzov
https://github.com/two-bridges
https://github.com/MartoYankov
https://github.com/SvetoslavTsenov
https://github.com/ns-bot
https://github.com/apps/copilot-swe-agent
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.