| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:f5d41221-4278-de6a-d44c-118ded2a32c7 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 976E:191380:C5F2B:10AE69:6973E1BE |
| html-safe-nonce | 988c6db2430cf3440e943a436b0523ad6b066e3b5ccce2ff566a33eca7a711ba |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NzZFOjE5MTM4MDpDNUYyQjoxMEFFNjk6Njk3M0UxQkUiLCJ2aXNpdG9yX2lkIjoiNzEzNTQ0ODM0NzA5MDA4NDI4NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | e64c461d679184d92cceb5ee7faaa1c1caa4e052e2c0f71b3fc3d107cd9e39d8 |
| hovercard-subject-tag | pull_request:221246419 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/NativeScript/NativeScript/6370/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/1e31b53c6ce0203df9272fd455c0070f55b4aed60932b423020c7da267549502/NativeScript/NativeScript/pull/6370 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/1e31b53c6ce0203df9272fd455c0070f55b4aed60932b423020c7da267549502/NativeScript/NativeScript/pull/6370 |
| og:image:alt | PR Checklist
The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/CONTRIBUTING.md#commit-messages.
There is an issue for the bug/feature this PR is for. ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | NathanWalker |
| hostname | github.com |
| expected-hostname | github.com |
| None | bcae444bf5f475d712cb2ad536c10eaebd406c84ae2d3a77c5f05aee5010c786 |
| turbo-cache-control | no-preview |
| go-import | github.com/NativeScript/NativeScript git https://github.com/NativeScript/NativeScript.git |
| octolytics-dimension-user_id | 7392261 |
| octolytics-dimension-user_login | NativeScript |
| octolytics-dimension-repository_id | 31492490 |
| octolytics-dimension-repository_nwo | NativeScript/NativeScript |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 31492490 |
| octolytics-dimension-repository_network_root_nwo | NativeScript/NativeScript |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 7da815895d8ce3ba55f0017efb5a34bac921756a |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/NativeScript/NativeScript/pull/6370#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNativeScript%2FNativeScript%2Fpull%2F6370 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNativeScript%2FNativeScript%2Fpull%2F6370 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=NativeScript%2FNativeScript |
| Reload | https://github.com/NativeScript/NativeScript/pull/6370 |
| Reload | https://github.com/NativeScript/NativeScript/pull/6370 |
| Reload | https://github.com/NativeScript/NativeScript/pull/6370 |
|
NativeScript
| https://github.com/NativeScript |
| NativeScript | https://github.com/NativeScript/NativeScript |
| Please reload this page | https://github.com/NativeScript/NativeScript/pull/6370 |
|
Notifications
| https://github.com/login?return_to=%2FNativeScript%2FNativeScript |
|
Fork
1.7k
| https://github.com/login?return_to=%2FNativeScript%2FNativeScript |
|
Star
25.4k
| https://github.com/login?return_to=%2FNativeScript%2FNativeScript |
|
Code
| https://github.com/NativeScript/NativeScript |
|
Issues
869
| https://github.com/NativeScript/NativeScript/issues |
|
Pull requests
59
| https://github.com/NativeScript/NativeScript/pulls |
|
Discussions
| https://github.com/NativeScript/NativeScript/discussions |
|
Actions
| https://github.com/NativeScript/NativeScript/actions |
|
Projects
0
| https://github.com/NativeScript/NativeScript/projects |
|
Wiki
| https://github.com/NativeScript/NativeScript/wiki |
|
Security
0
| https://github.com/NativeScript/NativeScript/security |
|
Insights
| https://github.com/NativeScript/NativeScript/pulse |
|
Code
| https://github.com/NativeScript/NativeScript |
|
Issues
| https://github.com/NativeScript/NativeScript/issues |
|
Pull requests
| https://github.com/NativeScript/NativeScript/pulls |
|
Discussions
| https://github.com/NativeScript/NativeScript/discussions |
|
Actions
| https://github.com/NativeScript/NativeScript/actions |
|
Projects
| https://github.com/NativeScript/NativeScript/projects |
|
Wiki
| https://github.com/NativeScript/NativeScript/wiki |
|
Security
| https://github.com/NativeScript/NativeScript/security |
|
Insights
| https://github.com/NativeScript/NativeScript/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2FNativeScript%2FNativeScript%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2FNativeScript%2FNativeScript%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/NativeScript/NativeScript/pull/6370#issue-comment-box |
| NathanWalker | https://github.com/NathanWalker |
| NativeScript:master | https://github.com/NativeScript/NativeScript/tree/master |
| NathanWalker:feat-ios-viewhierarchy-improvements | https://github.com/NathanWalker/NativeScript/tree/feat-ios-viewhierarchy-improvements |
|
fix(iOS): viewhierarchy stability with modals
| https://github.com/NativeScript/NativeScript/pull/6370#top |
| NathanWalker | https://github.com/NathanWalker |
| NativeScript:master | https://github.com/NativeScript/NativeScript/tree/master |
| NathanWalker:feat-ios-viewhierarchy-improvements | https://github.com/NathanWalker/NativeScript/tree/feat-ios-viewhierarchy-improvements |
|
Conversation
7
| https://github.com/NativeScript/NativeScript/pull/6370 |
|
Commits
1
| https://github.com/NativeScript/NativeScript/pull/6370/commits |
|
Checks
0
| https://github.com/NativeScript/NativeScript/pull/6370/checks |
|
Files changed
| https://github.com/NativeScript/NativeScript/pull/6370/files |
| Please reload this page | https://github.com/NativeScript/NativeScript/pull/6370 |
| https://github.co/hiddenchars |
| https://github.com/NativeScript/NativeScript/pull/{{ revealButtonHref }} |
|
| https://github.com/NathanWalker |
| NathanWalker | https://github.com/NathanWalker |
| Oct 8, 2018 | https://github.com/NativeScript/NativeScript/pull/6370#issue-367957104 |
| https://github.com/NativeScript/NativeScript/blob/master/CONTRIBUTING.md#commit-messages | https://github.com/NativeScript/NativeScript/blob/master/CONTRIBUTING.md#commit-messages |
| CLA | http://www.nativescript.org/cla |
| https://github.com/NativeScript/NativeScript/blob/master/DevelopmentWorkflow.md#running-unit-tests | https://github.com/NativeScript/NativeScript/blob/master/DevelopmentWorkflow.md#running-unit-tests |
| https://github.com/NativeScript/NativeScript/blob/master/WritingUnitTests.md | https://github.com/NativeScript/NativeScript/blob/master/WritingUnitTests.md |
| NativeScript/nativescript-angular#1546 | https://github.com/NativeScript/nativescript-angular/issues/1546 |
| Please reload this page | https://github.com/NativeScript/NativeScript/pull/6370 |
|
♥ community PR
| https://github.com/NativeScript/NativeScript/issues?q=state%3Aopen%20label%3A%22%E2%99%A5%20community%20PR%22 |
| Oct 8, 2018 | https://github.com/NativeScript/NativeScript/pull/6370#event-1891327074 |
| https://github.com/NathanWalker |
| NathanWalker | https://github.com/NathanWalker |
| Oct 8, 2018 | https://github.com/NativeScript/NativeScript/pull/6370#issuecomment-427983175 |
| Please reload this page | https://github.com/NativeScript/NativeScript/pull/6370 |
| https://github.com/ns-bot |
| ns-bot | https://github.com/ns-bot |
|
cla: yes
| https://github.com/NativeScript/NativeScript/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
| Oct 8, 2018 | https://github.com/NativeScript/NativeScript/pull/6370#event-1891334407 |
| https://github.com/NathanWalker |
| NathanWalker | https://github.com/NathanWalker |
| force-pushed | https://github.com/NativeScript/NativeScript/compare/c1309c61a1f2e298f76611732b03747e38c32f67..c238bc5e6779f7c26a1915eef920f6f04b92e8a2 |
| c1309c6 | https://github.com/NativeScript/NativeScript/commit/c1309c61a1f2e298f76611732b03747e38c32f67 |
| c238bc5 | https://github.com/NativeScript/NativeScript/commit/c238bc5e6779f7c26a1915eef920f6f04b92e8a2 |
|
Compare
| https://github.com/NativeScript/NativeScript/compare/c1309c61a1f2e298f76611732b03747e38c32f67..c238bc5e6779f7c26a1915eef920f6f04b92e8a2 |
| October 8, 2018 21:32 | https://github.com/NativeScript/NativeScript/pull/6370#event-1891347338 |
| https://github.com/NathanWalker |
| NathanWalker | https://github.com/NathanWalker |
| Oct 8, 2018 | https://github.com/NativeScript/NativeScript/pull/6370#issuecomment-427995439 |
| Please reload this page | https://github.com/NativeScript/NativeScript/pull/6370 |
| https://developer.apple.com/documentation/uikit/uiviewcontroller/1621505-dismissviewcontrolleranimated | https://developer.apple.com/documentation/uikit/uiviewcontroller/1621505-dismissviewcontrolleranimated |
| Please reload this page | https://github.com/NativeScript/NativeScript/pull/6370 |
| https://github.com/MartoYankov |
| MartoYankov | https://github.com/MartoYankov |
| Oct 9, 2018 | https://github.com/NativeScript/NativeScript/pull/6370#issuecomment-428146034 |
| @NathanWalker | https://github.com/NathanWalker |
| Please reload this page | https://github.com/NativeScript/NativeScript/pull/6370 |
| https://github.com/NathanWalker |
| NathanWalker | https://github.com/NathanWalker |
| Oct 9, 2018 | https://github.com/NativeScript/NativeScript/pull/6370#issuecomment-428337553 |
| @MartoYankov | https://github.com/MartoYankov |
| Please reload this page | https://github.com/NativeScript/NativeScript/pull/6370 |
|
| https://github.com/NathanWalker |
| fix(iOS): viewController stability for modal handling | https://github.com/NativeScript/NativeScript/pull/6370/commits/edb9566ff70926487a77cc6365c965d92ab8082c |
| edb9566 | https://github.com/NativeScript/NativeScript/pull/6370/commits/edb9566ff70926487a77cc6365c965d92ab8082c |
| https://github.com/NathanWalker |
| NathanWalker | https://github.com/NathanWalker |
| force-pushed | https://github.com/NativeScript/NativeScript/compare/c238bc5e6779f7c26a1915eef920f6f04b92e8a2..edb9566ff70926487a77cc6365c965d92ab8082c |
| c238bc5 | https://github.com/NativeScript/NativeScript/commit/c238bc5e6779f7c26a1915eef920f6f04b92e8a2 |
| edb9566 | https://github.com/NativeScript/NativeScript/commit/edb9566ff70926487a77cc6365c965d92ab8082c |
|
Compare
| https://github.com/NativeScript/NativeScript/compare/c238bc5e6779f7c26a1915eef920f6f04b92e8a2..edb9566ff70926487a77cc6365c965d92ab8082c |
| October 9, 2018 21:38 | https://github.com/NativeScript/NativeScript/pull/6370#event-1894030111 |
| https://github.com/vakrilov |
| vakrilov | https://github.com/vakrilov |
| MartoYankov | https://github.com/MartoYankov |
| Nov 20, 2018 | https://github.com/NativeScript/NativeScript/pull/6370#event-1977582844 |
| https://github.com/vakrilov |
| vakrilov | https://github.com/vakrilov |
| Nov 28, 2018 | https://github.com/NativeScript/NativeScript/pull/6370#issuecomment-442408753 |
| @NathanWalker | https://github.com/NathanWalker |
| dismissViewControllerAnimatedCompletion | https://developer.apple.com/documentation/uikit/uiviewcontroller/1621505-dismissviewcontrolleranimated |
| #5744 | https://github.com/NativeScript/NativeScript/issues/5744 |
| Here | https://github.com/NativeScript/NativeScript/tree/async-modals |
| dismissViewControllerAnimatedCompletion | https://github.com/NativeScript/NativeScript/commit/b28837cde73897e2347e1b6d3aec385230c2351a#diff-2775a71872c1630de8108bf058a1628eR438 |
| the test-app | https://github.com/NativeScript/NativeScript/commit/b28837cde73897e2347e1b6d3aec385230c2351a#diff-930d331ce60f8ce090318a4b2f1fb5efR26 |
| dismissViewControllerAnimatedCompletion | https://github.com/NativeScript/NativeScript/tree/async-modals |
| iOS: issue when trying to chain modal pages within promise #5744 | https://github.com/NativeScript/NativeScript/issues/5744 |
| Please reload this page | https://github.com/NativeScript/NativeScript/pull/6370 |
| https://github.com/vakrilov |
| vakrilov | https://github.com/vakrilov |
| Nov 28, 2018 | https://github.com/NativeScript/NativeScript/pull/6370#event-1992121701 |
|
♥ community PR
| https://github.com/NativeScript/NativeScript/issues?q=state%3Aopen%20label%3A%22%E2%99%A5%20community%20PR%22 |
| Nov 28, 2018 | https://github.com/NativeScript/NativeScript/pull/6370#event-1992121796 |
| https://github.com/NathanWalker |
| NathanWalker | https://github.com/NathanWalker |
| Nov 28, 2018 | https://github.com/NativeScript/NativeScript/pull/6370#issuecomment-442503000 |
| @vakrilov | https://github.com/vakrilov |
| Please reload this page | https://github.com/NativeScript/NativeScript/pull/6370 |
| https://github.com/vakrilov |
| vakrilov | https://github.com/vakrilov |
|
Nov 28, 2018
| https://github.com/NativeScript/NativeScript/pull/6370#ref-pullrequest-385443856 |
|
feat(modals): Enable modal dialog chaining in IOS
#6637
| https://github.com/NativeScript/NativeScript/pull/6637 |
| https://github.com/apps/lock |
| lock | https://github.com/apps/lock |
| Nov 28, 2019 | https://github.com/NativeScript/NativeScript/pull/6370#issuecomment-559556082 |
| Please reload this page | https://github.com/NativeScript/NativeScript/pull/6370 |
| https://github.com/apps/lock |
| lock | https://github.com/apps/lock |
| Nov 28, 2019 | https://github.com/NativeScript/NativeScript/pull/6370#event-2839510519 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNativeScript%2FNativeScript%2Fpull%2F6370 |
|
| https://github.com/MartoYankov |
|
MartoYankov
| https://github.com/MartoYankov |
|
cla: yes
| https://github.com/NativeScript/NativeScript/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
|
feat(modals): easier ViewContainerRef handling
| https://github.com/NativeScript/nativescript-angular/issues/1546 |
| Please reload this page | https://github.com/NativeScript/NativeScript/pull/6370 |
|
| https://github.com/NathanWalker |
|
| https://github.com/MartoYankov |
|
| https://github.com/vakrilov |
|
| https://github.com/ns-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |