Title: fix: Clear the "view" to avoid left over referenced once the View is detached and should be collected by GC by VladimirAmiorkov · Pull Request #6353 · NativeScript/NativeScript · GitHub
Open Graph Title: fix: Clear the "view" to avoid left over referenced once the View is detached and should be collected by GC by VladimirAmiorkov · Pull Request #6353 · NativeScript/NativeScript
X Title: fix: Clear the "view" to avoid left over referenced once the View is detached and should be collected by GC by VladimirAmiorkov · Pull Request #6353 · NativeScript/NativeScript
Description: PR Checklist The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/CONTRIBUTING.md#commit-messages. There is an issue for the bug/feature this PR is for. To avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it. You have signed the CLA. All existing tests are passing: https://github.com/NativeScript/NativeScript/blob/master/DevelopmentWorkflow.md#running-unit-tests. Tests for the changes are included - Due to having to profile the JS heap I am not sure how we can efficiently make a unit test for that What is the current behavior? When using the Angular createEmbeddeedView from the ViewContainerRef, after calling clear() the created NativeScript Views are left in the memory What is the new behavior? When using the Angular createEmbeddeedView from the ViewContainerRef, after calling clear() the created NativeScript Views are collected by the GC and a no longer in the memory Fixes/Implements/Closes #[Issue Number]. ProgressNS/nativescript-ui-feedback#825
Open Graph Description: PR Checklist The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/CONTRIBUTING.md#commit-messages. There is an issue for the bug/feature this PR is for. ...
X Description: PR Checklist The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/CONTRIBUTING.md#commit-messages. There is an issue for the bug/feature this PR is for. ...
Opengraph URL: https://github.com/NativeScript/NativeScript/pull/6353
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:dde28048-cc61-9db3-1e74-04d65d4714b7 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | AD0A:119AFD:42EBCD9:587B49A:69748EB2 |
| html-safe-nonce | 43c3e377dfbf0b81083bb4ca48cc733dcc891a93eb1b6b15470fd25f5351c6d9 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRDBBOjExOUFGRDo0MkVCQ0Q5OjU4N0I0OUE6Njk3NDhFQjIiLCJ2aXNpdG9yX2lkIjoiOTExNTM1Njc4OTQwNTQyMTIzNCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 1b98eb0df850c7955b825c0d5246f3e14758a15f4aa6f399695fbae5f3633293 |
| hovercard-subject-tag | pull_request:220386471 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/NativeScript/NativeScript/pull/6353/files |
| twitter:image | https://avatars.githubusercontent.com/u/4989411?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/4989411?s=400&v=4 |
| og:image:alt | PR Checklist The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/CONTRIBUTING.md#commit-messages. There is an issue for the bug/feature this PR is for. ... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 4a4bf5f4e28041a9d2e5c107d7d20b78b4294ba261cab243b28167c16a623a1f |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/NativeScript/NativeScript git https://github.com/NativeScript/NativeScript.git |
| octolytics-dimension-user_id | 7392261 |
| octolytics-dimension-user_login | NativeScript |
| octolytics-dimension-repository_id | 31492490 |
| octolytics-dimension-repository_nwo | NativeScript/NativeScript |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 31492490 |
| octolytics-dimension-repository_network_root_nwo | NativeScript/NativeScript |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 488b30e96dfd057fbbe44c6665ccbc030b729dde |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width