| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:18ca0de9-2402-910a-01ed-c930ffc090e0 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E3A4:36B82B:1C8455:279D15:6973AD4F |
| html-safe-nonce | 2bc1e4700d9303fdf4bce827fa97900d74502b5871413d6dab66c183ee05fbf5 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFM0E0OjM2QjgyQjoxQzg0NTU6Mjc5RDE1OjY5NzNBRDRGIiwidmlzaXRvcl9pZCI6IjcyMjkyMDM5MTQwNDM5Mjc4ODciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | b6e4f5784b05d5d0e6bf0f877ac30dda4a6d292a56351353257edc296c152da4 |
| hovercard-subject-tag | pull_request:203002563 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/NativeScript/NativeScript/6102/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/4978b4e9d260e6375b586d4ddcf3b1846084e7a16cd9aeb20db6eee31c61a877/NativeScript/NativeScript/pull/6102 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/4978b4e9d260e6375b586d4ddcf3b1846084e7a16cd9aeb20db6eee31c61a877/NativeScript/NativeScript/pull/6102 |
| og:image:alt | This PR propose a simple refactoring to make life easier for plugin developers.
I am writing a plugin which brings material components for iOS and Android.
in material-components, Google simply inh... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | farfromrefug |
| hostname | github.com |
| expected-hostname | github.com |
| None | 3e9aa9d0c22a21b13b378b4acd09f5dd4876a884425aacd32a9f473b84c8762d |
| turbo-cache-control | no-preview |
| go-import | github.com/NativeScript/NativeScript git https://github.com/NativeScript/NativeScript.git |
| octolytics-dimension-user_id | 7392261 |
| octolytics-dimension-user_login | NativeScript |
| octolytics-dimension-repository_id | 31492490 |
| octolytics-dimension-repository_nwo | NativeScript/NativeScript |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 31492490 |
| octolytics-dimension-repository_network_root_nwo | NativeScript/NativeScript |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 9240c0b5247c88bacc8dffb46ecac04c94fd094b |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/NativeScript/NativeScript/pull/6102#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNativeScript%2FNativeScript%2Fpull%2F6102 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNativeScript%2FNativeScript%2Fpull%2F6102 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=NativeScript%2FNativeScript |
| Reload | https://github.com/NativeScript/NativeScript/pull/6102 |
| Reload | https://github.com/NativeScript/NativeScript/pull/6102 |
| Reload | https://github.com/NativeScript/NativeScript/pull/6102 |
|
NativeScript
| https://github.com/NativeScript |
| NativeScript | https://github.com/NativeScript/NativeScript |
| Please reload this page | https://github.com/NativeScript/NativeScript/pull/6102 |
|
Notifications
| https://github.com/login?return_to=%2FNativeScript%2FNativeScript |
|
Fork
1.7k
| https://github.com/login?return_to=%2FNativeScript%2FNativeScript |
|
Star
25.4k
| https://github.com/login?return_to=%2FNativeScript%2FNativeScript |
|
Code
| https://github.com/NativeScript/NativeScript |
|
Issues
869
| https://github.com/NativeScript/NativeScript/issues |
|
Pull requests
59
| https://github.com/NativeScript/NativeScript/pulls |
|
Discussions
| https://github.com/NativeScript/NativeScript/discussions |
|
Actions
| https://github.com/NativeScript/NativeScript/actions |
|
Projects
0
| https://github.com/NativeScript/NativeScript/projects |
|
Wiki
| https://github.com/NativeScript/NativeScript/wiki |
|
Security
0
| https://github.com/NativeScript/NativeScript/security |
|
Insights
| https://github.com/NativeScript/NativeScript/pulse |
|
Code
| https://github.com/NativeScript/NativeScript |
|
Issues
| https://github.com/NativeScript/NativeScript/issues |
|
Pull requests
| https://github.com/NativeScript/NativeScript/pulls |
|
Discussions
| https://github.com/NativeScript/NativeScript/discussions |
|
Actions
| https://github.com/NativeScript/NativeScript/actions |
|
Projects
| https://github.com/NativeScript/NativeScript/projects |
|
Wiki
| https://github.com/NativeScript/NativeScript/wiki |
|
Security
| https://github.com/NativeScript/NativeScript/security |
|
Insights
| https://github.com/NativeScript/NativeScript/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2FNativeScript%2FNativeScript%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2FNativeScript%2FNativeScript%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/NativeScript/NativeScript/pull/6102#issue-comment-box |
| MartoYankov | https://github.com/MartoYankov |
| NativeScript:master | https://github.com/NativeScript/NativeScript/tree/master |
| Akylas:module_refactoring | https://github.com/Akylas/NativeScript/tree/module_refactoring |
|
refactor(core-modules): implement createNativeView and initNativeView for all components
| https://github.com/NativeScript/NativeScript/pull/6102#top |
| MartoYankov | https://github.com/MartoYankov |
| NativeScript:master | https://github.com/NativeScript/NativeScript/tree/master |
| Akylas:module_refactoring | https://github.com/Akylas/NativeScript/tree/module_refactoring |
|
Conversation
70
| https://github.com/NativeScript/NativeScript/pull/6102 |
|
Commits
42
| https://github.com/NativeScript/NativeScript/pull/6102/commits |
|
Checks
0
| https://github.com/NativeScript/NativeScript/pull/6102/checks |
|
Files changed
| https://github.com/NativeScript/NativeScript/pull/6102/files |
| Please reload this page | https://github.com/NativeScript/NativeScript/pull/6102 |
| https://github.co/hiddenchars |
| https://github.com/NativeScript/NativeScript/pull/{{ revealButtonHref }} |
|
| https://github.com/farfromrefug |
| farfromrefug | https://github.com/farfromrefug |
| Jul 21, 2018 | https://github.com/NativeScript/NativeScript/pull/6102#issue-343313738 |
| Please reload this page | https://github.com/NativeScript/NativeScript/pull/6102 |
| plugin | https://github.com/Akylas/nativescript-material-components |
| material-components | https://github.com/material-components |
| iOS label | https://github.com/Nativescript/NativeScript/blob/master/tns-core-modules/ui/label/label.ios.ts#L29 |
| https://github.com/NativeScript/NativeScript/blob/master/CONTRIBUTING.md#commit-messages | https://github.com/NativeScript/NativeScript/blob/master/CONTRIBUTING.md#commit-messages |
| CLA | http://www.nativescript.org/cla |
| https://github.com/NativeScript/NativeScript/blob/master/DevelopmentWorkflow.md#running-unit-tests | https://github.com/NativeScript/NativeScript/blob/master/DevelopmentWorkflow.md#running-unit-tests |
| https://github.com/NativeScript/NativeScript/blob/master/WritingUnitTests.md | https://github.com/NativeScript/NativeScript/blob/master/WritingUnitTests.md |
| Please reload this page | https://github.com/NativeScript/NativeScript/pull/6102 |
| farfromrefug | https://github.com/farfromrefug |
| July 20, 2018 19:11 | https://github.com/NativeScript/NativeScript/pull/6102#commits-pushed-ac28aed |
|
| https://github.com/farfromrefug |
| define and use nativeTextViewProtected for all text configuration rel… | https://github.com/NativeScript/NativeScript/pull/6102/commits/ac28aeda18444d26a256d9fa5e735e37f1fbff21 |
| ac28aed | https://github.com/NativeScript/NativeScript/pull/6102/commits/ac28aeda18444d26a256d9fa5e735e37f1fbff21 |
|
| https://github.com/farfromrefug |
| separate createNativeView from nativeview delegate creations | https://github.com/NativeScript/NativeScript/pull/6102/commits/bb67da7063fd1532ed9811f6b6ad0815143b4a72 |
| bb67da7 | https://github.com/NativeScript/NativeScript/pull/6102/commits/bb67da7063fd1532ed9811f6b6ad0815143b4a72 |
|
♥ community PR
| https://github.com/NativeScript/NativeScript/issues?q=state%3Aopen%20label%3A%22%E2%99%A5%20community%20PR%22 |
| Jul 21, 2018 | https://github.com/NativeScript/NativeScript/pull/6102#event-1746026779 |
|
| https://github.com/farfromrefug |
| Merge branch 'master' of github.com:NativeScript/NativeScript into mo… | https://github.com/NativeScript/NativeScript/pull/6102/commits/194231e34e2d8dba86eaa1a0caac81f387f6a0ae |
| 194231e | https://github.com/NativeScript/NativeScript/pull/6102/commits/194231e34e2d8dba86eaa1a0caac81f387f6a0ae |
| https://github.com/ns-bot |
| ns-bot | https://github.com/ns-bot |
|
cla: yes
| https://github.com/NativeScript/NativeScript/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
| Jul 21, 2018 | https://github.com/NativeScript/NativeScript/pull/6102#event-1746027206 |
| farfromrefug | https://github.com/farfromrefug |
| July 21, 2018 11:42 | https://github.com/NativeScript/NativeScript/pull/6102#commits-pushed-5839cb5 |
|
| https://github.com/farfromrefug |
| fixed lint error | https://github.com/NativeScript/NativeScript/pull/6102/commits/5839cb5e5edcd55435ca86d31dacd2f28a880f1b |
| 5839cb5 | https://github.com/NativeScript/NativeScript/pull/6102/commits/5839cb5e5edcd55435ca86d31dacd2f28a880f1b |
|
| https://github.com/farfromrefug |
| button refactoring | https://github.com/NativeScript/NativeScript/pull/6102/commits/5bad5f6e2f4c9d1dbb38b18f10cf4d12deecb19f |
| 5bad5f6 | https://github.com/NativeScript/NativeScript/pull/6102/commits/5bad5f6e2f4c9d1dbb38b18f10cf4d12deecb19f |
|
| https://github.com/farfromrefug |
| better that way? | https://github.com/NativeScript/NativeScript/pull/6102/commits/db752b18f1e14e4d5ba890f8dafd9975c749a3b8 |
| db752b1 | https://github.com/NativeScript/NativeScript/pull/6102/commits/db752b18f1e14e4d5ba890f8dafd9975c749a3b8 |
| https://github.com/SvetoslavTsenov |
| SvetoslavTsenov | https://github.com/SvetoslavTsenov |
| Jul 23, 2018 | https://github.com/NativeScript/NativeScript/pull/6102#issuecomment-407004480 |
| Please reload this page | https://github.com/NativeScript/NativeScript/pull/6102 |
| https://github.com/farfromrefug |
| farfromrefug | https://github.com/farfromrefug |
| Jul 23, 2018 | https://github.com/NativeScript/NativeScript/pull/6102#issuecomment-407038691 |
| @SvetoslavTsenov | https://github.com/SvetoslavTsenov |
| Please reload this page | https://github.com/NativeScript/NativeScript/pull/6102 |
| https://github.com/SvetoslavTsenov |
| SvetoslavTsenov | https://github.com/SvetoslavTsenov |
| Jul 23, 2018 | https://github.com/NativeScript/NativeScript/pull/6102#issuecomment-407046645 |
| @farfromrefug | https://github.com/farfromrefug |
| Please reload this page | https://github.com/NativeScript/NativeScript/pull/6102 |
| farfromrefug | https://github.com/farfromrefug |
| July 24, 2018 10:19 | https://github.com/NativeScript/NativeScript/pull/6102#commits-pushed-24b8f38 |
|
| https://github.com/farfromrefug |
| fixed ios view creation as createNativeView is not fully supported on… | https://github.com/NativeScript/NativeScript/pull/6102/commits/24b8f3826bfd524ef684e46849f73c391d210452 |
| 24b8f38 | https://github.com/NativeScript/NativeScript/pull/6102/commits/24b8f3826bfd524ef684e46849f73c391d210452 |
|
| https://github.com/farfromrefug |
| Merge branch 'master' of github.com:NativeScript/NativeScript into mo… | https://github.com/NativeScript/NativeScript/pull/6102/commits/0fb47fad250b014435a5b1f0a195255741329c22 |
| 0fb47fa | https://github.com/NativeScript/NativeScript/pull/6102/commits/0fb47fad250b014435a5b1f0a195255741329c22 |
| https://github.com/farfromrefug |
| farfromrefug | https://github.com/farfromrefug |
| Jul 24, 2018 | https://github.com/NativeScript/NativeScript/pull/6102#issuecomment-407322957 |
| @SvetoslavTsenov | https://github.com/SvetoslavTsenov |
| Please reload this page | https://github.com/NativeScript/NativeScript/pull/6102 |
| https://github.com/farfromrefug |
| farfromrefug | https://github.com/farfromrefug |
| Jul 24, 2018 | https://github.com/NativeScript/NativeScript/pull/6102#issuecomment-407528050 |
| @SvetoslavTsenov | https://github.com/SvetoslavTsenov |
| Please reload this page | https://github.com/NativeScript/NativeScript/pull/6102 |
|
| https://github.com/farfromrefug |
| prevent undefined error | https://github.com/NativeScript/NativeScript/pull/6102/commits/58fc92c683baf649df46f6dd43e75ae7feb06a36 |
| 58fc92c | https://github.com/NativeScript/NativeScript/pull/6102/commits/58fc92c683baf649df46f6dd43e75ae7feb06a36 |
| https://github.com/MartoYankov |
| MartoYankov | https://github.com/MartoYankov |
| Jul 27, 2018 | https://github.com/NativeScript/NativeScript/pull/6102#issuecomment-408395936 |
| @farfromrefug | https://github.com/farfromrefug |
| setupUI | https://github.com/NativeScript/NativeScript/blob/master/tns-core-modules/ui/core/view-base/view-base.ts#L682 |
| https://docs.nativescript.org/plugins/ui-plugin-custom#building-ui-plugins-using-custom-components | https://docs.nativescript.org/plugins/ui-plugin-custom#building-ui-plugins-using-custom-components |
| Please reload this page | https://github.com/NativeScript/NativeScript/pull/6102 |
| https://github.com/farfromrefug |
| farfromrefug | https://github.com/farfromrefug |
| Jul 27, 2018 | https://github.com/NativeScript/NativeScript/pull/6102#issuecomment-408396544 |
| @MartoYankov | https://github.com/MartoYankov |
| https://github.com/Akylas/nativescript-material-components | https://github.com/Akylas/nativescript-material-components |
| Please reload this page | https://github.com/NativeScript/NativeScript/pull/6102 |
| https://github.com/farfromrefug |
| farfromrefug | https://github.com/farfromrefug |
| Jul 27, 2018 | https://github.com/NativeScript/NativeScript/pull/6102#issuecomment-408398059 |
| @MartoYankov | https://github.com/MartoYankov |
| Please reload this page | https://github.com/NativeScript/NativeScript/pull/6102 |
|
| https://github.com/farfromrefug |
| update based on comments | https://github.com/NativeScript/NativeScript/pull/6102/commits/a2f914a54376db5261e7792ba5ad53db5cd50d10 |
| a2f914a | https://github.com/NativeScript/NativeScript/pull/6102/commits/a2f914a54376db5261e7792ba5ad53db5cd50d10 |
| https://github.com/farfromrefug |
| farfromrefug | https://github.com/farfromrefug |
| Jul 30, 2018 | https://github.com/NativeScript/NativeScript/pull/6102#issuecomment-408846057 |
| @MartoYankov | https://github.com/MartoYankov |
| Please reload this page | https://github.com/NativeScript/NativeScript/pull/6102 |
| farfromrefug | https://github.com/farfromrefug |
| July 30, 2018 14:29 | https://github.com/NativeScript/NativeScript/pull/6102#commits-pushed-1dbc942 |
|
| https://github.com/farfromrefug |
| Merge branch 'master' of github.com:NativeScript/NativeScript into mo… | https://github.com/NativeScript/NativeScript/pull/6102/commits/1dbc94207022e3fd2ca31ead30fcc12782cfb54b |
| 1dbc942 | https://github.com/NativeScript/NativeScript/pull/6102/commits/1dbc94207022e3fd2ca31ead30fcc12782cfb54b |
|
| https://github.com/farfromrefug |
| fixed missing delegate call on ios | https://github.com/NativeScript/NativeScript/pull/6102/commits/48f7b66959e20154051f12a875cedf725f13b178 |
| 48f7b66 | https://github.com/NativeScript/NativeScript/pull/6102/commits/48f7b66959e20154051f12a875cedf725f13b178 |
| https://github.com/MartoYankov |
| MartoYankov | https://github.com/MartoYankov |
| Aug 8, 2018 | https://github.com/NativeScript/NativeScript/pull/6102#issuecomment-411354915 |
| @farfromrefug | https://github.com/farfromrefug |
| Please reload this page | https://github.com/NativeScript/NativeScript/pull/6102 |
| https://github.com/farfromrefug |
| farfromrefug | https://github.com/farfromrefug |
| Aug 8, 2018 | https://github.com/NativeScript/NativeScript/pull/6102#issuecomment-411360241 |
| @MartoYankov | https://github.com/MartoYankov |
| here | https://github.com/NativeScript/NativeScript/blob/master/tns-core-modules/ui/editable-text-base/editable-text-base.android.ts |
| Please reload this page | https://github.com/NativeScript/NativeScript/pull/6102 |
| https://github.com/MartoYankov |
| MartoYankov | https://github.com/MartoYankov |
| Aug 9, 2018 | https://github.com/NativeScript/NativeScript/pull/6102#issuecomment-411717414 |
| @farfromrefug | https://github.com/farfromrefug |
| Please reload this page | https://github.com/NativeScript/NativeScript/pull/6102 |
| https://github.com/farfromrefug |
| farfromrefug | https://github.com/farfromrefug |
| Aug 9, 2018 | https://github.com/NativeScript/NativeScript/pull/6102#issuecomment-411727158 |
| @MartoYankov | https://github.com/MartoYankov |
| Please reload this page | https://github.com/NativeScript/NativeScript/pull/6102 |
| https://github.com/MartoYankov |
| MartoYankov | https://github.com/MartoYankov |
| Aug 9, 2018 | https://github.com/NativeScript/NativeScript/pull/6102#issuecomment-411760419 |
| @farfromrefug | https://github.com/farfromrefug |
| Please reload this page | https://github.com/NativeScript/NativeScript/pull/6102 |
| farfromrefug | https://github.com/farfromrefug |
| August 11, 2018 16:09 | https://github.com/NativeScript/NativeScript/pull/6102#commits-pushed-2ae1133 |
|
| https://github.com/farfromrefug |
| refactored all UI widgets for better use of createNativeView/initNati… | https://github.com/NativeScript/NativeScript/pull/6102/commits/2ae113391738ce7fe960dd2fd634de7a24e48fbc |
| 2ae1133 | https://github.com/NativeScript/NativeScript/pull/6102/commits/2ae113391738ce7fe960dd2fd634de7a24e48fbc |
|
| https://github.com/farfromrefug |
| Merge branch 'master' into module_refactoring | https://github.com/NativeScript/NativeScript/pull/6102/commits/e20a8c5103002a4b833c6f47acbe5d5959b4b4c5 |
| e20a8c5 | https://github.com/NativeScript/NativeScript/pull/6102/commits/e20a8c5103002a4b833c6f47acbe5d5959b4b4c5 |
|
| https://github.com/MartoYankov |
| Merge branch 'master' into module_refactoring | https://github.com/NativeScript/NativeScript/pull/6102/commits/4ff80b9c934d2059a0fa6b27eb78eb7861572570 |
| 4ff80b9 | https://github.com/NativeScript/NativeScript/pull/6102/commits/4ff80b9c934d2059a0fa6b27eb78eb7861572570 |
| https://github.com/MartoYankov |
| MartoYankov | https://github.com/MartoYankov |
|
Sep 20, 2018
| https://github.com/NativeScript/NativeScript/pull/6102#pullrequestreview-157240380 |
|
View reviewed changes
| https://github.com/NativeScript/NativeScript/pull/6102/files/81dded987d00fe2074b68402c7f92fea31fc7225 |
| tns-core-modules/ui/scroll-view/scroll-view.ios.ts | https://github.com/NativeScript/NativeScript/pull/6102/files/439e8253bf805f25ff556275662e544d78aabf24..81dded987d00fe2074b68402c7f92fea31fc7225#diff-a2bc1dc368f56a640ce432f9a72d7d4a59b7bb4b9d439a6d70fb87a3670be516 |
| Please reload this page | https://github.com/NativeScript/NativeScript/pull/6102 |
| tns-core-modules/ui/frame/frame.ios.ts | https://github.com/NativeScript/NativeScript/pull/6102/files/aef4b3099eb8c5b9d491b8203874c199dc87864c..439e8253bf805f25ff556275662e544d78aabf24#diff-b70b2d09c77639b1b9ced4e1ef63c82277f28a4faab393d37b957bcda24a8f44 |
| MartoYankov | https://github.com/MartoYankov |
| Sep 20, 2018 | https://github.com/NativeScript/NativeScript/pull/6102#discussion_r219200054 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/NativeScript/NativeScript/pull/6102 |
| farfromrefug | https://github.com/farfromrefug |
| Sep 20, 2018 | https://github.com/NativeScript/NativeScript/pull/6102#discussion_r219212280 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/NativeScript/NativeScript/pull/6102 |
| MartoYankov | https://github.com/MartoYankov |
| Sep 20, 2018 | https://github.com/NativeScript/NativeScript/pull/6102#discussion_r219214676 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/NativeScript/NativeScript/pull/6102 |
| farfromrefug | https://github.com/farfromrefug |
| Sep 20, 2018 | https://github.com/NativeScript/NativeScript/pull/6102#discussion_r219217691 |
| Please reload this page | https://github.com/NativeScript/NativeScript/pull/6102 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/NativeScript/NativeScript/pull/6102 |
| MartoYankov | https://github.com/MartoYankov |
| Sep 21, 2018 | https://github.com/NativeScript/NativeScript/pull/6102#discussion_r219403686 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/NativeScript/NativeScript/pull/6102 |
| https://github.com/MartoYankov |
| MartoYankov | https://github.com/MartoYankov |
|
Sep 20, 2018
| https://github.com/NativeScript/NativeScript/pull/6102#pullrequestreview-157320209 |
|
View reviewed changes
| https://github.com/NativeScript/NativeScript/pull/6102/files/4ff80b9c934d2059a0fa6b27eb78eb7861572570 |
| tns-core-modules/ui/scroll-view/scroll-view.ios.ts | https://github.com/NativeScript/NativeScript/pull/6102/files/4ff80b9c934d2059a0fa6b27eb78eb7861572570#diff-a2bc1dc368f56a640ce432f9a72d7d4a59b7bb4b9d439a6d70fb87a3670be516 |
| MartoYankov | https://github.com/MartoYankov |
| Sep 20, 2018 | https://github.com/NativeScript/NativeScript/pull/6102#discussion_r219201389 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/NativeScript/NativeScript/pull/6102 |
| farfromrefug | https://github.com/farfromrefug |
| September 20, 2018 17:29 | https://github.com/NativeScript/NativeScript/pull/6102#commits-pushed-9dfafff |
|
| https://github.com/farfromrefug |
| better to call this in initNativeView | https://github.com/NativeScript/NativeScript/pull/6102/commits/9dfafffb1560af69761cb7350190af1292fbcb49 |
| 9dfafff | https://github.com/NativeScript/NativeScript/pull/6102/commits/9dfafffb1560af69761cb7350190af1292fbcb49 |
|
| https://github.com/farfromrefug |
| oops! | https://github.com/NativeScript/NativeScript/pull/6102/commits/90488790c7b583033382ce1791fc355aa6ad264d |
| 9048879 | https://github.com/NativeScript/NativeScript/pull/6102/commits/90488790c7b583033382ce1791fc355aa6ad264d |
| https://github.com/MartoYankov |
| MartoYankov | https://github.com/MartoYankov |
|
Sep 21, 2018
| https://github.com/NativeScript/NativeScript/pull/6102#pullrequestreview-157567003 |
|
View reviewed changes
| https://github.com/NativeScript/NativeScript/pull/6102/files/90488790c7b583033382ce1791fc355aa6ad264d |
| tns-core-modules/ui/scroll-view/scroll-view.ios.ts | https://github.com/NativeScript/NativeScript/pull/6102/files/90488790c7b583033382ce1791fc355aa6ad264d#diff-a2bc1dc368f56a640ce432f9a72d7d4a59b7bb4b9d439a6d70fb87a3670be516 |
| MartoYankov | https://github.com/MartoYankov |
| Sep 21, 2018 | https://github.com/NativeScript/NativeScript/pull/6102#discussion_r219400696 |
| Please reload this page | https://github.com/NativeScript/NativeScript/pull/6102 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/NativeScript/NativeScript/pull/6102 |
| farfromrefug | https://github.com/farfromrefug |
| September 21, 2018 09:16 | https://github.com/NativeScript/NativeScript/pull/6102#commits-pushed-ce76f94 |
|
| https://github.com/farfromrefug |
| refactoring | https://github.com/NativeScript/NativeScript/pull/6102/commits/ce76f94a068eb16abc84489cd69c4d2933e2ab5d |
| ce76f94 | https://github.com/NativeScript/NativeScript/pull/6102/commits/ce76f94a068eb16abc84489cd69c4d2933e2ab5d |
|
| https://github.com/farfromrefug |
| not needed as we have createNativeView | https://github.com/NativeScript/NativeScript/pull/6102/commits/e5494853a84e6dd57d17262b3dbddf1ad172fb3a |
| e549485 | https://github.com/NativeScript/NativeScript/pull/6102/commits/e5494853a84e6dd57d17262b3dbddf1ad172fb3a |
| https://github.com/MartoYankov |
| MartoYankov | https://github.com/MartoYankov |
| Sep 21, 2018 | https://github.com/NativeScript/NativeScript/pull/6102#issuecomment-423446070 |
| Please reload this page | https://github.com/NativeScript/NativeScript/pull/6102 |
|
| https://github.com/MartoYankov |
| refactor: call setupUI on components created with constructor | https://github.com/NativeScript/NativeScript/pull/6102/commits/b8113d8ac18c5b46d4a4250507eda442103585fa |
| b8113d8 | https://github.com/NativeScript/NativeScript/pull/6102/commits/b8113d8ac18c5b46d4a4250507eda442103585fa |
| https://github.com/MartoYankov |
| MartoYankov | https://github.com/MartoYankov |
| Sep 25, 2018 | https://github.com/NativeScript/NativeScript/pull/6102#issuecomment-424256666 |
| Please reload this page | https://github.com/NativeScript/NativeScript/pull/6102 |
|
| https://github.com/MartoYankov |
| call setupUI on dialog components for iOS only | https://github.com/NativeScript/NativeScript/pull/6102/commits/af042abe416a85b73e6251e6214ec2cdea4f5490 |
| af042ab | https://github.com/NativeScript/NativeScript/pull/6102/commits/af042abe416a85b73e6251e6214ec2cdea4f5490 |
| https://github.com/MartoYankov |
| MartoYankov | https://github.com/MartoYankov |
| Sep 25, 2018 | https://github.com/NativeScript/NativeScript/pull/6102#issuecomment-424382728 |
| Please reload this page | https://github.com/NativeScript/NativeScript/pull/6102 |
| https://github.com/MartoYankov |
| MartoYankov | https://github.com/MartoYankov |
| Sep 25, 2018 | https://github.com/NativeScript/NativeScript/pull/6102#issuecomment-424393238 |
| @farfromrefug | https://github.com/farfromrefug |
| Please reload this page | https://github.com/NativeScript/NativeScript/pull/6102 |
| https://github.com/farfromrefug |
| farfromrefug | https://github.com/farfromrefug |
| Sep 25, 2018 | https://github.com/NativeScript/NativeScript/pull/6102#issuecomment-424426793 |
| @MartoYankov | https://github.com/MartoYankov |
| Please reload this page | https://github.com/NativeScript/NativeScript/pull/6102 |
|
| https://github.com/MartoYankov |
| move setupAsRootView before the modal is shown | https://github.com/NativeScript/NativeScript/pull/6102/commits/8d39e65479866f1cadf7c2b2b701407195f3fbfe |
| 8d39e65 | https://github.com/NativeScript/NativeScript/pull/6102/commits/8d39e65479866f1cadf7c2b2b701407195f3fbfe |
| https://github.com/MartoYankov |
| MartoYankov | https://github.com/MartoYankov |
| Sep 26, 2018 | https://github.com/NativeScript/NativeScript/pull/6102#issuecomment-424637858 |
| Please reload this page | https://github.com/NativeScript/NativeScript/pull/6102 |
| https://github.com/MartoYankov |
| MartoYankov | https://github.com/MartoYankov |
|
Sep 26, 2018
| https://github.com/NativeScript/NativeScript/pull/6102#pullrequestreview-158919017 |
|
View reviewed changes
| https://github.com/NativeScript/NativeScript/pull/6102/files/8d39e65479866f1cadf7c2b2b701407195f3fbfe |
| https://github.com/MartoYankov |
| MartoYankov | https://github.com/MartoYankov |
| Sep 26, 2018 | https://github.com/NativeScript/NativeScript/pull/6102#issuecomment-424659168 |
| Please reload this page | https://github.com/NativeScript/NativeScript/pull/6102 |
| https://github.com/MartoYankov |
| MartoYankov | https://github.com/MartoYankov |
| Sep 26, 2018 | https://github.com/NativeScript/NativeScript/pull/6102#event-1868081931 |
| https://github.com/MartoYankov |
| MartoYankov | https://github.com/MartoYankov |
| 46705ee | https://github.com/NativeScript/NativeScript/commit/46705ee33278e8f9ec04b00ea592dd65ba855e74 |
| Sep 26, 2018 | https://github.com/NativeScript/NativeScript/pull/6102#event-1868082716 |
|
in progress
| https://github.com/NativeScript/NativeScript/issues?q=state%3Aopen%20label%3A%22in%20progress%22 |
| Sep 26, 2018 | https://github.com/NativeScript/NativeScript/pull/6102#event-1868082810 |
| https://github.com/MartoYankov |
| MartoYankov | https://github.com/MartoYankov |
| Sep 26, 2018 | https://github.com/NativeScript/NativeScript/pull/6102#issuecomment-424674298 |
| @farfromrefug | https://github.com/farfromrefug |
| Please reload this page | https://github.com/NativeScript/NativeScript/pull/6102 |
| https://github.com/farfromrefug |
| farfromrefug | https://github.com/farfromrefug |
| Sep 26, 2018 | https://github.com/NativeScript/NativeScript/pull/6102#issuecomment-424674597 |
| @MartoYankov | https://github.com/MartoYankov |
| Please reload this page | https://github.com/NativeScript/NativeScript/pull/6102 |
| https://github.com/farfromrefug |
| farfromrefug | https://github.com/farfromrefug |
| September 26, 2018 11:02 | https://github.com/NativeScript/NativeScript/pull/6102#event-1868089042 |
| https://github.com/farfromrefug |
| farfromrefug | https://github.com/farfromrefug |
|
Oct 2, 2018
| https://github.com/NativeScript/NativeScript/pull/6102#ref-issue-299403449 |
|
[FR] easier way to override native view creation
#5456
| https://github.com/NativeScript/NativeScript/issues/5456 |
| https://github.com/MartoYankov |
| MartoYankov | https://github.com/MartoYankov |
|
Oct 10, 2018
| https://github.com/NativeScript/NativeScript/pull/6102#ref-pullrequest-368639268 |
|
fix-next: drawer plugin viewcontroller init
#6379
| https://github.com/NativeScript/NativeScript/pull/6379 |
| https://github.com/radeva |
| radeva | https://github.com/radeva |
|
♥ community PR
| https://github.com/NativeScript/NativeScript/issues?q=state%3Aopen%20label%3A%22%E2%99%A5%20community%20PR%22 |
| Nov 2, 2018 | https://github.com/NativeScript/NativeScript/pull/6102#event-1943858368 |
| https://github.com/apps/lock |
| lock | https://github.com/apps/lock |
| Nov 2, 2019 | https://github.com/NativeScript/NativeScript/pull/6102#issuecomment-549079216 |
| Please reload this page | https://github.com/NativeScript/NativeScript/pull/6102 |
| https://github.com/apps/lock |
| lock | https://github.com/apps/lock |
| Nov 2, 2019 | https://github.com/NativeScript/NativeScript/pull/6102#event-2765541110 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNativeScript%2FNativeScript%2Fpull%2F6102 |
|
| https://github.com/MartoYankov |
|
MartoYankov
| https://github.com/MartoYankov |
|
| https://github.com/NativeScript/NativeScript/pull/6102/files/8d39e65479866f1cadf7c2b2b701407195f3fbfe |
|
| https://github.com/MartoYankov |
|
MartoYankov
| https://github.com/MartoYankov |
|
cla: yes
| https://github.com/NativeScript/NativeScript/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
|
♥ community PR
| https://github.com/NativeScript/NativeScript/issues?q=state%3Aopen%20label%3A%22%E2%99%A5%20community%20PR%22 |
| Please reload this page | https://github.com/NativeScript/NativeScript/pull/6102 |
|
| https://github.com/farfromrefug |
|
| https://github.com/SvetoslavTsenov |
|
| https://github.com/MartoYankov |
|
| https://github.com/radeva |
|
| https://github.com/ns-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |