Title: feat(ios-image-source): standardize quality scale in image-source by sudhanshu-15 · Pull Request #5517 · NativeScript/NativeScript · GitHub
Open Graph Title: feat(ios-image-source): standardize quality scale in image-source by sudhanshu-15 · Pull Request #5517 · NativeScript/NativeScript
X Title: feat(ios-image-source): standardize quality scale in image-source by sudhanshu-15 · Pull Request #5517 · NativeScript/NativeScript
Description: Normalize quality in saveToFile and toBase64String to follow 0-100 scale - standardize implementation on both platforms closes #5474 PR Checklist The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/CONTRIBUTING.md#commit-messages. There is an issue for the bug/feature this PR is for. To avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it. You have signed the CLA. All existing tests are passing: https://github.com/NativeScript/NativeScript/blob/master/DevelopmentWorkflow.md#running-unit-tests. Tests for the changes are included - https://github.com/NativeScript/NativeScript/blob/master/WritingUnitTests.md. What is the current behavior? quality parameter in image-source follows different scales for both the platforms. On iOS it goes from 0.0-1.0 and on Android it goes from 0-100. Developer needs to manually check for platform when using quality. What is the new behavior? iOS implementation of image-source toBase64String and saveToFile now normalizes the quality scale so that both the platforms follow the same scale from 0-100. For iOS the values of 0-100 are converted to a scale of 0.0-1.0. Fixes/Implements/Closes #[5474].
Open Graph Description: Normalize quality in saveToFile and toBase64String to follow 0-100 scale - standardize implementation on both platforms closes #5474 PR Checklist The PR title follows our guidelines: https://g...
X Description: Normalize quality in saveToFile and toBase64String to follow 0-100 scale - standardize implementation on both platforms closes #5474 PR Checklist The PR title follows our guidelines: https://g...
Opengraph URL: https://github.com/NativeScript/NativeScript/pull/5517
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:16fd97b4-1f63-37ef-ea83-6b8dcc4a4b0d |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 92C4:338491:1FF6E0:29D144:6A5FEA81 |
| html-safe-nonce | 6b5a7e65abee20eb81b4dfd0979c2b0ea51f9a866dbb04f055c939f61e5dacdf |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MkM0OjMzODQ5MToxRkY2RTA6MjlEMTQ0OjZBNUZFQTgxIiwidmlzaXRvcl9pZCI6IjYyNzE0OTcwNzgzMDY3NjEzNDUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | da20017a987832249898e9733f0c2f705191742d9a60abb9bf4a4411898fab6e |
| hovercard-subject-tag | pull_request:173928004 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/NativeScript/NativeScript/pull/5517/files |
| twitter:image | https://avatars.githubusercontent.com/u/883233?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/883233?s=400&v=4 |
| og:image:alt | Normalize quality in saveToFile and toBase64String to follow 0-100 scale - standardize implementation on both platforms closes #5474 PR Checklist The PR title follows our guidelines: https://g... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | ba296ecd3a3521238fe43b3b3b08cc09207ddc21173e16ee656db03803de8e2b |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/NativeScript/NativeScript git https://github.com/NativeScript/NativeScript.git |
| octolytics-dimension-user_id | 7392261 |
| octolytics-dimension-user_login | NativeScript |
| octolytics-dimension-repository_id | 31492490 |
| octolytics-dimension-repository_nwo | NativeScript/NativeScript |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 31492490 |
| octolytics-dimension-repository_network_root_nwo | NativeScript/NativeScript |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 6e50fb37e29e4aa0df6386cb485e58b0e3ca97ab |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width