René's URL Explorer Experiment


Title: Atanasovg/snapshot refactorings by atanasovg · Pull Request #1407 · NativeScript/NativeScript · GitHub

Open Graph Title: Atanasovg/snapshot refactorings by atanasovg · Pull Request #1407 · NativeScript/NativeScript

X Title: Atanasovg/snapshot refactorings by atanasovg · Pull Request #1407 · NativeScript/NativeScript

Description: This pull applies the following refactoring: Some circular dependencies removed - for example in the application module, which has the following require graph: application-common requires application application requires application-common application requires application All of the android.xxx calls are now wrapped in functions in order to be lazily evaluated. This enables initial snap-shotting of the modules. Modified the file-system.currentApp implementation to use Android APIs rather than string operations. Removed definition.xxx calls for all BUT types calls. This fixes cases where the module requires itself. For example, the TS compiler will generate a require call for the same module import definition = require("myModule"); exports class Class1 implements definition.Class1 { } var a; if (a typeof definition.Class1) { // wrong, generates require call for the same module } if (a typeof Class1) { // correct, uses the definition import only for type reference }

Open Graph Description: This pull applies the following refactoring: Some circular dependencies removed - for example in the application module, which has the following require graph: application-common requires applic...

X Description: This pull applies the following refactoring: Some circular dependencies removed - for example in the application module, which has the following require graph: application-common requires applic...

Opengraph URL: https://github.com/NativeScript/NativeScript/pull/1407

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:edd890a6-26d3-568e-7444-7972f19c556c
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id80BE:38C5CF:1EF5A64:2751C0F:6B014C89
html-safe-nonce52e1ff4c2c3d36cf5d9d3a4d3b588078a025cb52bed03e3d4b53f56465ad4ed3
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MEJFOjM4QzVDRjoxRUY1QTY0OjI3NTFDMEY6NkIwMTRDODkiLCJ2aXNpdG9yX2lkIjoiNjcyODIxMjIyMjU1Nzg5OTkxNCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacf55d33275a51814bf3299fa918e1ea6d32afe2994653cad751e2a6cd052abf54
hovercard-subject-tagpull_request:56578169
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/NativeScript/NativeScript/pull/1407/files
twitter:imagehttps://avatars.githubusercontent.com/u/5878999?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/5878999?s=400&v=4
og:image:altThis pull applies the following refactoring: Some circular dependencies removed - for example in the application module, which has the following require graph: application-common requires applic...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/NativeScript/NativeScript git https://github.com/NativeScript/NativeScript.git
octolytics-dimension-user_id7392261
octolytics-dimension-user_loginNativeScript
octolytics-dimension-repository_id31492490
octolytics-dimension-repository_nwoNativeScript/NativeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id31492490
octolytics-dimension-repository_network_root_nwoNativeScript/NativeScript
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/NativeScript/NativeScript/pull/1407/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNativeScript%2FNativeScript%2Fpull%2F1407%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNativeScript%2FNativeScript%2Fpull%2F1407%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=NativeScript%2FNativeScript
Reloadhttps://github.com/NativeScript/NativeScript/pull/1407/files
Reloadhttps://github.com/NativeScript/NativeScript/pull/1407/files
Reloadhttps://github.com/NativeScript/NativeScript/pull/1407/files
NativeScripthttps://github.com/NativeScript
NativeScripthttps://github.com/NativeScript/NativeScript
Codehttps://github.com/NativeScript/NativeScript
Issues231 (231)https://github.com/NativeScript/NativeScript/issues
Pull requests107 (107)https://github.com/NativeScript/NativeScript/pulls
Discussionshttps://github.com/NativeScript/NativeScript/discussions
Actionshttps://github.com/NativeScript/NativeScript/actions
Projectshttps://github.com/NativeScript/NativeScript/projects
Wikihttps://github.com/NativeScript/NativeScript/wiki
Security and qualityhttps://github.com/NativeScript/NativeScript/security
Insightshttps://github.com/NativeScript/NativeScript/insights
Sign up for GitHub https://github.com/signup?return_to=%2FNativeScript%2FNativeScript%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FNativeScript%2FNativeScript%2Fissues%2Fnew%2Fchoose
atanasovghttps://github.com/atanasovg
masterhttps://github.com/NativeScript/NativeScript/tree/master
atanasovg/snapshot-refactoringshttps://github.com/NativeScript/NativeScript/tree/atanasovg/snapshot-refactorings
Conversation 7 https://github.com/NativeScript/NativeScript/pull/1407
Commits 5 https://github.com/NativeScript/NativeScript/pull/1407/commits
Checks 0 https://github.com/NativeScript/NativeScript/pull/1407/checks
Files changed https://github.com/NativeScript/NativeScript/pull/1407/files
Please reload this pagehttps://github.com/NativeScript/NativeScript/pull/1407/files
Atanasovg/snapshot refactorings https://github.com/NativeScript/NativeScript/pull/1407/files#top
Show all changes 5 commits https://github.com/NativeScript/NativeScript/pull/1407/files
935939b Refactor the application module to prevent cyclic dependencies, which… atanasovg Jan 14, 2016 https://github.com/NativeScript/NativeScript/pull/1407/commits/935939bb516a05f304890fdb4a4a0bf596bd2324
fbc6126 Snapshot refactorings, which mainly wraps Android extends within inne… atanasovg Jan 19, 2016 https://github.com/NativeScript/NativeScript/pull/1407/commits/fbc612610f6850dca0522e88c931873619065847
f930914 Added typed information for lazily loaded android types. atanasovg Jan 20, 2016 https://github.com/NativeScript/NativeScript/pull/1407/commits/f930914fa86366e457a71158bc3db4bc73761ae3
f5eb344 Some snapshot-specific fixes/improvements. atanasovg Jan 22, 2016 https://github.com/NativeScript/NativeScript/pull/1407/commits/f5eb34466ecffac20a581e52557e481c3747d795
a760328 Applied several fixes over the initial commit. atanasovg Jan 22, 2016 https://github.com/NativeScript/NativeScript/pull/1407/commits/a760328422c121156815419dcac9a3201c2231ae
Clear filters https://github.com/NativeScript/NativeScript/pull/1407/files
Please reload this pagehttps://github.com/NativeScript/NativeScript/pull/1407/files
Please reload this pagehttps://github.com/NativeScript/NativeScript/pull/1407/files
CrossPlatformModules.csproj https://github.com/NativeScript/NativeScript/pull/1407/files#diff-cee96456022225059e677d4ded0b0fea90cbb9cd375d323b96a636970404a871
application-settings-common.ts https://github.com/NativeScript/NativeScript/pull/1407/files#diff-9ec66d10ccd9ee5f624200fd98b162d044c59450d6423762dfca321a47fc19ed
application-settings.android.ts https://github.com/NativeScript/NativeScript/pull/1407/files#diff-94f3ef018e9dc76bd77c11d7514c42c39d848578dcf6273b0124f50305f28d56
application-common.ts https://github.com/NativeScript/NativeScript/pull/1407/files#diff-ac8becfa51b66956afa70d4f984ef84ff0366298e6934ac06af0fe039cf6c28e
application.android.ts https://github.com/NativeScript/NativeScript/pull/1407/files#diff-5e616de3f680cd2a16352c076ebf33039125bb6aa6006dee6dd06547b105b93f
application.d.ts https://github.com/NativeScript/NativeScript/pull/1407/files#diff-118aac89aab41ed3a881c8bd79a2e991fa738a1fdcc62402f42cb5902578f217
application.ios.ts https://github.com/NativeScript/NativeScript/pull/1407/files#diff-0c1be1f7f2d436e764bc536624937b3318aa4b29ffbd549bde7d7d86649b3be6
console.ts https://github.com/NativeScript/NativeScript/pull/1407/files#diff-649ea88f83c21868db10880c6008904e17ae440fd0a56cc1087f8ff0657ef3bc
file-name-resolver.ts https://github.com/NativeScript/NativeScript/pull/1407/files#diff-85541dea56263b61cf2d07d86fcb00199fce9f907409bb0de92310d21aac6105
file-system-access.android.ts https://github.com/NativeScript/NativeScript/pull/1407/files#diff-db27b0b6b64fd8535ff13cf9c5d217bbf71dd4253a2e0e6bed0ed8ca6f20f06c
file-system-access.d.ts https://github.com/NativeScript/NativeScript/pull/1407/files#diff-b8d6e0db7f84e50092afae29ef9e8547e8506c3af1659c442bf7fcb439021e6a
file-system-access.ios.ts https://github.com/NativeScript/NativeScript/pull/1407/files#diff-6850c83621e5bf2545f556596e0a2c8dba69be1f753187b74df170d7faee972d
file-system.ts https://github.com/NativeScript/NativeScript/pull/1407/files#diff-218931a6f683e07b076a0ee4d8d95e1658a02df1a662a44cacfa1a1a70d10acf
fps-meter.ts https://github.com/NativeScript/NativeScript/pull/1407/files#diff-adb3d7999c3c4bd7af3615b49164662030307ebd5c330da5b02d0649d51a3287
globals.ts https://github.com/NativeScript/NativeScript/pull/1407/files#diff-df86dd858875392bcd5c615e7d01952681088a850acc198bd5c80563771a7354
http-request.android.ts https://github.com/NativeScript/NativeScript/pull/1407/files#diff-2524a594b63c33995ce77fed921468a2c126fff04811cd1ef99925cb2c9b7e15
location.android.ts https://github.com/NativeScript/NativeScript/pull/1407/files#diff-5536c802e61beeaec203373a8a38c3fcd1658aa256d82d7c047be075c799afdd
formatted-string-common.ts https://github.com/NativeScript/NativeScript/pull/1407/files#diff-9a508b40b0a0a57404ae2129d62a85464c02e05616a1e1e60fd09161b9608d52
span.android.ts https://github.com/NativeScript/NativeScript/pull/1407/files#diff-d16c15757adeb64fdb99db3696cb5e9d2724a42d490bf29f67040cb80174ef54
animation.android.ts https://github.com/NativeScript/NativeScript/pull/1407/files#diff-65943155215ba5170b0bd573cf98c4ec9663cba6c11babf37a8bed411db5d0c1
dialogs.android.ts https://github.com/NativeScript/NativeScript/pull/1407/files#diff-d0b9295fbe02bd1695f0b3d3f0499934cff35418b04f422fbf388bb0482e7e74
editable-text-base.android.ts https://github.com/NativeScript/NativeScript/pull/1407/files#diff-23a8bed1de1e44ac4d8751fc4254154e9757d8fa7a9a41e32902435a06a1c5cd
frame.android.ts https://github.com/NativeScript/NativeScript/pull/1407/files#diff-5d10a03be2c3120de0450ae311454456836d2f3055fe034f8b05d0b97d655f3a
gestures.android.ts https://github.com/NativeScript/NativeScript/pull/1407/files#diff-e95b1197c5af5f1ea711c52cf7b4d1db6ba90054909b3a4558dd9d03076267ca
html-view.android.ts https://github.com/NativeScript/NativeScript/pull/1407/files#diff-6aed2e9381d3c922f6c88ddd8284fbbca8fe7ae82e4dba71e5302c444876dd5c
image-cache.android.ts https://github.com/NativeScript/NativeScript/pull/1407/files#diff-0ce03226530a845c4ba94a79d5e6db5d00c04ee4299f6300a1028efc02ec6d98
layout.android.ts https://github.com/NativeScript/NativeScript/pull/1407/files#diff-c21c173617a1fda680e854708f0a1d385e50b8fafc7095082c32f1c3b8f4deb6
list-view.android.ts https://github.com/NativeScript/NativeScript/pull/1407/files#diff-e2e64cca432f5ebc625526d393a6ce36356ffad31c77dd0133b38dfcf5109085
page.android.ts https://github.com/NativeScript/NativeScript/pull/1407/files#diff-d7de8b01aa2f180679fd956401d4d9d51ca7169d07bb9030c64be96786c7aa0c
scroll-view-common.ts https://github.com/NativeScript/NativeScript/pull/1407/files#diff-a6202de476cf85248c6ead2a7b955b4753bcb35c84d9e343c2dd5c3f7f5e803b
scroll-view.android.ts https://github.com/NativeScript/NativeScript/pull/1407/files#diff-bf8af649c1b77a9028e30767ee9dfa70c7874ff71321e49b3ae9b407a6845243
segmented-bar.android.ts https://github.com/NativeScript/NativeScript/pull/1407/files#diff-4f03c15bd45b4e03b98eaaed4c2e909edab80eb09e25e613f4df5177add00678
background-common.ts https://github.com/NativeScript/NativeScript/pull/1407/files#diff-a1abb8e7b8b26393696efabce661ddcf7a2157c28176fe859273915460ad2c31
background.android.ts https://github.com/NativeScript/NativeScript/pull/1407/files#diff-41c2328a67c12d79aac49990672d568f444ddaa974b83ce859778b8270773a10
tab-view.android.ts https://github.com/NativeScript/NativeScript/pull/1407/files#diff-66589b4279b841ee1873c1c935b577c4b5ac4d6f58c6b9b53039be0029e8200c
web-view.android.ts https://github.com/NativeScript/NativeScript/pull/1407/files#diff-281480f36740c54f30ed379cfb75f360b476b5488786129a4b5405d2fd2aefab
debug.ts https://github.com/NativeScript/NativeScript/pull/1407/files#diff-fbe27218215b7c5e895a6c9429e94f12bcef219e71ce6ab199878ad2d3c6adcf
xml.ts https://github.com/NativeScript/NativeScript/pull/1407/files#diff-ed7efa989c7e510de127927c3ef987d08290a541481cc0b9ad08c729817ac5ec
CrossPlatformModules.csprojhttps://github.com/NativeScript/NativeScript/pull/1407/files#diff-cee96456022225059e677d4ded0b0fea90cbb9cd375d323b96a636970404a871
View file https://github.com/NativeScript/NativeScript/blob/a760328422c121156815419dcac9a3201c2231ae/CrossPlatformModules.csproj
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/NativeScript/NativeScript/pull/1407/{{ revealButtonHref }}
https://github.com/NativeScript/NativeScript/pull/1407/files#diff-cee96456022225059e677d4ded0b0fea90cbb9cd375d323b96a636970404a871
https://github.com/NativeScript/NativeScript/pull/1407/files#diff-cee96456022225059e677d4ded0b0fea90cbb9cd375d323b96a636970404a871
https://github.com/NativeScript/NativeScript/pull/1407/files#diff-cee96456022225059e677d4ded0b0fea90cbb9cd375d323b96a636970404a871
https://github.com/NativeScript/NativeScript/pull/1407/files#diff-cee96456022225059e677d4ded0b0fea90cbb9cd375d323b96a636970404a871
application-settings/application-settings-common.tshttps://github.com/NativeScript/NativeScript/pull/1407/files#diff-9ec66d10ccd9ee5f624200fd98b162d044c59450d6423762dfca321a47fc19ed
View file https://github.com/NativeScript/NativeScript/blob/a760328422c121156815419dcac9a3201c2231ae/application-settings/application-settings-common.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/NativeScript/NativeScript/pull/1407/{{ revealButtonHref }}
https://github.com/NativeScript/NativeScript/pull/1407/files#diff-9ec66d10ccd9ee5f624200fd98b162d044c59450d6423762dfca321a47fc19ed
application-settings/application-settings.android.tshttps://github.com/NativeScript/NativeScript/pull/1407/files#diff-94f3ef018e9dc76bd77c11d7514c42c39d848578dcf6273b0124f50305f28d56
View file https://github.com/NativeScript/NativeScript/blob/a760328422c121156815419dcac9a3201c2231ae/application-settings/application-settings.android.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/NativeScript/NativeScript/pull/1407/{{ revealButtonHref }}
https://github.com/NativeScript/NativeScript/pull/1407/files#diff-94f3ef018e9dc76bd77c11d7514c42c39d848578dcf6273b0124f50305f28d56
https://github.com/NativeScript/NativeScript/pull/1407/files#diff-94f3ef018e9dc76bd77c11d7514c42c39d848578dcf6273b0124f50305f28d56
application/application-common.tshttps://github.com/NativeScript/NativeScript/pull/1407/files#diff-ac8becfa51b66956afa70d4f984ef84ff0366298e6934ac06af0fe039cf6c28e
View file https://github.com/NativeScript/NativeScript/blob/a760328422c121156815419dcac9a3201c2231ae/application/application-common.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/NativeScript/NativeScript/pull/1407/{{ revealButtonHref }}
https://github.com/NativeScript/NativeScript/pull/1407/files#diff-ac8becfa51b66956afa70d4f984ef84ff0366298e6934ac06af0fe039cf6c28e
https://github.com/NativeScript/NativeScript/pull/1407/files#diff-ac8becfa51b66956afa70d4f984ef84ff0366298e6934ac06af0fe039cf6c28e
https://github.com/NativeScript/NativeScript/pull/1407/files#diff-ac8becfa51b66956afa70d4f984ef84ff0366298e6934ac06af0fe039cf6c28e
Please reload this pagehttps://github.com/NativeScript/NativeScript/pull/1407/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.