René's URL Explorer Experiment


Title: fix(android): keep TabView and ListPicker child views off their native views by edusperoni · Pull Request #11661 · NativeScript/NativeScript · GitHub

Open Graph Title: fix(android): keep TabView and ListPicker child views off their native views by edusperoni · Pull Request #11661 · NativeScript/NativeScript

X Title: fix(android): keep TabView and ListPicker child views off their native views by edusperoni · Pull Request #11661 · NativeScript/NativeScript

Description: PR Checklist The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/CONTRIBUTING.md#commit-messages. There is an issue for the bug/feature this PR is for. To avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it. You have signed the CLA. All existing tests are passing: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/DevelopmentWorkflow.md#unit-testing. Tests for the changes are included - https://github.com/NativeScript/NativeScript/blob/master/tools/notes/WritingUnitTests.md. What is the current behavior? TabView stored its ViewPager and TabLayout as JS properties of its GridLayout, and the PagerAdapter as a JS property of the ViewPager. ListPicker stored its EditText as a JS property of the NumberPicker. Each child's native parent (or, for the adapter, its ViewPager observer) is the object holding the property: GridLayout --(JS) viewPager--> TabViewPager --mParent--> GridLayout TabViewPager --(JS) adapter--> PagerAdapter --mViewPagerObserver--> TabViewPager NumberPicker --(JS) editText--> EditText --mParent--> NumberPicker With today's wrapper lifetime, JS properties on wrappers of plain Java objects are dropped when the wrapper is collected. With a wrapper lifetime that keeps a native object's JS properties for as long as Java holds the object (the experimental canary mode with "scope": "all", NativeScript/android#2127), these cycles are never collected, even after disposeNativeView. On the automated suite that was 31 tab views and 15 list pickers. These are not leaks with "scope": "extended". What is the new behavior? TabView keeps the three references in the private fields it already used (_viewPager, _tabLayout, _pagerAdapter), now assigned in createNativeView. ListPicker keeps its EditText in a private _editText field, cleared in disposeNativeView. The JS view already held these objects, so their reachability under resurrection is unchanged. The editText JS property on the NumberPicker is no longer set. It was undocumented; the ListPicker specs that read it now use the field. New LIST-PICKER spec test_Android_EditTextIsUpdatedAfterGarbageCollection collects both heaps, then changes the selection and checks the edit text. Verified on an Android 15 (API 35) emulator against an Android runtime built from NativeScript/android#2130 (stacked on #2127), with this change and the other Android wrapper-lifetime fixes applied together: "wrapperLifetime": { "mode": "resurrecting" } (today's default behavior, confirmed with getConfig("wrapperLifetimeMode")): full automated suite 1703 OK, 0 failed. The runtime counted 78,980 resurrections and 29,187 collected wrappers over the run, so the new specs ran while wrappers were being resurrected and their Java objects released. "wrapperLifetime": { "mode": "canary", "scope": "all" }: full suite 1703 OK, 0 failed. After the run, findLeakCycles() reports 0 cycles, 0 leaked objects, compared with 1054 leaked objects on main.

Open Graph Description: PR Checklist The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/CONTRIBUTING.md#commit-messages. There is an issue for the bug/feature this...

X Description: PR Checklist The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/CONTRIBUTING.md#commit-messages. There is an issue for the bug/feature this...

Opengraph URL: https://github.com/NativeScript/NativeScript/pull/11661

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:1cbdb23c-725f-91be-a329-68d4a8206c91
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idED34:3A347:14137D0:1A997FF:6B0124D9
html-safe-noncefeaad2a2fddbef0f6c456aa2154d7097f036336930748372306bfd5f3fafc55d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFRDM0OjNBMzQ3OjE0MTM3RDA6MUE5OTdGRjo2QjAxMjREOSIsInZpc2l0b3JfaWQiOiIxMTIyNjg5NjMxMDM3NDk4NTg1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacaf925bff772669e908595e1e59e85af356fd83aefbc9f5cd8ffd80c208ec3c2a
hovercard-subject-tagpull_request:5419424177
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/NativeScript/NativeScript/pull/11661/files
twitter:imagehttps://avatars.githubusercontent.com/u/4061767?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/4061767?s=400&v=4
og:image:altPR Checklist The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/CONTRIBUTING.md#commit-messages. There is an issue for the bug/feature this...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/NativeScript/NativeScript git https://github.com/NativeScript/NativeScript.git
octolytics-dimension-user_id7392261
octolytics-dimension-user_loginNativeScript
octolytics-dimension-repository_id31492490
octolytics-dimension-repository_nwoNativeScript/NativeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id31492490
octolytics-dimension-repository_network_root_nwoNativeScript/NativeScript
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/NativeScript/NativeScript/pull/11661/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNativeScript%2FNativeScript%2Fpull%2F11661%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNativeScript%2FNativeScript%2Fpull%2F11661%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=NativeScript%2FNativeScript
Reloadhttps://github.com/NativeScript/NativeScript/pull/11661/files
Reloadhttps://github.com/NativeScript/NativeScript/pull/11661/files
Reloadhttps://github.com/NativeScript/NativeScript/pull/11661/files
NativeScripthttps://github.com/NativeScript
NativeScripthttps://github.com/NativeScript/NativeScript
Codehttps://github.com/NativeScript/NativeScript
Issues231 (231)https://github.com/NativeScript/NativeScript/issues
Pull requests107 (107)https://github.com/NativeScript/NativeScript/pulls
Discussionshttps://github.com/NativeScript/NativeScript/discussions
Actionshttps://github.com/NativeScript/NativeScript/actions
Projectshttps://github.com/NativeScript/NativeScript/projects
Wikihttps://github.com/NativeScript/NativeScript/wiki
Security and qualityhttps://github.com/NativeScript/NativeScript/security
Insightshttps://github.com/NativeScript/NativeScript/insights
Sign up for GitHub https://github.com/signup?return_to=%2FNativeScript%2FNativeScript%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FNativeScript%2FNativeScript%2Fissues%2Fnew%2Fchoose
edusperonihttps://github.com/edusperoni
mainhttps://github.com/NativeScript/NativeScript/tree/main
fix/android-native-view-child-referenceshttps://github.com/NativeScript/NativeScript/tree/fix/android-native-view-child-references
Conversation 2 https://github.com/NativeScript/NativeScript/pull/11661
Commits 1 https://github.com/NativeScript/NativeScript/pull/11661/commits
Checks 9 https://github.com/NativeScript/NativeScript/pull/11661/checks
Files changed 3 https://github.com/NativeScript/NativeScript/pull/11661/files
fix(android): keep TabView and ListPicker child views off their native views https://github.com/NativeScript/NativeScript/pull/11661/files#top
Show all changes 1 commit https://github.com/NativeScript/NativeScript/pull/11661/files
b56210e fix(android): keep TabView and ListPicker child views off their nativ… edusperoni Nov 20, 2026 https://github.com/NativeScript/NativeScript/pull/11661/commits/b56210ee21ef837b30ee9b21322ec8f7264f066c
Clear filters https://github.com/NativeScript/NativeScript/pull/11661/files
Please reload this pagehttps://github.com/NativeScript/NativeScript/pull/11661/files
Please reload this pagehttps://github.com/NativeScript/NativeScript/pull/11661/files
list-picker-tests.ts https://github.com/NativeScript/NativeScript/pull/11661/files#diff-5c478eb0bb1c1950dc379233509f4dea6aba579557decbc13197ea15adf173ad
index.android.ts https://github.com/NativeScript/NativeScript/pull/11661/files#diff-bea00ddf7929b262af34c11140b1b8c55c8f496fd89f956973f0c913b5bbb0c6
index.android.ts https://github.com/NativeScript/NativeScript/pull/11661/files#diff-ea71ccf0b57d09f21fb739e9c1cb4e9cc51960d7f4403c753160bc4b6f6b2d5b
apps/automated/src/ui/list-picker/list-picker-tests.tshttps://github.com/NativeScript/NativeScript/pull/11661/files#diff-5c478eb0bb1c1950dc379233509f4dea6aba579557decbc13197ea15adf173ad
View file https://github.com/NativeScript/NativeScript/blob/b56210ee21ef837b30ee9b21322ec8f7264f066c/apps/automated/src/ui/list-picker/list-picker-tests.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/NativeScript/NativeScript/pull/11661/{{ revealButtonHref }}
https://github.com/NativeScript/NativeScript/pull/11661/files#diff-5c478eb0bb1c1950dc379233509f4dea6aba579557decbc13197ea15adf173ad
https://github.com/NativeScript/NativeScript/pull/11661/files#diff-5c478eb0bb1c1950dc379233509f4dea6aba579557decbc13197ea15adf173ad
https://github.com/NativeScript/NativeScript/pull/11661/files#diff-5c478eb0bb1c1950dc379233509f4dea6aba579557decbc13197ea15adf173ad
https://github.com/NativeScript/NativeScript/pull/11661/files#diff-5c478eb0bb1c1950dc379233509f4dea6aba579557decbc13197ea15adf173ad
packages/core/ui/list-picker/index.android.tshttps://github.com/NativeScript/NativeScript/pull/11661/files#diff-bea00ddf7929b262af34c11140b1b8c55c8f496fd89f956973f0c913b5bbb0c6
View file https://github.com/NativeScript/NativeScript/blob/b56210ee21ef837b30ee9b21322ec8f7264f066c/packages/core/ui/list-picker/index.android.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/NativeScript/NativeScript/pull/11661/{{ revealButtonHref }}
https://github.com/NativeScript/NativeScript/pull/11661/files#diff-bea00ddf7929b262af34c11140b1b8c55c8f496fd89f956973f0c913b5bbb0c6
https://github.com/NativeScript/NativeScript/pull/11661/files#diff-bea00ddf7929b262af34c11140b1b8c55c8f496fd89f956973f0c913b5bbb0c6
https://github.com/NativeScript/NativeScript/pull/11661/files#diff-bea00ddf7929b262af34c11140b1b8c55c8f496fd89f956973f0c913b5bbb0c6
https://github.com/NativeScript/NativeScript/pull/11661/files#diff-bea00ddf7929b262af34c11140b1b8c55c8f496fd89f956973f0c913b5bbb0c6
https://github.com/NativeScript/NativeScript/pull/11661/files#diff-bea00ddf7929b262af34c11140b1b8c55c8f496fd89f956973f0c913b5bbb0c6
https://github.com/NativeScript/NativeScript/pull/11661/files#diff-bea00ddf7929b262af34c11140b1b8c55c8f496fd89f956973f0c913b5bbb0c6
https://github.com/NativeScript/NativeScript/pull/11661/files#diff-bea00ddf7929b262af34c11140b1b8c55c8f496fd89f956973f0c913b5bbb0c6
https://github.com/NativeScript/NativeScript/pull/11661/files#diff-bea00ddf7929b262af34c11140b1b8c55c8f496fd89f956973f0c913b5bbb0c6
packages/core/ui/tab-view/index.android.tshttps://github.com/NativeScript/NativeScript/pull/11661/files#diff-ea71ccf0b57d09f21fb739e9c1cb4e9cc51960d7f4403c753160bc4b6f6b2d5b
View file https://github.com/NativeScript/NativeScript/blob/b56210ee21ef837b30ee9b21322ec8f7264f066c/packages/core/ui/tab-view/index.android.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/NativeScript/NativeScript/pull/11661/{{ revealButtonHref }}
https://github.com/NativeScript/NativeScript/pull/11661/files#diff-ea71ccf0b57d09f21fb739e9c1cb4e9cc51960d7f4403c753160bc4b6f6b2d5b
https://github.com/NativeScript/NativeScript/pull/11661/files#diff-ea71ccf0b57d09f21fb739e9c1cb4e9cc51960d7f4403c753160bc4b6f6b2d5b
https://github.com/NativeScript/NativeScript/pull/11661/files#diff-ea71ccf0b57d09f21fb739e9c1cb4e9cc51960d7f4403c753160bc4b6f6b2d5b
https://github.com/NativeScript/NativeScript/pull/11661/files#diff-ea71ccf0b57d09f21fb739e9c1cb4e9cc51960d7f4403c753160bc4b6f6b2d5b
https://github.com/NativeScript/NativeScript/pull/11661/files#diff-ea71ccf0b57d09f21fb739e9c1cb4e9cc51960d7f4403c753160bc4b6f6b2d5b
Please reload this pagehttps://github.com/NativeScript/NativeScript/pull/11661/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.