Title: fix(android): keep TabView and ListPicker child views off their native views by edusperoni · Pull Request #11661 · NativeScript/NativeScript · GitHub
Open Graph Title: fix(android): keep TabView and ListPicker child views off their native views by edusperoni · Pull Request #11661 · NativeScript/NativeScript
X Title: fix(android): keep TabView and ListPicker child views off their native views by edusperoni · Pull Request #11661 · NativeScript/NativeScript
Description: PR Checklist The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/CONTRIBUTING.md#commit-messages. There is an issue for the bug/feature this PR is for. To avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it. You have signed the CLA. All existing tests are passing: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/DevelopmentWorkflow.md#unit-testing. Tests for the changes are included - https://github.com/NativeScript/NativeScript/blob/master/tools/notes/WritingUnitTests.md. What is the current behavior? TabView stored its ViewPager and TabLayout as JS properties of its GridLayout, and the PagerAdapter as a JS property of the ViewPager. ListPicker stored its EditText as a JS property of the NumberPicker. Each child's native parent (or, for the adapter, its ViewPager observer) is the object holding the property: GridLayout --(JS) viewPager--> TabViewPager --mParent--> GridLayout TabViewPager --(JS) adapter--> PagerAdapter --mViewPagerObserver--> TabViewPager NumberPicker --(JS) editText--> EditText --mParent--> NumberPicker With today's wrapper lifetime, JS properties on wrappers of plain Java objects are dropped when the wrapper is collected. With a wrapper lifetime that keeps a native object's JS properties for as long as Java holds the object (the experimental canary mode with "scope": "all", NativeScript/android#2127), these cycles are never collected, even after disposeNativeView. On the automated suite that was 31 tab views and 15 list pickers. These are not leaks with "scope": "extended". What is the new behavior? TabView keeps the three references in the private fields it already used (_viewPager, _tabLayout, _pagerAdapter), now assigned in createNativeView. ListPicker keeps its EditText in a private _editText field, cleared in disposeNativeView. The JS view already held these objects, so their reachability under resurrection is unchanged. The editText JS property on the NumberPicker is no longer set. It was undocumented; the ListPicker specs that read it now use the field. New LIST-PICKER spec test_Android_EditTextIsUpdatedAfterGarbageCollection collects both heaps, then changes the selection and checks the edit text. Verified on an Android 15 (API 35) emulator against an Android runtime built from NativeScript/android#2130 (stacked on #2127), with this change and the other Android wrapper-lifetime fixes applied together: "wrapperLifetime": { "mode": "resurrecting" } (today's default behavior, confirmed with getConfig("wrapperLifetimeMode")): full automated suite 1703 OK, 0 failed. The runtime counted 78,980 resurrections and 29,187 collected wrappers over the run, so the new specs ran while wrappers were being resurrected and their Java objects released. "wrapperLifetime": { "mode": "canary", "scope": "all" }: full suite 1703 OK, 0 failed. After the run, findLeakCycles() reports 0 cycles, 0 leaked objects, compared with 1054 leaked objects on main.
Open Graph Description: PR Checklist The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/CONTRIBUTING.md#commit-messages. There is an issue for the bug/feature this...
X Description: PR Checklist The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/CONTRIBUTING.md#commit-messages. There is an issue for the bug/feature this...
Opengraph URL: https://github.com/NativeScript/NativeScript/pull/11661
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:1cbdb23c-725f-91be-a329-68d4a8206c91 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | ED34:3A347:14137D0:1A997FF:6B0124D9 |
| html-safe-nonce | feaad2a2fddbef0f6c456aa2154d7097f036336930748372306bfd5f3fafc55d |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFRDM0OjNBMzQ3OjE0MTM3RDA6MUE5OTdGRjo2QjAxMjREOSIsInZpc2l0b3JfaWQiOiIxMTIyNjg5NjMxMDM3NDk4NTg1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | af925bff772669e908595e1e59e85af356fd83aefbc9f5cd8ffd80c208ec3c2a |
| hovercard-subject-tag | pull_request:5419424177 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/NativeScript/NativeScript/pull/11661/files |
| twitter:image | https://avatars.githubusercontent.com/u/4061767?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/4061767?s=400&v=4 |
| og:image:alt | PR Checklist The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/CONTRIBUTING.md#commit-messages. There is an issue for the bug/feature this... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/NativeScript/NativeScript git https://github.com/NativeScript/NativeScript.git |
| octolytics-dimension-user_id | 7392261 |
| octolytics-dimension-user_login | NativeScript |
| octolytics-dimension-repository_id | 31492490 |
| octolytics-dimension-repository_nwo | NativeScript/NativeScript |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 31492490 |
| octolytics-dimension-repository_network_root_nwo | NativeScript/NativeScript |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width