Title: fix(android): hold Button and ActionBar from their native listeners weakly by edusperoni · Pull Request #11658 · NativeScript/NativeScript · GitHub
Open Graph Title: fix(android): hold Button and ActionBar from their native listeners weakly by edusperoni · Pull Request #11658 · NativeScript/NativeScript
X Title: fix(android): hold Button and ActionBar from their native listeners weakly by edusperoni · Pull Request #11658 · NativeScript/NativeScript
Description: PR Checklist The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/CONTRIBUTING.md#commit-messages. There is an issue for the bug/feature this PR is for. To avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it. You have signed the CLA. All existing tests are passing: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/DevelopmentWorkflow.md#unit-testing. Tests for the changes are included - https://github.com/NativeScript/NativeScript/blob/master/tools/notes/WritingUnitTests.md. What is the current behavior? Button's native view holds its ClickListenerImpl, and the Toolbar holds the ActionBar's MenuItemClickListenerImpl. Each listener held its view in a strong owner, which only disposeNativeView cleared: android.widget.Button --mListenerInfo--> ClickListenerImpl --(JS) owner--> Button --nativeView--> android.widget.Button Toolbar --mOnMenuItemClickListener--> MenuItemClickListenerImpl --(JS) owner--> ActionBar --> Page --> ... --> Toolbar A view whose native view is never disposed keeps that cycle. One case is the previous root after Application.resetRootView(): resetActivityContent unloads the old root and calls _onRootViewReset() but does not tear down its UI (iOS does the same). With the default wrapper lifetime, the runtime breaks these cycles once the listener's wrapper is unreachable from JS. A wrapper lifetime that keeps a JS-implemented object's state for as long as Java holds the object (the experimental canary mode, NativeScript/android#2127) cannot, so the old root's buttons and pages stayed alive. On the automated suite these are the ROOT-VIEW / RESET-ROOT-VIEW tests: 8 button cycles and 2 action bar cycles. What is the new behavior? Both listeners hold their owner through a WeakRef and do nothing (the menu listener returns false) once it is gone. This matches the iOS handlers and the Android TabView and EditableTextBase listeners. The views stay reachable from the view tree as before, and disposeNativeView still clears the owner. I chose this over tearing down the old root in resetActivityContent. That would change the root lifecycle for every flavor; the code there notes that some flavors reuse the same root view. It would also cover only that one path to an undisposed view. The same strong-owner pattern remains in other Android listeners: Switch, SegmentedBar's tab-change listener, ListView, SearchBar, TimePicker, ListPicker, WebView, Image and DatePicker. None of them showed up on the suite, so they are left for a follow-up. New specs BUTTON.testOnClickAfterGarbageCollection and ACTION-BAR.test_actionItem_tap_after_garbage_collection collect both heaps, then tap through the native listener (performClick, Menu.performIdentifierAction) and assert the tap event fires. Verified on an Android 15 (API 35) emulator against an Android runtime built from NativeScript/android#2130 (stacked on #2127), with this change and the other Android wrapper-lifetime fixes applied together: "wrapperLifetime": { "mode": "resurrecting" } (today's default behavior, confirmed with getConfig("wrapperLifetimeMode")): full automated suite 1703 OK, 0 failed. The runtime counted 78,980 resurrections and 29,187 collected wrappers over the run, so the new specs ran while wrappers were being resurrected and their Java objects released. "wrapperLifetime": { "mode": "canary", "scope": "all" }: full suite 1703 OK, 0 failed. After the run, findLeakCycles() reports 0 cycles, 0 leaked objects, compared with 1054 leaked objects on main.
Open Graph Description: PR Checklist The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/CONTRIBUTING.md#commit-messages. There is an issue for the bug/feature this...
X Description: PR Checklist The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/CONTRIBUTING.md#commit-messages. There is an issue for the bug/feature this...
Opengraph URL: https://github.com/NativeScript/NativeScript/pull/11658
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:d45dedf1-4035-87c0-8449-1f636dad3dce |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 8128:EA09B:1325914:196461D:6B0124C1 |
| html-safe-nonce | 55dcf77013cdad65e91897f148dfeb932bb945ca444e0647658fb4cd1577d0cb |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MTI4OkVBMDlCOjEzMjU5MTQ6MTk2NDYxRDo2QjAxMjRDMSIsInZpc2l0b3JfaWQiOiIxMTY4NDEwODkzNjM4MjQ3NjE3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | a2d7ecdaf0015dc34ee67ae43a2812dbfbaaa7bdb8cdb0c51701162312b858bd |
| hovercard-subject-tag | pull_request:5419422576 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/NativeScript/NativeScript/pull/11658/files |
| twitter:image | https://avatars.githubusercontent.com/u/4061767?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/4061767?s=400&v=4 |
| og:image:alt | PR Checklist The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/CONTRIBUTING.md#commit-messages. There is an issue for the bug/feature this... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/NativeScript/NativeScript git https://github.com/NativeScript/NativeScript.git |
| octolytics-dimension-user_id | 7392261 |
| octolytics-dimension-user_login | NativeScript |
| octolytics-dimension-repository_id | 31492490 |
| octolytics-dimension-repository_nwo | NativeScript/NativeScript |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 31492490 |
| octolytics-dimension-repository_network_root_nwo | NativeScript/NativeScript |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width