René's URL Explorer Experiment


Title: fix(android): hold Button and ActionBar from their native listeners weakly by edusperoni · Pull Request #11658 · NativeScript/NativeScript · GitHub

Open Graph Title: fix(android): hold Button and ActionBar from their native listeners weakly by edusperoni · Pull Request #11658 · NativeScript/NativeScript

X Title: fix(android): hold Button and ActionBar from their native listeners weakly by edusperoni · Pull Request #11658 · NativeScript/NativeScript

Description: PR Checklist The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/CONTRIBUTING.md#commit-messages. There is an issue for the bug/feature this PR is for. To avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it. You have signed the CLA. All existing tests are passing: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/DevelopmentWorkflow.md#unit-testing. Tests for the changes are included - https://github.com/NativeScript/NativeScript/blob/master/tools/notes/WritingUnitTests.md. What is the current behavior? Button's native view holds its ClickListenerImpl, and the Toolbar holds the ActionBar's MenuItemClickListenerImpl. Each listener held its view in a strong owner, which only disposeNativeView cleared: android.widget.Button --mListenerInfo--> ClickListenerImpl --(JS) owner--> Button --nativeView--> android.widget.Button Toolbar --mOnMenuItemClickListener--> MenuItemClickListenerImpl --(JS) owner--> ActionBar --> Page --> ... --> Toolbar A view whose native view is never disposed keeps that cycle. One case is the previous root after Application.resetRootView(): resetActivityContent unloads the old root and calls _onRootViewReset() but does not tear down its UI (iOS does the same). With the default wrapper lifetime, the runtime breaks these cycles once the listener's wrapper is unreachable from JS. A wrapper lifetime that keeps a JS-implemented object's state for as long as Java holds the object (the experimental canary mode, NativeScript/android#2127) cannot, so the old root's buttons and pages stayed alive. On the automated suite these are the ROOT-VIEW / RESET-ROOT-VIEW tests: 8 button cycles and 2 action bar cycles. What is the new behavior? Both listeners hold their owner through a WeakRef and do nothing (the menu listener returns false) once it is gone. This matches the iOS handlers and the Android TabView and EditableTextBase listeners. The views stay reachable from the view tree as before, and disposeNativeView still clears the owner. I chose this over tearing down the old root in resetActivityContent. That would change the root lifecycle for every flavor; the code there notes that some flavors reuse the same root view. It would also cover only that one path to an undisposed view. The same strong-owner pattern remains in other Android listeners: Switch, SegmentedBar's tab-change listener, ListView, SearchBar, TimePicker, ListPicker, WebView, Image and DatePicker. None of them showed up on the suite, so they are left for a follow-up. New specs BUTTON.testOnClickAfterGarbageCollection and ACTION-BAR.test_actionItem_tap_after_garbage_collection collect both heaps, then tap through the native listener (performClick, Menu.performIdentifierAction) and assert the tap event fires. Verified on an Android 15 (API 35) emulator against an Android runtime built from NativeScript/android#2130 (stacked on #2127), with this change and the other Android wrapper-lifetime fixes applied together: "wrapperLifetime": { "mode": "resurrecting" } (today's default behavior, confirmed with getConfig("wrapperLifetimeMode")): full automated suite 1703 OK, 0 failed. The runtime counted 78,980 resurrections and 29,187 collected wrappers over the run, so the new specs ran while wrappers were being resurrected and their Java objects released. "wrapperLifetime": { "mode": "canary", "scope": "all" }: full suite 1703 OK, 0 failed. After the run, findLeakCycles() reports 0 cycles, 0 leaked objects, compared with 1054 leaked objects on main.

Open Graph Description: PR Checklist The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/CONTRIBUTING.md#commit-messages. There is an issue for the bug/feature this...

X Description: PR Checklist The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/CONTRIBUTING.md#commit-messages. There is an issue for the bug/feature this...

Opengraph URL: https://github.com/NativeScript/NativeScript/pull/11658

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:d45dedf1-4035-87c0-8449-1f636dad3dce
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8128:EA09B:1325914:196461D:6B0124C1
html-safe-nonce55dcf77013cdad65e91897f148dfeb932bb945ca444e0647658fb4cd1577d0cb
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MTI4OkVBMDlCOjEzMjU5MTQ6MTk2NDYxRDo2QjAxMjRDMSIsInZpc2l0b3JfaWQiOiIxMTY4NDEwODkzNjM4MjQ3NjE3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmaca2d7ecdaf0015dc34ee67ae43a2812dbfbaaa7bdb8cdb0c51701162312b858bd
hovercard-subject-tagpull_request:5419422576
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/NativeScript/NativeScript/pull/11658/files
twitter:imagehttps://avatars.githubusercontent.com/u/4061767?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/4061767?s=400&v=4
og:image:altPR Checklist The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/CONTRIBUTING.md#commit-messages. There is an issue for the bug/feature this...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/NativeScript/NativeScript git https://github.com/NativeScript/NativeScript.git
octolytics-dimension-user_id7392261
octolytics-dimension-user_loginNativeScript
octolytics-dimension-repository_id31492490
octolytics-dimension-repository_nwoNativeScript/NativeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id31492490
octolytics-dimension-repository_network_root_nwoNativeScript/NativeScript
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/NativeScript/NativeScript/pull/11658/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNativeScript%2FNativeScript%2Fpull%2F11658%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNativeScript%2FNativeScript%2Fpull%2F11658%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=NativeScript%2FNativeScript
Reloadhttps://github.com/NativeScript/NativeScript/pull/11658/files
Reloadhttps://github.com/NativeScript/NativeScript/pull/11658/files
Reloadhttps://github.com/NativeScript/NativeScript/pull/11658/files
NativeScripthttps://github.com/NativeScript
NativeScripthttps://github.com/NativeScript/NativeScript
Codehttps://github.com/NativeScript/NativeScript
Issues231 (231)https://github.com/NativeScript/NativeScript/issues
Pull requests107 (107)https://github.com/NativeScript/NativeScript/pulls
Discussionshttps://github.com/NativeScript/NativeScript/discussions
Actionshttps://github.com/NativeScript/NativeScript/actions
Projectshttps://github.com/NativeScript/NativeScript/projects
Wikihttps://github.com/NativeScript/NativeScript/wiki
Security and qualityhttps://github.com/NativeScript/NativeScript/security
Insightshttps://github.com/NativeScript/NativeScript/insights
Sign up for GitHub https://github.com/signup?return_to=%2FNativeScript%2FNativeScript%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FNativeScript%2FNativeScript%2Fissues%2Fnew%2Fchoose
edusperonihttps://github.com/edusperoni
mainhttps://github.com/NativeScript/NativeScript/tree/main
fix/android-weak-button-action-bar-ownershttps://github.com/NativeScript/NativeScript/tree/fix/android-weak-button-action-bar-owners
Conversation 2 https://github.com/NativeScript/NativeScript/pull/11658
Commits 1 https://github.com/NativeScript/NativeScript/pull/11658/commits
Checks 9 https://github.com/NativeScript/NativeScript/pull/11658/checks
Files changed 4 https://github.com/NativeScript/NativeScript/pull/11658/files
fix(android): hold Button and ActionBar from their native listeners weakly https://github.com/NativeScript/NativeScript/pull/11658/files#top
Show all changes 1 commit https://github.com/NativeScript/NativeScript/pull/11658/files
cc3419c fix(android): hold Button and ActionBar from their native listeners w… edusperoni Nov 20, 2026 https://github.com/NativeScript/NativeScript/pull/11658/commits/cc3419cb484b86b66c394dfdb4bd6847adfe6ccc
Clear filters https://github.com/NativeScript/NativeScript/pull/11658/files
Please reload this pagehttps://github.com/NativeScript/NativeScript/pull/11658/files
Please reload this pagehttps://github.com/NativeScript/NativeScript/pull/11658/files
action-bar-tests.android.ts https://github.com/NativeScript/NativeScript/pull/11658/files#diff-74a32214c3bb7bb62bf0cf1eabe79accd3073521698fb970e21e85e4f1077902
button-tests.ts https://github.com/NativeScript/NativeScript/pull/11658/files#diff-32cf56d631561ff63fc7ea58b8f6d4947de42450aef283ae44a78d99f15da599
index.android.ts https://github.com/NativeScript/NativeScript/pull/11658/files#diff-bcdbd45f3c4405c714710636507295bf648f6d70aa93af14bb9a28d9f56fd3b8
index.android.ts https://github.com/NativeScript/NativeScript/pull/11658/files#diff-150fb8fcce10cfa9fa13d4fc0ae95c4d1277cd3f6836bacd4fef406a6406aae8
apps/automated/src/ui/action-bar/action-bar-tests.android.tshttps://github.com/NativeScript/NativeScript/pull/11658/files#diff-74a32214c3bb7bb62bf0cf1eabe79accd3073521698fb970e21e85e4f1077902
View file https://github.com/NativeScript/NativeScript/blob/cc3419cb484b86b66c394dfdb4bd6847adfe6ccc/apps/automated/src/ui/action-bar/action-bar-tests.android.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/NativeScript/NativeScript/pull/11658/{{ revealButtonHref }}
https://github.com/NativeScript/NativeScript/pull/11658/files#diff-74a32214c3bb7bb62bf0cf1eabe79accd3073521698fb970e21e85e4f1077902
apps/automated/src/ui/button/button-tests.tshttps://github.com/NativeScript/NativeScript/pull/11658/files#diff-32cf56d631561ff63fc7ea58b8f6d4947de42450aef283ae44a78d99f15da599
View file https://github.com/NativeScript/NativeScript/blob/cc3419cb484b86b66c394dfdb4bd6847adfe6ccc/apps/automated/src/ui/button/button-tests.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/NativeScript/NativeScript/pull/11658/{{ revealButtonHref }}
https://github.com/NativeScript/NativeScript/pull/11658/files#diff-32cf56d631561ff63fc7ea58b8f6d4947de42450aef283ae44a78d99f15da599
https://github.com/NativeScript/NativeScript/pull/11658/files#diff-32cf56d631561ff63fc7ea58b8f6d4947de42450aef283ae44a78d99f15da599
packages/core/ui/action-bar/index.android.tshttps://github.com/NativeScript/NativeScript/pull/11658/files#diff-bcdbd45f3c4405c714710636507295bf648f6d70aa93af14bb9a28d9f56fd3b8
View file https://github.com/NativeScript/NativeScript/blob/cc3419cb484b86b66c394dfdb4bd6847adfe6ccc/packages/core/ui/action-bar/index.android.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/NativeScript/NativeScript/pull/11658/{{ revealButtonHref }}
https://github.com/NativeScript/NativeScript/pull/11658/files#diff-bcdbd45f3c4405c714710636507295bf648f6d70aa93af14bb9a28d9f56fd3b8
https://github.com/NativeScript/NativeScript/pull/11658/files#diff-bcdbd45f3c4405c714710636507295bf648f6d70aa93af14bb9a28d9f56fd3b8
packages/core/ui/button/index.android.tshttps://github.com/NativeScript/NativeScript/pull/11658/files#diff-150fb8fcce10cfa9fa13d4fc0ae95c4d1277cd3f6836bacd4fef406a6406aae8
View file https://github.com/NativeScript/NativeScript/blob/cc3419cb484b86b66c394dfdb4bd6847adfe6ccc/packages/core/ui/button/index.android.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/NativeScript/NativeScript/pull/11658/{{ revealButtonHref }}
https://github.com/NativeScript/NativeScript/pull/11658/files#diff-150fb8fcce10cfa9fa13d4fc0ae95c4d1277cd3f6836bacd4fef406a6406aae8
https://github.com/NativeScript/NativeScript/pull/11658/files#diff-150fb8fcce10cfa9fa13d4fc0ae95c4d1277cd3f6836bacd4fef406a6406aae8
Please reload this pagehttps://github.com/NativeScript/NativeScript/pull/11658/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.