René's URL Explorer Experiment


Title: fix(android): hold the SegmentedBar from its tab content factory weakly by edusperoni · Pull Request #11657 · NativeScript/NativeScript · GitHub

Open Graph Title: fix(android): hold the SegmentedBar from its tab content factory weakly by edusperoni · Pull Request #11657 · NativeScript/NativeScript

X Title: fix(android): hold the SegmentedBar from its tab content factory weakly by edusperoni · Pull Request #11657 · NativeScript/NativeScript

Description: PR Checklist The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/CONTRIBUTING.md#commit-messages. There is an issue for the bug/feature this PR is for. To avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it. You have signed the CLA. All existing tests are passing: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/DevelopmentWorkflow.md#unit-testing. Tests for the changes are included - https://github.com/NativeScript/NativeScript/blob/master/tools/notes/WritingUnitTests.md. What is the current behavior? SegmentedBar keeps its TabContentFactoryImpl in _tabContentFactory, and the factory kept the bar as a strong owner. disposeNativeView clears the tab-change listener's owner but never the factory's: TabContentFactoryImpl --(JS) owner--> SegmentedBar --_tabContentFactory--> TabContentFactoryImpl The cycle runs through the factory's native counterpart (Java also holds the factory in each TabSpec). With the default wrapper lifetime, the runtime breaks it once the factory's wrapper is unreachable from JS. A wrapper lifetime that keeps a JS-implemented object's state for as long as Java holds the object (the experimental canary mode, NativeScript/android#2127) cannot, so every SegmentedBar stays alive, along with everything it references. That is 18 bars on the automated suite, even when disposed normally. What is the new behavior? The factory holds the bar through a WeakRef, like TabView's PagerAdapter. If the bar is gone when Android asks for tab content, it returns the same collapsed TextView, built on the application context. The factory itself is still held by the bar and by Java, as before, and the bar is held by its parent, so nothing it needs becomes weaker under resurrection. New SEGMENTED-BAR spec test_SelectingTabsAfterGarbageCollection_CreatesTheirContent collects both heaps between tab selections, which makes TabHost create tab content lazily through the factory. Verified on an Android 15 (API 35) emulator against an Android runtime built from NativeScript/android#2130 (stacked on #2127), with this change and the other Android wrapper-lifetime fixes applied together: "wrapperLifetime": { "mode": "resurrecting" } (today's default behavior, confirmed with getConfig("wrapperLifetimeMode")): full automated suite 1703 OK, 0 failed. The runtime counted 78,980 resurrections and 29,187 collected wrappers over the run, so the new specs ran while wrappers were being resurrected and their Java objects released. "wrapperLifetime": { "mode": "canary", "scope": "all" }: full suite 1703 OK, 0 failed. After the run, findLeakCycles() reports 0 cycles, 0 leaked objects, compared with 1054 leaked objects on main.

Open Graph Description: PR Checklist The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/CONTRIBUTING.md#commit-messages. There is an issue for the bug/feature this...

X Description: PR Checklist The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/CONTRIBUTING.md#commit-messages. There is an issue for the bug/feature this...

Opengraph URL: https://github.com/NativeScript/NativeScript/pull/11657

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:9b955b7d-ecff-154f-b118-2eb294e1104e
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8236:7A60E:1556349:1B6AF95:6B012438
html-safe-nonce7af18542d4ebc613fa3417848c628d4b468fe9939d7ea2dc344e450387adfb89
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MjM2OjdBNjBFOjE1NTYzNDk6MUI2QUY5NTo2QjAxMjQzOCIsInZpc2l0b3JfaWQiOiI3MTA4ODc1OTk3NjEzMzUzNTIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac613c57a8e08590433b830894e114258a98627c3e8edc6ab41f6011d344c00d66
hovercard-subject-tagpull_request:5419422038
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/NativeScript/NativeScript/pull/11657/files
twitter:imagehttps://avatars.githubusercontent.com/u/4061767?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/4061767?s=400&v=4
og:image:altPR Checklist The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/CONTRIBUTING.md#commit-messages. There is an issue for the bug/feature this...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/NativeScript/NativeScript git https://github.com/NativeScript/NativeScript.git
octolytics-dimension-user_id7392261
octolytics-dimension-user_loginNativeScript
octolytics-dimension-repository_id31492490
octolytics-dimension-repository_nwoNativeScript/NativeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id31492490
octolytics-dimension-repository_network_root_nwoNativeScript/NativeScript
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/NativeScript/NativeScript/pull/11657/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNativeScript%2FNativeScript%2Fpull%2F11657%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNativeScript%2FNativeScript%2Fpull%2F11657%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=NativeScript%2FNativeScript
Reloadhttps://github.com/NativeScript/NativeScript/pull/11657/files
Reloadhttps://github.com/NativeScript/NativeScript/pull/11657/files
Reloadhttps://github.com/NativeScript/NativeScript/pull/11657/files
NativeScripthttps://github.com/NativeScript
NativeScripthttps://github.com/NativeScript/NativeScript
Codehttps://github.com/NativeScript/NativeScript
Issues231 (231)https://github.com/NativeScript/NativeScript/issues
Pull requests107 (107)https://github.com/NativeScript/NativeScript/pulls
Discussionshttps://github.com/NativeScript/NativeScript/discussions
Actionshttps://github.com/NativeScript/NativeScript/actions
Projectshttps://github.com/NativeScript/NativeScript/projects
Wikihttps://github.com/NativeScript/NativeScript/wiki
Security and qualityhttps://github.com/NativeScript/NativeScript/security
Insightshttps://github.com/NativeScript/NativeScript/insights
Sign up for GitHub https://github.com/signup?return_to=%2FNativeScript%2FNativeScript%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FNativeScript%2FNativeScript%2Fissues%2Fnew%2Fchoose
edusperonihttps://github.com/edusperoni
mainhttps://github.com/NativeScript/NativeScript/tree/main
fix/android-segmented-bar-factory-cyclehttps://github.com/NativeScript/NativeScript/tree/fix/android-segmented-bar-factory-cycle
Conversation 2 https://github.com/NativeScript/NativeScript/pull/11657
Commits 1 https://github.com/NativeScript/NativeScript/pull/11657/commits
Checks 9 https://github.com/NativeScript/NativeScript/pull/11657/checks
Files changed 2 https://github.com/NativeScript/NativeScript/pull/11657/files
fix(android): hold the SegmentedBar from its tab content factory weakly https://github.com/NativeScript/NativeScript/pull/11657/files#top
Show all changes 1 commit https://github.com/NativeScript/NativeScript/pull/11657/files
90ff841 fix(android): hold the SegmentedBar from its tab content factory weakly edusperoni Nov 20, 2026 https://github.com/NativeScript/NativeScript/pull/11657/commits/90ff841c00f29cf04eb9e5eb2250012b3c4cc0ed
Clear filters https://github.com/NativeScript/NativeScript/pull/11657/files
Please reload this pagehttps://github.com/NativeScript/NativeScript/pull/11657/files
Please reload this pagehttps://github.com/NativeScript/NativeScript/pull/11657/files
segmented-bar-tests.ts https://github.com/NativeScript/NativeScript/pull/11657/files#diff-ee28aebaf5a889daa17b499ca5468da41edf2765b901c39733cb99e411a71334
index.android.ts https://github.com/NativeScript/NativeScript/pull/11657/files#diff-fb0d3863996ca496d7ab1388dbb1472772dea1ddffa0cdd43c8b0c6252baf30d
apps/automated/src/ui/segmented-bar/segmented-bar-tests.tshttps://github.com/NativeScript/NativeScript/pull/11657/files#diff-ee28aebaf5a889daa17b499ca5468da41edf2765b901c39733cb99e411a71334
View file https://github.com/NativeScript/NativeScript/blob/90ff841c00f29cf04eb9e5eb2250012b3c4cc0ed/apps/automated/src/ui/segmented-bar/segmented-bar-tests.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/NativeScript/NativeScript/pull/11657/{{ revealButtonHref }}
https://github.com/NativeScript/NativeScript/pull/11657/files#diff-ee28aebaf5a889daa17b499ca5468da41edf2765b901c39733cb99e411a71334
https://github.com/NativeScript/NativeScript/pull/11657/files#diff-ee28aebaf5a889daa17b499ca5468da41edf2765b901c39733cb99e411a71334
https://github.com/NativeScript/NativeScript/pull/11657/files#diff-ee28aebaf5a889daa17b499ca5468da41edf2765b901c39733cb99e411a71334
packages/core/ui/segmented-bar/index.android.tshttps://github.com/NativeScript/NativeScript/pull/11657/files#diff-fb0d3863996ca496d7ab1388dbb1472772dea1ddffa0cdd43c8b0c6252baf30d
View file https://github.com/NativeScript/NativeScript/blob/90ff841c00f29cf04eb9e5eb2250012b3c4cc0ed/packages/core/ui/segmented-bar/index.android.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/NativeScript/NativeScript/pull/11657/{{ revealButtonHref }}
https://github.com/NativeScript/NativeScript/pull/11657/files#diff-fb0d3863996ca496d7ab1388dbb1472772dea1ddffa0cdd43c8b0c6252baf30d
https://github.com/NativeScript/NativeScript/pull/11657/files#diff-fb0d3863996ca496d7ab1388dbb1472772dea1ddffa0cdd43c8b0c6252baf30d
https://github.com/NativeScript/NativeScript/pull/11657/files#diff-fb0d3863996ca496d7ab1388dbb1472772dea1ddffa0cdd43c8b0c6252baf30d
https://github.com/NativeScript/NativeScript/pull/11657/files#diff-fb0d3863996ca496d7ab1388dbb1472772dea1ddffa0cdd43c8b0c6252baf30d
Please reload this pagehttps://github.com/NativeScript/NativeScript/pull/11657/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.