Title: fix(android): stop fragment transition listeners from holding their transition by edusperoni · Pull Request #11656 · NativeScript/NativeScript · GitHub
Open Graph Title: fix(android): stop fragment transition listeners from holding their transition by edusperoni · Pull Request #11656 · NativeScript/NativeScript
X Title: fix(android): stop fragment transition listeners from holding their transition by edusperoni · Pull Request #11656 · NativeScript/NativeScript
Description: PR Checklist The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/CONTRIBUTING.md#commit-messages. There is an issue for the bug/feature this PR is for. To avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it. You have signed the CLA. All existing tests are passing: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/DevelopmentWorkflow.md#unit-testing. Tests for the changes are included - https://github.com/NativeScript/NativeScript/blob/master/tools/notes/WritingUnitTests.md. What is the current behavior? Each fragment transition holds its TransitionListenerImpl from Java (Transition.mListeners), and the listener held that transition back as a JS property (public transition): Transition --mListeners--> TransitionListenerImpl --(JS) transition--> Transition #11136 made the listener's entry a WeakRef, which removed the path to the page, but this cycle remains. With the default wrapper lifetime, the runtime breaks it: once the listener's wrapper is unreachable from JS, it is resurrected and its Java object weakened, so the GC can collect both sides. A wrapper lifetime that keeps a JS-implemented object's state for as long as Java holds the object (the experimental canary mode in NativeScript/android#2127) cannot see that the cycle is garbage, so every navigation transition (the transition, its listener and their JS state) stays alive. On the automated suite this was the largest leak: at least 247 such cycles (the probe's search limit was hit), about 890 live CustomTransition wrappers at the end of the run. What is the new behavior? The listener no longer references its transition. addNativeTransitionListener returns { listener, transition }, and the entry keeps that pair in its *TransitionListener fields; _updateTransitions, _reverseTransitions, the transition-state clone and the clear functions read the transition from the pair and remove pair.listener. Everything the frame uses stays reachable from the backstack entry, as before, so nothing becomes weaker under resurrection. New TRANSITIONS spec test_Transitions_SurviveGarbageCollectionBeforeGoingBack navigates forward with a transition, collects both heaps (gc() + java.lang.System.gc()), then goes back through the stored transitions. Verified on an Android 15 (API 35) emulator against an Android runtime built from NativeScript/android#2130 (stacked on #2127), with this change and the other Android wrapper-lifetime fixes applied together: "wrapperLifetime": { "mode": "resurrecting" } (today's default behavior, confirmed with getConfig("wrapperLifetimeMode")): full automated suite 1703 OK, 0 failed. The runtime counted 78,980 resurrections and 29,187 collected wrappers over the run, so the new specs ran while wrappers were being resurrected and their Java objects released. "wrapperLifetime": { "mode": "canary", "scope": "all" }: full suite 1703 OK, 0 failed. After the run, findLeakCycles() reports 0 cycles, 0 leaked objects, compared with 1054 leaked objects on main. Under canary, CustomTransition wrappers alive at the end of the run drop from about 890 to 100. Related: #11136
Open Graph Description: PR Checklist The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/CONTRIBUTING.md#commit-messages. There is an issue for the bug/feature this...
X Description: PR Checklist The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/CONTRIBUTING.md#commit-messages. There is an issue for the bug/feature this...
Opengraph URL: https://github.com/NativeScript/NativeScript/pull/11656
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:3b4d3554-edde-b82a-65bf-8f608c50cf50 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | C23E:7A60E:1557B11:1B6CE29:6B012442 |
| html-safe-nonce | 9aebc6af9d75de1b8d3d39cc66735ca5a3523001c2fa040dc39d92c98cac2f3e |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMjNFOjdBNjBFOjE1NTdCMTE6MUI2Q0UyOTo2QjAxMjQ0MiIsInZpc2l0b3JfaWQiOiI1MjAwMzkyMzU5OTQyMTA0MTMwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 8926111ff6f0f5499bc6fd1373a566842e95d3a3853a4067ac7f8655cf0393db |
| hovercard-subject-tag | pull_request:5419421435 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/NativeScript/NativeScript/pull/11656/files |
| twitter:image | https://avatars.githubusercontent.com/u/4061767?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/4061767?s=400&v=4 |
| og:image:alt | PR Checklist The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/CONTRIBUTING.md#commit-messages. There is an issue for the bug/feature this... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/NativeScript/NativeScript git https://github.com/NativeScript/NativeScript.git |
| octolytics-dimension-user_id | 7392261 |
| octolytics-dimension-user_login | NativeScript |
| octolytics-dimension-repository_id | 31492490 |
| octolytics-dimension-repository_nwo | NativeScript/NativeScript |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 31492490 |
| octolytics-dimension-repository_network_root_nwo | NativeScript/NativeScript |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width