René's URL Explorer Experiment


Title: fix(android): stop fragment transition listeners from holding their transition by edusperoni · Pull Request #11656 · NativeScript/NativeScript · GitHub

Open Graph Title: fix(android): stop fragment transition listeners from holding their transition by edusperoni · Pull Request #11656 · NativeScript/NativeScript

X Title: fix(android): stop fragment transition listeners from holding their transition by edusperoni · Pull Request #11656 · NativeScript/NativeScript

Description: PR Checklist The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/CONTRIBUTING.md#commit-messages. There is an issue for the bug/feature this PR is for. To avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it. You have signed the CLA. All existing tests are passing: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/DevelopmentWorkflow.md#unit-testing. Tests for the changes are included - https://github.com/NativeScript/NativeScript/blob/master/tools/notes/WritingUnitTests.md. What is the current behavior? Each fragment transition holds its TransitionListenerImpl from Java (Transition.mListeners), and the listener held that transition back as a JS property (public transition): Transition --mListeners--> TransitionListenerImpl --(JS) transition--> Transition #11136 made the listener's entry a WeakRef, which removed the path to the page, but this cycle remains. With the default wrapper lifetime, the runtime breaks it: once the listener's wrapper is unreachable from JS, it is resurrected and its Java object weakened, so the GC can collect both sides. A wrapper lifetime that keeps a JS-implemented object's state for as long as Java holds the object (the experimental canary mode in NativeScript/android#2127) cannot see that the cycle is garbage, so every navigation transition (the transition, its listener and their JS state) stays alive. On the automated suite this was the largest leak: at least 247 such cycles (the probe's search limit was hit), about 890 live CustomTransition wrappers at the end of the run. What is the new behavior? The listener no longer references its transition. addNativeTransitionListener returns { listener, transition }, and the entry keeps that pair in its *TransitionListener fields; _updateTransitions, _reverseTransitions, the transition-state clone and the clear functions read the transition from the pair and remove pair.listener. Everything the frame uses stays reachable from the backstack entry, as before, so nothing becomes weaker under resurrection. New TRANSITIONS spec test_Transitions_SurviveGarbageCollectionBeforeGoingBack navigates forward with a transition, collects both heaps (gc() + java.lang.System.gc()), then goes back through the stored transitions. Verified on an Android 15 (API 35) emulator against an Android runtime built from NativeScript/android#2130 (stacked on #2127), with this change and the other Android wrapper-lifetime fixes applied together: "wrapperLifetime": { "mode": "resurrecting" } (today's default behavior, confirmed with getConfig("wrapperLifetimeMode")): full automated suite 1703 OK, 0 failed. The runtime counted 78,980 resurrections and 29,187 collected wrappers over the run, so the new specs ran while wrappers were being resurrected and their Java objects released. "wrapperLifetime": { "mode": "canary", "scope": "all" }: full suite 1703 OK, 0 failed. After the run, findLeakCycles() reports 0 cycles, 0 leaked objects, compared with 1054 leaked objects on main. Under canary, CustomTransition wrappers alive at the end of the run drop from about 890 to 100. Related: #11136

Open Graph Description: PR Checklist The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/CONTRIBUTING.md#commit-messages. There is an issue for the bug/feature this...

X Description: PR Checklist The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/CONTRIBUTING.md#commit-messages. There is an issue for the bug/feature this...

Opengraph URL: https://github.com/NativeScript/NativeScript/pull/11656

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:3b4d3554-edde-b82a-65bf-8f608c50cf50
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC23E:7A60E:1557B11:1B6CE29:6B012442
html-safe-nonce9aebc6af9d75de1b8d3d39cc66735ca5a3523001c2fa040dc39d92c98cac2f3e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMjNFOjdBNjBFOjE1NTdCMTE6MUI2Q0UyOTo2QjAxMjQ0MiIsInZpc2l0b3JfaWQiOiI1MjAwMzkyMzU5OTQyMTA0MTMwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac8926111ff6f0f5499bc6fd1373a566842e95d3a3853a4067ac7f8655cf0393db
hovercard-subject-tagpull_request:5419421435
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/NativeScript/NativeScript/pull/11656/files
twitter:imagehttps://avatars.githubusercontent.com/u/4061767?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/4061767?s=400&v=4
og:image:altPR Checklist The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/CONTRIBUTING.md#commit-messages. There is an issue for the bug/feature this...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/NativeScript/NativeScript git https://github.com/NativeScript/NativeScript.git
octolytics-dimension-user_id7392261
octolytics-dimension-user_loginNativeScript
octolytics-dimension-repository_id31492490
octolytics-dimension-repository_nwoNativeScript/NativeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id31492490
octolytics-dimension-repository_network_root_nwoNativeScript/NativeScript
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/NativeScript/NativeScript/pull/11656/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNativeScript%2FNativeScript%2Fpull%2F11656%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNativeScript%2FNativeScript%2Fpull%2F11656%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=NativeScript%2FNativeScript
Reloadhttps://github.com/NativeScript/NativeScript/pull/11656/files
Reloadhttps://github.com/NativeScript/NativeScript/pull/11656/files
Reloadhttps://github.com/NativeScript/NativeScript/pull/11656/files
NativeScripthttps://github.com/NativeScript
NativeScripthttps://github.com/NativeScript/NativeScript
Codehttps://github.com/NativeScript/NativeScript
Issues231 (231)https://github.com/NativeScript/NativeScript/issues
Pull requests107 (107)https://github.com/NativeScript/NativeScript/pulls
Discussionshttps://github.com/NativeScript/NativeScript/discussions
Actionshttps://github.com/NativeScript/NativeScript/actions
Projectshttps://github.com/NativeScript/NativeScript/projects
Wikihttps://github.com/NativeScript/NativeScript/wiki
Security and qualityhttps://github.com/NativeScript/NativeScript/security
Insightshttps://github.com/NativeScript/NativeScript/insights
Sign up for GitHub https://github.com/signup?return_to=%2FNativeScript%2FNativeScript%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FNativeScript%2FNativeScript%2Fissues%2Fnew%2Fchoose
edusperonihttps://github.com/edusperoni
mainhttps://github.com/NativeScript/NativeScript/tree/main
fix/android-transition-listener-cyclehttps://github.com/NativeScript/NativeScript/tree/fix/android-transition-listener-cycle
Conversation 2 https://github.com/NativeScript/NativeScript/pull/11656
Commits 1 https://github.com/NativeScript/NativeScript/pull/11656/commits
Checks 9 https://github.com/NativeScript/NativeScript/pull/11656/checks
Files changed 2 https://github.com/NativeScript/NativeScript/pull/11656/files
fix(android): stop fragment transition listeners from holding their transition https://github.com/NativeScript/NativeScript/pull/11656/files#top
Show all changes 1 commit https://github.com/NativeScript/NativeScript/pull/11656/files
e7bc65a fix(android): stop fragment transition listeners from holding their t… edusperoni Nov 20, 2026 https://github.com/NativeScript/NativeScript/pull/11656/commits/e7bc65a07211b5b09610940c4ec0303e284cfb1e
Clear filters https://github.com/NativeScript/NativeScript/pull/11656/files
Please reload this pagehttps://github.com/NativeScript/NativeScript/pull/11656/files
Please reload this pagehttps://github.com/NativeScript/NativeScript/pull/11656/files
transition-tests.ts https://github.com/NativeScript/NativeScript/pull/11656/files#diff-b773dc88ffd7bad43a0b653e18ccc9037612ebabe24bc5992f7139a4a4b4fc58
fragment.transitions.android.ts https://github.com/NativeScript/NativeScript/pull/11656/files#diff-f96968064f042038a3579fef94d23a11c1fff5a8a3b4c33e161ccfc8911a4672
apps/automated/src/navigation/transition-tests.tshttps://github.com/NativeScript/NativeScript/pull/11656/files#diff-b773dc88ffd7bad43a0b653e18ccc9037612ebabe24bc5992f7139a4a4b4fc58
View file https://github.com/NativeScript/NativeScript/blob/e7bc65a07211b5b09610940c4ec0303e284cfb1e/apps/automated/src/navigation/transition-tests.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/NativeScript/NativeScript/pull/11656/{{ revealButtonHref }}
https://github.com/NativeScript/NativeScript/pull/11656/files#diff-b773dc88ffd7bad43a0b653e18ccc9037612ebabe24bc5992f7139a4a4b4fc58
https://github.com/NativeScript/NativeScript/pull/11656/files#diff-b773dc88ffd7bad43a0b653e18ccc9037612ebabe24bc5992f7139a4a4b4fc58
https://github.com/NativeScript/NativeScript/pull/11656/files#diff-b773dc88ffd7bad43a0b653e18ccc9037612ebabe24bc5992f7139a4a4b4fc58
packages/core/ui/frame/fragment.transitions.android.tshttps://github.com/NativeScript/NativeScript/pull/11656/files#diff-f96968064f042038a3579fef94d23a11c1fff5a8a3b4c33e161ccfc8911a4672
View file https://github.com/NativeScript/NativeScript/blob/e7bc65a07211b5b09610940c4ec0303e284cfb1e/packages/core/ui/frame/fragment.transitions.android.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/NativeScript/NativeScript/pull/11656/{{ revealButtonHref }}
https://github.com/NativeScript/NativeScript/pull/11656/files#diff-f96968064f042038a3579fef94d23a11c1fff5a8a3b4c33e161ccfc8911a4672
https://github.com/NativeScript/NativeScript/pull/11656/files#diff-f96968064f042038a3579fef94d23a11c1fff5a8a3b4c33e161ccfc8911a4672
https://github.com/NativeScript/NativeScript/pull/11656/files#diff-f96968064f042038a3579fef94d23a11c1fff5a8a3b4c33e161ccfc8911a4672
https://github.com/NativeScript/NativeScript/pull/11656/files#diff-f96968064f042038a3579fef94d23a11c1fff5a8a3b4c33e161ccfc8911a4672
https://github.com/NativeScript/NativeScript/pull/11656/files#diff-f96968064f042038a3579fef94d23a11c1fff5a8a3b4c33e161ccfc8911a4672
https://github.com/NativeScript/NativeScript/pull/11656/files#diff-f96968064f042038a3579fef94d23a11c1fff5a8a3b4c33e161ccfc8911a4672
https://github.com/NativeScript/NativeScript/pull/11656/files#diff-f96968064f042038a3579fef94d23a11c1fff5a8a3b4c33e161ccfc8911a4672
https://github.com/NativeScript/NativeScript/pull/11656/files#diff-f96968064f042038a3579fef94d23a11c1fff5a8a3b4c33e161ccfc8911a4672
https://github.com/NativeScript/NativeScript/pull/11656/files#diff-f96968064f042038a3579fef94d23a11c1fff5a8a3b4c33e161ccfc8911a4672
https://github.com/NativeScript/NativeScript/pull/11656/files#diff-f96968064f042038a3579fef94d23a11c1fff5a8a3b4c33e161ccfc8911a4672
https://github.com/NativeScript/NativeScript/pull/11656/files#diff-f96968064f042038a3579fef94d23a11c1fff5a8a3b4c33e161ccfc8911a4672
https://github.com/NativeScript/NativeScript/pull/11656/files#diff-f96968064f042038a3579fef94d23a11c1fff5a8a3b4c33e161ccfc8911a4672
https://github.com/NativeScript/NativeScript/pull/11656/files#diff-f96968064f042038a3579fef94d23a11c1fff5a8a3b4c33e161ccfc8911a4672
https://github.com/NativeScript/NativeScript/pull/11656/files#diff-f96968064f042038a3579fef94d23a11c1fff5a8a3b4c33e161ccfc8911a4672
https://github.com/NativeScript/NativeScript/pull/11656/files#diff-f96968064f042038a3579fef94d23a11c1fff5a8a3b4c33e161ccfc8911a4672
https://github.com/NativeScript/NativeScript/pull/11656/files#diff-f96968064f042038a3579fef94d23a11c1fff5a8a3b4c33e161ccfc8911a4672
Please reload this pagehttps://github.com/NativeScript/NativeScript/pull/11656/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.