René's URL Explorer Experiment


Title: perf(file-system): single-pass Android readTextSync that keeps line breaks by edusperoni · Pull Request #11653 · NativeScript/NativeScript · GitHub

Open Graph Title: perf(file-system): single-pass Android readTextSync that keeps line breaks by edusperoni · Pull Request #11653 · NativeScript/NativeScript

X Title: perf(file-system): single-pass Android readTextSync that keeps line breaks by edusperoni · Pull Request #11653 · NativeScript/NativeScript

Description: PR Checklist The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/CONTRIBUTING.md#commit-messages. There is an issue for the bug/feature this PR is for. To avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it. You have signed the CLA. All existing tests are passing: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/DevelopmentWorkflow.md#unit-testing. Tests for the changes are included - https://github.com/NativeScript/NativeScript/blob/master/tools/notes/WritingUnitTests.md. What is the current behavior? Android readTextSync (file-system/file-system-access.android.ts) makes one JNI readLine() call per line and rebuilds the text from the lines. That is slow, and it also changes the content: \r\n and lone \r become \n; the trailing line break is dropped; leading blank lines are dropped. Android readText() (Async.File.readText) and iOS readTextSync()/readText() return the file unchanged, so the same file reads differently depending on the API and platform. What is the new behavior? Two commits, so either can be reverted alone. perf(file-system): read the whole file readTextSync reads the file in 64 KiB chunks into a ByteArrayOutputStream and decodes it with one toString(charset) call. This commit keeps the old output exactly, through a small _readLinesLegacy step. java.nio.file.Files isn't used: it needs API 26, and the widgets minSdk is 21. File.length() is only a size hint, so special files like /proc/* (which report a length of 0) still read correctly. The stream is now always closed. Before, it leaked whenever an error was thrown. The encoding parameter, the UTF-8 BOM removal and the onError behaviour are unchanged. fix(file-system): return the content unchanged ImportantBehaviour change. readTextSync on Android now returns the file content unchanged, like Android readText() and both iOS functions. Android-only code that compares a file's contents exactly will now see the trailing line break, and code that splits on \n keeps the \r of CRLF files. The UTF-8 BOM is still removed. test_FileReadTextKeepsLineBreaks in apps/automated covers this. It writes CRLF, CR and LF content larger than one read chunk and checks that readTextSync() and readText() both return it unchanged. Verification apps/automated on an Android emulator (API 36, @nativescript/android 9.1.1) passes. A temporary benchmark module (not committed): readTextSync() of a 1 MiB file with 16,645 CRLF lines went from ~12 ms to 2–3.5 ms. It also checked that the BOM is still stripped, onError is still called with undefined returned for a missing file, and /proc/self/status still reads. Split out of #11636.

Open Graph Description: PR Checklist The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/CONTRIBUTING.md#commit-messages. There is an issue for the bug/feature this...

X Description: PR Checklist The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/CONTRIBUTING.md#commit-messages. There is an issue for the bug/feature this...

Opengraph URL: https://github.com/NativeScript/NativeScript/pull/11653

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:fef4cd06-56fd-9b54-cd50-3134075f453c
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC59A:882E2:175FC66:1EC1405:6B013035
html-safe-nonce678039800d016513cdba82af0329a5d985fb601bac94f6f6d842e97ceeb2a216
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNTlBOjg4MkUyOjE3NUZDNjY6MUVDMTQwNTo2QjAxMzAzNSIsInZpc2l0b3JfaWQiOiI0NDg5MzQ5Njk2NDc2NzUzOTczIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmaca1d092d3ff362cb6f573fffa47e1b5910839a6772100a74703a836cdc7ae5d6f
hovercard-subject-tagpull_request:5416995232
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/NativeScript/NativeScript/pull/11653/files
twitter:imagehttps://avatars.githubusercontent.com/u/4061767?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/4061767?s=400&v=4
og:image:altPR Checklist The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/CONTRIBUTING.md#commit-messages. There is an issue for the bug/feature this...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/NativeScript/NativeScript git https://github.com/NativeScript/NativeScript.git
octolytics-dimension-user_id7392261
octolytics-dimension-user_loginNativeScript
octolytics-dimension-repository_id31492490
octolytics-dimension-repository_nwoNativeScript/NativeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id31492490
octolytics-dimension-repository_network_root_nwoNativeScript/NativeScript
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/NativeScript/NativeScript/pull/11653/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNativeScript%2FNativeScript%2Fpull%2F11653%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNativeScript%2FNativeScript%2Fpull%2F11653%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=NativeScript%2FNativeScript
Reloadhttps://github.com/NativeScript/NativeScript/pull/11653/files
Reloadhttps://github.com/NativeScript/NativeScript/pull/11653/files
Reloadhttps://github.com/NativeScript/NativeScript/pull/11653/files
NativeScripthttps://github.com/NativeScript
NativeScripthttps://github.com/NativeScript/NativeScript
Codehttps://github.com/NativeScript/NativeScript
Issues231 (231)https://github.com/NativeScript/NativeScript/issues
Pull requests107 (107)https://github.com/NativeScript/NativeScript/pulls
Discussionshttps://github.com/NativeScript/NativeScript/discussions
Actionshttps://github.com/NativeScript/NativeScript/actions
Projectshttps://github.com/NativeScript/NativeScript/projects
Wikihttps://github.com/NativeScript/NativeScript/wiki
Security and qualityhttps://github.com/NativeScript/NativeScript/security
Insightshttps://github.com/NativeScript/NativeScript/insights
Sign up for GitHub https://github.com/signup?return_to=%2FNativeScript%2FNativeScript%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FNativeScript%2FNativeScript%2Fissues%2Fnew%2Fchoose
edusperonihttps://github.com/edusperoni
mainhttps://github.com/NativeScript/NativeScript/tree/main
perf/android-readtextsynchttps://github.com/NativeScript/NativeScript/tree/perf/android-readtextsync
Conversation 2 https://github.com/NativeScript/NativeScript/pull/11653
Commits 2 https://github.com/NativeScript/NativeScript/pull/11653/commits
Checks 9 https://github.com/NativeScript/NativeScript/pull/11653/checks
Files changed 2 https://github.com/NativeScript/NativeScript/pull/11653/files
perf(file-system): single-pass Android readTextSync that keeps line breaks https://github.com/NativeScript/NativeScript/pull/11653/files#top
Show all changes 2 commits https://github.com/NativeScript/NativeScript/pull/11653/files
49cb8a6 perf(file-system): read the whole file in Android readTextSync edusperoni Nov 11, 2026 https://github.com/NativeScript/NativeScript/pull/11653/commits/49cb8a629bc4cc0c6764ce958477c1098bfd864f
2a321da fix(file-system): return Android readTextSync content unchanged edusperoni Nov 11, 2026 https://github.com/NativeScript/NativeScript/pull/11653/commits/2a321da5ad3a006c3442f29a824dc9e6bf577816
Clear filters https://github.com/NativeScript/NativeScript/pull/11653/files
Please reload this pagehttps://github.com/NativeScript/NativeScript/pull/11653/files
Please reload this pagehttps://github.com/NativeScript/NativeScript/pull/11653/files
file-system-tests.ts https://github.com/NativeScript/NativeScript/pull/11653/files#diff-a16352876c108a2826c6e7227b937aae7119fb2284da72bd6bfb348e7e0304c4
file-system-access.android.ts https://github.com/NativeScript/NativeScript/pull/11653/files#diff-2b4b1b59c60bf2bb798df4ee47f9a87535f981abd0b39059ae34ec00106b7c51
apps/automated/src/file-system/file-system-tests.tshttps://github.com/NativeScript/NativeScript/pull/11653/files#diff-a16352876c108a2826c6e7227b937aae7119fb2284da72bd6bfb348e7e0304c4
View file https://github.com/NativeScript/NativeScript/blob/2a321da5ad3a006c3442f29a824dc9e6bf577816/apps/automated/src/file-system/file-system-tests.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/NativeScript/NativeScript/pull/11653/{{ revealButtonHref }}
https://github.com/NativeScript/NativeScript/pull/11653/files#diff-a16352876c108a2826c6e7227b937aae7119fb2284da72bd6bfb348e7e0304c4
packages/core/file-system/file-system-access.android.tshttps://github.com/NativeScript/NativeScript/pull/11653/files#diff-2b4b1b59c60bf2bb798df4ee47f9a87535f981abd0b39059ae34ec00106b7c51
View file https://github.com/NativeScript/NativeScript/blob/2a321da5ad3a006c3442f29a824dc9e6bf577816/packages/core/file-system/file-system-access.android.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/NativeScript/NativeScript/pull/11653/{{ revealButtonHref }}
https://github.com/NativeScript/NativeScript/pull/11653/files#diff-2b4b1b59c60bf2bb798df4ee47f9a87535f981abd0b39059ae34ec00106b7c51
https://github.com/NativeScript/NativeScript/pull/11653/files#diff-2b4b1b59c60bf2bb798df4ee47f9a87535f981abd0b39059ae34ec00106b7c51
https://github.com/NativeScript/NativeScript/pull/11653/files#diff-2b4b1b59c60bf2bb798df4ee47f9a87535f981abd0b39059ae34ec00106b7c51
Please reload this pagehttps://github.com/NativeScript/NativeScript/pull/11653/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.