Title: fix(ios): don't treat a page covered by navigation as presenting a controller by edusperoni · Pull Request #11648 · NativeScript/NativeScript · GitHub
Open Graph Title: fix(ios): don't treat a page covered by navigation as presenting a controller by edusperoni · Pull Request #11648 · NativeScript/NativeScript
X Title: fix(ios): don't treat a page covered by navigation as presenting a controller by edusperoni · Pull Request #11648 · NativeScript/NativeScript
Description: PR Checklist The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/CONTRIBUTING.md#commit-messages. There is an issue for the bug/feature this PR is for. To avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it. You have signed the CLA. All existing tests are passing: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/DevelopmentWorkflow.md#unit-testing. Tests for the changes are included - https://github.com/NativeScript/NativeScript/blob/master/tools/notes/WritingUnitTests.md. What is the current behavior? On iOS, when a page has a modal open and its frame navigates forward and then back to it, the back navigation never completes. frame.currentPage stays on the covering page, frame._executingContext is never cleared, and every later navigation of that frame queues behind it forever, also after the modal is closed. The page caches its presentedViewController in viewWillDisappear so that presenting a controller over it doesn't raise navigation events. When the frame pushes another page over a page that has a modal open, presentedViewController still returns the modal, so the page is flagged as presenting even though it disappears because of the navigation. On going back, viewDidAppear skips setCurrent and _processNavigationQueue for it and then clears the flag, so nothing ever completes the back. What is the new behavior? A page doesn't cache the presented controller while its frame is executing a navigation to a different entry. Going back to a page with an open modal completes normally: the page becomes current, the queue drains, and later navigations work. Presenting a controller over the current page still raises no navigation events, including a controller presented from the page's own navigatedTo handler (the executing entry is the page's own then). New test in the PAGE group: test_WhenGoingBackToPageThatShowsModal_FrameCompletesTheNavigation. It fails without the change (frame.currentPage is the covering page) and passes with it. Full automated suite on an iOS 26.3 simulator: 1837 OK, 0 failed.
Open Graph Description: PR Checklist The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/CONTRIBUTING.md#commit-messages. There is an issue for the bug/feature this...
X Description: PR Checklist The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/CONTRIBUTING.md#commit-messages. There is an issue for the bug/feature this...
Opengraph URL: https://github.com/NativeScript/NativeScript/pull/11648
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:b8e637f8-82b0-d474-3780-39784f157f86 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E0E4:1CEA6F:16B98B4:1DF4AFF:6B01303F |
| html-safe-nonce | c97bef658bfe033f56b3b922aef3dec533f215ea671ed1dfe5ec7430119acc44 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMEU0OjFDRUE2RjoxNkI5OEI0OjFERjRBRkY6NkIwMTMwM0YiLCJ2aXNpdG9yX2lkIjoiNzMwNzY0ODg0NTAwODg1NTY3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | b44a4e9e145be2fd61741d2decb380a8bacf895d22a5a2fe258306aa520e5e24 |
| hovercard-subject-tag | pull_request:5382247402 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/NativeScript/NativeScript/pull/11648/files |
| twitter:image | https://avatars.githubusercontent.com/u/4061767?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/4061767?s=400&v=4 |
| og:image:alt | PR Checklist The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/CONTRIBUTING.md#commit-messages. There is an issue for the bug/feature this... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/NativeScript/NativeScript git https://github.com/NativeScript/NativeScript.git |
| octolytics-dimension-user_id | 7392261 |
| octolytics-dimension-user_login | NativeScript |
| octolytics-dimension-repository_id | 31492490 |
| octolytics-dimension-repository_nwo | NativeScript/NativeScript |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 31492490 |
| octolytics-dimension-repository_network_root_nwo | NativeScript/NativeScript |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width