René's URL Explorer Experiment


Title: fix(ios): don't treat a page covered by navigation as presenting a controller by edusperoni · Pull Request #11648 · NativeScript/NativeScript · GitHub

Open Graph Title: fix(ios): don't treat a page covered by navigation as presenting a controller by edusperoni · Pull Request #11648 · NativeScript/NativeScript

X Title: fix(ios): don't treat a page covered by navigation as presenting a controller by edusperoni · Pull Request #11648 · NativeScript/NativeScript

Description: PR Checklist The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/CONTRIBUTING.md#commit-messages. There is an issue for the bug/feature this PR is for. To avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it. You have signed the CLA. All existing tests are passing: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/DevelopmentWorkflow.md#unit-testing. Tests for the changes are included - https://github.com/NativeScript/NativeScript/blob/master/tools/notes/WritingUnitTests.md. What is the current behavior? On iOS, when a page has a modal open and its frame navigates forward and then back to it, the back navigation never completes. frame.currentPage stays on the covering page, frame._executingContext is never cleared, and every later navigation of that frame queues behind it forever, also after the modal is closed. The page caches its presentedViewController in viewWillDisappear so that presenting a controller over it doesn't raise navigation events. When the frame pushes another page over a page that has a modal open, presentedViewController still returns the modal, so the page is flagged as presenting even though it disappears because of the navigation. On going back, viewDidAppear skips setCurrent and _processNavigationQueue for it and then clears the flag, so nothing ever completes the back. What is the new behavior? A page doesn't cache the presented controller while its frame is executing a navigation to a different entry. Going back to a page with an open modal completes normally: the page becomes current, the queue drains, and later navigations work. Presenting a controller over the current page still raises no navigation events, including a controller presented from the page's own navigatedTo handler (the executing entry is the page's own then). New test in the PAGE group: test_WhenGoingBackToPageThatShowsModal_FrameCompletesTheNavigation. It fails without the change (frame.currentPage is the covering page) and passes with it. Full automated suite on an iOS 26.3 simulator: 1837 OK, 0 failed.

Open Graph Description: PR Checklist The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/CONTRIBUTING.md#commit-messages. There is an issue for the bug/feature this...

X Description: PR Checklist The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/CONTRIBUTING.md#commit-messages. There is an issue for the bug/feature this...

Opengraph URL: https://github.com/NativeScript/NativeScript/pull/11648

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:b8e637f8-82b0-d474-3780-39784f157f86
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE0E4:1CEA6F:16B98B4:1DF4AFF:6B01303F
html-safe-noncec97bef658bfe033f56b3b922aef3dec533f215ea671ed1dfe5ec7430119acc44
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMEU0OjFDRUE2RjoxNkI5OEI0OjFERjRBRkY6NkIwMTMwM0YiLCJ2aXNpdG9yX2lkIjoiNzMwNzY0ODg0NTAwODg1NTY3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacb44a4e9e145be2fd61741d2decb380a8bacf895d22a5a2fe258306aa520e5e24
hovercard-subject-tagpull_request:5382247402
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/NativeScript/NativeScript/pull/11648/files
twitter:imagehttps://avatars.githubusercontent.com/u/4061767?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/4061767?s=400&v=4
og:image:altPR Checklist The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/CONTRIBUTING.md#commit-messages. There is an issue for the bug/feature this...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/NativeScript/NativeScript git https://github.com/NativeScript/NativeScript.git
octolytics-dimension-user_id7392261
octolytics-dimension-user_loginNativeScript
octolytics-dimension-repository_id31492490
octolytics-dimension-repository_nwoNativeScript/NativeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id31492490
octolytics-dimension-repository_network_root_nwoNativeScript/NativeScript
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/NativeScript/NativeScript/pull/11648/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNativeScript%2FNativeScript%2Fpull%2F11648%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNativeScript%2FNativeScript%2Fpull%2F11648%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=NativeScript%2FNativeScript
Reloadhttps://github.com/NativeScript/NativeScript/pull/11648/files
Reloadhttps://github.com/NativeScript/NativeScript/pull/11648/files
Reloadhttps://github.com/NativeScript/NativeScript/pull/11648/files
NativeScripthttps://github.com/NativeScript
NativeScripthttps://github.com/NativeScript/NativeScript
Codehttps://github.com/NativeScript/NativeScript
Issues231 (231)https://github.com/NativeScript/NativeScript/issues
Pull requests107 (107)https://github.com/NativeScript/NativeScript/pulls
Discussionshttps://github.com/NativeScript/NativeScript/discussions
Actionshttps://github.com/NativeScript/NativeScript/actions
Projectshttps://github.com/NativeScript/NativeScript/projects
Wikihttps://github.com/NativeScript/NativeScript/wiki
Security and qualityhttps://github.com/NativeScript/NativeScript/security
Insightshttps://github.com/NativeScript/NativeScript/insights
Sign up for GitHub https://github.com/signup?return_to=%2FNativeScript%2FNativeScript%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FNativeScript%2FNativeScript%2Fissues%2Fnew%2Fchoose
edusperonihttps://github.com/edusperoni
mainhttps://github.com/NativeScript/NativeScript/tree/main
fix/ios-page-presented-controller-on-pushhttps://github.com/NativeScript/NativeScript/tree/fix/ios-page-presented-controller-on-push
Conversation 3 https://github.com/NativeScript/NativeScript/pull/11648
Commits 1 https://github.com/NativeScript/NativeScript/pull/11648/commits
Checks 9 https://github.com/NativeScript/NativeScript/pull/11648/checks
Files changed 2 https://github.com/NativeScript/NativeScript/pull/11648/files
fix(ios): don't treat a page covered by navigation as presenting a controller https://github.com/NativeScript/NativeScript/pull/11648/files#top
Show all changes 1 commit https://github.com/NativeScript/NativeScript/pull/11648/files
c74d6ff fix(ios): don't treat a page covered by navigation as presenting a co… edusperoni Nov 18, 2026 https://github.com/NativeScript/NativeScript/pull/11648/commits/c74d6ff35edd41b6828cbb0029e867d41f246bb2
Clear filters https://github.com/NativeScript/NativeScript/pull/11648/files
Please reload this pagehttps://github.com/NativeScript/NativeScript/pull/11648/files
Please reload this pagehttps://github.com/NativeScript/NativeScript/pull/11648/files
page-tests.ios.ts https://github.com/NativeScript/NativeScript/pull/11648/files#diff-0344875bd17fb0d93d163b84cb192f2656cccdf6c890ee95c591e5bb27469aa7
index.ios.ts https://github.com/NativeScript/NativeScript/pull/11648/files#diff-e10bced30a590017c0d42bb1d654b00cc718c5e7385bd6bb797d8dcf5d8bb11c
apps/automated/src/ui/page/page-tests.ios.tshttps://github.com/NativeScript/NativeScript/pull/11648/files#diff-0344875bd17fb0d93d163b84cb192f2656cccdf6c890ee95c591e5bb27469aa7
View file https://github.com/NativeScript/NativeScript/blob/c74d6ff35edd41b6828cbb0029e867d41f246bb2/apps/automated/src/ui/page/page-tests.ios.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/NativeScript/NativeScript/pull/11648/{{ revealButtonHref }}
https://github.com/NativeScript/NativeScript/pull/11648/files#diff-0344875bd17fb0d93d163b84cb192f2656cccdf6c890ee95c591e5bb27469aa7
https://github.com/NativeScript/NativeScript/pull/11648/files#diff-0344875bd17fb0d93d163b84cb192f2656cccdf6c890ee95c591e5bb27469aa7
packages/core/ui/page/index.ios.tshttps://github.com/NativeScript/NativeScript/pull/11648/files#diff-e10bced30a590017c0d42bb1d654b00cc718c5e7385bd6bb797d8dcf5d8bb11c
View file https://github.com/NativeScript/NativeScript/blob/c74d6ff35edd41b6828cbb0029e867d41f246bb2/packages/core/ui/page/index.ios.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/NativeScript/NativeScript/pull/11648/{{ revealButtonHref }}
https://github.com/NativeScript/NativeScript/pull/11648/files#diff-e10bced30a590017c0d42bb1d654b00cc718c5e7385bd6bb797d8dcf5d8bb11c
farfromrefughttps://github.com/farfromrefug
Nov 19, 2026https://github.com/NativeScript/NativeScript/pull/11648/files#r4635207971
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/NativeScript/NativeScript/pull/11648/files
https://github.com/NativeScript/NativeScript/pull/11648/files#diff-e10bced30a590017c0d42bb1d654b00cc718c5e7385bd6bb797d8dcf5d8bb11c
Please reload this pagehttps://github.com/NativeScript/NativeScript/pull/11648/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.