René's URL Explorer Experiment


Title: fix(core): preserve unknown and deprecated media query types by amirthn6533 · Pull Request #11644 · NativeScript/NativeScript · GitHub

Open Graph Title: fix(core): preserve unknown and deprecated media query types by amirthn6533 · Pull Request #11644 · NativeScript/NativeScript

X Title: fix(core): preserve unknown and deprecated media query types by amirthn6533 · Pull Request #11644 · NativeScript/NativeScript

Description: PR Checklist The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/CONTRIBUTING.md#commit-messages. There is an issue for the bug/feature this PR is for. To avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it. You have signed the CLA. All existing tests are passing: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/DevelopmentWorkflow.md#unit-testing. Tests for the changes are included - https://github.com/NativeScript/NativeScript/blob/master/tools/notes/WritingUnitTests.md. What is the current behavior? parseQuery only keeps the media types in MediaQueryType (all, print, screen); any other type (tv, speech, handheld, projection, or an unknown identifier) falls back to all. Since media queries are evaluated with type: screen, @media tv { ... } rules apply on every screen, matchMedia('tv').matches is true, and @media not tv / matchMedia('not tv').matches are false. Per Media Queries Level 4 §2.3, unknown and deprecated media types never match, and negating them with not evaluates to true. What is the new behavior? Preserves parsed unknown and deprecated media types (e.g., tv, speech, handheld, projection) in lowercase instead of falling back to MediaQueryType.all when type is present in parseQuery, so they never match and not matches. Updates MediaQueryExpression.type to MediaQueryType | string to reflect preserved non-enum media type strings. Adds unit tests in packages/core/css-mediaquery/index.spec.ts verifying parseQuery and matchQuery behavior for unknown/deprecated media types and their not negations. Testing: npx nx run core:test --testFile=packages/core/css-mediaquery/index.spec.ts (20 passed) npx nx run core:test --testFile=packages/core/media-query-list/index.spec.ts (8 passed) npx eslint packages/core/css-mediaquery/index.ts packages/core/css-mediaquery/index.spec.ts (clean) Fixes #11643.

Open Graph Description: PR Checklist The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/CONTRIBUTING.md#commit-messages. There is an issue for the bug/feature this...

X Description: PR Checklist The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/CONTRIBUTING.md#commit-messages. There is an issue for the bug/feature this...

Opengraph URL: https://github.com/NativeScript/NativeScript/pull/11644

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:13f48157-20a4-21d4-cb99-da9c214a66cb
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE838:1F2D:BA4FD2:EACDFF:6B01303A
html-safe-nonce8d626628e93c0dda5037084512ebfda4a79ee26db137c41a4196e5bf6366a0b8
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFODM4OjFGMkQ6QkE0RkQyOkVBQ0RGRjo2QjAxMzAzQSIsInZpc2l0b3JfaWQiOiIxMTQxMTMwNjIyODc4NjkxMzg2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmace0e0f82ff0750b17e26e1f47782dd14391735ad30c64cf6c831950405a4c7153
hovercard-subject-tagpull_request:5335734219
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/NativeScript/NativeScript/pull/11644/files
twitter:imagehttps://avatars.githubusercontent.com/u/127450356?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/127450356?s=400&v=4
og:image:altPR Checklist The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/CONTRIBUTING.md#commit-messages. There is an issue for the bug/feature this...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/NativeScript/NativeScript git https://github.com/NativeScript/NativeScript.git
octolytics-dimension-user_id7392261
octolytics-dimension-user_loginNativeScript
octolytics-dimension-repository_id31492490
octolytics-dimension-repository_nwoNativeScript/NativeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id31492490
octolytics-dimension-repository_network_root_nwoNativeScript/NativeScript
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetcanary-2
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/NativeScript/NativeScript/pull/11644/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNativeScript%2FNativeScript%2Fpull%2F11644%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNativeScript%2FNativeScript%2Fpull%2F11644%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=NativeScript%2FNativeScript
Reloadhttps://github.com/NativeScript/NativeScript/pull/11644/files
Reloadhttps://github.com/NativeScript/NativeScript/pull/11644/files
Reloadhttps://github.com/NativeScript/NativeScript/pull/11644/files
NativeScripthttps://github.com/NativeScript
NativeScripthttps://github.com/NativeScript/NativeScript
Codehttps://github.com/NativeScript/NativeScript
Issues231 (231)https://github.com/NativeScript/NativeScript/issues
Pull requests107 (107)https://github.com/NativeScript/NativeScript/pulls
Discussionshttps://github.com/NativeScript/NativeScript/discussions
Actionshttps://github.com/NativeScript/NativeScript/actions
Projectshttps://github.com/NativeScript/NativeScript/projects
Wikihttps://github.com/NativeScript/NativeScript/wiki
Security and qualityhttps://github.com/NativeScript/NativeScript/security
Insightshttps://github.com/NativeScript/NativeScript/insights
Sign up for GitHub https://github.com/signup?return_to=%2FNativeScript%2FNativeScript%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FNativeScript%2FNativeScript%2Fissues%2Fnew%2Fchoose
amirthn6533https://github.com/amirthn6533
NativeScript:mainhttps://github.com/NativeScript/NativeScript/tree/main
amirthn6533:fix/css-mediaquery-unknown-typeshttps://github.com/amirthn6533/NativeScript/tree/fix/css-mediaquery-unknown-types
Conversation 6 https://github.com/NativeScript/NativeScript/pull/11644
Commits 2 https://github.com/NativeScript/NativeScript/pull/11644/commits
Checks 1 https://github.com/NativeScript/NativeScript/pull/11644/checks
Files changed 2 https://github.com/NativeScript/NativeScript/pull/11644/files
fix(core): preserve unknown and deprecated media query types https://github.com/NativeScript/NativeScript/pull/11644/files#top
Show all changes 2 commits https://github.com/NativeScript/NativeScript/pull/11644/files
e1da7fa fix(core): preserve unknown and deprecated media query types amirthn6533 Nov 16, 2026 https://github.com/NativeScript/NativeScript/pull/11644/commits/e1da7fa700920694d8521a8180c89ebba71458ce
edcb2d0 fix(core): treat reserved media type keywords as never-matching amirthn6533 Nov 20, 2026 https://github.com/NativeScript/NativeScript/pull/11644/commits/edcb2d042b8bec5d3e4cb31ae751828c704bb90c
Clear filters https://github.com/NativeScript/NativeScript/pull/11644/files
Please reload this pagehttps://github.com/NativeScript/NativeScript/pull/11644/files
Please reload this pagehttps://github.com/NativeScript/NativeScript/pull/11644/files
index.spec.ts https://github.com/NativeScript/NativeScript/pull/11644/files#diff-c19a29abb7a8b93b0f624e3c777bd6c11aef1cc3362a79697bd344ec0d9554f6
index.ts https://github.com/NativeScript/NativeScript/pull/11644/files#diff-627550f17b52d605fc8c1c3ca0fc2632ded7f668dd591c6c709c650374a7573b
packages/core/css-mediaquery/index.spec.tshttps://github.com/NativeScript/NativeScript/pull/11644/files#diff-c19a29abb7a8b93b0f624e3c777bd6c11aef1cc3362a79697bd344ec0d9554f6
View file https://github.com/NativeScript/NativeScript/blob/edcb2d042b8bec5d3e4cb31ae751828c704bb90c/packages/core/css-mediaquery/index.spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/NativeScript/NativeScript/pull/11644/{{ revealButtonHref }}
https://github.com/NativeScript/NativeScript/pull/11644/files#diff-c19a29abb7a8b93b0f624e3c777bd6c11aef1cc3362a79697bd344ec0d9554f6
https://github.com/NativeScript/NativeScript/pull/11644/files#diff-c19a29abb7a8b93b0f624e3c777bd6c11aef1cc3362a79697bd344ec0d9554f6
https://github.com/NativeScript/NativeScript/pull/11644/files#diff-c19a29abb7a8b93b0f624e3c777bd6c11aef1cc3362a79697bd344ec0d9554f6
packages/core/css-mediaquery/index.tshttps://github.com/NativeScript/NativeScript/pull/11644/files#diff-627550f17b52d605fc8c1c3ca0fc2632ded7f668dd591c6c709c650374a7573b
View file https://github.com/NativeScript/NativeScript/blob/edcb2d042b8bec5d3e4cb31ae751828c704bb90c/packages/core/css-mediaquery/index.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/NativeScript/NativeScript/pull/11644/{{ revealButtonHref }}
https://github.com/NativeScript/NativeScript/pull/11644/files#diff-627550f17b52d605fc8c1c3ca0fc2632ded7f668dd591c6c709c650374a7573b
https://github.com/NativeScript/NativeScript/pull/11644/files#diff-627550f17b52d605fc8c1c3ca0fc2632ded7f668dd591c6c709c650374a7573b
https://github.com/NativeScript/NativeScript/pull/11644/files#diff-627550f17b52d605fc8c1c3ca0fc2632ded7f668dd591c6c709c650374a7573b
https://github.com/NativeScript/NativeScript/pull/11644/files#diff-627550f17b52d605fc8c1c3ca0fc2632ded7f668dd591c6c709c650374a7573b
https://github.com/NativeScript/NativeScript/pull/11644/files#diff-627550f17b52d605fc8c1c3ca0fc2632ded7f668dd591c6c709c650374a7573b
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.