René's URL Explorer Experiment


Title: fix(android): map font-weight to the wght axis for custom fonts on API 26+ by aleclarson · Pull Request #11514 · NativeScript/NativeScript · GitHub

Open Graph Title: fix(android): map font-weight to the wght axis for custom fonts on API 26+ by aleclarson · Pull Request #11514 · NativeScript/NativeScript

X Title: fix(android): map font-weight to the wght axis for custom fonts on API 26+ by aleclarson · Pull Request #11514 · NativeScript/NativeScript

Description: PR Checklist The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/CONTRIBUTING.md#commit-messages. There is an issue for the bug/feature this PR is for — #11513. You have signed the CLA. All existing tests are passing — npx vitest run ui/styling/font.android.spec.ts (6/6); the new spec fails 4 of 6 cases against unpatched font.android.ts. Tests for the changes are included — packages/core/ui/styling/font.android.spec.ts. What is the current behavior? On Android API 26+, custom fonts loaded from files ignore CSS font-weight: loadFontFromFile passes only explicit font-variation-settings to Typeface.Builder.setFontVariationSettings, so a variable font with font-weight: 700 renders at its default weight. computeFontCacheKey also omits the weight, so two weights of the same family would collide in the typeface cache. And if a font doesn't support the wght axis, builder.build() throws with no retry — the file load fails outright. What is the new behavior? A wght axis entry derived from fontWeight (getNumericFontWeight) is appended to the variation settings unless the caller set wght explicitly — explicit settings always win. fontWeight joins the typeface cache key, so weights of one family cache independently. If the augmented build throws, the load retries once with the caller's explicit settings (fonts that lack the wght axis still load). If the caller did request wght explicitly, the error propagates to the outer catch as before and the font falls back to the default typeface — no retry of a request the caller made. Fixes #11513

Open Graph Description: PR Checklist The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/CONTRIBUTING.md#commit-messages. There is an issue for the bug/feature this...

X Description: PR Checklist The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/CONTRIBUTING.md#commit-messages. There is an issue for the bug/feature this...

Opengraph URL: https://github.com/NativeScript/NativeScript/pull/11514

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:5dad5050-e0af-565a-17ee-492458bf1e35
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE136:928E2:162CC46:1D98983:6B013B6D
html-safe-nonce6bcbdb3807531dd2ecba974a8b817f2cc8c2f2bc4b4ae127e714e28d7351af46
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMTM2OjkyOEUyOjE2MkNDNDY6MUQ5ODk4Mzo2QjAxM0I2RCIsInZpc2l0b3JfaWQiOiIyODM2NTE1MzI3NDIzMTAxODA1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac8eb720779bd72a4bf2acae8553458aa163bb3c961de690fc1fa8c1867e327c70
hovercard-subject-tagpull_request:4780670547
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/NativeScript/NativeScript/pull/11514/files
twitter:imagehttps://avatars.githubusercontent.com/u/1925840?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/1925840?s=400&v=4
og:image:altPR Checklist The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/CONTRIBUTING.md#commit-messages. There is an issue for the bug/feature this...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/NativeScript/NativeScript git https://github.com/NativeScript/NativeScript.git
octolytics-dimension-user_id7392261
octolytics-dimension-user_loginNativeScript
octolytics-dimension-repository_id31492490
octolytics-dimension-repository_nwoNativeScript/NativeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id31492490
octolytics-dimension-repository_network_root_nwoNativeScript/NativeScript
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/NativeScript/NativeScript/pull/11514/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNativeScript%2FNativeScript%2Fpull%2F11514%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNativeScript%2FNativeScript%2Fpull%2F11514%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=NativeScript%2FNativeScript
Reloadhttps://github.com/NativeScript/NativeScript/pull/11514/files
Reloadhttps://github.com/NativeScript/NativeScript/pull/11514/files
Reloadhttps://github.com/NativeScript/NativeScript/pull/11514/files
NativeScripthttps://github.com/NativeScript
NativeScripthttps://github.com/NativeScript/NativeScript
Codehttps://github.com/NativeScript/NativeScript
Issues231 (231)https://github.com/NativeScript/NativeScript/issues
Pull requests107 (107)https://github.com/NativeScript/NativeScript/pulls
Discussionshttps://github.com/NativeScript/NativeScript/discussions
Actionshttps://github.com/NativeScript/NativeScript/actions
Projectshttps://github.com/NativeScript/NativeScript/projects
Wikihttps://github.com/NativeScript/NativeScript/wiki
Security and qualityhttps://github.com/NativeScript/NativeScript/security
Insightshttps://github.com/NativeScript/NativeScript/insights
Sign up for GitHub https://github.com/signup?return_to=%2FNativeScript%2FNativeScript%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FNativeScript%2FNativeScript%2Fissues%2Fnew%2Fchoose
aleclarsonhttps://github.com/aleclarson
NativeScript:mainhttps://github.com/NativeScript/NativeScript/tree/main
aleclarson:fix/android-font-weight-wghthttps://github.com/aleclarson/nativescript/tree/fix/android-font-weight-wght
Conversation 2 https://github.com/NativeScript/NativeScript/pull/11514
Commits 1 https://github.com/NativeScript/NativeScript/pull/11514/commits
Checks 5 https://github.com/NativeScript/NativeScript/pull/11514/checks
Files changed https://github.com/NativeScript/NativeScript/pull/11514/files
Please reload this pagehttps://github.com/NativeScript/NativeScript/pull/11514/files
fix(android): map font-weight to the wght axis for custom fonts on API 26+ https://github.com/NativeScript/NativeScript/pull/11514/files#top
Show all changes 1 commit https://github.com/NativeScript/NativeScript/pull/11514/files
f2843f7 fix(android): map font-weight to the wght axis for custom fonts on AP… aleclarson Oct 8, 2026 https://github.com/NativeScript/NativeScript/pull/11514/commits/f2843f78e40d373e817a583369312656f36ad554
Clear filters https://github.com/NativeScript/NativeScript/pull/11514/files
Please reload this pagehttps://github.com/NativeScript/NativeScript/pull/11514/files
Please reload this pagehttps://github.com/NativeScript/NativeScript/pull/11514/files
font.android.spec.ts https://github.com/NativeScript/NativeScript/pull/11514/files#diff-e6c39c3e06b739a833d57d50a91cd6e53aa621e878c6a55dd1aa48b4919026dc
font.android.ts https://github.com/NativeScript/NativeScript/pull/11514/files#diff-de3eb41a054bd4313e620ee129b0f80670729ee6f354cecb879253226b5152db
packages/core/ui/styling/font.android.spec.tshttps://github.com/NativeScript/NativeScript/pull/11514/files#diff-e6c39c3e06b739a833d57d50a91cd6e53aa621e878c6a55dd1aa48b4919026dc
View file https://github.com/NativeScript/NativeScript/blob/f2843f78e40d373e817a583369312656f36ad554/packages/core/ui/styling/font.android.spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/NativeScript/NativeScript/pull/11514/{{ revealButtonHref }}
packages/core/ui/styling/font.android.tshttps://github.com/NativeScript/NativeScript/pull/11514/files#diff-de3eb41a054bd4313e620ee129b0f80670729ee6f354cecb879253226b5152db
View file https://github.com/NativeScript/NativeScript/blob/f2843f78e40d373e817a583369312656f36ad554/packages/core/ui/styling/font.android.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/NativeScript/NativeScript/pull/11514/{{ revealButtonHref }}
https://github.com/NativeScript/NativeScript/pull/11514/files#diff-de3eb41a054bd4313e620ee129b0f80670729ee6f354cecb879253226b5152db
https://github.com/NativeScript/NativeScript/pull/11514/files#diff-de3eb41a054bd4313e620ee129b0f80670729ee6f354cecb879253226b5152db
https://github.com/NativeScript/NativeScript/pull/11514/files#diff-de3eb41a054bd4313e620ee129b0f80670729ee6f354cecb879253226b5152db
https://github.com/NativeScript/NativeScript/pull/11514/files#diff-de3eb41a054bd4313e620ee129b0f80670729ee6f354cecb879253226b5152db
Please reload this pagehttps://github.com/NativeScript/NativeScript/pull/11514/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.