Title: perf(ios): request layout once per turn and append subviews without copying by triniwiz · Pull Request #11507 · NativeScript/NativeScript · GitHub
Open Graph Title: perf(ios): request layout once per turn and append subviews without copying by triniwiz · Pull Request #11507 · NativeScript/NativeScript
X Title: perf(ios): request layout once per turn and append subviews without copying by triniwiz · Pull Request #11507 · NativeScript/NativeScript
Description: PR Checklist The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/CONTRIBUTING.md#commit-messages. There is an issue for the bug/feature this PR is for. To avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it. You have signed the CLA. All existing tests are passing: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/DevelopmentWorkflow.md#running-unit-tests-application. Tests for the changes are included - https://github.com/NativeScript/NativeScript/blob/master/tools/notes/WritingUnitTests.md. What is the current behavior? requestLayout on iOS climbs to the root on every call and calls setNeedsLayout at each level. CSS calls it once per layout-affecting property, so styling one view costs depth times properties native calls, all reaching ancestors that were already flagged by the first call. insertNativeSubview reads subviews before checking whether an index was given. Reading it copies the array, so appending k children to one parent is O(k^2). What is the new behavior? requestLayout returns early when the view already climbed in this turn and is still flagged. A layout pass in between clears the flag, so the next request climbs again. The set of views is cleared by a microtask at the end of the turn. Appends call addSubview without reading subviews. New specs: a repeat request in the same turn does not climb (fails on main), and a request climbs again in the next turn and after a layout pass. Numbers Scenario (M) Painted before Painted after Attach before Attach after flex-wrap-tiles 1155.9 987.8 551.0 390.6 grid-dashboard 292.7 256.1 143.5 112.0 insert-remove 1144.0 1004.8 541.9 396.0 nested-chain 31.7 27.0 16.1 10.3 relayout-resize 330.2 302.1 118.7 92.3 relayout-style 328.1 302.7 117.5 91.4 styled-cards 385.6 337.1 198.0 152.5 text-flow 205.6 192.8 48.5 40.8 tree-fanout 330.5 299.7 118.6 90.9 Mutation (M) Before After restyle (relayout-style) 185.9 176.2 restore (relayout-style) 186.0 173.6 insert (insert-remove) 466.0 458.4 remove (insert-remove) 303.3 306.0 shrink (relayout-resize) 144.4 143.1 grow (relayout-resize) 144.0 142.9 How this was measured xplat-benchmarks ns-core app (plain core, no plugins), iPhone 17 Pro Max simulator, iOS 26.4. Each scenario mounts about 1,000 views at size M. Base and change were installed alternately for 3 rounds of 10 measured iterations, median ms, lower is better. "Attach" is assigning the built tree to a loaded parent (native view creation, CSS, native setters); "painted" ends one frame after layout. A GC is forced before each mutation, as it already is after each unmount, so a collection pause lands in the same phase for both builds. Part of a series: #11505, #11506, #11507 (this), #11510.
Open Graph Description: PR Checklist The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/CONTRIBUTING.md#commit-messages. There is an issue for the bug/feature this...
X Description: PR Checklist The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/CONTRIBUTING.md#commit-messages. There is an issue for the bug/feature this...
Opengraph URL: https://github.com/NativeScript/NativeScript/pull/11507
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:8da61a43-a639-db7a-27ad-ae28a1a3db49 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 8B38:24ACB9:18170E5:1FA19EC:6B01335F |
| html-safe-nonce | 85d9c70668dccb68dc99d404424845356470d7ec0b72d09f2b60f2524312e09d |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4QjM4OjI0QUNCOToxODE3MEU1OjFGQTE5RUM6NkIwMTMzNUYiLCJ2aXNpdG9yX2lkIjoiMjQ4ODY0MzIyNzIxNzkwMDM4MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 43eed9313121bb13944a10b00aa3244eb8ea988a12d03f89ca27eeb2f0cb0c7d |
| hovercard-subject-tag | pull_request:4752619722 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/NativeScript/NativeScript/pull/11507/files |
| twitter:image | https://avatars.githubusercontent.com/u/6695919?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/6695919?s=400&v=4 |
| og:image:alt | PR Checklist The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/CONTRIBUTING.md#commit-messages. There is an issue for the bug/feature this... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/NativeScript/NativeScript git https://github.com/NativeScript/NativeScript.git |
| octolytics-dimension-user_id | 7392261 |
| octolytics-dimension-user_login | NativeScript |
| octolytics-dimension-repository_id | 31492490 |
| octolytics-dimension-repository_nwo | NativeScript/NativeScript |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 31492490 |
| octolytics-dimension-repository_network_root_nwo | NativeScript/NativeScript |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width