René's URL Explorer Experiment


Title: fix(ios): honor corner-shape: squircle for non-uniform border radii by aleclarson · Pull Request #11451 · NativeScript/NativeScript · GitHub

Open Graph Title: fix(ios): honor corner-shape: squircle for non-uniform border radii by aleclarson · Pull Request #11451 · NativeScript/NativeScript

X Title: fix(ios): honor corner-shape: squircle for non-uniform border radii by aleclarson · Pull Request #11451 · NativeScript/NativeScript

Description: PR Checklist The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/CONTRIBUTING.md#commit-messages. There is an issue for the bug/feature this PR is for. To avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it. You have signed the CLA. All existing tests are passing: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/DevelopmentWorkflow.md#running-unit-tests-application. Tests for the changes are included - https://github.com/NativeScript/NativeScript/blob/master/tools/notes/WritingUnitTests.md. What is the current behavior? #11365 added corner-shape: squircle support by mapping it to CALayer.cornerCurve — but only on the uniform border-radius path, where the view's own cornerRadius does the rounding. Views with non-uniform radii (e.g. border-radius: 16px 16px 0 0, a bottom sheet with rounded top corners) are instead clipped by a CAShapeLayer mask built from custom CGPath generators — and those generators hardcode CGPathAddArcToPoint/CGPathAddArc, so corner-shape is silently ignored. What is the new behavior? The non-uniform path generators honor background.cornerShape. A new addSquircleArcToPoint helper draws each corner as a sampled n=4 superellipse (the curve the CSS spec defines for corner-shape: squircle, and the closest parametric approximation of Apple's continuous corner — CAShapeLayer has no cornerCurve equivalent for custom paths). It is wired into: generateNonUniformBorderOuterClipPath (view mask, LayerMask.BORDER) generateNonUniformBorderInnerClipPath (uniform-color border fill) generateShadowLayerPaths (box-shadow inner/mask + shadow paths, both uniform and non-uniform radius cases) generateNonUniformBorderOuterClipRoundedPath (bounds-animation path updates) cornerShape: round output is byte-for-byte what it was before — the circular-arc calls remain untouched behind if (squircle) branches. Implementation note: each quarter arc is emitted as a 12-segment polyline (SQUIRCLE_CORNER_STEPS). Corner masks are rasterized once per bounds change, so the sampling is visually indistinguishable at screen scale while keeping the code dependency-free. Happy to switch to cubic Bézier segments if reviewers prefer — the polyline keeps the math readable but a two-curve fit would shrink the element count. Testing The unit suite can't exercise real CGPath/CAShapeLayer code, so I verified on an iOS 26.5 simulator: Uniform radius + corner-shape: squircle → layer.cornerCurve === 'continuous' (unchanged behavior). Non-uniform radius (20pt top corners) + corner-shape: squircle → layer.mask is a CAShapeLayer whose path containsPoint a coordinate that lies inside a squircle but outside a circular arc of the same radius — confirming the mask is the superellipse, not a circle. A near-vertex control point correctly reports outside. corner-shape unset/round → identical mask path shape as before. Refs #11365.

Open Graph Description: PR Checklist The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/CONTRIBUTING.md#commit-messages. There is an issue for the bug/feature this...

X Description: PR Checklist The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/CONTRIBUTING.md#commit-messages. There is an issue for the bug/feature this...

Opengraph URL: https://github.com/NativeScript/NativeScript/pull/11451

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:35dfd841-9358-f703-3830-82a9dfc61d0b
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAB5A:21BD98:B527FC:E49F64:6B013037
html-safe-nonce5c1bd4729ff14032dbec9e76dd2871824f10dc68bd379b52b082e99e45640ecf
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQjVBOjIxQkQ5ODpCNTI3RkM6RTQ5RjY0OjZCMDEzMDM3IiwidmlzaXRvcl9pZCI6IjY3MjM3NDIxMzIyNjUzNjU1NTkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac5794771ad34e1d0d69d7044e7d7b2e85472dbb9c48ac430a30527b1c79a31916
hovercard-subject-tagpull_request:4640875739
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/NativeScript/NativeScript/pull/11451/files
twitter:imagehttps://avatars.githubusercontent.com/u/1925840?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/1925840?s=400&v=4
og:image:altPR Checklist The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/CONTRIBUTING.md#commit-messages. There is an issue for the bug/feature this...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/NativeScript/NativeScript git https://github.com/NativeScript/NativeScript.git
octolytics-dimension-user_id7392261
octolytics-dimension-user_loginNativeScript
octolytics-dimension-repository_id31492490
octolytics-dimension-repository_nwoNativeScript/NativeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id31492490
octolytics-dimension-repository_network_root_nwoNativeScript/NativeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/NativeScript/NativeScript/pull/11451/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNativeScript%2FNativeScript%2Fpull%2F11451%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNativeScript%2FNativeScript%2Fpull%2F11451%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=NativeScript%2FNativeScript
Reloadhttps://github.com/NativeScript/NativeScript/pull/11451/files
Reloadhttps://github.com/NativeScript/NativeScript/pull/11451/files
Reloadhttps://github.com/NativeScript/NativeScript/pull/11451/files
NativeScripthttps://github.com/NativeScript
NativeScripthttps://github.com/NativeScript/NativeScript
Codehttps://github.com/NativeScript/NativeScript
Issues231 (231)https://github.com/NativeScript/NativeScript/issues
Pull requests107 (107)https://github.com/NativeScript/NativeScript/pulls
Discussionshttps://github.com/NativeScript/NativeScript/discussions
Actionshttps://github.com/NativeScript/NativeScript/actions
Projectshttps://github.com/NativeScript/NativeScript/projects
Wikihttps://github.com/NativeScript/NativeScript/wiki
Security and qualityhttps://github.com/NativeScript/NativeScript/security
Insightshttps://github.com/NativeScript/NativeScript/insights
Sign up for GitHub https://github.com/signup?return_to=%2FNativeScript%2FNativeScript%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FNativeScript%2FNativeScript%2Fissues%2Fnew%2Fchoose
aleclarsonhttps://github.com/aleclarson
NativeScript:mainhttps://github.com/NativeScript/NativeScript/tree/main
aleclarson:fix/corner-shape-non-uniformhttps://github.com/aleclarson/nativescript/tree/fix/corner-shape-non-uniform
Conversation 3 https://github.com/NativeScript/NativeScript/pull/11451
Commits 1 https://github.com/NativeScript/NativeScript/pull/11451/commits
Checks 5 https://github.com/NativeScript/NativeScript/pull/11451/checks
Files changed https://github.com/NativeScript/NativeScript/pull/11451/files
Please reload this pagehttps://github.com/NativeScript/NativeScript/pull/11451/files
fix(ios): honor corner-shape: squircle for non-uniform border radii https://github.com/NativeScript/NativeScript/pull/11451/files#top
Show all changes 1 commit https://github.com/NativeScript/NativeScript/pull/11451/files
dd4717e fix(core-ios): honor corner-shape: squircle for non-uniform border radii aleclarson Sep 25, 2026 https://github.com/NativeScript/NativeScript/pull/11451/commits/dd4717ee6c6c2fc8879d5185ab6bd8ea2c9352a2
Clear filters https://github.com/NativeScript/NativeScript/pull/11451/files
Please reload this pagehttps://github.com/NativeScript/NativeScript/pull/11451/files
Please reload this pagehttps://github.com/NativeScript/NativeScript/pull/11451/files
packages/core/ui/styling/background.ios.tshttps://github.com/NativeScript/NativeScript/pull/11451/files#diff-3af015d97ace6f8360474b5aef4d08baa3b943fbdf28968b12e537325e11e6a9
View file https://github.com/NativeScript/NativeScript/blob/dd4717ee6c6c2fc8879d5185ab6bd8ea2c9352a2/packages/core/ui/styling/background.ios.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/NativeScript/NativeScript/pull/11451/{{ revealButtonHref }}
https://github.com/NativeScript/NativeScript/pull/11451/files#diff-3af015d97ace6f8360474b5aef4d08baa3b943fbdf28968b12e537325e11e6a9
https://github.com/NativeScript/NativeScript/pull/11451/files#diff-3af015d97ace6f8360474b5aef4d08baa3b943fbdf28968b12e537325e11e6a9
https://github.com/NativeScript/NativeScript/pull/11451/files#diff-3af015d97ace6f8360474b5aef4d08baa3b943fbdf28968b12e537325e11e6a9
https://github.com/NativeScript/NativeScript/pull/11451/files#diff-3af015d97ace6f8360474b5aef4d08baa3b943fbdf28968b12e537325e11e6a9
https://github.com/NativeScript/NativeScript/pull/11451/files#diff-3af015d97ace6f8360474b5aef4d08baa3b943fbdf28968b12e537325e11e6a9
https://github.com/NativeScript/NativeScript/pull/11451/files#diff-3af015d97ace6f8360474b5aef4d08baa3b943fbdf28968b12e537325e11e6a9
https://github.com/NativeScript/NativeScript/pull/11451/files#diff-3af015d97ace6f8360474b5aef4d08baa3b943fbdf28968b12e537325e11e6a9
https://github.com/NativeScript/NativeScript/pull/11451/files#diff-3af015d97ace6f8360474b5aef4d08baa3b943fbdf28968b12e537325e11e6a9
https://github.com/NativeScript/NativeScript/pull/11451/files#diff-3af015d97ace6f8360474b5aef4d08baa3b943fbdf28968b12e537325e11e6a9
https://github.com/NativeScript/NativeScript/pull/11451/files#diff-3af015d97ace6f8360474b5aef4d08baa3b943fbdf28968b12e537325e11e6a9
https://github.com/NativeScript/NativeScript/pull/11451/files#diff-3af015d97ace6f8360474b5aef4d08baa3b943fbdf28968b12e537325e11e6a9
https://github.com/NativeScript/NativeScript/pull/11451/files#diff-3af015d97ace6f8360474b5aef4d08baa3b943fbdf28968b12e537325e11e6a9
https://github.com/NativeScript/NativeScript/pull/11451/files#diff-3af015d97ace6f8360474b5aef4d08baa3b943fbdf28968b12e537325e11e6a9
Please reload this pagehttps://github.com/NativeScript/NativeScript/pull/11451/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.