René's URL Explorer Experiment


Title: fix(core): keep function values intact when splitting css shorthands by edusperoni · Pull Request #11364 · NativeScript/NativeScript · GitHub

Open Graph Title: fix(core): keep function values intact when splitting css shorthands by edusperoni · Pull Request #11364 · NativeScript/NativeScript

X Title: fix(core): keep function values intact when splitting css shorthands by edusperoni · Pull Request #11364 · NativeScript/NativeScript

Description: PR Checklist The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/CONTRIBUTING.md#commit-messages. There is an issue for the bug/feature this PR is for. To avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it. You have signed the CLA. All existing tests are passing: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/DevelopmentWorkflow.md#running-unit-tests-application. Tests for the changes are included - https://github.com/NativeScript/NativeScript/blob/master/tools/notes/WritingUnitTests.md. What is the current behavior? CSS values holding nested functions fall apart during parsing: The whitespace/comma splitters in css-utils.ts guard parenthesized arguments with a negative lookahead (/\s(?![^(]*\))/) that only understands a single paren level. A shadow like box-shadow: 0 0 10px color-mix(in srgb, var(--x) 35%, transparent) — or a comma-separated list of such shadows — gets split inside the function and the parse fails. border-color only special-cases values starting with rgb/hsl; any other function color (color-mix(), oklch(), hwb()) or a per-side list containing a function gets shredded on every space and comma — even though Color itself parses all of these. Consecutive whitespace in a shorthand (1px 1px 2px black) injects an empty part that becomes a bogus zero length, silently shifting every value after it (blur becomes 0, spread takes the blur). Apps currently patch @nativescript/core dist output to work around both. What is the new behavior? A depth-counting scanner splits on top-level separators only, so any nesting depth parses correctly. Since a per-character scan is several times slower than the native regex engine when there's no JIT (iOS), the splitters are tiered: values with no parenthesis take a plain native split, a single paren level keeps the previous (provably correct there) lookahead regex, and only nested values — previously broken, so nothing regresses — take the scan. input class JIT old→new (ns/op) jitless old→new no parens 117 → 100 262 → 290 single paren level 141 → 177 301 → 438 nested (was broken) 232 → 130 447 → 1621 border-color splits sides on top-level spaces/commas, so border-color: color-mix(in srgb, red 50%, blue) applies to all four sides, and border-color: red rgb(1, 2, 3) blue oklch(0.5 0.1 20) assigns per side. The rgb/hsl prefix special case is gone. Legacy comma-separated values still parse. Empty parts from consecutive whitespace are dropped, fixing the shifted-shadow bug. 20 new unit tests across css-utils.spec.ts (new), css-shadow.spec.ts, and style-properties.spec.ts (new).

Open Graph Description: PR Checklist The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/CONTRIBUTING.md#commit-messages. There is an issue for the bug/feature this...

X Description: PR Checklist The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/CONTRIBUTING.md#commit-messages. There is an issue for the bug/feature this...

Opengraph URL: https://github.com/NativeScript/NativeScript/pull/11364

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:63c11870-e15b-40d5-dda4-8107593dc2a7
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDE1A:358871:187ACBB:20347A0:6B013A4D
html-safe-nonce2b1a288793f6d7ac24d4380e3ad4f92db7d394659807b23a7fcbc2de6e91c50e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERTFBOjM1ODg3MToxODdBQ0JCOjIwMzQ3QTA6NkIwMTNBNEQiLCJ2aXNpdG9yX2lkIjoiNzU3NDM0NDcxMDQwNDk4MjUzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac0f502329906f37e0fd5b2e15326727471b84ecc4ddeed417ccc1b7ad4981452d
hovercard-subject-tagpull_request:4369726279
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/NativeScript/NativeScript/pull/11364/files
twitter:imagehttps://avatars.githubusercontent.com/u/4061767?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/4061767?s=400&v=4
og:image:altPR Checklist The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/CONTRIBUTING.md#commit-messages. There is an issue for the bug/feature this...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/NativeScript/NativeScript git https://github.com/NativeScript/NativeScript.git
octolytics-dimension-user_id7392261
octolytics-dimension-user_loginNativeScript
octolytics-dimension-repository_id31492490
octolytics-dimension-repository_nwoNativeScript/NativeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id31492490
octolytics-dimension-repository_network_root_nwoNativeScript/NativeScript
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/NativeScript/NativeScript/pull/11364/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNativeScript%2FNativeScript%2Fpull%2F11364%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNativeScript%2FNativeScript%2Fpull%2F11364%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=NativeScript%2FNativeScript
Reloadhttps://github.com/NativeScript/NativeScript/pull/11364/files
Reloadhttps://github.com/NativeScript/NativeScript/pull/11364/files
Reloadhttps://github.com/NativeScript/NativeScript/pull/11364/files
NativeScripthttps://github.com/NativeScript
NativeScripthttps://github.com/NativeScript/NativeScript
Codehttps://github.com/NativeScript/NativeScript
Issues231 (231)https://github.com/NativeScript/NativeScript/issues
Pull requests107 (107)https://github.com/NativeScript/NativeScript/pulls
Discussionshttps://github.com/NativeScript/NativeScript/discussions
Actionshttps://github.com/NativeScript/NativeScript/actions
Projectshttps://github.com/NativeScript/NativeScript/projects
Wikihttps://github.com/NativeScript/NativeScript/wiki
Security and qualityhttps://github.com/NativeScript/NativeScript/security
Insightshttps://github.com/NativeScript/NativeScript/insights
Sign up for GitHub https://github.com/signup?return_to=%2FNativeScript%2FNativeScript%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FNativeScript%2FNativeScript%2Fissues%2Fnew%2Fchoose
NathanWalkerhttps://github.com/NathanWalker
mainhttps://github.com/NativeScript/NativeScript/tree/main
fix/css-function-value-splittinghttps://github.com/NativeScript/NativeScript/tree/fix/css-function-value-splitting
Conversation 2 https://github.com/NativeScript/NativeScript/pull/11364
Commits 2 https://github.com/NativeScript/NativeScript/pull/11364/commits
Checks 8 https://github.com/NativeScript/NativeScript/pull/11364/checks
Files changed https://github.com/NativeScript/NativeScript/pull/11364/files
Please reload this pagehttps://github.com/NativeScript/NativeScript/pull/11364/files
fix(core): keep function values intact when splitting css shorthands https://github.com/NativeScript/NativeScript/pull/11364/files#top
Show all changes 2 commits https://github.com/NativeScript/NativeScript/pull/11364/files
edc9a7c fix(core): keep css values with nested functions intact when splitting edusperoni Aug 26, 2026 https://github.com/NativeScript/NativeScript/pull/11364/commits/edc9a7cc16bb70ecb5717aba70688a61b5b9b67c
8007ee0 fix(core): support function colors in the border-color shorthand edusperoni Aug 26, 2026 https://github.com/NativeScript/NativeScript/pull/11364/commits/8007ee0680357f0915959484ce88e3954e932a8d
Clear filters https://github.com/NativeScript/NativeScript/pull/11364/files
Please reload this pagehttps://github.com/NativeScript/NativeScript/pull/11364/files
Please reload this pagehttps://github.com/NativeScript/NativeScript/pull/11364/files
css-shadow.spec.ts https://github.com/NativeScript/NativeScript/pull/11364/files#diff-92a0b9be9bf639be30b2445a53835db093f7daf7e7a9f01f6fc56de9fc17b42a
css-utils.spec.ts https://github.com/NativeScript/NativeScript/pull/11364/files#diff-42d450b588f74cad50059b316746789b001905bb77f191df75104a654d0ed976
css-utils.ts https://github.com/NativeScript/NativeScript/pull/11364/files#diff-ccce8d9a430456b3f1016f3417eea41c23e1f68d7bb4dde4a9e750724b0cdf29
style-properties.spec.ts https://github.com/NativeScript/NativeScript/pull/11364/files#diff-bf7cc640372dd2033e116ccafb137f8da74050d01a78862fd1eca46d043fa6e1
style-properties.ts https://github.com/NativeScript/NativeScript/pull/11364/files#diff-b12b429e27aa4ee7a29b40656bcbdf29f8df59d8214899f324d5dd279ebe026b
packages/core/ui/styling/css-shadow.spec.tshttps://github.com/NativeScript/NativeScript/pull/11364/files#diff-92a0b9be9bf639be30b2445a53835db093f7daf7e7a9f01f6fc56de9fc17b42a
View file https://github.com/NativeScript/NativeScript/blob/8007ee0680357f0915959484ce88e3954e932a8d/packages/core/ui/styling/css-shadow.spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/NativeScript/NativeScript/pull/11364/{{ revealButtonHref }}
https://github.com/NativeScript/NativeScript/pull/11364/files#diff-92a0b9be9bf639be30b2445a53835db093f7daf7e7a9f01f6fc56de9fc17b42a
https://github.com/NativeScript/NativeScript/pull/11364/files#diff-92a0b9be9bf639be30b2445a53835db093f7daf7e7a9f01f6fc56de9fc17b42a
packages/core/ui/styling/css-utils.spec.tshttps://github.com/NativeScript/NativeScript/pull/11364/files#diff-42d450b588f74cad50059b316746789b001905bb77f191df75104a654d0ed976
View file https://github.com/NativeScript/NativeScript/blob/8007ee0680357f0915959484ce88e3954e932a8d/packages/core/ui/styling/css-utils.spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/NativeScript/NativeScript/pull/11364/{{ revealButtonHref }}
packages/core/ui/styling/css-utils.tshttps://github.com/NativeScript/NativeScript/pull/11364/files#diff-ccce8d9a430456b3f1016f3417eea41c23e1f68d7bb4dde4a9e750724b0cdf29
View file https://github.com/NativeScript/NativeScript/blob/8007ee0680357f0915959484ce88e3954e932a8d/packages/core/ui/styling/css-utils.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/NativeScript/NativeScript/pull/11364/{{ revealButtonHref }}
https://github.com/NativeScript/NativeScript/pull/11364/files#diff-ccce8d9a430456b3f1016f3417eea41c23e1f68d7bb4dde4a9e750724b0cdf29
https://github.com/NativeScript/NativeScript/pull/11364/files#diff-ccce8d9a430456b3f1016f3417eea41c23e1f68d7bb4dde4a9e750724b0cdf29
https://github.com/NativeScript/NativeScript/pull/11364/files#diff-ccce8d9a430456b3f1016f3417eea41c23e1f68d7bb4dde4a9e750724b0cdf29
packages/core/ui/styling/style-properties.spec.tshttps://github.com/NativeScript/NativeScript/pull/11364/files#diff-bf7cc640372dd2033e116ccafb137f8da74050d01a78862fd1eca46d043fa6e1
View file https://github.com/NativeScript/NativeScript/blob/8007ee0680357f0915959484ce88e3954e932a8d/packages/core/ui/styling/style-properties.spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/NativeScript/NativeScript/pull/11364/{{ revealButtonHref }}
packages/core/ui/styling/style-properties.tshttps://github.com/NativeScript/NativeScript/pull/11364/files#diff-b12b429e27aa4ee7a29b40656bcbdf29f8df59d8214899f324d5dd279ebe026b
View file https://github.com/NativeScript/NativeScript/blob/8007ee0680357f0915959484ce88e3954e932a8d/packages/core/ui/styling/style-properties.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/NativeScript/NativeScript/pull/11364/{{ revealButtonHref }}
https://github.com/NativeScript/NativeScript/pull/11364/files#diff-b12b429e27aa4ee7a29b40656bcbdf29f8df59d8214899f324d5dd279ebe026b
https://github.com/NativeScript/NativeScript/pull/11364/files#diff-b12b429e27aa4ee7a29b40656bcbdf29f8df59d8214899f324d5dd279ebe026b
https://github.com/NativeScript/NativeScript/pull/11364/files#diff-b12b429e27aa4ee7a29b40656bcbdf29f8df59d8214899f324d5dd279ebe026b
https://github.com/NativeScript/NativeScript/pull/11364/files#diff-b12b429e27aa4ee7a29b40656bcbdf29f8df59d8214899f324d5dd279ebe026b
https://github.com/NativeScript/NativeScript/pull/11364/files#diff-b12b429e27aa4ee7a29b40656bcbdf29f8df59d8214899f324d5dd279ebe026b
https://github.com/NativeScript/NativeScript/pull/11364/files#diff-b12b429e27aa4ee7a29b40656bcbdf29f8df59d8214899f324d5dd279ebe026b
Please reload this pagehttps://github.com/NativeScript/NativeScript/pull/11364/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.