René's URL Explorer Experiment


Title: fix(ios): Added missing Frame backstack disposal handling by CatchABus · Pull Request #10672 · NativeScript/NativeScript · GitHub

Open Graph Title: fix(ios): Added missing Frame backstack disposal handling by CatchABus · Pull Request #10672 · NativeScript/NativeScript

X Title: fix(ios): Added missing Frame backstack disposal handling by CatchABus · Pull Request #10672 · NativeScript/NativeScript

Description: PR Checklist The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/CONTRIBUTING.md#commit-messages. There is an issue for the bug/feature this PR is for. To avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it. You have signed the CLA. All existing tests are passing: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/DevelopmentWorkflow.md#running-unit-tests-application. Tests for the changes are included - https://github.com/NativeScript/NativeScript/blob/master/tools/notes/WritingUnitTests.md. What is the current behavior? Upon disposal, iOS frame does not dispose its page views resulting in memory leaks or accessible native view references that have already been affected by GC. That goes for current, executing, and backstack pages. What is the new behavior? Frame will dispose all owning page views upon its disposal.

Open Graph Description: PR Checklist The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/CONTRIBUTING.md#commit-messages. There is an issue for the bug/feature this...

X Description: PR Checklist The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/CONTRIBUTING.md#commit-messages. There is an issue for the bug/feature this...

Opengraph URL: https://github.com/NativeScript/NativeScript/pull/10672

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:293b3f54-88b1-6383-802d-e0b88b8f8ecb
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC380:12D7DC:5077969:694095F:6A5D81F3
html-safe-nonce6d8850fb14b5beec76c5f89980ece845fa33fe95936c6e41624706741f656769
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMzgwOjEyRDdEQzo1MDc3OTY5OjY5NDA5NUY6NkE1RDgxRjMiLCJ2aXNpdG9yX2lkIjoiOTYxMTkzODY5OTQ1MTc2NTYzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacfb1403c9e70fba35d95b2ed4e8304e23c07a4c8fda36638ebc90c223e972f735
hovercard-subject-tagpull_request:2293070138
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/NativeScript/NativeScript/pull/10672/files
twitter:imagehttps://avatars.githubusercontent.com/u/55595100?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/55595100?s=400&v=4
og:image:altPR Checklist The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/CONTRIBUTING.md#commit-messages. There is an issue for the bug/feature this...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None5290d7e14309ad1e76106a9c4237bd1041517e83ea182c8ab756752cb0c6940b
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/NativeScript/NativeScript git https://github.com/NativeScript/NativeScript.git
octolytics-dimension-user_id7392261
octolytics-dimension-user_loginNativeScript
octolytics-dimension-repository_id31492490
octolytics-dimension-repository_nwoNativeScript/NativeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id31492490
octolytics-dimension-repository_network_root_nwoNativeScript/NativeScript
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9c975978430e9ad293956f2bbdaf153b1bd84a99
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/NativeScript/NativeScript/pull/10672/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNativeScript%2FNativeScript%2Fpull%2F10672%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNativeScript%2FNativeScript%2Fpull%2F10672%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=NativeScript%2FNativeScript
Reloadhttps://github.com/NativeScript/NativeScript/pull/10672/files
Reloadhttps://github.com/NativeScript/NativeScript/pull/10672/files
Reloadhttps://github.com/NativeScript/NativeScript/pull/10672/files
Please reload this pagehttps://github.com/NativeScript/NativeScript/pull/10672/files
NativeScript https://github.com/NativeScript
NativeScripthttps://github.com/NativeScript/NativeScript
Please reload this pagehttps://github.com/NativeScript/NativeScript/pull/10672/files
Notifications https://github.com/login?return_to=%2FNativeScript%2FNativeScript
Fork 1.7k https://github.com/login?return_to=%2FNativeScript%2FNativeScript
Star 25.6k https://github.com/login?return_to=%2FNativeScript%2FNativeScript
Code https://github.com/NativeScript/NativeScript
Issues 771 https://github.com/NativeScript/NativeScript/issues
Pull requests 67 https://github.com/NativeScript/NativeScript/pulls
Discussions https://github.com/NativeScript/NativeScript/discussions
Actions https://github.com/NativeScript/NativeScript/actions
Projects https://github.com/NativeScript/NativeScript/projects
Wiki https://github.com/NativeScript/NativeScript/wiki
Security and quality 0 https://github.com/NativeScript/NativeScript/security
Insights https://github.com/NativeScript/NativeScript/pulse
Code https://github.com/NativeScript/NativeScript
Issues https://github.com/NativeScript/NativeScript/issues
Pull requests https://github.com/NativeScript/NativeScript/pulls
Discussions https://github.com/NativeScript/NativeScript/discussions
Actions https://github.com/NativeScript/NativeScript/actions
Projects https://github.com/NativeScript/NativeScript/projects
Wiki https://github.com/NativeScript/NativeScript/wiki
Security and quality https://github.com/NativeScript/NativeScript/security
Insights https://github.com/NativeScript/NativeScript/pulse
Sign up for GitHub https://github.com/signup?return_to=%2FNativeScript%2FNativeScript%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FNativeScript%2FNativeScript%2Fissues%2Fnew%2Fchoose
NathanWalkerhttps://github.com/NathanWalker
NativeScript:mainhttps://github.com/NativeScript/NativeScript/tree/main
CatchABus:fix/ios-frame-cleanuphttps://github.com/CatchABus/NativeScript/tree/fix/ios-frame-cleanup
Conversation 0 https://github.com/NativeScript/NativeScript/pull/10672
Commits 2 https://github.com/NativeScript/NativeScript/pull/10672/commits
Checks 0 https://github.com/NativeScript/NativeScript/pull/10672/checks
Files changed https://github.com/NativeScript/NativeScript/pull/10672/files
Please reload this pagehttps://github.com/NativeScript/NativeScript/pull/10672/files
fix(ios): Added missing Frame backstack disposal handling https://github.com/NativeScript/NativeScript/pull/10672/files#top
Show all changes 2 commits https://github.com/NativeScript/NativeScript/pull/10672/files
5986f10 fix(ios): Added missing Frame backstack disposal handling CatchABus Jan 22, 2025 https://github.com/NativeScript/NativeScript/pull/10672/commits/5986f1059382b2c08e89c32cdb98d2b049ff0839
a99035a chore: Small caller correction CatchABus Jan 22, 2025 https://github.com/NativeScript/NativeScript/pull/10672/commits/a99035a55304952f2a76e16297ab9f103aef196f
Clear filters https://github.com/NativeScript/NativeScript/pull/10672/files
Please reload this pagehttps://github.com/NativeScript/NativeScript/pull/10672/files
Please reload this pagehttps://github.com/NativeScript/NativeScript/pull/10672/files
frame-common.ts https://github.com/NativeScript/NativeScript/pull/10672/files#diff-b6c28c76dc54a2ecbf53229d19bcd804d8ffbecc67ad7d320ad27f4faf42ab47
index.android.ts https://github.com/NativeScript/NativeScript/pull/10672/files#diff-aac2c6e11b65a628114bb7df638ed7e629e2cbe6d160c2172f37b2a7a9ef3e69
index.ios.ts https://github.com/NativeScript/NativeScript/pull/10672/files#diff-d7fa2fb35efcfa012bf5e14ab298e596dc99f814b26661330debfc6264f133df
packages/core/ui/frame/frame-common.tshttps://github.com/NativeScript/NativeScript/pull/10672/files#diff-b6c28c76dc54a2ecbf53229d19bcd804d8ffbecc67ad7d320ad27f4faf42ab47
View file https://github.com/CatchABus/NativeScript/blob/a99035a55304952f2a76e16297ab9f103aef196f/packages/core/ui/frame/frame-common.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/NativeScript/NativeScript/pull/10672/{{ revealButtonHref }}
https://github.com/NativeScript/NativeScript/pull/10672/files#diff-b6c28c76dc54a2ecbf53229d19bcd804d8ffbecc67ad7d320ad27f4faf42ab47
https://github.com/NativeScript/NativeScript/pull/10672/files#diff-b6c28c76dc54a2ecbf53229d19bcd804d8ffbecc67ad7d320ad27f4faf42ab47
packages/core/ui/frame/index.android.tshttps://github.com/NativeScript/NativeScript/pull/10672/files#diff-aac2c6e11b65a628114bb7df638ed7e629e2cbe6d160c2172f37b2a7a9ef3e69
View file https://github.com/CatchABus/NativeScript/blob/a99035a55304952f2a76e16297ab9f103aef196f/packages/core/ui/frame/index.android.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/NativeScript/NativeScript/pull/10672/{{ revealButtonHref }}
https://github.com/NativeScript/NativeScript/pull/10672/files#diff-aac2c6e11b65a628114bb7df638ed7e629e2cbe6d160c2172f37b2a7a9ef3e69
https://github.com/NativeScript/NativeScript/pull/10672/files#diff-aac2c6e11b65a628114bb7df638ed7e629e2cbe6d160c2172f37b2a7a9ef3e69
https://github.com/NativeScript/NativeScript/pull/10672/files#diff-aac2c6e11b65a628114bb7df638ed7e629e2cbe6d160c2172f37b2a7a9ef3e69
https://github.com/NativeScript/NativeScript/pull/10672/files#diff-aac2c6e11b65a628114bb7df638ed7e629e2cbe6d160c2172f37b2a7a9ef3e69
https://github.com/NativeScript/NativeScript/pull/10672/files#diff-aac2c6e11b65a628114bb7df638ed7e629e2cbe6d160c2172f37b2a7a9ef3e69
https://github.com/NativeScript/NativeScript/pull/10672/files#diff-aac2c6e11b65a628114bb7df638ed7e629e2cbe6d160c2172f37b2a7a9ef3e69
https://github.com/NativeScript/NativeScript/pull/10672/files#diff-aac2c6e11b65a628114bb7df638ed7e629e2cbe6d160c2172f37b2a7a9ef3e69
https://github.com/NativeScript/NativeScript/pull/10672/files#diff-aac2c6e11b65a628114bb7df638ed7e629e2cbe6d160c2172f37b2a7a9ef3e69
packages/core/ui/frame/index.ios.tshttps://github.com/NativeScript/NativeScript/pull/10672/files#diff-d7fa2fb35efcfa012bf5e14ab298e596dc99f814b26661330debfc6264f133df
View file https://github.com/CatchABus/NativeScript/blob/a99035a55304952f2a76e16297ab9f103aef196f/packages/core/ui/frame/index.ios.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/NativeScript/NativeScript/pull/10672/{{ revealButtonHref }}
https://github.com/NativeScript/NativeScript/pull/10672/files#diff-d7fa2fb35efcfa012bf5e14ab298e596dc99f814b26661330debfc6264f133df
https://github.com/NativeScript/NativeScript/pull/10672/files#diff-d7fa2fb35efcfa012bf5e14ab298e596dc99f814b26661330debfc6264f133df
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.