René's URL Explorer Experiment


Title: Revert "fix(core): Proper line-height calculation" by CatchABus · Pull Request #10647 · NativeScript/NativeScript · GitHub

Open Graph Title: Revert "fix(core): Proper line-height calculation" by CatchABus · Pull Request #10647 · NativeScript/NativeScript

X Title: Revert "fix(core): Proper line-height calculation" by CatchABus · Pull Request #10647 · NativeScript/NativeScript

Description: Reverts #10642 @NathanWalker I revert these changes because due to a weird line height behavior on iOS. I'm preparing a new PR with typography improvements that will include a better version of these changes. Note: Additionally, css line-height accepts multipliers so the original {N} approach might be the most recommended approach.

Open Graph Description: Reverts #10642 @NathanWalker I revert these changes because due to a weird line height behavior on iOS. I'm preparing a new PR with typography improvements that will include a better version of...

X Description: Reverts #10642 @NathanWalker I revert these changes because due to a weird line height behavior on iOS. I'm preparing a new PR with typography improvements that will include a better versio...

Opengraph URL: https://github.com/NativeScript/NativeScript/pull/10647

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:b41fa3c6-6c17-9dca-eafe-7d60c6e94cb4
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idEC08:2F6413:8D5821C:BE6907D:6A5E55B8
html-safe-nonceabc1aed7ed3d4561f5d4349ce4a5438299e27c2eff9b93393cbefa70509928b9
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQzA4OjJGNjQxMzo4RDU4MjFDOkJFNjkwN0Q6NkE1RTU1QjgiLCJ2aXNpdG9yX2lkIjoiODc0MjY4NDQyNzA2MTk3NDQ1NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacf7b553e3376382e116c9480fb429fdbc13b7a8d2b1b8074c8e82b3be1a5bcd84
hovercard-subject-tagpull_request:2170595999
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/NativeScript/NativeScript/pull/10647/files
twitter:imagehttps://avatars.githubusercontent.com/u/55595100?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/55595100?s=400&v=4
og:image:altReverts #10642 @NathanWalker I revert these changes because due to a weird line height behavior on iOS. I'm preparing a new PR with typography improvements that will include a better version of...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None7034b9f0130cdfcbd93bbcf3e8c0f4cc3007af54a2804bfd31f70d472b22852b
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/NativeScript/NativeScript git https://github.com/NativeScript/NativeScript.git
octolytics-dimension-user_id7392261
octolytics-dimension-user_loginNativeScript
octolytics-dimension-repository_id31492490
octolytics-dimension-repository_nwoNativeScript/NativeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id31492490
octolytics-dimension-repository_network_root_nwoNativeScript/NativeScript
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasee75cd8524a0802713165f77a0088258ff9261683
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/NativeScript/NativeScript/pull/10647/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNativeScript%2FNativeScript%2Fpull%2F10647%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
Code QualityEnforce quality at mergehttps://github.com/features/code-quality
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNativeScript%2FNativeScript%2Fpull%2F10647%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=NativeScript%2FNativeScript
Reloadhttps://github.com/NativeScript/NativeScript/pull/10647/files
Reloadhttps://github.com/NativeScript/NativeScript/pull/10647/files
Reloadhttps://github.com/NativeScript/NativeScript/pull/10647/files
Please reload this pagehttps://github.com/NativeScript/NativeScript/pull/10647/files
NativeScript https://github.com/NativeScript
NativeScripthttps://github.com/NativeScript/NativeScript
Please reload this pagehttps://github.com/NativeScript/NativeScript/pull/10647/files
Notifications https://github.com/login?return_to=%2FNativeScript%2FNativeScript
Fork 1.7k https://github.com/login?return_to=%2FNativeScript%2FNativeScript
Star 25.6k https://github.com/login?return_to=%2FNativeScript%2FNativeScript
Code https://github.com/NativeScript/NativeScript
Issues 771 https://github.com/NativeScript/NativeScript/issues
Pull requests 66 https://github.com/NativeScript/NativeScript/pulls
Discussions https://github.com/NativeScript/NativeScript/discussions
Actions https://github.com/NativeScript/NativeScript/actions
Projects https://github.com/NativeScript/NativeScript/projects
Wiki https://github.com/NativeScript/NativeScript/wiki
Security and quality 0 https://github.com/NativeScript/NativeScript/security
Insights https://github.com/NativeScript/NativeScript/pulse
Code https://github.com/NativeScript/NativeScript
Issues https://github.com/NativeScript/NativeScript/issues
Pull requests https://github.com/NativeScript/NativeScript/pulls
Discussions https://github.com/NativeScript/NativeScript/discussions
Actions https://github.com/NativeScript/NativeScript/actions
Projects https://github.com/NativeScript/NativeScript/projects
Wiki https://github.com/NativeScript/NativeScript/wiki
Security and quality https://github.com/NativeScript/NativeScript/security
Insights https://github.com/NativeScript/NativeScript/pulse
Sign up for GitHub https://github.com/signup?return_to=%2FNativeScript%2FNativeScript%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FNativeScript%2FNativeScript%2Fissues%2Fnew%2Fchoose
NathanWalkerhttps://github.com/NathanWalker
mainhttps://github.com/NativeScript/NativeScript/tree/main
revert-10642-line-height-fixhttps://github.com/NativeScript/NativeScript/tree/revert-10642-line-height-fix
Conversation 0 https://github.com/NativeScript/NativeScript/pull/10647
Commits 2 https://github.com/NativeScript/NativeScript/pull/10647/commits
Checks 0 https://github.com/NativeScript/NativeScript/pull/10647/checks
Files changed https://github.com/NativeScript/NativeScript/pull/10647/files
Please reload this pagehttps://github.com/NativeScript/NativeScript/pull/10647/files
Revert "fix(core): Proper line-height calculation" https://github.com/NativeScript/NativeScript/pull/10647/files#top
Show all changes 2 commits https://github.com/NativeScript/NativeScript/pull/10647/files
b4a4a76 Revert "fix(core): proper line-height calculation (#10642)" CatchABus Nov 8, 2024 https://github.com/NativeScript/NativeScript/pull/10647/commits/b4a4a769c726ecf0f5ac6b2ba8983335d9c2f37a
5eb3a11 Merge branch 'main' into revert-10642-line-height-fix NathanWalker Nov 19, 2024 https://github.com/NativeScript/NativeScript/pull/10647/commits/5eb3a11f2473f052139d69514c7207971a1bed82
Clear filters https://github.com/NativeScript/NativeScript/pull/10647/files
Please reload this pagehttps://github.com/NativeScript/NativeScript/pull/10647/files
Please reload this pagehttps://github.com/NativeScript/NativeScript/pull/10647/files
UIView+NativeScript.m https://github.com/NativeScript/NativeScript/pull/10647/files#diff-296ef24d13beafe426aac34ce9d26309829ee88d488ee0aceefc5ad7c33a15e6
style-properties.d.ts https://github.com/NativeScript/NativeScript/pull/10647/files#diff-db7ad0ecfeb07f3efd3305a812cdcb2dcdfcde420e25c719701c17805f521668
index.android.ts https://github.com/NativeScript/NativeScript/pull/10647/files#diff-d6c6ee5086ae6a6cd68421197312bba4d1880efb0a844c86d1a9c18080dd50f3
packages/core/platforms/ios/src/UIView+NativeScript.mhttps://github.com/NativeScript/NativeScript/pull/10647/files#diff-296ef24d13beafe426aac34ce9d26309829ee88d488ee0aceefc5ad7c33a15e6
View file https://github.com/NativeScript/NativeScript/blob/5eb3a11f2473f052139d69514c7207971a1bed82/packages/core/platforms/ios/src/UIView%2BNativeScript.m
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/NativeScript/NativeScript/pull/10647/{{ revealButtonHref }}
https://github.com/NativeScript/NativeScript/pull/10647/files#diff-296ef24d13beafe426aac34ce9d26309829ee88d488ee0aceefc5ad7c33a15e6
https://github.com/NativeScript/NativeScript/pull/10647/files#diff-296ef24d13beafe426aac34ce9d26309829ee88d488ee0aceefc5ad7c33a15e6
https://github.com/NativeScript/NativeScript/pull/10647/files#diff-296ef24d13beafe426aac34ce9d26309829ee88d488ee0aceefc5ad7c33a15e6
https://github.com/NativeScript/NativeScript/pull/10647/files#diff-296ef24d13beafe426aac34ce9d26309829ee88d488ee0aceefc5ad7c33a15e6
packages/core/ui/styling/style-properties.d.tshttps://github.com/NativeScript/NativeScript/pull/10647/files#diff-db7ad0ecfeb07f3efd3305a812cdcb2dcdfcde420e25c719701c17805f521668
View file https://github.com/NativeScript/NativeScript/blob/5eb3a11f2473f052139d69514c7207971a1bed82/packages/core/ui/styling/style-properties.d.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/NativeScript/NativeScript/pull/10647/{{ revealButtonHref }}
https://github.com/NativeScript/NativeScript/pull/10647/files#diff-db7ad0ecfeb07f3efd3305a812cdcb2dcdfcde420e25c719701c17805f521668
https://github.com/NativeScript/NativeScript/pull/10647/files#diff-db7ad0ecfeb07f3efd3305a812cdcb2dcdfcde420e25c719701c17805f521668
packages/core/ui/text-base/index.android.tshttps://github.com/NativeScript/NativeScript/pull/10647/files#diff-d6c6ee5086ae6a6cd68421197312bba4d1880efb0a844c86d1a9c18080dd50f3
View file https://github.com/NativeScript/NativeScript/blob/5eb3a11f2473f052139d69514c7207971a1bed82/packages/core/ui/text-base/index.android.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/NativeScript/NativeScript/pull/10647/{{ revealButtonHref }}
https://github.com/NativeScript/NativeScript/pull/10647/files#diff-d6c6ee5086ae6a6cd68421197312bba4d1880efb0a844c86d1a9c18080dd50f3
https://github.com/NativeScript/NativeScript/pull/10647/files#diff-d6c6ee5086ae6a6cd68421197312bba4d1880efb0a844c86d1a9c18080dd50f3
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.