René's URL Explorer Experiment


Title: fix(core): Frame ignored event listeners in xml markup by CatchABus · Pull Request #10646 · NativeScript/NativeScript · GitHub

Open Graph Title: fix(core): Frame ignored event listeners in xml markup by CatchABus · Pull Request #10646 · NativeScript/NativeScript

X Title: fix(core): Frame ignored event listeners in xml markup by CatchABus · Pull Request #10646 · NativeScript/NativeScript

Description: PR Checklist The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/CONTRIBUTING.md#commit-messages. There is an issue for the bug/feature this PR is for. To avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it. You have signed the CLA. All existing tests are passing: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/DevelopmentWorkflow.md#running-unit-tests-application. Tests for the changes are included - https://github.com/NativeScript/NativeScript/blob/master/tools/notes/WritingUnitTests.md. What is the current behavior? Frame ignores listeners defined in xml markup What is the new behavior? Frame will now register listeners defined in xml markup. This PR also removes an androidOptionSelectedEvent property which was garbage from an old PR.

Open Graph Description: PR Checklist The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/CONTRIBUTING.md#commit-messages. There is an issue for the bug/feature this...

X Description: PR Checklist The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/CONTRIBUTING.md#commit-messages. There is an issue for the bug/feature this...

Opengraph URL: https://github.com/NativeScript/NativeScript/pull/10646

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:a78f92cc-1aae-60b3-a586-408d4ee7e957
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC2B6:A4600:456ACB4:5F882AC:6A5E1B83
html-safe-nonce8f9d51eba93b2c3b46d36005ad18395859b12a547c76b5f3526a427a9b42c6f5
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMkI2OkE0NjAwOjQ1NkFDQjQ6NUY4ODJBQzo2QTVFMUI4MyIsInZpc2l0b3JfaWQiOiI1NDkxMTgxMTEwNjYyNDA0OTk1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac2686ed0a592434a9e00e3abd753b30035e4922b4305434bd021069b1e98aa341
hovercard-subject-tagpull_request:2170374053
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/NativeScript/NativeScript/pull/10646/files
twitter:imagehttps://avatars.githubusercontent.com/u/55595100?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/55595100?s=400&v=4
og:image:altPR Checklist The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/CONTRIBUTING.md#commit-messages. There is an issue for the bug/feature this...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None7a60e060dad2c24f72179d36247204b454da37845d1728020cd42046a433f87f
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/NativeScript/NativeScript git https://github.com/NativeScript/NativeScript.git
octolytics-dimension-user_id7392261
octolytics-dimension-user_loginNativeScript
octolytics-dimension-repository_id31492490
octolytics-dimension-repository_nwoNativeScript/NativeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id31492490
octolytics-dimension-repository_network_root_nwoNativeScript/NativeScript
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release0ae7f3ea7b1bb2f1f4623bb093bbf54cee05d830
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/NativeScript/NativeScript/pull/10646/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNativeScript%2FNativeScript%2Fpull%2F10646%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNativeScript%2FNativeScript%2Fpull%2F10646%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=NativeScript%2FNativeScript
Reloadhttps://github.com/NativeScript/NativeScript/pull/10646/files
Reloadhttps://github.com/NativeScript/NativeScript/pull/10646/files
Reloadhttps://github.com/NativeScript/NativeScript/pull/10646/files
Please reload this pagehttps://github.com/NativeScript/NativeScript/pull/10646/files
NativeScript https://github.com/NativeScript
NativeScripthttps://github.com/NativeScript/NativeScript
Please reload this pagehttps://github.com/NativeScript/NativeScript/pull/10646/files
Notifications https://github.com/login?return_to=%2FNativeScript%2FNativeScript
Fork 1.7k https://github.com/login?return_to=%2FNativeScript%2FNativeScript
Star 25.6k https://github.com/login?return_to=%2FNativeScript%2FNativeScript
Code https://github.com/NativeScript/NativeScript
Issues 771 https://github.com/NativeScript/NativeScript/issues
Pull requests 66 https://github.com/NativeScript/NativeScript/pulls
Discussions https://github.com/NativeScript/NativeScript/discussions
Actions https://github.com/NativeScript/NativeScript/actions
Projects https://github.com/NativeScript/NativeScript/projects
Wiki https://github.com/NativeScript/NativeScript/wiki
Security and quality 0 https://github.com/NativeScript/NativeScript/security
Insights https://github.com/NativeScript/NativeScript/pulse
Code https://github.com/NativeScript/NativeScript
Issues https://github.com/NativeScript/NativeScript/issues
Pull requests https://github.com/NativeScript/NativeScript/pulls
Discussions https://github.com/NativeScript/NativeScript/discussions
Actions https://github.com/NativeScript/NativeScript/actions
Projects https://github.com/NativeScript/NativeScript/projects
Wiki https://github.com/NativeScript/NativeScript/wiki
Security and quality https://github.com/NativeScript/NativeScript/security
Insights https://github.com/NativeScript/NativeScript/pulse
Sign up for GitHub https://github.com/signup?return_to=%2FNativeScript%2FNativeScript%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FNativeScript%2FNativeScript%2Fissues%2Fnew%2Fchoose
NathanWalkerhttps://github.com/NathanWalker
NativeScript:mainhttps://github.com/NativeScript/NativeScript/tree/main
CatchABus:frame-navigate-event-declarationshttps://github.com/CatchABus/NativeScript/tree/frame-navigate-event-declarations
Conversation 0 https://github.com/NativeScript/NativeScript/pull/10646
Commits 3 https://github.com/NativeScript/NativeScript/pull/10646/commits
Checks 0 https://github.com/NativeScript/NativeScript/pull/10646/checks
Files changed https://github.com/NativeScript/NativeScript/pull/10646/files
Please reload this pagehttps://github.com/NativeScript/NativeScript/pull/10646/files
fix(core): Frame ignored event listeners in xml markup https://github.com/NativeScript/NativeScript/pull/10646/files#top
Show all changes 3 commits https://github.com/NativeScript/NativeScript/pull/10646/files
2e8c66f fix(core): Frame ignored event listeners in xml markup CatchABus Nov 8, 2024 https://github.com/NativeScript/NativeScript/pull/10646/commits/2e8c66f5a6c099cdafaa4f4aabcfbf88de6ae67d
70f416f Merge branch 'main' into frame-navigate-event-declarations NathanWalker Nov 19, 2024 https://github.com/NativeScript/NativeScript/pull/10646/commits/70f416fab54cdd5b66c94556d887f5e69cd3f7ed
7b1b77a Merge branch 'main' into frame-navigate-event-declarations NathanWalker Nov 19, 2024 https://github.com/NativeScript/NativeScript/pull/10646/commits/7b1b77a3574f30e9d9a02d3aa0bb733129355f02
Clear filters https://github.com/NativeScript/NativeScript/pull/10646/files
Please reload this pagehttps://github.com/NativeScript/NativeScript/pull/10646/files
Please reload this pagehttps://github.com/NativeScript/NativeScript/pull/10646/files
frame-common.ts https://github.com/NativeScript/NativeScript/pull/10646/files#diff-b6c28c76dc54a2ecbf53229d19bcd804d8ffbecc67ad7d320ad27f4faf42ab47
index.d.ts https://github.com/NativeScript/NativeScript/pull/10646/files#diff-c2da838793c3be894a7178f566ef79c7add9d201f3fbf85b7fa1ac38deab9781
packages/core/ui/frame/frame-common.tshttps://github.com/NativeScript/NativeScript/pull/10646/files#diff-b6c28c76dc54a2ecbf53229d19bcd804d8ffbecc67ad7d320ad27f4faf42ab47
View file https://github.com/CatchABus/NativeScript/blob/7b1b77a3574f30e9d9a02d3aa0bb733129355f02/packages/core/ui/frame/frame-common.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/NativeScript/NativeScript/pull/10646/{{ revealButtonHref }}
https://github.com/NativeScript/NativeScript/pull/10646/files#diff-b6c28c76dc54a2ecbf53229d19bcd804d8ffbecc67ad7d320ad27f4faf42ab47
https://github.com/NativeScript/NativeScript/pull/10646/files#diff-b6c28c76dc54a2ecbf53229d19bcd804d8ffbecc67ad7d320ad27f4faf42ab47
https://github.com/NativeScript/NativeScript/pull/10646/files#diff-b6c28c76dc54a2ecbf53229d19bcd804d8ffbecc67ad7d320ad27f4faf42ab47
https://github.com/NativeScript/NativeScript/pull/10646/files#diff-b6c28c76dc54a2ecbf53229d19bcd804d8ffbecc67ad7d320ad27f4faf42ab47
https://github.com/NativeScript/NativeScript/pull/10646/files#diff-b6c28c76dc54a2ecbf53229d19bcd804d8ffbecc67ad7d320ad27f4faf42ab47
https://github.com/NativeScript/NativeScript/pull/10646/files#diff-b6c28c76dc54a2ecbf53229d19bcd804d8ffbecc67ad7d320ad27f4faf42ab47
packages/core/ui/frame/index.d.tshttps://github.com/NativeScript/NativeScript/pull/10646/files#diff-c2da838793c3be894a7178f566ef79c7add9d201f3fbf85b7fa1ac38deab9781
View file https://github.com/CatchABus/NativeScript/blob/7b1b77a3574f30e9d9a02d3aa0bb733129355f02/packages/core/ui/frame/index.d.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/NativeScript/NativeScript/pull/10646/{{ revealButtonHref }}
https://github.com/NativeScript/NativeScript/pull/10646/files#diff-c2da838793c3be894a7178f566ef79c7add9d201f3fbf85b7fa1ac38deab9781
https://github.com/NativeScript/NativeScript/pull/10646/files#diff-c2da838793c3be894a7178f566ef79c7add9d201f3fbf85b7fa1ac38deab9781
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.