Title: fix(ios): Setting of property mask on 'undefined' during view disposal by CatchABus · Pull Request #10404 · NativeScript/NativeScript · GitHub
Open Graph Title: fix(ios): Setting of property mask on 'undefined' during view disposal by CatchABus · Pull Request #10404 · NativeScript/NativeScript
X Title: fix(ios): Setting of property mask on 'undefined' during view disposal by CatchABus · Pull Request #10404 · NativeScript/NativeScript
Description: PR Checklist The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/CONTRIBUTING.md#commit-messages. There is an issue for the bug/feature this PR is for. To avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it. You have signed the CLA. All existing tests are passing: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/DevelopmentWorkflow.md#running-unit-tests-application. Tests for the changes are included - https://github.com/NativeScript/NativeScript/blob/master/tools/notes/WritingUnitTests.md. What is the current behavior? iOS apps crash when trying to dispose native views that do not extend UIView (e.g. UITabBarItem) due to CALayers cleanup. This trace was provided in discord: [11:04:49.026] Debug: uncaughtErrorEvent - NativeScriptError: TypeError: Cannot set properties of undefined (setting 'mask') ***** Fatal JavaScript exception - application has been terminated. ***** NativeScript encountered a fatal error: Uncaught TypeError: Cannot set properties of undefined (setting 'mask') at clearLayerMask(file: src/webpack:/app/node_modules/@nativescript/core/ui/styling/background.ios.js:279:0) at clearBackgroundVisualEffects(file: src/webpack:/app/node_modules/@nativescript/core/ui/styling/background.ios.js:100:0) at disposeNativeView(file: src/webpack:/app/node_modules/@nativescript/core/ui/core/view/index.ios.js:47:21) at _tearDownUI(file: src/webpack:/app/node_modules/@nativescript/core/ui/core/view-base/index.js:809:0) at (file: src/webpack:/app/node_modules/@nativescript/core/ui/core/view-base/index.js:784:0) at (file: src/webpack:/app/node_modules/@nativescript-community/ui-material-core-tabs/tab-strip/index.js:36:0) at eachChild(file: src/webpack:/app/node_modules/@nativescript-community/ui-material-core-tabs/tab-strip/index.js:35:0) What is the new behavior? Apps will execute the steps after checking whether native view extends UIView.
Open Graph Description: PR Checklist The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/CONTRIBUTING.md#commit-messages. There is an issue for the bug/feature this...
X Description: PR Checklist The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/CONTRIBUTING.md#commit-messages. There is an issue for the bug/feature this...
Opengraph URL: https://github.com/NativeScript/NativeScript/pull/10404
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:b3e0518e-59fe-c4e8-c6d4-0ddcbb32c315 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E248:D0E27:21D25:2DF6D:6A5FBC60 |
| html-safe-nonce | 33c5ededab7da3b273f78be8c1a705fbd1643d849ab2e3cc216d6601d757d996 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMjQ4OkQwRTI3OjIxRDI1OjJERjZEOjZBNUZCQzYwIiwidmlzaXRvcl9pZCI6IjIyNTc5NjIyODE3OTA4NDgwOTYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | bcf10fce4b41c7980b81cc708d9fc80be14f18f22957d7238f14b779476edbfc |
| hovercard-subject-tag | pull_request:1554921855 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/NativeScript/NativeScript/pull/10404/files |
| twitter:image | https://avatars.githubusercontent.com/u/55595100?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/55595100?s=400&v=4 |
| og:image:alt | PR Checklist The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/CONTRIBUTING.md#commit-messages. There is an issue for the bug/feature this... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | e0cfc367faf9c4c774d2a903897aa214c786247c4f45ffcee48cda2b819fb0c8 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/NativeScript/NativeScript git https://github.com/NativeScript/NativeScript.git |
| octolytics-dimension-user_id | 7392261 |
| octolytics-dimension-user_login | NativeScript |
| octolytics-dimension-repository_id | 31492490 |
| octolytics-dimension-repository_nwo | NativeScript/NativeScript |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 31492490 |
| octolytics-dimension-repository_network_root_nwo | NativeScript/NativeScript |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 94569c859bc88d6bf7de7e0ce3f2a11cd529a131 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width