Title: fix(webpack): Adjust appComponents Env by azriel46d · Pull Request #10401 · NativeScript/NativeScript · GitHub
Open Graph Title: fix(webpack): Adjust appComponents Env by azriel46d · Pull Request #10401 · NativeScript/NativeScript
X Title: fix(webpack): Adjust appComponents Env by azriel46d · Pull Request #10401 · NativeScript/NativeScript
Description: Documentation indicates https://beta.docs.nativescript.org/configuration/webpack#env-appcomponents where --env.appComponents=./someActivity.js can be passed. However, when utilsing this, webpack throws an error appComponents.push is not a function when a single Activity is added. This PR adjusts the reading of appCompnents env and if it is a single item, its wrapped inside an array PR Checklist The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/CONTRIBUTING.md#commit-messages. There is an issue for the bug/feature this PR is for. To avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it. You have signed the CLA. All existing tests are passing: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/DevelopmentWorkflow.md#running-unit-tests-application. Tests for the changes are included - https://github.com/NativeScript/NativeScript/blob/master/tools/notes/WritingUnitTests.md. What is the current behavior? Create a new app Add a CustomActivity.js ns build android --env.appComponents=./CustomActivity.js TypeError: appComponents.push is not a function What is the new behavior? Build continues normally
Open Graph Description: Documentation indicates https://beta.docs.nativescript.org/configuration/webpack#env-appcomponents where --env.appComponents=./someActivity.js can be passed. However, when utilsing this, webpack t...
X Description: Documentation indicates https://beta.docs.nativescript.org/configuration/webpack#env-appcomponents where --env.appComponents=./someActivity.js can be passed. However, when utilsing this, webpack t...
Opengraph URL: https://github.com/NativeScript/NativeScript/pull/10401
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:50aef2d0-813b-4f12-d9d4-5e6dfff2f2e1 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | BCB6:366BF1:285563D:37A9456:6A60B45E |
| html-safe-nonce | f488ab7d9a296c68daa0efe44a662f8abe739a0f7fc722949f055ed9536a4a7a |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQ0I2OjM2NkJGMToyODU1NjNEOjM3QTk0NTY6NkE2MEI0NUUiLCJ2aXNpdG9yX2lkIjoiOTUwMTg5MTA3MTcxMDc5MjYyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 884c6b1a282b1859447ca644c19ab0d8100ea33b59bd94093f59712ef2f747d0 |
| hovercard-subject-tag | pull_request:1547895308 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/NativeScript/NativeScript/pull/10401/files |
| twitter:image | https://avatars.githubusercontent.com/u/2339134?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/2339134?s=400&v=4 |
| og:image:alt | Documentation indicates https://beta.docs.nativescript.org/configuration/webpack#env-appcomponents where --env.appComponents=./someActivity.js can be passed. However, when utilsing this, webpack t... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 35671f8a6946a7a2a81d51ae49f5465bdc5f925c23c9cb839206b24345dbe8d9 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/NativeScript/NativeScript git https://github.com/NativeScript/NativeScript.git |
| octolytics-dimension-user_id | 7392261 |
| octolytics-dimension-user_login | NativeScript |
| octolytics-dimension-repository_id | 31492490 |
| octolytics-dimension-repository_nwo | NativeScript/NativeScript |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 31492490 |
| octolytics-dimension-repository_network_root_nwo | NativeScript/NativeScript |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 746dc49090e6e3995bb502dce0f8807393e36eda |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width