René's URL Explorer Experiment


Title: Wrong Dialog colors on android in dark mode and no way to handle dark/light mode · Issue #9462 · NativeScript/NativeScript · GitHub

Open Graph Title: Wrong Dialog colors on android in dark mode and no way to handle dark/light mode · Issue #9462 · NativeScript/NativeScript

X Title: Wrong Dialog colors on android in dark mode and no way to handle dark/light mode · Issue #9462 · NativeScript/NativeScript

Description: Environment nativescript: 8.0.2 @nativescript/core: 8.0.8 @nativescript/android: 8.0.0 @nativescript/ios: 8.0.0 Describe the bug Could not set label and button colors for Dialogs via css (to handle dark mode colors) To Reproduce run: ns ...

Open Graph Description: Environment nativescript: 8.0.2 @nativescript/core: 8.0.8 @nativescript/android: 8.0.0 @nativescript/ios: 8.0.0 Describe the bug Could not set label and button colors for Dialogs via css (to handle...

X Description: Environment nativescript: 8.0.2 @nativescript/core: 8.0.8 @nativescript/android: 8.0.0 @nativescript/ios: 8.0.0 Describe the bug Could not set label and button colors for Dialogs via css (to handle...

Opengraph URL: https://github.com/NativeScript/NativeScript/issues/9462

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Wrong Dialog colors on android in dark mode and no way to handle dark/light mode","articleBody":"**Environment**\r\n - nativescript: 8.0.2\r\n - @nativescript/core: 8.0.8\r\n - @nativescript/android: 8.0.0\r\n - @nativescript/ios: 8.0.0\r\n\r\n**Describe the bug**\r\nCould not set label and button colors for `Dialogs` via `css` (to handle dark mode colors)\r\n\r\n**To Reproduce**\r\n- run: `ns create ...`\r\n- add somewhere a `Dialog.alert('Hi')`\r\n- replace the scss as followed:\r\n```scss\r\nPage {\r\n  Label,\r\n  Button {\r\n    color: gray;\r\n  }\r\n\r\n  \u0026.ns-dark {\r\n    Label,\r\n    Button {\r\n      color: white;\r\n    }\r\n  }\r\n  \u0026.ns-light {\r\n    Label,\r\n    Button {\r\n      color: black;\r\n    }\r\n  }\r\n}\r\n\r\nLabel,\r\nButton {\r\n  color: blue;\r\n\r\n  \u0026.ns-dark {\r\n    color: yellow;\r\n  }\r\n  \u0026.ns-light {\r\n    color: green;\r\n  }\r\n}\r\n```\r\n\r\n***Result on Android***\r\n![android](https://user-images.githubusercontent.com/13959976/124453432-a5fbd400-dd87-11eb-8d90-416b01b6742b.png)\r\n\r\n***Result on iOS***\r\n![ios](https://user-images.githubusercontent.com/13959976/124452458-b2cbf800-dd86-11eb-98a7-aed5b8b2b493.png)\r\n\r\n\r\n**Expected behavior**\r\n- in light mode, the `Dialogs` text and button colors should be `black` or `green` in light mode and `white` or `yellow` in dark mode\r\n- without dark/light mode support they shloud be `gray` or `blue`;\r\n\r\n**Sample project**\r\nPlayground is useless, because it it's last version runs on NS 6.5 (released a year ago).\r\n\r\n**Additional context**\r\n- the [`lbl`](https://github.com/NativeScript/NativeScript/blob/master/packages/core/ui/dialogs/dialogs-common.ts#L299) and [`btn`](https://github.com/NativeScript/NativeScript/blob/master/packages/core/ui/dialogs/dialogs-common.ts#L281) have no `page` or `parentNode`, so the css selectors `Page Label` and `Page Button` fail (described here: https://github.com/NativeScript/NativeScript/issues/3830#issuecomment-547349025)\r\n- the [`lbl`](https://github.com/NativeScript/NativeScript/blob/master/packages/core/ui/dialogs/dialogs-common.ts#L299) and [`btn`](https://github.com/NativeScript/NativeScript/blob/master/packages/core/ui/dialogs/dialogs-common.ts#L281) have no `ns-light` or `ns-dark` css-class, so there is no possibility to set different colors via css.\r\n- on android and ios the color property of [`lbl`](https://github.com/NativeScript/NativeScript/blob/master/packages/core/ui/dialogs/dialogs-common.ts#L299) and [`btn`](https://github.com/NativeScript/NativeScript/blob/master/packages/core/ui/dialogs/dialogs-common.ts#L281) is:\r\n```js\r\ncolor: {\r\n  _argb: 4278190335\r\n  _name: \"blue\"\r\n  a: 255\r\n  android: -16776961\r\n  argb: 4278190335\r\n  b: 255\r\n  g: 0\r\n  hex: \"#0000FF\"\r\n  ios: undefined\r\n  name: \"blue\"\r\n  r: 0\r\n}\r\n```\r\nthere are a some existing issues about this problem, wich are opend over moths, like:\r\nhttps://github.com/NativeScript/NativeScript/issues/8484\r\nhttps://github.com/NativeScript/theme/issues/184\r\n\r\n**Summarized:**\r\n- no chance to apply custom colors for dark mode on both platforms (this is realy bad -\u003e dialogs are not usable in dark mode)\r\n- on android in dark mode gets generated \"magically\" a custom color (but at least is a bit lighter and could be used in dark mode)\r\n- If I'm not wrong, this issue could not be solved, by css (and `@nativescript/theme`)\r\n","author":{"url":"https://github.com/wendt88","@type":"Person","name":"wendt88"},"datePublished":"2021-07-05T10:08:34.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":2},"url":"https://github.com/9462/NativeScript/issues/9462"}

route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:f4ee2d88-00dc-e077-c563-db398a566d29
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idCC1C:23324C:632CDD:83B7E3:6A5FCFAB
html-safe-nonce2f72958e5c07a63323664f54cdd66fdddac503345056cd23cfc187fdbeed2289
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQzFDOjIzMzI0Qzo2MzJDREQ6ODNCN0UzOjZBNUZDRkFCIiwidmlzaXRvcl9pZCI6Ijg3MDg5MTI1MTUwOTgwNzA5NTUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac2de5429ce4c91104dd8e0769ca8b7e6e2a40de9451211818889d8e0a104fa190
hovercard-subject-tagissue:936926526
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/NativeScript/NativeScript/9462/issue_layout
twitter:imagehttps://opengraph.githubassets.com/3da95674c3b979068978cebd9fb966e0b52a83cfef5b8669754e7eb387e208ca/NativeScript/NativeScript/issues/9462
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/3da95674c3b979068978cebd9fb966e0b52a83cfef5b8669754e7eb387e208ca/NativeScript/NativeScript/issues/9462
og:image:altEnvironment nativescript: 8.0.2 @nativescript/core: 8.0.8 @nativescript/android: 8.0.0 @nativescript/ios: 8.0.0 Describe the bug Could not set label and button colors for Dialogs via css (to handle...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamewendt88
hostnamegithub.com
expected-hostnamegithub.com
None53a28a7799cbf673993ab89fc44869fea4c4a6545a861a4d1445e83e8d03aabd
turbo-cache-controlno-preview
go-importgithub.com/NativeScript/NativeScript git https://github.com/NativeScript/NativeScript.git
octolytics-dimension-user_id7392261
octolytics-dimension-user_loginNativeScript
octolytics-dimension-repository_id31492490
octolytics-dimension-repository_nwoNativeScript/NativeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id31492490
octolytics-dimension-repository_network_root_nwoNativeScript/NativeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasedc08399f879d576f0edbb8c52a0a1a30d498b203
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/NativeScript/NativeScript/issues/9462#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNativeScript%2FNativeScript%2Fissues%2F9462
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
Code QualityEnforce quality at mergehttps://github.com/features/code-quality
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNativeScript%2FNativeScript%2Fissues%2F9462
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=NativeScript%2FNativeScript
Reloadhttps://github.com/NativeScript/NativeScript/issues/9462
Reloadhttps://github.com/NativeScript/NativeScript/issues/9462
Reloadhttps://github.com/NativeScript/NativeScript/issues/9462
Please reload this pagehttps://github.com/NativeScript/NativeScript/issues/9462
NativeScript https://github.com/NativeScript
NativeScripthttps://github.com/NativeScript/NativeScript
Please reload this pagehttps://github.com/NativeScript/NativeScript/issues/9462
Notifications https://github.com/login?return_to=%2FNativeScript%2FNativeScript
Fork 1.7k https://github.com/login?return_to=%2FNativeScript%2FNativeScript
Star 25.6k https://github.com/login?return_to=%2FNativeScript%2FNativeScript
Code https://github.com/NativeScript/NativeScript
Issues 771 https://github.com/NativeScript/NativeScript/issues
Pull requests 66 https://github.com/NativeScript/NativeScript/pulls
Discussions https://github.com/NativeScript/NativeScript/discussions
Actions https://github.com/NativeScript/NativeScript/actions
Projects https://github.com/NativeScript/NativeScript/projects
Wiki https://github.com/NativeScript/NativeScript/wiki
Security and quality 0 https://github.com/NativeScript/NativeScript/security
Insights https://github.com/NativeScript/NativeScript/pulse
Code https://github.com/NativeScript/NativeScript
Issues https://github.com/NativeScript/NativeScript/issues
Pull requests https://github.com/NativeScript/NativeScript/pulls
Discussions https://github.com/NativeScript/NativeScript/discussions
Actions https://github.com/NativeScript/NativeScript/actions
Projects https://github.com/NativeScript/NativeScript/projects
Wiki https://github.com/NativeScript/NativeScript/wiki
Security and quality https://github.com/NativeScript/NativeScript/security
Insights https://github.com/NativeScript/NativeScript/pulse
Wrong Dialog colors on android in dark mode and no way to handle dark/light modehttps://github.com/NativeScript/NativeScript/issues/9462#top
bughttps://github.com/NativeScript/NativeScript/issues?q=state%3Aopen%20label%3A%22bug%22
https://github.com/wendt88
wendt88https://github.com/wendt88
on Jul 5, 2021https://github.com/NativeScript/NativeScript/issues/9462#issue-936926526
https://user-images.githubusercontent.com/13959976/124453432-a5fbd400-dd87-11eb-8d90-416b01b6742b.png
https://user-images.githubusercontent.com/13959976/124452458-b2cbf800-dd86-11eb-98a7-aed5b8b2b493.png
lblhttps://github.com/NativeScript/NativeScript/blob/master/packages/core/ui/dialogs/dialogs-common.ts#L299
btnhttps://github.com/NativeScript/NativeScript/blob/master/packages/core/ui/dialogs/dialogs-common.ts#L281
Dialogs: Provide ability to set different color/font style for title #3830 (comment)https://github.com/NativeScript/NativeScript/issues/3830#issuecomment-547349025
lblhttps://github.com/NativeScript/NativeScript/blob/master/packages/core/ui/dialogs/dialogs-common.ts#L299
btnhttps://github.com/NativeScript/NativeScript/blob/master/packages/core/ui/dialogs/dialogs-common.ts#L281
lblhttps://github.com/NativeScript/NativeScript/blob/master/packages/core/ui/dialogs/dialogs-common.ts#L299
btnhttps://github.com/NativeScript/NativeScript/blob/master/packages/core/ui/dialogs/dialogs-common.ts#L281
#8484https://github.com/NativeScript/NativeScript/issues/8484
NativeScript/theme#184https://github.com/NativeScript/theme/issues/184
bughttps://github.com/NativeScript/NativeScript/issues?q=state%3Aopen%20label%3A%22bug%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.