René's URL Explorer Experiment


Title: .ns-dark doesn't apply through to dialogs · Issue #8484 · NativeScript/NativeScript · GitHub

Open Graph Title: .ns-dark doesn't apply through to dialogs · Issue #8484 · NativeScript/NativeScript

X Title: .ns-dark doesn't apply through to dialogs · Issue #8484 · NativeScript/NativeScript

Description: Environment From play.nativescript.org: { "@angular/animations": "8.2.14", "@angular/common": "8.2.14", "@angular/compiler": "8.2.14", "@angular/core": "8.2.14", "@angular/forms": "8.2.14", "@angular/platform-browser": "8.2.14", "@angula...

Open Graph Description: Environment From play.nativescript.org: { "@angular/animations": "8.2.14", "@angular/common": "8.2.14", "@angular/compiler": "8.2.14", "@angular/core": "8.2.14", "@angular/forms": "8.2.14", "@angul...

X Description: Environment From play.nativescript.org: { "@angular/animations": "8.2.14", "@angular/common": "8.2.14", "@angular/compiler": "8.2.14", &q...

Opengraph URL: https://github.com/NativeScript/NativeScript/issues/8484

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":".ns-dark doesn't apply through to dialogs","articleBody":"**Environment**\r\nFrom play.nativescript.org:\r\n```json\r\n{\r\n  \"@angular/animations\": \"8.2.14\",\r\n  \"@angular/common\": \"8.2.14\",\r\n  \"@angular/compiler\": \"8.2.14\",\r\n  \"@angular/core\": \"8.2.14\",\r\n  \"@angular/forms\": \"8.2.14\",\r\n  \"@angular/platform-browser\": \"8.2.14\",\r\n  \"@angular/platform-browser-dynamic\": \"8.2.14\",\r\n  \"@angular/router\": \"8.2.14\",\r\n  \"@nativescript/angular\": \"8.21.0\",\r\n  \"@nativescript/core\": \"6.5.0\",\r\n  \"@nativescript/theme\": \"2.3.3\",\r\n  \"@progress-nativechat/nativescript-nativechat\": \"3.0.0\",\r\n  \"kinvey-nativescript-sdk\": \"4.2.5\",\r\n  \"nativescript-accelerometer\": \"3.0.0\",\r\n  \"nativescript-angular\": \"8.21.0\",\r\n  \"nativescript-background-http\": \"4.2.1\",\r\n  \"nativescript-camera\": \"4.5.0\",\r\n  \"nativescript-geolocation\": \"5.1.0\",\r\n  \"nativescript-image\": \"3.0.1\",\r\n  \"nativescript-imagepicker\": \"7.1.0\",\r\n  \"nativescript-intl\": \"3.0.0\",\r\n  \"nativescript-iqkeyboardmanager\": \"1.5.1\",\r\n  \"nativescript-social-share\": \"1.6.0\",\r\n  \"nativescript-theme-core\": \"1.0.6\",\r\n  \"nativescript-ui-autocomplete\": \"6.0.1\",\r\n  \"nativescript-ui-calendar\": \"6.1.0\",\r\n  \"nativescript-ui-chart\": \"7.1.1\",\r\n  \"nativescript-ui-dataform\": \"6.0.0\",\r\n  \"nativescript-ui-gauge\": \"6.0.0\",\r\n  \"nativescript-ui-listview\": \"8.0.1\",\r\n  \"nativescript-ui-sidedrawer\": \"8.0.0\",\r\n  \"nativescript-vue\": \"2.5.0\",\r\n  \"react\": \"16.13.0\",\r\n  \"react-hot-loader\": \"4.12.20\",\r\n  \"react-nativescript\": \"0.18.0\",\r\n  \"reflect-metadata\": \"0.1.13\",\r\n  \"rxjs\": \"6.5.4\",\r\n  \"rxjs-compat\": \"6.5.4\",\r\n  \"svelte\": \"3.20.1\",\r\n  \"svelte-native\": \"0.8.1\",\r\n  \"tns-core-modules\": \"6.5.0\",\r\n  \"zone.js\": \"0.10.2\"\r\n}\r\n```\r\n\r\n**Describe the bug**\r\nLaunching a dialog from `@nativescript/core/ui/dialogs` pulls the colour from `Button`, but constructs one globally without attaching it to any context, so any extra styles are not applied appropriately. This includes component-local .css definitions for `Button`, but more importantly (for my use case), the `app.css` `.ns-dark Button` definition doesn't get used when the user is in dark mode.\r\n\r\nKeep in mind that the `Button` that is used for style extraction is only ever constructed once, too, which would disable the ability to switch back and forth between dark and light even if the style were properly composed at instantiation.\r\n\r\n**To Reproduce**\r\nAdd two styles:\r\n```css\r\nButton {\r\n  color: #ff0000;\r\n}\r\n\r\n.ns-dark Button {\r\n  color: #00ff00;\r\n}\r\n```\r\n\r\n**Expected behavior**\r\nWhen in Dark Mode, the buttons on a dialog should be green (in the example).\r\n\r\n**Sample project**\r\nhttps://play.nativescript.org/?template=play-ng\u0026id=Uklyzp","author":{"url":"https://github.com/facetious","@type":"Person","name":"facetious"},"datePublished":"2020-03-31T20:44:35.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":1},"url":"https://github.com/8484/NativeScript/issues/8484"}

route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:a82dc221-6503-4454-d48b-9369e667a7e1
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id936C:1E0C3E:1DE903C:2737818:6A5C8F2C
html-safe-nonce78655f82ea18e28fee1254a7d0227ce813cdd70a75a6dc32178a2562eb9e8900
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MzZDOjFFMEMzRToxREU5MDNDOjI3Mzc4MTg6NkE1QzhGMkMiLCJ2aXNpdG9yX2lkIjoiNzI4MjkxNTUyNTIyNzQ4MjkyNCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacf49e766456d3a82ef6a7986a59633917615eba73527acc6a780e517293473371
hovercard-subject-tagissue:591413974
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/NativeScript/NativeScript/8484/issue_layout
twitter:imagehttps://opengraph.githubassets.com/9f56a9df00feca4be0c5103cfd6aa8d9a1c8cad395cbbffe7420d76eaace5d1c/NativeScript/NativeScript/issues/8484
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/9f56a9df00feca4be0c5103cfd6aa8d9a1c8cad395cbbffe7420d76eaace5d1c/NativeScript/NativeScript/issues/8484
og:image:altEnvironment From play.nativescript.org: { "@angular/animations": "8.2.14", "@angular/common": "8.2.14", "@angular/compiler": "8.2.14", "@angular/core": "8.2.14", "@angular/forms": "8.2.14", "@angul...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamefacetious
hostnamegithub.com
expected-hostnamegithub.com
None5290d7e14309ad1e76106a9c4237bd1041517e83ea182c8ab756752cb0c6940b
turbo-cache-controlno-preview
go-importgithub.com/NativeScript/NativeScript git https://github.com/NativeScript/NativeScript.git
octolytics-dimension-user_id7392261
octolytics-dimension-user_loginNativeScript
octolytics-dimension-repository_id31492490
octolytics-dimension-repository_nwoNativeScript/NativeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id31492490
octolytics-dimension-repository_network_root_nwoNativeScript/NativeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9c975978430e9ad293956f2bbdaf153b1bd84a99
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/NativeScript/NativeScript/issues/8484#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNativeScript%2FNativeScript%2Fissues%2F8484
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNativeScript%2FNativeScript%2Fissues%2F8484
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=NativeScript%2FNativeScript
Reloadhttps://github.com/NativeScript/NativeScript/issues/8484
Reloadhttps://github.com/NativeScript/NativeScript/issues/8484
Reloadhttps://github.com/NativeScript/NativeScript/issues/8484
Please reload this pagehttps://github.com/NativeScript/NativeScript/issues/8484
NativeScript https://github.com/NativeScript
NativeScripthttps://github.com/NativeScript/NativeScript
Please reload this pagehttps://github.com/NativeScript/NativeScript/issues/8484
Notifications https://github.com/login?return_to=%2FNativeScript%2FNativeScript
Fork 1.7k https://github.com/login?return_to=%2FNativeScript%2FNativeScript
Star 25.6k https://github.com/login?return_to=%2FNativeScript%2FNativeScript
Code https://github.com/NativeScript/NativeScript
Issues 771 https://github.com/NativeScript/NativeScript/issues
Pull requests 67 https://github.com/NativeScript/NativeScript/pulls
Discussions https://github.com/NativeScript/NativeScript/discussions
Actions https://github.com/NativeScript/NativeScript/actions
Projects https://github.com/NativeScript/NativeScript/projects
Wiki https://github.com/NativeScript/NativeScript/wiki
Security and quality 0 https://github.com/NativeScript/NativeScript/security
Insights https://github.com/NativeScript/NativeScript/pulse
Code https://github.com/NativeScript/NativeScript
Issues https://github.com/NativeScript/NativeScript/issues
Pull requests https://github.com/NativeScript/NativeScript/pulls
Discussions https://github.com/NativeScript/NativeScript/discussions
Actions https://github.com/NativeScript/NativeScript/actions
Projects https://github.com/NativeScript/NativeScript/projects
Wiki https://github.com/NativeScript/NativeScript/wiki
Security and quality https://github.com/NativeScript/NativeScript/security
Insights https://github.com/NativeScript/NativeScript/pulse
.ns-dark doesn't apply through to dialogshttps://github.com/NativeScript/NativeScript/issues/8484#top
bughttps://github.com/NativeScript/NativeScript/issues?q=state%3Aopen%20label%3A%22bug%22
known-issuehttps://github.com/NativeScript/NativeScript/issues?q=state%3Aopen%20label%3A%22known-issue%22
https://github.com/facetious
facetioushttps://github.com/facetious
on Mar 31, 2020https://github.com/NativeScript/NativeScript/issues/8484#issue-591413974
https://play.nativescript.org/?template=play-ng&id=Uklyzphttps://play.nativescript.org/?template=play-ng&id=Uklyzp
bughttps://github.com/NativeScript/NativeScript/issues?q=state%3Aopen%20label%3A%22bug%22
known-issuehttps://github.com/NativeScript/NativeScript/issues?q=state%3Aopen%20label%3A%22known-issue%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.