Title: [modal] ns-dark not applied to top element · Issue #8374 · NativeScript/NativeScript · GitHub
Open Graph Title: [modal] ns-dark not applied to top element · Issue #8374 · NativeScript/NativeScript
X Title: [modal] ns-dark not applied to top element · Issue #8374 · NativeScript/NativeScript
Description: I am using latest of everything If you run the attached example: click the button => opened page is not themed but child label is change the code to open modal modalFrame/modalFrame click the button => opened page is themed but child lab...
Open Graph Description: I am using latest of everything If you run the attached example: click the button => opened page is not themed but child label is change the code to open modal modalFrame/modalFrame click the butto...
X Description: I am using latest of everything If you run the attached example: click the button => opened page is not themed but child label is change the code to open modal modalFrame/modalFrame click the bu...
Opengraph URL: https://github.com/NativeScript/NativeScript/issues/8374
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"[modal] ns-dark not applied to top element","articleBody":"I am using latest of everything\r\n\r\nIf you run the attached example:\r\n* click the button =\u003e opened page is not themed but child label is\r\n* change the code to open modal `modalFrame/modalFrame` \r\n* click the button =\u003e opened page is themed but child label is\r\n[NSPlayground 2.zip](https://github.com/NativeScript/NativeScript/files/4244537/NSPlayground.2.zip)\r\n\r\nI think the issue is that the top/root view opened in modal is not applied ns-dark.\r\n\r\nI also see that behavior in my `nativescript-material-bottomsheet` and `nativescript-material-dialogs` when i show custom view inside dialog or bottom sheet.\r\nhttps://github.com/Akylas/nativescript-material-components/blob/2ed3d870bdce10e66fa2bcda4d936da499690f39/src/bottomsheet/bottomsheet-common.ts#L134\r\nBTW it happens on both platforms\r\n","author":{"url":"https://github.com/farfromrefug","@type":"Person","name":"farfromrefug"},"datePublished":"2020-02-24T12:41:48.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":3},"url":"https://github.com/8374/NativeScript/issues/8374"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:512f318f-110d-f535-fc33-4315be7f1ea0 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | BA94:2AB6CB:5ECE58:85E0D5:6A5F8A61 |
| html-safe-nonce | 581c5f2bfd0a9eb68244b640697d4e61d6190fb393236b6fb8c153270b23307d |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQTk0OjJBQjZDQjo1RUNFNTg6ODVFMEQ1OjZBNUY4QTYxIiwidmlzaXRvcl9pZCI6IjE0NTYwMjY2NTg4NDEyNTc5MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 52719a05c077adb5219b9edf8602857d9eb3c0c56a56d20a7d5af94177d6eea0 |
| hovercard-subject-tag | issue:569831198 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/NativeScript/NativeScript/8374/issue_layout |
| twitter:image | https://opengraph.githubassets.com/f4e14b7bec7133be480776ae8c77678796e0fc74d38cf2eb9b5663218440a79a/NativeScript/NativeScript/issues/8374 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/f4e14b7bec7133be480776ae8c77678796e0fc74d38cf2eb9b5663218440a79a/NativeScript/NativeScript/issues/8374 |
| og:image:alt | I am using latest of everything If you run the attached example: click the button => opened page is not themed but child label is change the code to open modal modalFrame/modalFrame click the butto... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | farfromrefug |
| hostname | github.com |
| expected-hostname | github.com |
| None | 05a5a04783bf869edc9d6ffbeac22f1152a11abce708ff1bf649457a9b96836a |
| turbo-cache-control | no-preview |
| go-import | github.com/NativeScript/NativeScript git https://github.com/NativeScript/NativeScript.git |
| octolytics-dimension-user_id | 7392261 |
| octolytics-dimension-user_login | NativeScript |
| octolytics-dimension-repository_id | 31492490 |
| octolytics-dimension-repository_nwo | NativeScript/NativeScript |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 31492490 |
| octolytics-dimension-repository_network_root_nwo | NativeScript/NativeScript |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | ebe18dcab12b14d87b778dc32f6b70e7a6910911 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width