René's URL Explorer Experiment


Title: Cannot link tns-core-modules in Angular app · Issue #7905 · NativeScript/NativeScript · GitHub

Open Graph Title: Cannot link tns-core-modules in Angular app · Issue #7905 · NativeScript/NativeScript

X Title: Cannot link tns-core-modules in Angular app · Issue #7905 · NativeScript/NativeScript

Description: Environment Provide version numbers for the following components (information can be retrieved by running tns info in your project folder or by inspecting the package.json of the project): CLI: 6.1.2 Cross-platform modules: 6.1.1 Android...

Open Graph Description: Environment Provide version numbers for the following components (information can be retrieved by running tns info in your project folder or by inspecting the package.json of the project): CLI: 6.1...

X Description: Environment Provide version numbers for the following components (information can be retrieved by running tns info in your project folder or by inspecting the package.json of the project): CLI: 6.1...

Opengraph URL: https://github.com/NativeScript/NativeScript/issues/7905

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Cannot link tns-core-modules in Angular app","articleBody":"**Environment**\r\nProvide version numbers for the following components (information can be retrieved by running `tns info` in your project folder or by inspecting the `package.json` of the project):\r\n - CLI: 6.1.2\r\n - Cross-platform modules: 6.1.1\r\n - Android Runtime: 6.1.2\r\n - iOS Runtime: 6.1.1\r\n\r\n**Describe the bug**\r\nWhen trying to contribute to `tns-core-modules` and using an external NS Angular app to develop / test these contributions, the compile step fails when following the instructions currently outlined in [DevelopmentWorkflow.md](https://github.com/NativeScript/NativeScript/blob/master/DevelopmentWorkflow.md#running-another-app) (Running Another App).\r\n\r\n**To Reproduce**\r\n``` bash\r\ngit clone git@github.com:NativeScript/NativeScript.git\r\ncd NativeScript\r\ntns create blank-ng --template tns-template-blank-ng\r\ncd blank ng\r\nnpm install ../tns-core-modules --save\r\ntns run ios # or tns run android\r\n```\r\n\r\n**Expected behavior**\r\nApplication should run successfully but instead generates the following log https://gist.github.com/rynop/5156d00932b17937cc8889f2a0581f03\r\n\r\n**Additional context**\r\n@bundyo discovered a [workaround](https://github.com/NativeScript/nativescript-dev-webpack/issues/1044#issuecomment-533397897):\r\n\r\n\u003e The problem with linking is that Angular/TS project tend to grab the linked TS files in core modules and try to compile them without the references needed. I've only managed to run it by compiling the core modules with outDir and linking that (.d.ts, package.json and other files, except TS ones should be copied over too). Maybe the team can consider moving to an outDir compilation. Another way would be dev-webpack to forbid Angular/ts-loader for traversing node_modules.\r\n\r\nBut as noted by @MartoYankov [here](https://github.com/NativeScript/NativeScript/pull/7861#issuecomment-535801655):\r\n\u003e @bundyo I followed the steps from \"running another app\" plus one additional step - adding the `tns-platform-declarations` packages to the app. The errors that the ng compiler producers are with types and exports. I suspect these still happen in the regular `ts-loader`, but as warnings. The ng compiler is producing them as errors.\r\n\u003e \r\n\u003e The reason why we don't want to promote alternative dev setups is because we can't support them. We adhere to the dev setup in the nativescript plugin seed to make sure the `tns-core-modules` have a similar setup to all plugins. What I mean is, we should fix the current setup or if not possible - change the dev setup in the plugin seed first.\r\n\r\nSo addressing this issue is two-fold:\r\n- Update dev workflow to require `tns-platform-declarations` as a dev dependency in the Angular app in this scenario (alongside with a references.d.ts in the app root)\r\n- Address the remaining errors that the Angular compiler produces with types and exports\r\n\r\n","author":{"url":"https://github.com/manoldonev","@type":"Person","name":"manoldonev"},"datePublished":"2019-10-04T14:57:50.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":5},"url":"https://github.com/7905/NativeScript/issues/7905"}

route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:2f06f6e9-6b0d-e2c8-8fde-d0b2a8edf010
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id9F26:14C87:273B613:3265774:697491CD
html-safe-noncea0fa29d0a0d3c19dade07f7bc702462fac06d24d1694210a78492ae55b71fb96
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5RjI2OjE0Qzg3OjI3M0I2MTM6MzI2NTc3NDo2OTc0OTFDRCIsInZpc2l0b3JfaWQiOiI3NzM0NDMwMTcyNzI2OTg5MjYxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac45f8c0289bace039090a537533cf4241a70d743018ffcbad94d65dfe3a5a9a97
hovercard-subject-tagissue:502685517
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/NativeScript/NativeScript/7905/issue_layout
twitter:imagehttps://opengraph.githubassets.com/96a2c3da66d3f1c90c1c7ec0a048b81712f66712d329355e59b0ab0b15986153/NativeScript/NativeScript/issues/7905
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/96a2c3da66d3f1c90c1c7ec0a048b81712f66712d329355e59b0ab0b15986153/NativeScript/NativeScript/issues/7905
og:image:altEnvironment Provide version numbers for the following components (information can be retrieved by running tns info in your project folder or by inspecting the package.json of the project): CLI: 6.1...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemanoldonev
hostnamegithub.com
expected-hostnamegithub.com
None4a4bf5f4e28041a9d2e5c107d7d20b78b4294ba261cab243b28167c16a623a1f
turbo-cache-controlno-preview
go-importgithub.com/NativeScript/NativeScript git https://github.com/NativeScript/NativeScript.git
octolytics-dimension-user_id7392261
octolytics-dimension-user_loginNativeScript
octolytics-dimension-repository_id31492490
octolytics-dimension-repository_nwoNativeScript/NativeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id31492490
octolytics-dimension-repository_network_root_nwoNativeScript/NativeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release488b30e96dfd057fbbe44c6665ccbc030b729dde
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/NativeScript/NativeScript/issues/7905#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNativeScript%2FNativeScript%2Fissues%2F7905
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNativeScript%2FNativeScript%2Fissues%2F7905
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=NativeScript%2FNativeScript
Reloadhttps://github.com/NativeScript/NativeScript/issues/7905
Reloadhttps://github.com/NativeScript/NativeScript/issues/7905
Reloadhttps://github.com/NativeScript/NativeScript/issues/7905
NativeScript https://github.com/NativeScript
NativeScripthttps://github.com/NativeScript/NativeScript
Please reload this pagehttps://github.com/NativeScript/NativeScript/issues/7905
Notifications https://github.com/login?return_to=%2FNativeScript%2FNativeScript
Fork 1.7k https://github.com/login?return_to=%2FNativeScript%2FNativeScript
Star 25.4k https://github.com/login?return_to=%2FNativeScript%2FNativeScript
Code https://github.com/NativeScript/NativeScript
Issues 869 https://github.com/NativeScript/NativeScript/issues
Pull requests 58 https://github.com/NativeScript/NativeScript/pulls
Discussions https://github.com/NativeScript/NativeScript/discussions
Actions https://github.com/NativeScript/NativeScript/actions
Projects 0 https://github.com/NativeScript/NativeScript/projects
Wiki https://github.com/NativeScript/NativeScript/wiki
Security 0 https://github.com/NativeScript/NativeScript/security
Insights https://github.com/NativeScript/NativeScript/pulse
Code https://github.com/NativeScript/NativeScript
Issues https://github.com/NativeScript/NativeScript/issues
Pull requests https://github.com/NativeScript/NativeScript/pulls
Discussions https://github.com/NativeScript/NativeScript/discussions
Actions https://github.com/NativeScript/NativeScript/actions
Projects https://github.com/NativeScript/NativeScript/projects
Wiki https://github.com/NativeScript/NativeScript/wiki
Security https://github.com/NativeScript/NativeScript/security
Insights https://github.com/NativeScript/NativeScript/pulse
New issuehttps://github.com/login?return_to=https://github.com/NativeScript/NativeScript/issues/7905
New issuehttps://github.com/login?return_to=https://github.com/NativeScript/NativeScript/issues/7905
Cannot link tns-core-modules in Angular apphttps://github.com/NativeScript/NativeScript/issues/7905#top
https://github.com/manoldonev
https://github.com/manoldonev
manoldonevhttps://github.com/manoldonev
on Oct 4, 2019https://github.com/NativeScript/NativeScript/issues/7905#issue-502685517
DevelopmentWorkflow.mdhttps://github.com/NativeScript/NativeScript/blob/master/DevelopmentWorkflow.md#running-another-app
https://gist.github.com/rynop/5156d00932b17937cc8889f2a0581f03https://gist.github.com/rynop/5156d00932b17937cc8889f2a0581f03
@bundyohttps://github.com/bundyo
workaroundhttps://github.com/NativeScript/nativescript-dev-webpack/issues/1044#issuecomment-533397897
@MartoYankovhttps://github.com/MartoYankov
herehttps://github.com/NativeScript/NativeScript/pull/7861#issuecomment-535801655
@bundyohttps://github.com/bundyo
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.