René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"[Feature Request] Flexible Error/Exception handling","articleBody":"## The Problem\r\nCurrently, when an unhandled exception is thrown in NativeScript (inside app-code, core-modules or plugins) it will (in most) cases crash the application showing the error and stack trace. \r\n\r\nWhen in **development** - in many cases this is what you'd expect. You would want to have the stack-trace of the exact location the unexpected behavior has occurred, so that you can more easily understand what happened and fix it.\r\n\r\nHowever, in **production**, an application crash can seriously hurt you application credibility and drive away customers. In many cases you might prefer anything else (app freeze, blank screen, failed navigation etc.) to an actual crash with an error log. There are even cases, in whitch the application will recover and will work OK even if something unexpected has happened - for exampled failed animation or a typo in CSS property.\r\n\r\n## Proposal\r\n\r\nThe aim of this FR is to propose an API that provides a way to handle errors in different ways in development and in production. It should provide flexibility to configure how errors should be handled. For example:\r\n\r\n1. _(development 1)_ Throw exceptions as soon as error occurs.\r\n2. _(development 2)_ Show a scary `console.log` with `ERROR: Something bad happened` but continue execution of the app. You will see it in you terminal, but decide if it is critical based on what happens with the app after that.\r\n3. _(production)_ Send an error report to your analytics/error-report server, but continue app execution. Maybe triggers some recover logic that will handle the app without a crash. \r\n\r\n### API Proposal\r\nExtend the `trace` module with an `error()` method. \r\n\r\nUse the method in core-framework/plugins/app code:\r\n```\r\nfunction doSomething(arg) {\r\n  // Instead of   \r\n  if(!arg) throw new Error(\"Arg not provided in \"doSomething\");\r\n  \r\n  // Use trace.error()\r\n  if(!arg) {\r\n    trace.error(\"Arg not provided in \"doSomething\");\r\n    return;\r\n  }\r\n  // ... implementation using arg\r\n}\r\n```\r\n\r\nDevelopers can define custom error handler logic (probably on app startup):\r\n\r\n```\r\nconst errorHandler: ErrorHandler = {\r\n    handleError(err){\r\n        //(development 1)\r\n        throw err;\r\n\r\n        //(development 2)\r\n        trace.write(err, \"unhandlede-error\", type.error);\r\n\r\n        //(production)\r\n        reportToAnalytics(err)\r\n    }\r\n}\r\n\r\ntrace.setErrorHandler(errorHandler)\r\n```\r\n\r\n### Next Steps\r\n\r\n- [x] Gather FB on this proposal and implement it in the `tns-core-modules`.\r\n- [x] Create a comprehensive guide on how to use the error API in the [contributing.md](https://github.com/NativeScript/NativeScript/blob/master/CONTRIBUTING.md).  **Update**: [here](https://github.com/NativeScript/NativeScript/blob/master/HandlingErrors.md) it is.\r\n- [x] Require all PRs to follow the guide and handle errors in a similar fashion\r\n- [x] _(ongoing)_ Gradually refactor most problematic areas of the codebase to use comply with the guides and use this approach (PRs will be welcome).\r\n \r\n\r\nPing @NathanWalker @EddyVerbruggen ","author":{"url":"https://github.com/vakrilov","@type":"Person","name":"vakrilov"},"datePublished":"2018-06-05T11:47:56.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":1},"url":"https://github.com/5914/NativeScript/issues/5914"}