René's URL Explorer Experiment


Title: fix: derive CUDA major version from headers for build by Andy-Jost · Pull Request #1395 · NVIDIA/cuda-python · GitHub

Open Graph Title: fix: derive CUDA major version from headers for build by Andy-Jost · Pull Request #1395 · NVIDIA/cuda-python

X Title: fix: derive CUDA major version from headers for build by Andy-Jost · Pull Request #1395 · NVIDIA/cuda-python

Description: Summary Fixes build failures when inferred CUDA major version does not match CUDA headers being compiled against Introduces _get_cuda_major_version() which is used for both: Determining which cuda-bindings version to install as a build dependency Setting CUDA_CORE_BUILD_MAJOR for Cython compile-time conditionals This ensures consistency: the installed cuda-bindings always matches the compile target Changes The version is derived from (in order of priority): CUDA_CORE_BUILD_MAJOR env var (explicit override, e.g. in CI) CUDA_VERSION macro in cuda.h from CUDA_PATH or CUDA_HOME Since CUDA_PATH or CUDA_HOME is required for the build anyway (to provide include directories), the cuda.h header should always be available. If neither the env var nor the headers are available, the build fails with a clear error message. Test plan Unit tests: pytest tests/test_build_hooks.py -v --noconftest CI tests pass

Open Graph Description: Summary Fixes build failures when inferred CUDA major version does not match CUDA headers being compiled against Introduces _get_cuda_major_version() which is used for both: Determining which cud...

X Description: Summary Fixes build failures when inferred CUDA major version does not match CUDA headers being compiled against Introduces _get_cuda_major_version() which is used for both: Determining which cud...

Opengraph URL: https://github.com/NVIDIA/cuda-python/pull/1395

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:6d726a12-3c2d-878e-4f55-b423b0dd44ee
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBD82:33B120:5E7BE2:7DCB30:6AF83B19
html-safe-nonceeaeb1279fb89a607fa0300891c0179fa372ec8dc4078d3e9a05888ee7ee50a64
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCRDgyOjMzQjEyMDo1RTdCRTI6N0RDQjMwOjZBRjgzQjE5IiwidmlzaXRvcl9pZCI6IjU0OTczNjc0MTgzNTY5MDY3NzYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac4e4a31f710ce32228a9a25634d9ea6c990e07546c60e22cd4761c20d0d86b0cd
hovercard-subject-tagpull_request:3110593765
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/NVIDIA/cuda-python/pull/1395/files
twitter:imagehttps://avatars.githubusercontent.com/u/225973198?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/225973198?s=400&v=4
og:image:altSummary Fixes build failures when inferred CUDA major version does not match CUDA headers being compiled against Introduces _get_cuda_major_version() which is used for both: Determining which cud...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None5713ecd83001b2f55c3509fb7a292bf7d66d0f167c7ae87a9f7eaec5a52bf8db
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/NVIDIA/cuda-python git https://github.com/NVIDIA/cuda-python.git
octolytics-dimension-user_id1728152
octolytics-dimension-user_loginNVIDIA
octolytics-dimension-repository_id381173759
octolytics-dimension-repository_nwoNVIDIA/cuda-python
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id381173759
octolytics-dimension-repository_network_root_nwoNVIDIA/cuda-python
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release653be32ff5c755082a4db662491bfbbcfc9112c1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/NVIDIA/cuda-python/pull/1395/changes#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNVIDIA%2Fcuda-python%2Fpull%2F1395%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNVIDIA%2Fcuda-python%2Fpull%2F1395%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=NVIDIA%2Fcuda-python
Reloadhttps://github.com/NVIDIA/cuda-python/pull/1395/changes
Reloadhttps://github.com/NVIDIA/cuda-python/pull/1395/changes
Reloadhttps://github.com/NVIDIA/cuda-python/pull/1395/changes
NVIDIAhttps://github.com/NVIDIA
cuda-pythonhttps://github.com/NVIDIA/cuda-python
Codehttps://github.com/NVIDIA/cuda-python
Issues219 (219)https://github.com/NVIDIA/cuda-python/issues
Pull requests92 (92)https://github.com/NVIDIA/cuda-python/pulls
Discussionshttps://github.com/NVIDIA/cuda-python/discussions
Actionshttps://github.com/NVIDIA/cuda-python/actions
Projectshttps://github.com/NVIDIA/cuda-python/projects
Wikihttps://github.com/NVIDIA/cuda-python/wiki
Security and qualityhttps://github.com/NVIDIA/cuda-python/security
Insightshttps://github.com/NVIDIA/cuda-python/pulse
Sign up for GitHub https://github.com/signup?return_to=%2FNVIDIA%2Fcuda-python%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FNVIDIA%2Fcuda-python%2Fissues%2Fnew%2Fchoose
Andy-Josthttps://github.com/Andy-Jost
NVIDIA:mainhttps://github.com/NVIDIA/cuda-python/tree/main
Andy-Jost:build-major-from-headershttps://github.com/Andy-Jost/cuda-python/tree/build-major-from-headers
Conversation 21 https://github.com/NVIDIA/cuda-python/pull/1395
Commits 4 https://github.com/NVIDIA/cuda-python/pull/1395/commits
Checks 80 https://github.com/NVIDIA/cuda-python/pull/1395/checks
Files changed https://github.com/NVIDIA/cuda-python/pull/1395/files
Please reload this pagehttps://github.com/NVIDIA/cuda-python/pull/1395/changes
fix: derive CUDA major version from headers for build https://github.com/NVIDIA/cuda-python/pull/1395/changes#top
Show all changes 4 commits https://github.com/NVIDIA/cuda-python/pull/1395/files
1fb09d4 fix: derive CUDA major version from headers for build Andy-Jost Dec 17, 2025 https://github.com/NVIDIA/cuda-python/pull/1395/commits/1fb09d486ff648838a0e8e0e96d75b6891442e94
af0f397 Merge branch 'main' into build-major-from-headers Andy-Jost Dec 19, 2025 https://github.com/NVIDIA/cuda-python/pull/1395/commits/af0f397630442688f398e73ba0a94ae342eb888d
42989a2 Minor refactoring. Andy-Jost Jan 6, 2026 https://github.com/NVIDIA/cuda-python/pull/1395/commits/42989a2f91796628c26d8685cbe28fe3917259b6
4565ae8 Merge branch 'main' into build-major-from-headers Andy-Jost Jan 6, 2026 https://github.com/NVIDIA/cuda-python/pull/1395/commits/4565ae8df935f3506443f87e883dc8556bec0e24
Clear filters https://github.com/NVIDIA/cuda-python/pull/1395/files
Please reload this pagehttps://github.com/NVIDIA/cuda-python/pull/1395/changes
Please reload this pagehttps://github.com/NVIDIA/cuda-python/pull/1395/changes
build_hooks.py https://github.com/NVIDIA/cuda-python/pull/1395/changes#diff-f548f2eb738fc5eb41d25700e66f4c87c32cd6da393a2aae3120eb45a9279ab4
test_build_hooks.py https://github.com/NVIDIA/cuda-python/pull/1395/changes#diff-8cdf52a9055777071eb5604af698ae396b88c620c06356f1304378bacf58291b
cuda_core/build_hooks.pyhttps://github.com/NVIDIA/cuda-python/pull/1395/changes#diff-f548f2eb738fc5eb41d25700e66f4c87c32cd6da393a2aae3120eb45a9279ab4
View file https://github.com/Andy-Jost/cuda-python/blob/4565ae8df935f3506443f87e883dc8556bec0e24/cuda_core/build_hooks.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/NVIDIA/cuda-python/pull/1395/{{ revealButtonHref }}
https://github.com/NVIDIA/cuda-python/pull/1395/changes#diff-f548f2eb738fc5eb41d25700e66f4c87c32cd6da393a2aae3120eb45a9279ab4
https://github.com/NVIDIA/cuda-python/pull/1395/changes#diff-f548f2eb738fc5eb41d25700e66f4c87c32cd6da393a2aae3120eb45a9279ab4
rwgkhttps://github.com/rwgk
Jan 4, 2026https://github.com/NVIDIA/cuda-python/pull/1395/changes#r2659938217
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/NVIDIA/cuda-python/pull/1395/changes
https://github.com/NVIDIA/cuda-python/pull/1395/changes#diff-f548f2eb738fc5eb41d25700e66f4c87c32cd6da393a2aae3120eb45a9279ab4
https://github.com/NVIDIA/cuda-python/pull/1395/changes#diff-f548f2eb738fc5eb41d25700e66f4c87c32cd6da393a2aae3120eb45a9279ab4
https://github.com/NVIDIA/cuda-python/pull/1395/changes#diff-f548f2eb738fc5eb41d25700e66f4c87c32cd6da393a2aae3120eb45a9279ab4
https://github.com/NVIDIA/cuda-python/pull/1395/changes#diff-f548f2eb738fc5eb41d25700e66f4c87c32cd6da393a2aae3120eb45a9279ab4
cuda_core/tests/test_build_hooks.pyhttps://github.com/NVIDIA/cuda-python/pull/1395/changes#diff-8cdf52a9055777071eb5604af698ae396b88c620c06356f1304378bacf58291b
View file https://github.com/Andy-Jost/cuda-python/blob/4565ae8df935f3506443f87e883dc8556bec0e24/cuda_core/tests/test_build_hooks.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/NVIDIA/cuda-python/pull/1395/{{ revealButtonHref }}
Please reload this pagehttps://github.com/NVIDIA/cuda-python/pull/1395/changes
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.