Title: Ensure only public entry points are used in tests · Issue #196 · NVIDIA/cuda-python · GitHub
Open Graph Title: Ensure only public entry points are used in tests · Issue #196 · NVIDIA/cuda-python
X Title: Ensure only public entry points are used in tests · Issue #196 · NVIDIA/cuda-python
Description: ex: we shouldn't call Stream._init() in the tests, which is an implementation detail of cuda.core. We should only test public APIs. It is fine to also have tests for internal modules/functionalities, but they should come after we have co...
Open Graph Description: ex: we shouldn't call Stream._init() in the tests, which is an implementation detail of cuda.core. We should only test public APIs. It is fine to also have tests for internal modules/functionalitie...
X Description: ex: we shouldn't call Stream._init() in the tests, which is an implementation detail of cuda.core. We should only test public APIs. It is fine to also have tests for internal modules/functional...
Opengraph URL: https://github.com/NVIDIA/cuda-python/issues/196
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Ensure only public entry points are used in tests","articleBody":"ex: we shouldn't call `Stream._init()` in the tests, which is an implementation detail of `cuda.core`. We should only test public APIs.\r\n\r\nIt is fine to also have tests for internal modules/functionalities, but they should come after we have coverage for public APIs.\r\n\r\n> I don't think we have \"relational tests\" added yet (ex: `Device.create_stream()` returns a `Stream`; `Stream.record()` returns an `Event`, etc), but let's add them in the next PR.\r\n\r\n_Originally posted by @leofang in https://github.com/NVIDIA/cuda-python/pull/153#pullrequestreview-2400399182_\r\n ","author":{"url":"https://github.com/leofang","@type":"Person","name":"leofang"},"datePublished":"2024-10-28T23:48:27Z","url":"https://github.com/NVIDIA/cuda-python/issues/196"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:f9563602-4d9f-a00c-7cd3-2c4dd71881fd |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | A988:B0154:12D4FBC:18EE444:6AF88C79 |
| html-safe-nonce | 6e66d3778304303649956ffa065e45b8c5701802815b84d9c0ae6c6616ba1796 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBOTg4OkIwMTU0OjEyRDRGQkM6MThFRTQ0NDo2QUY4OEM3OSIsInZpc2l0b3JfaWQiOiI0Njc1MTY2NjUwNDY5MjIzNTQ1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 2e39fdd41edd3448742e5d231a165d19e086bd67d085276c0f45b6a80112b20a |
| hovercard-subject-tag | issue:2619798360 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/NVIDIA/cuda-python/196/issue_layout |
| twitter:image | https://opengraph.githubassets.com/2dec744759fd890bd3bb7f00c8dcb92c6376bf48acb28bc2201aa1e0b8f7f517/NVIDIA/cuda-python/issues/196 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/2dec744759fd890bd3bb7f00c8dcb92c6376bf48acb28bc2201aa1e0b8f7f517/NVIDIA/cuda-python/issues/196 |
| og:image:alt | ex: we shouldn't call Stream._init() in the tests, which is an implementation detail of cuda.core. We should only test public APIs. It is fine to also have tests for internal modules/functionalitie... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | leofang |
| hostname | github.com |
| expected-hostname | github.com |
| None | 612d3e6ffd693e7ea8d9fcf452370995872baef31d825b1fedef704cd3d24ac7 |
| turbo-cache-control | no-preview |
| go-import | github.com/NVIDIA/cuda-python git https://github.com/NVIDIA/cuda-python.git |
| octolytics-dimension-user_id | 1728152 |
| octolytics-dimension-user_login | NVIDIA |
| octolytics-dimension-repository_id | 381173759 |
| octolytics-dimension-repository_nwo | NVIDIA/cuda-python |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 381173759 |
| octolytics-dimension-repository_network_root_nwo | NVIDIA/cuda-python |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 072e34035c13c31543fba9f025cbbbda4210dae4 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width