René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Failure when reading more than 500 messages from a MESH mailbox","articleBody":"**Context**\r\n\r\nWe are using version 3.2.1 of the MESH-client.\r\nWe are testing the last step of the pseudocode for MESH inbox cycle explained here: https://digital.nhs.uk/developer/api-catalogue/message-exchange-for-social-care-and-health-api#overview--mesh-api-pseudocode\r\n\r\nWhenever our application tries to pull messages from MESH and there are more than 500 messages the MESH client throws the following exception:\r\n\r\n```\r\nERROR MissingSchema: Invalid URL '/messageexchange/**********/inbox...\r\nNo scheme supplied. Perhaps you meant https:///messageexchange/**********/inbox...\r\n```\r\n\r\nWith the following stack trace:\r\n\r\n```\r\nFile \\\"/var/task/mesh_client/__init__.py\\\", line 816, in iterate_message_ids\",\r\n  result = self._inbox_v2_page(url=next_page)\",\r\nFile \\\"/var/task/mesh_client/__init__.py\\\", line 507, in _inbox_v2_page\",\r\n  response = self._session.get(url, timeout=self._timeout, params=params)\",\r\nFile \\\"/var/task/requests/sessions.py\\\", line 602, in get\",\r\n  return self.request(\\\"GET\\\", url, **kwargs)\",\r\nFile \\\"/var/task/requests/sessions.py\\\", line 575, in request\",\r\n  prep = self.prepare_request(req)\",\r\nFile \\\"/var/task/requests/sessions.py\\\", line 486, in prepare_request\",\r\n  p.prepare(\",\r\nFile \\\"/var/task/requests/models.py\\\", line 368, in prepare\",\r\n  self.prepare_url(url, params)\",\r\nFile \\\"/var/task/requests/models.py\\\", line 439, in prepare_url\",\r\n  raise MissingSchema(\",\r\n```\r\n\r\nThis occurs when trying to load the second batch of message (500 till the end). The reason is that the client expects the links object in the response to contain a fully qualifying URI: https://github.com/NHSDigital/mesh-client/blob/develop/mesh_client/__init__.py#L807-L817\r\nWhere instead the returned links object looks like this:\r\n```\r\n\"links\": {\r\n        \"self\": \"/messageexchange/X26ABC1/inbox\"\r\n    },\r\n```\r\n\r\n**Potential Fix**\r\n\r\nThis can be fixed by either\r\n\r\n- Updating the way that _inbox_v2_page function builds the url: https://github.com/NHSDigital/mesh-client/blob/develop/mesh_client/__init__.py#L506 To check the argument passed is a fully qualified url.\r\n\r\n- or the same  check can be performed when extracting the URL from the links object here: \r\nhttps://github.com/NHSDigital/mesh-client/blob/develop/mesh_client/__init__.py#L807\r\n\r\n","author":{"url":"https://github.com/vivanov-grailbio","@type":"Person","name":"vivanov-grailbio"},"datePublished":"2024-02-06T12:10:48.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":1},"url":"https://github.com/60/mesh-client/issues/60"}