René's URL Explorer Experiment


Title: fix: make time format more strict to stop invalid time date flowing by georgeRobertson · Pull Request #92 · NHSDigital/data-validation-engine · GitHub

Open Graph Title: fix: make time format more strict to stop invalid time date flowing by georgeRobertson · Pull Request #92 · NHSDigital/data-validation-engine

X Title: fix: make time format more strict to stop invalid time date flowing by georgeRobertson · Pull Request #92 · NHSDigital/data-validation-engine

Description: TLDR of changes Time format domain type in specific circumstances is not strict enough allowing indeterminate values to flow through. E.g. 12:3:12. Is this 12:30 or 12:03? Now it raises an error. What kind of changes does this PR introduce? Tick all that apply fix: A bug fix. Correlates with PATCH in SemVer feat: A new feature. Correlates with MINOR in SemVer docs: Documentation only changes style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc) refactor: A code change that neither fixes a bug nor adds a feature perf: A code change that improves performance test: Adding missing or correcting existing tests build: Changes that affect the build system or external dependencies (example scopes: pip, docker, npm) ci: Changes to CI configuration files and scripts (example scopes: GitLabCI) Please check if the PR fulfills these requirements I have read and followed the Contributing guidance Docs have been added / updated Tests and Linting in the CI are passing Changes have been reviewed and approved by a Project Maintainer

Open Graph Description: TLDR of changes Time format domain type in specific circumstances is not strict enough allowing indeterminate values to flow through. E.g. 12:3:12. Is this 12:30 or 12:03? Now it raises an error. W...

X Description: TLDR of changes Time format domain type in specific circumstances is not strict enough allowing indeterminate values to flow through. E.g. 12:3:12. Is this 12:30 or 12:03? Now it raises an error. W...

Opengraph URL: https://github.com/NHSDigital/data-validation-engine/pull/92

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:2cdd95a9-e648-56b2-75a9-ea9624456bae
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE9DC:2C813C:AB3786:F93B8E:6A55F78E
html-safe-nonce40bfedfd8d1850649de8bd218068f9549d6753b7a049c6563242e903c991b9ff
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFOURDOjJDODEzQzpBQjM3ODY6RjkzQjhFOjZBNTVGNzhFIiwidmlzaXRvcl9pZCI6IjIyOTMxNDgxNjU3MDc1MjgwNzgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmaca124885b79e3d931f23020575a4b8c5837ccd5816b2497af2c02536deabdb542
hovercard-subject-tagpull_request:3540325660
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/NHSDigital/data-validation-engine/pull/92/files
twitter:imagehttps://avatars.githubusercontent.com/u/50412379?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/50412379?s=400&v=4
og:image:altTLDR of changes Time format domain type in specific circumstances is not strict enough allowing indeterminate values to flow through. E.g. 12:3:12. Is this 12:30 or 12:03? Now it raises an error. W...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb5665c84831ed9ac4fb79519c16c9c5580ba8092fb8bb6e3e72972ec7197348e
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/NHSDigital/data-validation-engine git https://github.com/NHSDigital/data-validation-engine.git
octolytics-dimension-user_id6683590
octolytics-dimension-user_loginNHSDigital
octolytics-dimension-repository_id1071433568
octolytics-dimension-repository_nwoNHSDigital/data-validation-engine
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1071433568
octolytics-dimension-repository_network_root_nwoNHSDigital/data-validation-engine
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release3725c7f9b2a6e3a27ef57c5aed13428c0f65e045
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/NHSDigital/data-validation-engine/pull/92/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNHSDigital%2Fdata-validation-engine%2Fpull%2F92%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNHSDigital%2Fdata-validation-engine%2Fpull%2F92%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=NHSDigital%2Fdata-validation-engine
Reloadhttps://github.com/NHSDigital/data-validation-engine/pull/92/files
Reloadhttps://github.com/NHSDigital/data-validation-engine/pull/92/files
Reloadhttps://github.com/NHSDigital/data-validation-engine/pull/92/files
Please reload this pagehttps://github.com/NHSDigital/data-validation-engine/pull/92/files
NHSDigital https://github.com/NHSDigital
data-validation-enginehttps://github.com/NHSDigital/data-validation-engine
Notifications https://github.com/login?return_to=%2FNHSDigital%2Fdata-validation-engine
Fork 4 https://github.com/login?return_to=%2FNHSDigital%2Fdata-validation-engine
Star 5 https://github.com/login?return_to=%2FNHSDigital%2Fdata-validation-engine
Code https://github.com/NHSDigital/data-validation-engine
Issues 0 https://github.com/NHSDigital/data-validation-engine/issues
Pull requests 4 https://github.com/NHSDigital/data-validation-engine/pulls
Actions https://github.com/NHSDigital/data-validation-engine/actions
Projects https://github.com/NHSDigital/data-validation-engine/projects
Security and quality 0 https://github.com/NHSDigital/data-validation-engine/security
Insights https://github.com/NHSDigital/data-validation-engine/pulse
Code https://github.com/NHSDigital/data-validation-engine
Issues https://github.com/NHSDigital/data-validation-engine/issues
Pull requests https://github.com/NHSDigital/data-validation-engine/pulls
Actions https://github.com/NHSDigital/data-validation-engine/actions
Projects https://github.com/NHSDigital/data-validation-engine/projects
Security and quality https://github.com/NHSDigital/data-validation-engine/security
Insights https://github.com/NHSDigital/data-validation-engine/pulse
Sign up for GitHub https://github.com/signup?return_to=%2FNHSDigital%2Fdata-validation-engine%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FNHSDigital%2Fdata-validation-engine%2Fissues%2Fnew%2Fchoose
georgeRobertsonhttps://github.com/georgeRobertson
release_v080https://github.com/NHSDigital/data-validation-engine/tree/release_v080
fix/ndit-1166_make_time_format_stricterhttps://github.com/NHSDigital/data-validation-engine/tree/fix/ndit-1166_make_time_format_stricter
Conversation 1 https://github.com/NHSDigital/data-validation-engine/pull/92
Commits 2 https://github.com/NHSDigital/data-validation-engine/pull/92/commits
Checks 4 https://github.com/NHSDigital/data-validation-engine/pull/92/checks
Files changed https://github.com/NHSDigital/data-validation-engine/pull/92/files
Please reload this pagehttps://github.com/NHSDigital/data-validation-engine/pull/92/files
fix: make time format more strict to stop invalid time date flowing https://github.com/NHSDigital/data-validation-engine/pull/92/files#top
Show all changes 2 commits https://github.com/NHSDigital/data-validation-engine/pull/92/files
e58ba8b fix: make time format more strict to stop invalid time date flowing georgeRobertson Apr 16, 2026 https://github.com/NHSDigital/data-validation-engine/pull/92/commits/e58ba8b47aa89c7a4a8ef0f3d80f031158612f89
e537941 style: address sonarcube l523 comment georgeRobertson Apr 16, 2026 https://github.com/NHSDigital/data-validation-engine/pull/92/commits/e53794100bc14b36d9d886351a3410e065d22e83
Clear filters https://github.com/NHSDigital/data-validation-engine/pull/92/files
Please reload this pagehttps://github.com/NHSDigital/data-validation-engine/pull/92/files
Please reload this pagehttps://github.com/NHSDigital/data-validation-engine/pull/92/files
domain_types.py https://github.com/NHSDigital/data-validation-engine/pull/92/files#diff-2f7d96dcb40c049eb1b512345f8637bae833317ac0301a5046098f9185000d4d
test_domain_types.py https://github.com/NHSDigital/data-validation-engine/pull/92/files#diff-a13c3c7836de07af34a44480585f54eeac588b2eba6833d801fb75bc636eda83
src/dve/metadata_parser/domain_types.pyhttps://github.com/NHSDigital/data-validation-engine/pull/92/files#diff-2f7d96dcb40c049eb1b512345f8637bae833317ac0301a5046098f9185000d4d
View file https://github.com/NHSDigital/data-validation-engine/blob/e53794100bc14b36d9d886351a3410e065d22e83/src/dve/metadata_parser/domain_types.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/NHSDigital/data-validation-engine/pull/92/{{ revealButtonHref }}
https://github.com/NHSDigital/data-validation-engine/pull/92/files#diff-2f7d96dcb40c049eb1b512345f8637bae833317ac0301a5046098f9185000d4d
https://github.com/NHSDigital/data-validation-engine/pull/92/files#diff-2f7d96dcb40c049eb1b512345f8637bae833317ac0301a5046098f9185000d4d
tests/test_model_generation/test_domain_types.pyhttps://github.com/NHSDigital/data-validation-engine/pull/92/files#diff-a13c3c7836de07af34a44480585f54eeac588b2eba6833d801fb75bc636eda83
View file https://github.com/NHSDigital/data-validation-engine/blob/e53794100bc14b36d9d886351a3410e065d22e83/tests/test_model_generation/test_domain_types.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/NHSDigital/data-validation-engine/pull/92/{{ revealButtonHref }}
https://github.com/NHSDigital/data-validation-engine/pull/92/files#diff-a13c3c7836de07af34a44480585f54eeac588b2eba6833d801fb75bc636eda83
https://github.com/NHSDigital/data-validation-engine/pull/92/files#diff-a13c3c7836de07af34a44480585f54eeac588b2eba6833d801fb75bc636eda83
https://github.com/NHSDigital/data-validation-engine/pull/92/files#diff-a13c3c7836de07af34a44480585f54eeac588b2eba6833d801fb75bc636eda83
Please reload this pagehttps://github.com/NHSDigital/data-validation-engine/pull/92/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.