René's URL Explorer Experiment


Title: fix: make time format more strict to stop invalid time date flowing by georgeRobertson · Pull Request #92 · NHSDigital/data-validation-engine · GitHub

Open Graph Title: fix: make time format more strict to stop invalid time date flowing by georgeRobertson · Pull Request #92 · NHSDigital/data-validation-engine

X Title: fix: make time format more strict to stop invalid time date flowing by georgeRobertson · Pull Request #92 · NHSDigital/data-validation-engine

Description: Data Validation Engine source code. Contribute to NHSDigital/data-validation-engine development by creating an account on GitHub.

Open Graph Description: TLDR of changes Time format domain type in specific circumstances is not strict enough allowing indeterminate values to flow through. E.g. 12:3:12. Is this 12:30 or 12:03? Now it raises an error. W...

X Description: TLDR of changes Time format domain type in specific circumstances is not strict enough allowing indeterminate values to flow through. E.g. 12:3:12. Is this 12:30 or 12:03? Now it raises an error. W...

Opengraph URL: https://github.com/NHSDigital/data-validation-engine/pull/92

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:0280d56f-6ef6-9911-b193-cf7fc19c0720
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAEFA:6ED1:87295D:B7861C:6A55AC70
html-safe-nonceebcae22a65fdd69fb85948c14785de8909057fb7d3ead2dda1abd2c55868fbe5
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRUZBOjZFRDE6ODcyOTVEOkI3ODYxQzo2QTU1QUM3MCIsInZpc2l0b3JfaWQiOiIzODE2NjEyMTQ1NTA2MTM1MTUyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmace3cf8c06d97f9af9a9524b595b8f8d76e9b44df875ad3554898d0e72c5c95980
hovercard-subject-tagpull_request:3540325660
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/NHSDigital/data-validation-engine/92/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/7f8ecd016ef11b139585e1b0e384a0eba41966fd9f4fb591e7a34f1c976dcacd/NHSDigital/data-validation-engine/pull/92
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/7f8ecd016ef11b139585e1b0e384a0eba41966fd9f4fb591e7a34f1c976dcacd/NHSDigital/data-validation-engine/pull/92
og:image:altTLDR of changes Time format domain type in specific circumstances is not strict enough allowing indeterminate values to flow through. E.g. 12:3:12. Is this 12:30 or 12:03? Now it raises an error. W...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamegeorgeRobertson
hostnamegithub.com
expected-hostnamegithub.com
Noneb5665c84831ed9ac4fb79519c16c9c5580ba8092fb8bb6e3e72972ec7197348e
turbo-cache-controlno-cache
go-importgithub.com/NHSDigital/data-validation-engine git https://github.com/NHSDigital/data-validation-engine.git
octolytics-dimension-user_id6683590
octolytics-dimension-user_loginNHSDigital
octolytics-dimension-repository_id1071433568
octolytics-dimension-repository_nwoNHSDigital/data-validation-engine
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1071433568
octolytics-dimension-repository_network_root_nwoNHSDigital/data-validation-engine
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release653fccf1e27344851c0d3de3fa6faa526197f072
ui-targetcanary-2
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/NHSDigital/data-validation-engine/pull/92#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNHSDigital%2Fdata-validation-engine%2Fpull%2F92
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNHSDigital%2Fdata-validation-engine%2Fpull%2F92
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=NHSDigital%2Fdata-validation-engine
Reloadhttps://github.com/NHSDigital/data-validation-engine/pull/92
Reloadhttps://github.com/NHSDigital/data-validation-engine/pull/92
Reloadhttps://github.com/NHSDigital/data-validation-engine/pull/92
Please reload this pagehttps://github.com/NHSDigital/data-validation-engine/pull/92
NHSDigital https://github.com/NHSDigital
data-validation-enginehttps://github.com/NHSDigital/data-validation-engine
Notifications https://github.com/login?return_to=%2FNHSDigital%2Fdata-validation-engine
Fork 4 https://github.com/login?return_to=%2FNHSDigital%2Fdata-validation-engine
Star 5 https://github.com/login?return_to=%2FNHSDigital%2Fdata-validation-engine
Code https://github.com/NHSDigital/data-validation-engine
Issues 0 https://github.com/NHSDigital/data-validation-engine/issues
Pull requests 4 https://github.com/NHSDigital/data-validation-engine/pulls
Actions https://github.com/NHSDigital/data-validation-engine/actions
Projects https://github.com/NHSDigital/data-validation-engine/projects
Security and quality 0 https://github.com/NHSDigital/data-validation-engine/security
Insights https://github.com/NHSDigital/data-validation-engine/pulse
Code https://github.com/NHSDigital/data-validation-engine
Issues https://github.com/NHSDigital/data-validation-engine/issues
Pull requests https://github.com/NHSDigital/data-validation-engine/pulls
Actions https://github.com/NHSDigital/data-validation-engine/actions
Projects https://github.com/NHSDigital/data-validation-engine/projects
Security and quality https://github.com/NHSDigital/data-validation-engine/security
Insights https://github.com/NHSDigital/data-validation-engine/pulse
georgeRobertsonhttps://github.com/georgeRobertson
release_v080https://github.com/NHSDigital/data-validation-engine/tree/release_v080
fix/ndit-1166_make_time_format_stricterhttps://github.com/NHSDigital/data-validation-engine/tree/fix/ndit-1166_make_time_format_stricter
Conversationhttps://github.com/NHSDigital/data-validation-engine/pull/92
Commits2 (2)https://github.com/NHSDigital/data-validation-engine/pull/92/commits
Checkshttps://github.com/NHSDigital/data-validation-engine/pull/92/checks
Files changedhttps://github.com/NHSDigital/data-validation-engine/pull/92/files
fix: make time format more strict to stop invalid time date flowinghttps://github.com/NHSDigital/data-validation-engine/pull/92#top
georgeRobertsonhttps://github.com/georgeRobertson
release_v080https://github.com/NHSDigital/data-validation-engine/tree/release_v080
fix/ndit-1166_make_time_format_stricterhttps://github.com/NHSDigital/data-validation-engine/tree/fix/ndit-1166_make_time_format_stricter
https://github.com/georgeRobertson
georgeRobertsonhttps://github.com/georgeRobertson
Apr 16, 2026https://github.com/NHSDigital/data-validation-engine/pull/92#issue-4276814282
Please reload this pagehttps://github.com/NHSDigital/data-validation-engine/pull/92
Contributing guidancehttps://github.com/NHSDigital/data-validation-engine/CONTRIBUTE.md
Please reload this pagehttps://github.com/NHSDigital/data-validation-engine/pull/92
georgeRobertsonhttps://github.com/georgeRobertson
April 16, 2026 16:38https://github.com/NHSDigital/data-validation-engine/pull/92#commits-pushed-e58ba8b
https://github.com/georgeRobertson
fix: make time format more strict to stop invalid time date flowinghttps://github.com/NHSDigital/data-validation-engine/pull/92/commits/e58ba8b47aa89c7a4a8ef0f3d80f031158612f89
e58ba8bhttps://github.com/NHSDigital/data-validation-engine/pull/92/commits/e58ba8b47aa89c7a4a8ef0f3d80f031158612f89
https://github.com/georgeRobertson
style: address sonarcube l523 commenthttps://github.com/NHSDigital/data-validation-engine/pull/92/commits/e53794100bc14b36d9d886351a3410e065d22e83
e537941https://github.com/NHSDigital/data-validation-engine/pull/92/commits/e53794100bc14b36d9d886351a3410e065d22e83
https://github.com/apps/sonarqubecloud
sonarqubecloudhttps://github.com/apps/sonarqubecloud
Apr 16, 2026https://github.com/NHSDigital/data-validation-engine/pull/92#issuecomment-4261496086
https://sonarcloud.io/dashboard?id=NHSDigital_data-validation-engine&pullRequest=92
https://camo.githubusercontent.com/6cc27951a82703bd6a32deed62ec92af84fc495762ca86bc7af5a3ac490c7bda/68747470733a2f2f736f6e6172736f757263652e6769746875622e696f2f736f6e6172636c6f75642d6769746875622d7374617469632d7265736f75726365732f76322f636f6d6d6f6e2f7061737365642d313670782e706e67
0 New issueshttps://sonarcloud.io/project/issues?id=NHSDigital_data-validation-engine&pullRequest=92&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true
https://camo.githubusercontent.com/5ad34d7e6f2a5aa0d644209f46bb24fba00f31f704923ce46fe8434f94917f73/68747470733a2f2f736f6e6172736f757263652e6769746875622e696f2f736f6e6172636c6f75642d6769746875622d7374617469632d7265736f75726365732f76322f636f6d6d6f6e2f61636365707465642d313670782e706e67
1 Accepted issuehttps://sonarcloud.io/project/issues?id=NHSDigital_data-validation-engine&pullRequest=92&issueStatuses=ACCEPTED
https://camo.githubusercontent.com/6cc27951a82703bd6a32deed62ec92af84fc495762ca86bc7af5a3ac490c7bda/68747470733a2f2f736f6e6172736f757263652e6769746875622e696f2f736f6e6172636c6f75642d6769746875622d7374617469632d7265736f75726365732f76322f636f6d6d6f6e2f7061737365642d313670782e706e67
0 Security Hotspotshttps://sonarcloud.io/project/security_hotspots?id=NHSDigital_data-validation-engine&pullRequest=92&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true
https://camo.githubusercontent.com/6cc27951a82703bd6a32deed62ec92af84fc495762ca86bc7af5a3ac490c7bda/68747470733a2f2f736f6e6172736f757263652e6769746875622e696f2f736f6e6172636c6f75642d6769746875622d7374617469632d7265736f75726365732f76322f636f6d6d6f6e2f7061737365642d313670782e706e67
0.0% Coverage on New Codehttps://sonarcloud.io/component_measures?id=NHSDigital_data-validation-engine&pullRequest=92&metric=new_coverage&view=list
https://camo.githubusercontent.com/6cc27951a82703bd6a32deed62ec92af84fc495762ca86bc7af5a3ac490c7bda/68747470733a2f2f736f6e6172736f757263652e6769746875622e696f2f736f6e6172636c6f75642d6769746875622d7374617469632d7265736f75726365732f76322f636f6d6d6f6e2f7061737365642d313670782e706e67
0.0% Duplication on New Codehttps://sonarcloud.io/component_measures?id=NHSDigital_data-validation-engine&pullRequest=92&metric=new_duplicated_lines_density&view=list
See analysis details on SonarQube Cloudhttps://sonarcloud.io/dashboard?id=NHSDigital_data-validation-engine&pullRequest=92
Please reload this pagehttps://github.com/NHSDigital/data-validation-engine/pull/92
https://github.com/georgeRobertson
georgeRobertsonhttps://github.com/georgeRobertson
11930b8https://github.com/NHSDigital/data-validation-engine/commit/11930b81d8ed60e9957ec3018edb4c9989be304f
Apr 16, 2026https://github.com/NHSDigital/data-validation-engine/pull/92#event-24574571759
Please reload this pagehttps://github.com/NHSDigital/data-validation-engine/pull/92
georgeRobertsonhttps://github.com/georgeRobertson
Apr 16, 2026 https://github.com/NHSDigital/data-validation-engine/pull/92#ref-commit-6d342c5
https://github.com/georgeRobertson
Release v073https://github.com/NHSDigital/data-validation-engine/commit/6d342c5fd8c3e8dc8cd4345043902d636fbb804b
6d342c5https://github.com/NHSDigital/data-validation-engine/commit/6d342c5fd8c3e8dc8cd4345043902d636fbb804b
#92https://github.com/NHSDigital/data-validation-engine/pull/92
https://github.com/georgeRobertson
georgeRobertsonhttps://github.com/georgeRobertson
April 16, 2026 21:31https://github.com/NHSDigital/data-validation-engine/pull/92#event-24584335643
https://github.co/hiddenchars
https://github.com/NHSDigital/data-validation-engine/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNHSDigital%2Fdata-validation-engine%2Fpull%2F92
Please reload this pagehttps://github.com/NHSDigital/data-validation-engine/pull/92
https://github.com/georgeRobertson
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.