Title: Fix/sr ndit 1663 by stevenhsd · Pull Request #127 · NHSDigital/data-validation-engine · GitHub
Open Graph Title: Fix/sr ndit 1663 by stevenhsd · Pull Request #127 · NHSDigital/data-validation-engine
X Title: Fix/sr ndit 1663 by stevenhsd · Pull Request #127 · NHSDigital/data-validation-engine
Description: TLDR of changes Allow custom date formats to cascade to contract stage for casting. Ensure strict casting only - if a date doesn't meet the format exactly then it will be nulled - duckdb is too permissive and spark can error if not the case. What kind of changes does this PR introduce? Tick all that apply fix: A bug fix. Correlates with PATCH in SemVer feat: A new feature. Correlates with MINOR in SemVer docs: Documentation only changes style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc) refactor: A code change that neither fixes a bug nor adds a feature perf: A code change that improves performance test: Adding missing or correcting existing tests build: Changes that affect the build system or external dependencies (example scopes: pip, docker, npm) ci: Changes to CI configuration files and scripts (example scopes: GitLabCI) Please check if the PR fulfills these requirements I have read and followed the Contributing guidance Docs have been added / updated Tests and Linting in the CI are passing Changes have been reviewed and approved by a Project Maintainer
Open Graph Description: TLDR of changes Allow custom date formats to cascade to contract stage for casting. Ensure strict casting only - if a date doesn't meet the format exactly then it will be nulled - duckdb is too...
X Description: TLDR of changes Allow custom date formats to cascade to contract stage for casting. Ensure strict casting only - if a date doesn't meet the format exactly then it will be nulled - duckdb is...
Opengraph URL: https://github.com/NHSDigital/data-validation-engine/pull/127
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:d1e6e08f-7825-acab-03ba-9c614faf564f |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | C026:2818E8:92206C:C6B2D9:6A5278E8 |
| html-safe-nonce | fc01c845dbd0d79406579562d39fbb6213c28a2e3a2bad56f51e3185d2d0a244 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMDI2OjI4MThFODo5MjIwNkM6QzZCMkQ5OjZBNTI3OEU4IiwidmlzaXRvcl9pZCI6IjMzMjQ4NzgzMzc2MDQ3NDU0NDgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | b292615d01a726edc497ab9b500f452f6f322eec41ee6d0447297d5f5b5c4461 |
| hovercard-subject-tag | pull_request:4028345520 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/NHSDigital/data-validation-engine/pull/127/files |
| twitter:image | https://avatars.githubusercontent.com/u/56357022?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/56357022?s=400&v=4 |
| og:image:alt | TLDR of changes Allow custom date formats to cascade to contract stage for casting. Ensure strict casting only - if a date doesn't meet the format exactly then it will be nulled - duckdb is too... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | b9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/NHSDigital/data-validation-engine git https://github.com/NHSDigital/data-validation-engine.git |
| octolytics-dimension-user_id | 6683590 |
| octolytics-dimension-user_login | NHSDigital |
| octolytics-dimension-repository_id | 1071433568 |
| octolytics-dimension-repository_nwo | NHSDigital/data-validation-engine |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1071433568 |
| octolytics-dimension-repository_network_root_nwo | NHSDigital/data-validation-engine |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 07a982c1d40157c619b364352b704c3ce66bb332 |
| ui-target | canary-1 |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width