René's URL Explorer Experiment


Title: Fix/sr ndit 1663 by stevenhsd · Pull Request #127 · NHSDigital/data-validation-engine · GitHub

Open Graph Title: Fix/sr ndit 1663 by stevenhsd · Pull Request #127 · NHSDigital/data-validation-engine

X Title: Fix/sr ndit 1663 by stevenhsd · Pull Request #127 · NHSDigital/data-validation-engine

Description: Data Validation Engine source code. Contribute to NHSDigital/data-validation-engine development by creating an account on GitHub.

Open Graph Description: TLDR of changes Allow custom date formats to cascade to contract stage for casting. Ensure strict casting only - if a date doesn't meet the format exactly then it will be nulled - duckdb is too...

X Description: TLDR of changes Allow custom date formats to cascade to contract stage for casting. Ensure strict casting only - if a date doesn't meet the format exactly then it will be nulled - duckdb is...

Opengraph URL: https://github.com/NHSDigital/data-validation-engine/pull/127

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:99b6e045-9e54-f1d3-3e6b-b32179b5bb62
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC7A2:252FFA:6338:7B20:6A524D2F
html-safe-nonce418324aef948dfa50338254a6e59b578148e1f8559d09e3accbe6567d26c23de
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDN0EyOjI1MkZGQTo2MzM4OjdCMjA6NkE1MjREMkYiLCJ2aXNpdG9yX2lkIjoiNzIxNDUyOTc3NjAzOTY0NDQ2MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac1d34206b2529998445734c03566622fae89690a4c62a3bfb99713b43936c0938
hovercard-subject-tagpull_request:4028345520
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/NHSDigital/data-validation-engine/127/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/b0e7d31bda9ebbedff55b0f338e0c6631938fa7705885d991b1251a2343367f0/NHSDigital/data-validation-engine/pull/127
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/b0e7d31bda9ebbedff55b0f338e0c6631938fa7705885d991b1251a2343367f0/NHSDigital/data-validation-engine/pull/127
og:image:altTLDR of changes Allow custom date formats to cascade to contract stage for casting. Ensure strict casting only - if a date doesn't meet the format exactly then it will be nulled - duckdb is too...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamestevenhsd
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-cache
go-importgithub.com/NHSDigital/data-validation-engine git https://github.com/NHSDigital/data-validation-engine.git
octolytics-dimension-user_id6683590
octolytics-dimension-user_loginNHSDigital
octolytics-dimension-repository_id1071433568
octolytics-dimension-repository_nwoNHSDigital/data-validation-engine
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1071433568
octolytics-dimension-repository_network_root_nwoNHSDigital/data-validation-engine
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7aed05249554b889eb33d002851a973eebcc7e91
ui-targetcanary-1
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/NHSDigital/data-validation-engine/pull/127#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNHSDigital%2Fdata-validation-engine%2Fpull%2F127
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNHSDigital%2Fdata-validation-engine%2Fpull%2F127
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=NHSDigital%2Fdata-validation-engine
Reloadhttps://github.com/NHSDigital/data-validation-engine/pull/127
Reloadhttps://github.com/NHSDigital/data-validation-engine/pull/127
Reloadhttps://github.com/NHSDigital/data-validation-engine/pull/127
Please reload this pagehttps://github.com/NHSDigital/data-validation-engine/pull/127
NHSDigital https://github.com/NHSDigital
data-validation-enginehttps://github.com/NHSDigital/data-validation-engine
Notifications https://github.com/login?return_to=%2FNHSDigital%2Fdata-validation-engine
Fork 4 https://github.com/login?return_to=%2FNHSDigital%2Fdata-validation-engine
Star 5 https://github.com/login?return_to=%2FNHSDigital%2Fdata-validation-engine
Code https://github.com/NHSDigital/data-validation-engine
Issues 0 https://github.com/NHSDigital/data-validation-engine/issues
Pull requests 4 https://github.com/NHSDigital/data-validation-engine/pulls
Actions https://github.com/NHSDigital/data-validation-engine/actions
Projects https://github.com/NHSDigital/data-validation-engine/projects
Security and quality 0 https://github.com/NHSDigital/data-validation-engine/security
Insights https://github.com/NHSDigital/data-validation-engine/pulse
Code https://github.com/NHSDigital/data-validation-engine
Issues https://github.com/NHSDigital/data-validation-engine/issues
Pull requests https://github.com/NHSDigital/data-validation-engine/pulls
Actions https://github.com/NHSDigital/data-validation-engine/actions
Projects https://github.com/NHSDigital/data-validation-engine/projects
Security and quality https://github.com/NHSDigital/data-validation-engine/security
Insights https://github.com/NHSDigital/data-validation-engine/pulse
stevenhsdhttps://github.com/stevenhsd
release_v083https://github.com/NHSDigital/data-validation-engine/tree/release_v083
fix/sr-ndit-1663https://github.com/NHSDigital/data-validation-engine/tree/fix/sr-ndit-1663
Conversationhttps://github.com/NHSDigital/data-validation-engine/pull/127
Commits3 (3)https://github.com/NHSDigital/data-validation-engine/pull/127/commits
Checkshttps://github.com/NHSDigital/data-validation-engine/pull/127/checks
Files changedhttps://github.com/NHSDigital/data-validation-engine/pull/127/files
Fix/sr ndit 1663https://github.com/NHSDigital/data-validation-engine/pull/127#top
stevenhsdhttps://github.com/stevenhsd
release_v083https://github.com/NHSDigital/data-validation-engine/tree/release_v083
fix/sr-ndit-1663https://github.com/NHSDigital/data-validation-engine/tree/fix/sr-ndit-1663
https://github.com/stevenhsd
stevenhsdhttps://github.com/stevenhsd
Jul 10, 2026https://github.com/NHSDigital/data-validation-engine/pull/127#issue-4853857776
Please reload this pagehttps://github.com/NHSDigital/data-validation-engine/pull/127
Contributing guidancehttps://github.com/NHSDigital/data-validation-engine/CONTRIBUTE.md
Please reload this pagehttps://github.com/NHSDigital/data-validation-engine/pull/127
georgeRobertsonhttps://github.com/georgeRobertson
July 2, 2026 16:07https://github.com/NHSDigital/data-validation-engine/pull/127#commits-pushed-f8cd7e8
https://github.com/georgeRobertson
fix: fix issue with non iso date/datetime values in duck db casting a…https://github.com/NHSDigital/data-validation-engine/pull/127/commits/f8cd7e832eb8360c7740367b3f8ce190333917d2
f8cd7e8https://github.com/NHSDigital/data-validation-engine/pull/127/commits/f8cd7e832eb8360c7740367b3f8ce190333917d2
https://github.com/stevenhsd
fix: implement non iso timestamp formats in spark. constrain ddb and …https://github.com/NHSDigital/data-validation-engine/pull/127/commits/c0febac45561f53990d34a980780012759c7a77c
c0febachttps://github.com/NHSDigital/data-validation-engine/pull/127/commits/c0febac45561f53990d34a980780012759c7a77c
https://github.com/georgeRobertson
georgeRobertsonhttps://github.com/georgeRobertson
Jul 10, 2026 https://github.com/NHSDigital/data-validation-engine/pull/127#pullrequestreview-4670306591
View reviewed changes https://github.com/NHSDigital/data-validation-engine/pull/127/files/c0febac45561f53990d34a980780012759c7a77c
src/dve/core_engine/backends/implementations/duckdb/duckdb_helpers.pyhttps://github.com/NHSDigital/data-validation-engine/pull/127/files/c0febac45561f53990d34a980780012759c7a77c#diff-59e88ef19a46cb4c1be29c6fc6ba772f36aea7f1cfea15831032f4bebd1fd0b2
georgeRobertsonhttps://github.com/georgeRobertson
Jul 10, 2026https://github.com/NHSDigital/data-validation-engine/pull/127#discussion_r3557923374
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/NHSDigital/data-validation-engine/pull/127
src/dve/core_engine/backends/implementations/spark/contract.pyhttps://github.com/NHSDigital/data-validation-engine/pull/127/files/c0febac45561f53990d34a980780012759c7a77c#diff-46e980dcc6092190e6d6fa260f890877fc139e4ee857a9d3858e967297b5db66
georgeRobertsonhttps://github.com/georgeRobertson
Jul 10, 2026https://github.com/NHSDigital/data-validation-engine/pull/127#discussion_r3557934657
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/NHSDigital/data-validation-engine/pull/127
src/dve/core_engine/backends/implementations/spark/contract.pyhttps://github.com/NHSDigital/data-validation-engine/pull/127/files/c0febac45561f53990d34a980780012759c7a77c#diff-46e980dcc6092190e6d6fa260f890877fc139e4ee857a9d3858e967297b5db66
georgeRobertsonhttps://github.com/georgeRobertson
Jul 10, 2026https://github.com/NHSDigital/data-validation-engine/pull/127#discussion_r3557942740
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/NHSDigital/data-validation-engine/pull/127
src/dve/core_engine/backends/implementations/spark/spark_helpers.pyhttps://github.com/NHSDigital/data-validation-engine/pull/127/files/c0febac45561f53990d34a980780012759c7a77c#diff-22d9bcc445dd5ba5c657d835ad84f4232a39c2a08c0fb0f38f2efb53deb9851c
georgeRobertsonhttps://github.com/georgeRobertson
Jul 10, 2026https://github.com/NHSDigital/data-validation-engine/pull/127#discussion_r3557955369
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/NHSDigital/data-validation-engine/pull/127
pyproject.tomlhttps://github.com/NHSDigital/data-validation-engine/pull/127/files/c0febac45561f53990d34a980780012759c7a77c#diff-50c86b7ed8ac2cf95bd48334961bf0530cdc77b5a56f852c5c61b89d735fd711
georgeRobertsonhttps://github.com/georgeRobertson
Jul 10, 2026https://github.com/NHSDigital/data-validation-engine/pull/127#discussion_r3557995948
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/NHSDigital/data-validation-engine/pull/127
https://github.com/georgeRobertson
georgeRobertsonhttps://github.com/georgeRobertson
July 10, 2026 14:33https://github.com/NHSDigital/data-validation-engine/pull/127#event-27818521097
https://github.com/stevenhsd
fix: linting and typing fixeshttps://github.com/NHSDigital/data-validation-engine/pull/127/commits/41939d6d37c3129ce75523cdd95ff8f42e512e33
41939d6https://github.com/NHSDigital/data-validation-engine/pull/127/commits/41939d6d37c3129ce75523cdd95ff8f42e512e33
https://github.com/apps/sonarqubecloud
sonarqubecloudhttps://github.com/apps/sonarqubecloud
Jul 10, 2026https://github.com/NHSDigital/data-validation-engine/pull/127#issuecomment-4938153626
https://sonarcloud.io/dashboard?id=NHSDigital_data-validation-engine&pullRequest=127
https://camo.githubusercontent.com/6cc27951a82703bd6a32deed62ec92af84fc495762ca86bc7af5a3ac490c7bda/68747470733a2f2f736f6e6172736f757263652e6769746875622e696f2f736f6e6172636c6f75642d6769746875622d7374617469632d7265736f75726365732f76322f636f6d6d6f6e2f7061737365642d313670782e706e67
1 New issuehttps://sonarcloud.io/project/issues?id=NHSDigital_data-validation-engine&pullRequest=127&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true
https://camo.githubusercontent.com/5ad34d7e6f2a5aa0d644209f46bb24fba00f31f704923ce46fe8434f94917f73/68747470733a2f2f736f6e6172736f757263652e6769746875622e696f2f736f6e6172636c6f75642d6769746875622d7374617469632d7265736f75726365732f76322f636f6d6d6f6e2f61636365707465642d313670782e706e67
0 Accepted issueshttps://sonarcloud.io/project/issues?id=NHSDigital_data-validation-engine&pullRequest=127&issueStatuses=ACCEPTED
https://camo.githubusercontent.com/6cc27951a82703bd6a32deed62ec92af84fc495762ca86bc7af5a3ac490c7bda/68747470733a2f2f736f6e6172736f757263652e6769746875622e696f2f736f6e6172636c6f75642d6769746875622d7374617469632d7265736f75726365732f76322f636f6d6d6f6e2f7061737365642d313670782e706e67
0 Security Hotspotshttps://sonarcloud.io/project/security_hotspots?id=NHSDigital_data-validation-engine&pullRequest=127&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true
https://camo.githubusercontent.com/6cc27951a82703bd6a32deed62ec92af84fc495762ca86bc7af5a3ac490c7bda/68747470733a2f2f736f6e6172736f757263652e6769746875622e696f2f736f6e6172636c6f75642d6769746875622d7374617469632d7265736f75726365732f76322f636f6d6d6f6e2f7061737365642d313670782e706e67
0.0% Coverage on New Codehttps://sonarcloud.io/component_measures?id=NHSDigital_data-validation-engine&pullRequest=127&metric=new_coverage&view=list
https://camo.githubusercontent.com/6cc27951a82703bd6a32deed62ec92af84fc495762ca86bc7af5a3ac490c7bda/68747470733a2f2f736f6e6172736f757263652e6769746875622e696f2f736f6e6172636c6f75642d6769746875622d7374617469632d7265736f75726365732f76322f636f6d6d6f6e2f7061737365642d313670782e706e67
0.0% Duplication on New Codehttps://sonarcloud.io/component_measures?id=NHSDigital_data-validation-engine&pullRequest=127&metric=new_duplicated_lines_density&view=list
See analysis details on SonarQube Cloudhttps://sonarcloud.io/dashboard?id=NHSDigital_data-validation-engine&pullRequest=127
Please reload this pagehttps://github.com/NHSDigital/data-validation-engine/pull/127
https://github.co/hiddenchars
https://github.com/NHSDigital/data-validation-engine/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNHSDigital%2Fdata-validation-engine%2Fpull%2F127
https://github.com/georgeRobertson
georgeRobertson https://github.com/georgeRobertson
https://github.com/NHSDigital/data-validation-engine/pull/127/files/c0febac45561f53990d34a980780012759c7a77c
Please reload this pagehttps://github.com/NHSDigital/data-validation-engine/pull/127
https://github.com/stevenhsd
https://github.com/georgeRobertson
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.