René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"[Order 08][P3] Remove SQL Server SET ROWCOUNT paging","articleBody":"## Priority order\n\nOrder: 08 of 09\nPriority: P3 correctness/performance\n\n## Problem\n\nSQL Server dialect uses session-scoped `SET ROWCOUNT` for snapshot reads and natural paging.\n\nEvidence:\n\n- `src/NEventStore.Persistence.Sql/SqlDialects/MsSqlDialect.cs:21`\n- `GetSnapshot` prepends `SET ROWCOUNT 1`.\n- `NaturalPaging` uses `SET ROWCOUNT @Limit`.\n\n## Impact\n\n- `SET ROWCOUNT` is session-scoped and easy to misuse.\n- Snapshot reads can use explicit `TOP (1)` instead.\n- Natural paging can use explicit `TOP (@Limit)` or keyset query shapes.\n\n## Mandatory test-first workflow\n\n- Add tests first that verify SQL Server snapshot and natural-paging behavior.\n- Include `GetSnapshot` coverage.\n- Include `GetStreamsToSnapshot` coverage with more rows than page size.\n- Do not change SQL generation until behavior is covered.\n\n## Proposed action\n\n- Replace snapshot query with `SELECT TOP (1) ... ORDER BY StreamRevision DESC`.\n- Replace natural paging with explicit `TOP (@Limit)` query forms or keyset-compatible SQL.\n\n## Acceptance criteria\n\n- SQL Server integration tests pass.\n- No rowcount setting can affect later commands on the same connection.\n- Existing paging behavior remains ordered and complete.\n\nSource: `docs/Project-Analysis-Issue-Drafts.md`.","author":{"url":"https://github.com/AGiorgetti","@type":"Person","name":"AGiorgetti"},"datePublished":"2026-06-11T09:21:54.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":0},"url":"https://github.com/65/NEventStore.Persistence.SQL/issues/65"}