René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"[Order 07][P2] Review synchronous query resource lifetime for unenumerated results","articleBody":"## Priority order\n\nOrder: 07 of 09\nPriority: P2 correctness/operability\n\n## Problem\n\nSynchronous query APIs open database resources before returning lazy enumerables.\n\nEvidence:\n\n- `src/NEventStore.Persistence.Sql/SqlPersistenceEngine.cs:460`\n- `ExecuteQuery` opens connection/transaction/statement before returning the lazy enumerable.\n- Disposal depends on the returned enumerable being enumerated and disposed.\n\n## Impact\n\n- Callers that create but do not enumerate a result can leak an open connection/command.\n- Common LINQ terminal operations dispose correctly, but non-enumerated results are easy to miss.\n\n## Mandatory test-first workflow\n\n- Add tests first that reproduce or verify resource lifetime behavior.\n- Include a fake connection/statement test proving whether resources open before enumeration.\n- Include a test proving disposal on early termination.\n- Do not change resource-lifetime behavior until the intended contract is encoded in tests.\n\n## Proposed action\n\n- Consider making sync query methods iterator blocks that open resources on enumeration.\n- Alternatively document the disposal contract and add coverage for common paths if changing behavior is too risky.\n\n## Acceptance criteria\n\n- Resource lifetime behavior is explicit and tested.\n- Early enumeration termination disposes resources.\n- The selected contract is documented if lazy enumerable behavior remains.\n\nSource: `docs/Project-Analysis-Issue-Drafts.md`.","author":{"url":"https://github.com/AGiorgetti","@type":"Person","name":"AGiorgetti"},"datePublished":"2026-06-11T09:21:39.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":0},"url":"https://github.com/64/NEventStore.Persistence.SQL/issues/64"}