Title: [Order 04][P1] Fix Oracle CommitStampStart recursion after Oracle tests are enabled · Issue #61 · NEventStore/NEventStore.Persistence.SQL · GitHub
Open Graph Title: [Order 04][P1] Fix Oracle CommitStampStart recursion after Oracle tests are enabled · Issue #61 · NEventStore/NEventStore.Persistence.SQL
X Title: [Order 04][P1] Fix Oracle CommitStampStart recursion after Oracle tests are enabled · Issue #61 · NEventStore/NEventStore.Persistence.SQL
Description: Priority order Order: 04 of 09 Priority: P1 correctness Blocked by: #58 Problem OracleNativeDialect.CommitStampStart recursively calls itself. Evidence: src/NEventStore.Persistence.Sql/SqlDialects/OracleNativeDialect.cs:55 Getter calls M...
Open Graph Description: Priority order Order: 04 of 09 Priority: P1 correctness Blocked by: #58 Problem OracleNativeDialect.CommitStampStart recursively calls itself. Evidence: src/NEventStore.Persistence.Sql/SqlDialects/...
X Description: Priority order Order: 04 of 09 Priority: P1 correctness Blocked by: #58 Problem OracleNativeDialect.CommitStampStart recursively calls itself. Evidence: src/NEventStore.Persistence.Sql/SqlDialects/...
Opengraph URL: https://github.com/NEventStore/NEventStore.Persistence.SQL/issues/61
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"[Order 04][P1] Fix Oracle CommitStampStart recursion after Oracle tests are enabled","articleBody":"## Priority order\n\nOrder: 04 of 09\nPriority: P1 correctness\nBlocked by: #58\n\n## Problem\n\n`OracleNativeDialect.CommitStampStart` recursively calls itself.\n\nEvidence:\n\n- `src/NEventStore.Persistence.Sql/SqlDialects/OracleNativeDialect.cs:55`\n- Getter calls `MakeOracleParameter(CommitStampStart)` instead of `MakeOracleParameter(base.CommitStampStart)`.\n\n## Impact\n\nOracle date-range reads that need `CommitStampStart` can stack overflow before executing SQL.\n\n## Mandatory test-first workflow\n\n- Complete #58 first or explicitly document why Oracle tests still cannot run.\n- Add tests before changing production code.\n- At minimum, add a unit test against `new OracleNativeDialect().CommitStampStart`.\n- Add or enable Oracle integration coverage for `GetFromTo(bucketId, startDate, endDate)` once Oracle tests can run.\n\n## Proposed action\n\n- Change the getter to `MakeOracleParameter(base.CommitStampStart)`.\n\n## Acceptance criteria\n\n- Oracle `CommitStampStart` returns `:CommitStampStart` without recursion.\n- Oracle date-range read tests pass when Oracle test infrastructure is available.\n- No Oracle production-code fix is merged before the test prerequisite is addressed.\n\nSource: `docs/Project-Analysis-Issue-Drafts.md`.","author":{"url":"https://github.com/AGiorgetti","@type":"Person","name":"AGiorgetti"},"datePublished":"2026-06-11T09:20:57.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":1},"url":"https://github.com/61/NEventStore.Persistence.SQL/issues/61"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:b5fd8454-c57d-8f7f-d4c2-14b971f7f0c7 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 89BA:1F55B6:EE42AB:15CA871:6A4E31CA |
| html-safe-nonce | c7ea93369f3069d703f40e42a526843c7f072ca9bdb4dbe9545bd109972ea009 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4OUJBOjFGNTVCNjpFRTQyQUI6MTVDQTg3MTo2QTRFMzFDQSIsInZpc2l0b3JfaWQiOiI2MzM0NjU0NTY4MDk4MzEyNjUwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 26f8af33a95c19f16d5ada5c785636913b04b3ec1e05763430986d635b859e92 |
| hovercard-subject-tag | issue:4639064282 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/NEventStore/NEventStore.Persistence.SQL/61/issue_layout |
| twitter:image | https://opengraph.githubassets.com/adcedd2fae9033b028c64e786f55b206734e8aaa565df5d47ee5f67ec388213a/NEventStore/NEventStore.Persistence.SQL/issues/61 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/adcedd2fae9033b028c64e786f55b206734e8aaa565df5d47ee5f67ec388213a/NEventStore/NEventStore.Persistence.SQL/issues/61 |
| og:image:alt | Priority order Order: 04 of 09 Priority: P1 correctness Blocked by: #58 Problem OracleNativeDialect.CommitStampStart recursively calls itself. Evidence: src/NEventStore.Persistence.Sql/SqlDialects/... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | AGiorgetti |
| hostname | github.com |
| expected-hostname | github.com |
| None | 030096ee0db095447bfe77409d33bfac127ca7128299c58deef27c52eaa1b1f0 |
| turbo-cache-control | no-preview |
| go-import | github.com/NEventStore/NEventStore.Persistence.SQL git https://github.com/NEventStore/NEventStore.Persistence.SQL.git |
| octolytics-dimension-user_id | 4486767 |
| octolytics-dimension-user_login | NEventStore |
| octolytics-dimension-repository_id | 36130556 |
| octolytics-dimension-repository_nwo | NEventStore/NEventStore.Persistence.SQL |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 36130556 |
| octolytics-dimension-repository_network_root_nwo | NEventStore/NEventStore.Persistence.SQL |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 42a6d378d7587a44c93aca255096cd66b7c8eb2d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width