René's URL Explorer Experiment


Title: Refactor ExecuteQuery · Issue #20 · NEventStore/NEventStore.Persistence.SQL · GitHub

Open Graph Title: Refactor ExecuteQuery · Issue #20 · NEventStore/NEventStore.Persistence.SQL

X Title: Refactor ExecuteQuery · Issue #20 · NEventStore/NEventStore.Persistence.SQL

Description: If you look at the code of method SqlPersistenceEngine::ExecuteQuery you can notice that nor connection nor transaction gets disposed if the code is successful. Compare ExecuteQuery with the implementation of SqlPersistenEngine::ExecuteC...

Open Graph Description: If you look at the code of method SqlPersistenceEngine::ExecuteQuery you can notice that nor connection nor transaction gets disposed if the code is successful. Compare ExecuteQuery with the implem...

X Description: If you look at the code of method SqlPersistenceEngine::ExecuteQuery you can notice that nor connection nor transaction gets disposed if the code is successful. Compare ExecuteQuery with the implem...

Opengraph URL: https://github.com/NEventStore/NEventStore.Persistence.SQL/issues/20

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Refactor ExecuteQuery","articleBody":"If you look at the code of method [SqlPersistenceEngine::ExecuteQuery](https://github.com/NEventStore/NEventStore.Persistence.SQL/blob/accc7c627f4ad093e0dcd601043fc4eb511d95bd/src/NEventStore.Persistence.Sql/SqlPersistenceEngine.cs#L374) you can notice that nor connection nor transaction gets disposed if the code is successful. \n\nCompare ExecuteQuery with the implementation of [SqlPersistenEngine::ExecuteCommand](https://github.com/NEventStore/NEventStore.Persistence.SQL/blob/accc7c627f4ad093e0dcd601043fc4eb511d95bd/src/NEventStore.Persistence.Sql/SqlPersistenceEngine.cs#L443)  that correctly disposes everything.\n\nThis can lead to serious problem, and actually probably it did not generated error because the standard implementation of OpenTransaction returns null. \n\nI think that all the disposable object should be wrapped in using clause.\n","author":{"url":"https://github.com/alkampfergit","@type":"Person","name":"alkampfergit"},"datePublished":"2016-04-04T14:17:15.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":2},"url":"https://github.com/20/NEventStore.Persistence.SQL/issues/20"}

route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:d2101933-7f52-3b13-5e22-0d7eadac4dda
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idB3BC:2D8184:341F6A:4BD25F:6A4E0365
html-safe-nonce0628d6834cdc73a8e416546ceff91e8e6fc9e89857460dbbca34e3a530eba2ab
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCM0JDOjJEODE4NDozNDFGNkE6NEJEMjVGOjZBNEUwMzY1IiwidmlzaXRvcl9pZCI6IjMzMjE5ODc5NDkxNjgyOTY4MDUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac9da37ce845f570cb9010bfbbe66e70860c5c219aca6e3ff6ba2738a17a69e7bf
hovercard-subject-tagissue:145696685
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/NEventStore/NEventStore.Persistence.SQL/20/issue_layout
twitter:imagehttps://opengraph.githubassets.com/7f66ea354dd17e9af9d04bceb6187776ae57696cf00e4e7f56f7810b8a3a668e/NEventStore/NEventStore.Persistence.SQL/issues/20
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/7f66ea354dd17e9af9d04bceb6187776ae57696cf00e4e7f56f7810b8a3a668e/NEventStore/NEventStore.Persistence.SQL/issues/20
og:image:altIf you look at the code of method SqlPersistenceEngine::ExecuteQuery you can notice that nor connection nor transaction gets disposed if the code is successful. Compare ExecuteQuery with the implem...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamealkampfergit
hostnamegithub.com
expected-hostnamegithub.com
Nonedf0492960db29b4938cb72070351d6b1d0c6c0767b27ceb8394bbf4fcc0223c6
turbo-cache-controlno-preview
go-importgithub.com/NEventStore/NEventStore.Persistence.SQL git https://github.com/NEventStore/NEventStore.Persistence.SQL.git
octolytics-dimension-user_id4486767
octolytics-dimension-user_loginNEventStore
octolytics-dimension-repository_id36130556
octolytics-dimension-repository_nwoNEventStore/NEventStore.Persistence.SQL
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id36130556
octolytics-dimension-repository_network_root_nwoNEventStore/NEventStore.Persistence.SQL
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release52bde38e24398476f8eb1e0760c81346c6a00812
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/NEventStore/NEventStore.Persistence.SQL/issues/20#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNEventStore%2FNEventStore.Persistence.SQL%2Fissues%2F20
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNEventStore%2FNEventStore.Persistence.SQL%2Fissues%2F20
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=NEventStore%2FNEventStore.Persistence.SQL
Reloadhttps://github.com/NEventStore/NEventStore.Persistence.SQL/issues/20
Reloadhttps://github.com/NEventStore/NEventStore.Persistence.SQL/issues/20
Reloadhttps://github.com/NEventStore/NEventStore.Persistence.SQL/issues/20
Please reload this pagehttps://github.com/NEventStore/NEventStore.Persistence.SQL/issues/20
NEventStore https://github.com/NEventStore
NEventStore.Persistence.SQLhttps://github.com/NEventStore/NEventStore.Persistence.SQL
Notifications https://github.com/login?return_to=%2FNEventStore%2FNEventStore.Persistence.SQL
Fork 34 https://github.com/login?return_to=%2FNEventStore%2FNEventStore.Persistence.SQL
Star 10 https://github.com/login?return_to=%2FNEventStore%2FNEventStore.Persistence.SQL
Code https://github.com/NEventStore/NEventStore.Persistence.SQL
Issues 18 https://github.com/NEventStore/NEventStore.Persistence.SQL/issues
Pull requests 3 https://github.com/NEventStore/NEventStore.Persistence.SQL/pulls
Actions https://github.com/NEventStore/NEventStore.Persistence.SQL/actions
Projects https://github.com/NEventStore/NEventStore.Persistence.SQL/projects
Wiki https://github.com/NEventStore/NEventStore.Persistence.SQL/wiki
Security and quality 0 https://github.com/NEventStore/NEventStore.Persistence.SQL/security
Insights https://github.com/NEventStore/NEventStore.Persistence.SQL/pulse
Code https://github.com/NEventStore/NEventStore.Persistence.SQL
Issues https://github.com/NEventStore/NEventStore.Persistence.SQL/issues
Pull requests https://github.com/NEventStore/NEventStore.Persistence.SQL/pulls
Actions https://github.com/NEventStore/NEventStore.Persistence.SQL/actions
Projects https://github.com/NEventStore/NEventStore.Persistence.SQL/projects
Wiki https://github.com/NEventStore/NEventStore.Persistence.SQL/wiki
Security and quality https://github.com/NEventStore/NEventStore.Persistence.SQL/security
Insights https://github.com/NEventStore/NEventStore.Persistence.SQL/pulse
Refactor ExecuteQueryhttps://github.com/NEventStore/NEventStore.Persistence.SQL/issues/20#top
https://github.com/alkampfergit
alkampfergithttps://github.com/alkampfergit
on Apr 4, 2016https://github.com/NEventStore/NEventStore.Persistence.SQL/issues/20#issue-145696685
SqlPersistenceEngine::ExecuteQueryhttps://github.com/NEventStore/NEventStore.Persistence.SQL/blob/accc7c627f4ad093e0dcd601043fc4eb511d95bd/src/NEventStore.Persistence.Sql/SqlPersistenceEngine.cs#L374
SqlPersistenEngine::ExecuteCommandhttps://github.com/NEventStore/NEventStore.Persistence.SQL/blob/accc7c627f4ad093e0dcd601043fc4eb511d95bd/src/NEventStore.Persistence.Sql/SqlPersistenceEngine.cs#L443
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.