Title: Refactor ExecuteQuery · Issue #20 · NEventStore/NEventStore.Persistence.SQL · GitHub
Open Graph Title: Refactor ExecuteQuery · Issue #20 · NEventStore/NEventStore.Persistence.SQL
X Title: Refactor ExecuteQuery · Issue #20 · NEventStore/NEventStore.Persistence.SQL
Description: If you look at the code of method SqlPersistenceEngine::ExecuteQuery you can notice that nor connection nor transaction gets disposed if the code is successful. Compare ExecuteQuery with the implementation of SqlPersistenEngine::ExecuteC...
Open Graph Description: If you look at the code of method SqlPersistenceEngine::ExecuteQuery you can notice that nor connection nor transaction gets disposed if the code is successful. Compare ExecuteQuery with the implem...
X Description: If you look at the code of method SqlPersistenceEngine::ExecuteQuery you can notice that nor connection nor transaction gets disposed if the code is successful. Compare ExecuteQuery with the implem...
Opengraph URL: https://github.com/NEventStore/NEventStore.Persistence.SQL/issues/20
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Refactor ExecuteQuery","articleBody":"If you look at the code of method [SqlPersistenceEngine::ExecuteQuery](https://github.com/NEventStore/NEventStore.Persistence.SQL/blob/accc7c627f4ad093e0dcd601043fc4eb511d95bd/src/NEventStore.Persistence.Sql/SqlPersistenceEngine.cs#L374) you can notice that nor connection nor transaction gets disposed if the code is successful. \n\nCompare ExecuteQuery with the implementation of [SqlPersistenEngine::ExecuteCommand](https://github.com/NEventStore/NEventStore.Persistence.SQL/blob/accc7c627f4ad093e0dcd601043fc4eb511d95bd/src/NEventStore.Persistence.Sql/SqlPersistenceEngine.cs#L443) that correctly disposes everything.\n\nThis can lead to serious problem, and actually probably it did not generated error because the standard implementation of OpenTransaction returns null. \n\nI think that all the disposable object should be wrapped in using clause.\n","author":{"url":"https://github.com/alkampfergit","@type":"Person","name":"alkampfergit"},"datePublished":"2016-04-04T14:17:15.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":2},"url":"https://github.com/20/NEventStore.Persistence.SQL/issues/20"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:d2101933-7f52-3b13-5e22-0d7eadac4dda |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | B3BC:2D8184:341F6A:4BD25F:6A4E0365 |
| html-safe-nonce | 0628d6834cdc73a8e416546ceff91e8e6fc9e89857460dbbca34e3a530eba2ab |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCM0JDOjJEODE4NDozNDFGNkE6NEJEMjVGOjZBNEUwMzY1IiwidmlzaXRvcl9pZCI6IjMzMjE5ODc5NDkxNjgyOTY4MDUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 9da37ce845f570cb9010bfbbe66e70860c5c219aca6e3ff6ba2738a17a69e7bf |
| hovercard-subject-tag | issue:145696685 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/NEventStore/NEventStore.Persistence.SQL/20/issue_layout |
| twitter:image | https://opengraph.githubassets.com/7f66ea354dd17e9af9d04bceb6187776ae57696cf00e4e7f56f7810b8a3a668e/NEventStore/NEventStore.Persistence.SQL/issues/20 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/7f66ea354dd17e9af9d04bceb6187776ae57696cf00e4e7f56f7810b8a3a668e/NEventStore/NEventStore.Persistence.SQL/issues/20 |
| og:image:alt | If you look at the code of method SqlPersistenceEngine::ExecuteQuery you can notice that nor connection nor transaction gets disposed if the code is successful. Compare ExecuteQuery with the implem... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | alkampfergit |
| hostname | github.com |
| expected-hostname | github.com |
| None | df0492960db29b4938cb72070351d6b1d0c6c0767b27ceb8394bbf4fcc0223c6 |
| turbo-cache-control | no-preview |
| go-import | github.com/NEventStore/NEventStore.Persistence.SQL git https://github.com/NEventStore/NEventStore.Persistence.SQL.git |
| octolytics-dimension-user_id | 4486767 |
| octolytics-dimension-user_login | NEventStore |
| octolytics-dimension-repository_id | 36130556 |
| octolytics-dimension-repository_nwo | NEventStore/NEventStore.Persistence.SQL |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 36130556 |
| octolytics-dimension-repository_network_root_nwo | NEventStore/NEventStore.Persistence.SQL |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 52bde38e24398476f8eb1e0760c81346c6a00812 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width