René's URL Explorer Experiment


Title: Get name of declaration uniformly, even for JS-style assignment declarations. by sandersn · Pull Request #15594 · microsoft/TypeScript · GitHub

Open Graph Title: Get name of declaration uniformly, even for JS-style assignment declarations. by sandersn · Pull Request #15594 · microsoft/TypeScript

X Title: Get name of declaration uniformly, even for JS-style assignment declarations. by sandersn · Pull Request #15594 · microsoft/TypeScript

Description: TypeScript is a superset of JavaScript that compiles to clean JavaScript output. - Get name of declaration uniformly, even for JS-style assignment declarations. by sandersn · Pull Request #15594 · microsoft/TypeScript

Open Graph Description: JS-style assignment declarations have a name, but it's not stored on the name property of the BinaryExpression. This commit adds getNameOfDeclaration to uniformly get the name of a declaration....

X Description: JS-style assignment declarations have a name, but it's not stored on the name property of the BinaryExpression. This commit adds getNameOfDeclaration to uniformly get the name of a declarat...

Opengraph URL: https://github.com/microsoft/TypeScript/pull/15594

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:b2d87770-98c8-827b-2663-d60ea9857ea8
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCE70:10D9F8:751AE9:9D3558:6B00D7CD
html-safe-nonce6cb0dd9f2abc021bd36e84d36f0edb1cbc7805d0aa5415d2cea57c07d60a341b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDRTcwOjEwRDlGODo3NTFBRTk6OUQzNTU4OjZCMDBEN0NEIiwidmlzaXRvcl9pZCI6IjM5ODU3ODAwNjY4MDkzMzc4MDUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac7a50347c8f623456bcef48292c2d3eeb7315fd746025f0eb3d870ac9b8af4653
hovercard-subject-tagpull_request:119085851
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/Microsoft/TypeScript/15594/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/0eb75807a00d6b0d24a1fa485ef9e07899a884163b13df7651c9b6dcccb7c17a/microsoft/TypeScript/pull/15594
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/0eb75807a00d6b0d24a1fa485ef9e07899a884163b13df7651c9b6dcccb7c17a/microsoft/TypeScript/pull/15594
og:image:altJS-style assignment declarations have a name, but it's not stored on the name property of the BinaryExpression. This commit adds getNameOfDeclaration to uniformly get the name of a declaration....
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamesandersn
hostnamegithub.com
expected-hostnamegithub.com
Nonea481f62a1e04c9b9bdcb5628230682c66d59006f5b13b080f79cba84a176905b
turbo-cache-controlno-cache
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release84c8c5cc25e2fb7f2308428458538436baecc6d2
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/Microsoft/TypeScript/pull/15594#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FMicrosoft%2FTypeScript%2Fpull%2F15594
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FMicrosoft%2FTypeScript%2Fpull%2F15594
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/Microsoft/TypeScript/pull/15594
Reloadhttps://github.com/Microsoft/TypeScript/pull/15594
Reloadhttps://github.com/Microsoft/TypeScript/pull/15594
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests307 (307)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
https://github.com/microsoft/TypeScript
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
masterhttps://github.com/microsoft/TypeScript/tree/master
get-name-of-declaration-wrapperhttps://github.com/microsoft/TypeScript/tree/get-name-of-declaration-wrapper
Conversationhttps://github.com/microsoft/TypeScript/pull/15594
Commits12 (12)https://github.com/microsoft/TypeScript/pull/15594/commits
Checkshttps://github.com/microsoft/TypeScript/pull/15594/checks
Files changedhttps://github.com/microsoft/TypeScript/pull/15594/files
Get name of declaration uniformly, even for JS-style assignment declarations.https://github.com/Microsoft/TypeScript/pull/15594#top
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
masterhttps://github.com/microsoft/TypeScript/tree/master
get-name-of-declaration-wrapperhttps://github.com/microsoft/TypeScript/tree/get-name-of-declaration-wrapper
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
May 4, 2017https://github.com/Microsoft/TypeScript/pull/15594#issue-226434349
#15586https://github.com/microsoft/TypeScript/pull/15586
Please reload this pagehttps://github.com/Microsoft/TypeScript/pull/15594
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
May 4, 2017 16:12https://github.com/Microsoft/TypeScript/pull/15594#commits-pushed-d35f6c3
https://github.com/sandersn
getNameOfDeclaration uniformly, including JS declshttps://github.com/microsoft/TypeScript/pull/15594/commits/d35f6c3581943d5b473efa47f36c67707951cad6
d35f6c3https://github.com/microsoft/TypeScript/pull/15594/commits/d35f6c3581943d5b473efa47f36c67707951cad6
https://github.com/sandersn
Update baselineshttps://github.com/microsoft/TypeScript/pull/15594/commits/aceadeb04b06356dd7d3b4fc2f94d08e29e745e0
aceadebhttps://github.com/microsoft/TypeScript/pull/15594/commits/aceadeb04b06356dd7d3b4fc2f94d08e29e745e0
https://github.com/msftclas
Microsoft Contribution License Agreements (msftclas)https://github.com/msftclas
cla-not-required https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3Acla-not-required
May 4, 2017https://github.com/Microsoft/TypeScript/pull/15594#event-1069827753
https://github.com/mhegazy
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
May 4, 2017 https://github.com/Microsoft/TypeScript/pull/15594#pullrequestreview-36412722
View reviewed changes https://github.com/microsoft/TypeScript/pull/15594/files/aceadeb04b06356dd7d3b4fc2f94d08e29e745e0
src/compiler/checker.tshttps://github.com/microsoft/TypeScript/pull/15594/files/aceadeb04b06356dd7d3b4fc2f94d08e29e745e0#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
May 4, 2017https://github.com/Microsoft/TypeScript/pull/15594#discussion_r114910872
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/Microsoft/TypeScript/pull/15594
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
May 5, 2017https://github.com/Microsoft/TypeScript/pull/15594#discussion_r115095852
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/Microsoft/TypeScript/pull/15594
https://github.com/mhegazy
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
May 4, 2017 https://github.com/Microsoft/TypeScript/pull/15594#pullrequestreview-36412887
View reviewed changes https://github.com/microsoft/TypeScript/pull/15594/files/aceadeb04b06356dd7d3b4fc2f94d08e29e745e0
src/compiler/types.tshttps://github.com/microsoft/TypeScript/pull/15594/files/aceadeb04b06356dd7d3b4fc2f94d08e29e745e0#diff-e9fd483341eea176a38fbd370590e1dc65ce2d9bf70bfd317c5407f04dba9560
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
May 4, 2017https://github.com/Microsoft/TypeScript/pull/15594#discussion_r114911025
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/Microsoft/TypeScript/pull/15594
Ron Buckton (rbuckton)https://github.com/rbuckton
May 5, 2017https://github.com/Microsoft/TypeScript/pull/15594#discussion_r114919352
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/Microsoft/TypeScript/pull/15594
https://github.com/mhegazy
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
Ron Buckton (rbuckton)https://github.com/rbuckton
May 4, 2017 23:38https://github.com/Microsoft/TypeScript/pull/15594#event-1069846165
https://github.com/rbuckton
Ron Buckton (rbuckton)https://github.com/rbuckton
May 5, 2017 https://github.com/Microsoft/TypeScript/pull/15594#pullrequestreview-36421917
View reviewed changes https://github.com/microsoft/TypeScript/pull/15594/files/aceadeb04b06356dd7d3b4fc2f94d08e29e745e0
src/compiler/types.tshttps://github.com/microsoft/TypeScript/pull/15594/files/aceadeb04b06356dd7d3b4fc2f94d08e29e745e0#diff-e9fd483341eea176a38fbd370590e1dc65ce2d9bf70bfd317c5407f04dba9560
Ron Buckton (rbuckton)https://github.com/rbuckton
May 5, 2017https://github.com/Microsoft/TypeScript/pull/15594#discussion_r114919352
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/Microsoft/TypeScript/pull/15594
src/compiler/utilities.tshttps://github.com/microsoft/TypeScript/pull/15594/files/aceadeb04b06356dd7d3b4fc2f94d08e29e745e0#diff-1516c8349f7a625a2e4a2aa60f6bbe84e4b1a499128e8705d3087d893e01d367
Ron Buckton (rbuckton)https://github.com/rbuckton
May 5, 2017https://github.com/Microsoft/TypeScript/pull/15594#discussion_r114919510
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/Microsoft/TypeScript/pull/15594
src/compiler/utilities.tshttps://github.com/microsoft/TypeScript/pull/15594/files/aceadeb04b06356dd7d3b4fc2f94d08e29e745e0#diff-1516c8349f7a625a2e4a2aa60f6bbe84e4b1a499128e8705d3087d893e01d367
Ron Buckton (rbuckton)https://github.com/rbuckton
May 5, 2017https://github.com/Microsoft/TypeScript/pull/15594#discussion_r114919564
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/Microsoft/TypeScript/pull/15594
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
May 5, 2017https://github.com/Microsoft/TypeScript/pull/15594#discussion_r115096179
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/Microsoft/TypeScript/pull/15594
src/compiler/types.tshttps://github.com/microsoft/TypeScript/pull/15594/files/aceadeb04b06356dd7d3b4fc2f94d08e29e745e0#diff-e9fd483341eea176a38fbd370590e1dc65ce2d9bf70bfd317c5407f04dba9560
Ron Buckton (rbuckton)https://github.com/rbuckton
May 5, 2017https://github.com/Microsoft/TypeScript/pull/15594#discussion_r114919617
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/Microsoft/TypeScript/pull/15594
src/compiler/checker.tshttps://github.com/microsoft/TypeScript/pull/15594/files/aceadeb04b06356dd7d3b4fc2f94d08e29e745e0#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8
Ron Buckton (rbuckton)https://github.com/rbuckton
May 5, 2017https://github.com/Microsoft/TypeScript/pull/15594#discussion_r114919720
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/Microsoft/TypeScript/pull/15594
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
May 5, 2017https://github.com/Microsoft/TypeScript/pull/15594#discussion_r115096090
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/Microsoft/TypeScript/pull/15594
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
May 5, 2017 13:47https://github.com/Microsoft/TypeScript/pull/15594#commits-pushed-573040f
https://github.com/sandersn
Convert Declaration to union, not type hierarchyhttps://github.com/microsoft/TypeScript/pull/15594/commits/573040f0cfa713929bfa1fe84f4fd2a81cc82658
573040fhttps://github.com/microsoft/TypeScript/pull/15594/commits/573040f0cfa713929bfa1fe84f4fd2a81cc82658
https://github.com/sandersn
Fix linthttps://github.com/microsoft/TypeScript/pull/15594/commits/b39c319f0c4ee9b460ed51eba77e8c0958896c80
b39c319https://github.com/microsoft/TypeScript/pull/15594/commits/b39c319f0c4ee9b460ed51eba77e8c0958896c80
https://github.com/sandersn
Address comments: simplify, dedupe and clean uphttps://github.com/microsoft/TypeScript/pull/15594/commits/6a175321bf432f31490dd81fcc7fd0f7257c4baa
6a17532https://github.com/microsoft/TypeScript/pull/15594/commits/6a175321bf432f31490dd81fcc7fd0f7257c4baa
https://github.com/rbuckton
Ron Buckton (rbuckton)https://github.com/rbuckton
May 5, 2017 https://github.com/Microsoft/TypeScript/pull/15594#pullrequestreview-36618706
View reviewed changes https://github.com/microsoft/TypeScript/pull/15594/files/b39c319f0c4ee9b460ed51eba77e8c0958896c80
src/compiler/types.tshttps://github.com/microsoft/TypeScript/pull/15594/files/aceadeb04b06356dd7d3b4fc2f94d08e29e745e0..b39c319f0c4ee9b460ed51eba77e8c0958896c80#diff-e9fd483341eea176a38fbd370590e1dc65ce2d9bf70bfd317c5407f04dba9560
Ron Buckton (rbuckton)https://github.com/rbuckton
May 5, 2017https://github.com/Microsoft/TypeScript/pull/15594#discussion_r115095909
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/Microsoft/TypeScript/pull/15594
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
May 5, 2017https://github.com/Microsoft/TypeScript/pull/15594#discussion_r115099869
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/Microsoft/TypeScript/pull/15594
Ron Buckton (rbuckton)https://github.com/rbuckton
May 5, 2017https://github.com/Microsoft/TypeScript/pull/15594#discussion_r115100772
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/Microsoft/TypeScript/pull/15594
src/compiler/types.tshttps://github.com/microsoft/TypeScript/pull/15594/files/aceadeb04b06356dd7d3b4fc2f94d08e29e745e0..b39c319f0c4ee9b460ed51eba77e8c0958896c80#diff-e9fd483341eea176a38fbd370590e1dc65ce2d9bf70bfd317c5407f04dba9560
Ron Buckton (rbuckton)https://github.com/rbuckton
May 5, 2017https://github.com/Microsoft/TypeScript/pull/15594#discussion_r115095917
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/Microsoft/TypeScript/pull/15594
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
May 5, 2017https://github.com/Microsoft/TypeScript/pull/15594#discussion_r115099572
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Mohamed Hegazy (@mhegazy)https://github.com/mhegazy
Please reload this pagehttps://github.com/Microsoft/TypeScript/pull/15594
src/compiler/types.tshttps://github.com/microsoft/TypeScript/pull/15594/files/aceadeb04b06356dd7d3b4fc2f94d08e29e745e0..b39c319f0c4ee9b460ed51eba77e8c0958896c80#diff-e9fd483341eea176a38fbd370590e1dc65ce2d9bf70bfd317c5407f04dba9560
Ron Buckton (rbuckton)https://github.com/rbuckton
May 5, 2017https://github.com/Microsoft/TypeScript/pull/15594#discussion_r115096420
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/Microsoft/TypeScript/pull/15594
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
May 5, 2017https://github.com/Microsoft/TypeScript/pull/15594#discussion_r115100052
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/Microsoft/TypeScript/pull/15594
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
May 5, 2017https://github.com/Microsoft/TypeScript/pull/15594#discussion_r115104319
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/Microsoft/TypeScript/pull/15594
Ron Buckton (rbuckton)https://github.com/rbuckton
May 5, 2017https://github.com/Microsoft/TypeScript/pull/15594#discussion_r115106237
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/Microsoft/TypeScript/pull/15594
src/compiler/types.tshttps://github.com/microsoft/TypeScript/pull/15594/files/aceadeb04b06356dd7d3b4fc2f94d08e29e745e0..b39c319f0c4ee9b460ed51eba77e8c0958896c80#diff-e9fd483341eea176a38fbd370590e1dc65ce2d9bf70bfd317c5407f04dba9560
Ron Buckton (rbuckton)https://github.com/rbuckton
May 5, 2017https://github.com/Microsoft/TypeScript/pull/15594#discussion_r115096471
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/Microsoft/TypeScript/pull/15594
src/compiler/types.tshttps://github.com/microsoft/TypeScript/pull/15594/files/aceadeb04b06356dd7d3b4fc2f94d08e29e745e0..b39c319f0c4ee9b460ed51eba77e8c0958896c80#diff-e9fd483341eea176a38fbd370590e1dc65ce2d9bf70bfd317c5407f04dba9560
Ron Buckton (rbuckton)https://github.com/rbuckton
May 5, 2017https://github.com/Microsoft/TypeScript/pull/15594#discussion_r115096513
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/Microsoft/TypeScript/pull/15594
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
May 8, 2017https://github.com/Microsoft/TypeScript/pull/15594#issuecomment-299905659
Mohamed Hegazy (@mhegazy)https://github.com/mhegazy
Please reload this pagehttps://github.com/Microsoft/TypeScript/pull/15594
https://github.com/sandersn
Turn ClassElement and TypeElement into unions toohttps://github.com/microsoft/TypeScript/pull/15594/commits/22f353ac940bfd4e170d9e56a094fdd385476191
22f353ahttps://github.com/microsoft/TypeScript/pull/15594/commits/22f353ac940bfd4e170d9e56a094fdd385476191
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
May 8, 2017 https://github.com/Microsoft/TypeScript/pull/15594#ref-issue-226677600
Exception in getSpecialPropertyAssignmentKind when handling || in const value #15616 https://github.com/microsoft/TypeScript/issues/15616
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
May 8, 2017https://github.com/Microsoft/TypeScript/pull/15594#issuecomment-299953779
Ron Buckton (@rbuckton)https://github.com/rbuckton
Please reload this pagehttps://github.com/Microsoft/TypeScript/pull/15594
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
May 8, 2017 14:16https://github.com/Microsoft/TypeScript/pull/15594#commits-pushed-dd94ad2
https://github.com/sandersn
Revert "Turn ClassElement and TypeElement into unions too"https://github.com/microsoft/TypeScript/pull/15594/commits/dd94ad239abaafb9a4524bb8a437d55189b3807f
dd94ad2https://github.com/microsoft/TypeScript/pull/15594/commits/dd94ad239abaafb9a4524bb8a437d55189b3807f
22f353ahttps://github.com/microsoft/TypeScript/commit/22f353ac940bfd4e170d9e56a094fdd385476191
https://github.com/sandersn
Revert "Fix lint"https://github.com/microsoft/TypeScript/pull/15594/commits/e81733b82723dac1f853edec8ea8d8c4c6fc48a5
e81733bhttps://github.com/microsoft/TypeScript/pull/15594/commits/e81733b82723dac1f853edec8ea8d8c4c6fc48a5
b39c319https://github.com/microsoft/TypeScript/commit/b39c319f0c4ee9b460ed51eba77e8c0958896c80
https://github.com/sandersn
Revert "Convert Declaration to union, not type hierarchy"https://github.com/microsoft/TypeScript/pull/15594/commits/acec74b1afc93bba32ac44afc0c6aa8fc12e2807
acec74bhttps://github.com/microsoft/TypeScript/pull/15594/commits/acec74b1afc93bba32ac44afc0c6aa8fc12e2807
573040fhttps://github.com/microsoft/TypeScript/commit/573040f0cfa713929bfa1fe84f4fd2a81cc82658
Add Javascript declarations to index constraint check error reporting #15586 https://github.com/microsoft/TypeScript/pull/15586
Exception in checkIndexConstraintForProperty when handling assignment to property in constructor #15681 https://github.com/microsoft/TypeScript/issues/15681
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
May 8, 2017 15:07https://github.com/Microsoft/TypeScript/pull/15594#commits-pushed-9392342
https://github.com/sandersn
Switch to Declaration/NamedDeclaration hierarchyhttps://github.com/microsoft/TypeScript/pull/15594/commits/9392342f7807c28738199ce82c73e52ac3bc73ef
9392342https://github.com/microsoft/TypeScript/pull/15594/commits/9392342f7807c28738199ce82c73e52ac3bc73ef
https://github.com/sandersn
Merge branch 'master' into get-name-of-declaration-wrapperhttps://github.com/microsoft/TypeScript/pull/15594/commits/0080c5fd662fa8403ea570d5c63550b22b20d621
0080c5fhttps://github.com/microsoft/TypeScript/pull/15594/commits/0080c5fd662fa8403ea570d5c63550b22b20d621
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
May 8, 2017https://github.com/Microsoft/TypeScript/pull/15594#issuecomment-300011158
Please reload this pagehttps://github.com/Microsoft/TypeScript/pull/15594
https://github.com/rbuckton
Ron Buckton (rbuckton)https://github.com/rbuckton
May 8, 2017 https://github.com/Microsoft/TypeScript/pull/15594#pullrequestreview-36911434
View reviewed changes https://github.com/microsoft/TypeScript/pull/15594/files/0080c5fd662fa8403ea570d5c63550b22b20d621
src/compiler/types.tshttps://github.com/microsoft/TypeScript/pull/15594/files/0080c5fd662fa8403ea570d5c63550b22b20d621#diff-e9fd483341eea176a38fbd370590e1dc65ce2d9bf70bfd317c5407f04dba9560
Ron Buckton (rbuckton)https://github.com/rbuckton
May 8, 2017https://github.com/Microsoft/TypeScript/pull/15594#discussion_r115377925
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/Microsoft/TypeScript/pull/15594
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
May 9, 2017https://github.com/Microsoft/TypeScript/pull/15594#discussion_r115555545
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/Microsoft/TypeScript/pull/15594
src/compiler/types.tshttps://github.com/microsoft/TypeScript/pull/15594/files/0080c5fd662fa8403ea570d5c63550b22b20d621#diff-e9fd483341eea176a38fbd370590e1dc65ce2d9bf70bfd317c5407f04dba9560
Ron Buckton (rbuckton)https://github.com/rbuckton
May 8, 2017https://github.com/Microsoft/TypeScript/pull/15594#discussion_r115377930
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/Microsoft/TypeScript/pull/15594
src/compiler/types.tshttps://github.com/microsoft/TypeScript/pull/15594/files/0080c5fd662fa8403ea570d5c63550b22b20d621#diff-e9fd483341eea176a38fbd370590e1dc65ce2d9bf70bfd317c5407f04dba9560
Ron Buckton (rbuckton)https://github.com/rbuckton
May 8, 2017https://github.com/Microsoft/TypeScript/pull/15594#discussion_r115377947
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/Microsoft/TypeScript/pull/15594
src/compiler/types.tshttps://github.com/microsoft/TypeScript/pull/15594/files/0080c5fd662fa8403ea570d5c63550b22b20d621#diff-e9fd483341eea176a38fbd370590e1dc65ce2d9bf70bfd317c5407f04dba9560
Ron Buckton (rbuckton)https://github.com/rbuckton
May 8, 2017https://github.com/Microsoft/TypeScript/pull/15594#discussion_r115377973
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/Microsoft/TypeScript/pull/15594
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
May 9, 2017https://github.com/Microsoft/TypeScript/pull/15594#discussion_r115554897
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/Microsoft/TypeScript/pull/15594
https://github.com/sandersn
Unnamed nodes now extend Declaration, not NamedDeclarationhttps://github.com/microsoft/TypeScript/pull/15594/commits/157b777660b7e65d8e2d9cf871bd7f9c1aba5bbe
157b777https://github.com/microsoft/TypeScript/pull/15594/commits/157b777660b7e65d8e2d9cf871bd7f9c1aba5bbe
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
May 9, 2017https://github.com/Microsoft/TypeScript/pull/15594#issuecomment-300248080
Please reload this pagehttps://github.com/Microsoft/TypeScript/pull/15594
https://github.com/rbuckton
Ron Buckton (rbuckton)https://github.com/rbuckton
May 9, 2017 https://github.com/Microsoft/TypeScript/pull/15594#pullrequestreview-37144113
View reviewed changes https://github.com/microsoft/TypeScript/pull/15594/files/157b777660b7e65d8e2d9cf871bd7f9c1aba5bbe
https://github.com/mhegazy
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
May 10, 2017https://github.com/Microsoft/TypeScript/pull/15594#issuecomment-300345045
Please reload this pagehttps://github.com/Microsoft/TypeScript/pull/15594
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
3768daehttps://github.com/microsoft/TypeScript/commit/3768daeecaf98346e8455be6b23551d49e01a16e
May 10, 2017https://github.com/microsoft/TypeScript/pull/15594#event-1076612666
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
May 10, 2017 15:08https://github.com/Microsoft/TypeScript/pull/15594#event-1076612813
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
May 10, 2017https://github.com/Microsoft/TypeScript/pull/15594#issuecomment-300536913
Please reload this pagehttps://github.com/Microsoft/TypeScript/pull/15594
https://github.com/ghost
Deleted user (ghost)https://github.com/ghost
May 19, 2017https://github.com/Microsoft/TypeScript/pull/15594#issuecomment-302591535
Please reload this pagehttps://github.com/Microsoft/TypeScript/pull/15594
https://github.com/andy-hanson
Andy Hanson (andy-hanson)https://github.com/andy-hanson
May 19, 2017 https://github.com/Microsoft/TypeScript/pull/15594#ref-pullrequest-229856999
Fix failures on typescript@next palantir/tslint#2789 https://github.com/palantir/tslint/pull/2789
https://github.com/mhegazy
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
May 19, 2017https://github.com/Microsoft/TypeScript/pull/15594#issuecomment-302605764
Nathan Shively-Sanders (@sandersn)https://github.com/sandersn
Please reload this pagehttps://github.com/Microsoft/TypeScript/pull/15594
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
May 19, 2017https://github.com/Microsoft/TypeScript/pull/15594#issuecomment-302758604
Please reload this pagehttps://github.com/Microsoft/TypeScript/pull/15594
https://github.com/mhegazy
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
Breaking Change https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Breaking%20Change%22
Domain: API https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Domain%3A%20API%22
May 19, 2017https://github.com/Microsoft/TypeScript/pull/15594#event-1089888853
https://github.com/mhegazy
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
May 19, 2017https://github.com/Microsoft/TypeScript/pull/15594#issuecomment-302773585
https://github.com/Microsoft/TypeScript/wiki/API-Breaking-Changes#typescript-23https://github.com/Microsoft/TypeScript/wiki/API-Breaking-Changes#typescript-23
Please reload this pagehttps://github.com/Microsoft/TypeScript/pull/15594
May 22, 2017 https://github.com/Microsoft/TypeScript/pull/15594#ref-pullrequest-226119519
Clarify that some node types never have name defined. #15567 https://github.com/microsoft/TypeScript/pull/15567
https://github.com/microsoft
Microsoft (microsoft)https://github.com/microsoft
Jun 14, 2018https://github.com/Microsoft/TypeScript/pull/15594#event-1682156704
https://github.co/hiddenchars
https://github.com/Microsoft/TypeScript/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FMicrosoft%2FTypeScript%2Fpull%2F15594
https://github.com/mhegazy
Mohamed Hegazy (mhegazy) https://github.com/mhegazy
https://github.com/microsoft/TypeScript/pull/15594/files/aceadeb04b06356dd7d3b4fc2f94d08e29e745e0
https://github.com/rbuckton
Ron Buckton (rbuckton) https://github.com/rbuckton
https://github.com/microsoft/TypeScript/pull/15594/files/157b777660b7e65d8e2d9cf871bd7f9c1aba5bbe
Please reload this pagehttps://github.com/Microsoft/TypeScript/pull/15594
Breaking Change https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Breaking%20Change%22
Domain: API https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Domain%3A%20API%22
Please reload this pagehttps://github.com/Microsoft/TypeScript/pull/15594
https://github.com/sandersn
https://github.com/mhegazy
https://github.com/rbuckton
https://github.com/msftclas
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.