René's URL Explorer Experiment


Title: Do not treat local resolution of require call as external module by sheetalkamat · Pull Request #11370 · microsoft/TypeScript · GitHub

Open Graph Title: Do not treat local resolution of require call as external module by sheetalkamat · Pull Request #11370 · microsoft/TypeScript

X Title: Do not treat local resolution of require call as external module by sheetalkamat · Pull Request #11370 · microsoft/TypeScript

Description: TypeScript is a superset of JavaScript that compiles to clean JavaScript output. - Do not treat local resolution of require call as external module by sheetalkamat · Pull Request #11370 · microsoft/TypeScript

Open Graph Description: Bind the source file as external module only if not already done Return type of require call is from external module resolution only if it doesn't resolve to local module Fixes #10931 Note tha...

X Description: Bind the source file as external module only if not already done Return type of require call is from external module resolution only if it doesn't resolve to local module Fixes #10931 Note...

Opengraph URL: https://github.com/microsoft/TypeScript/pull/11370

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:282918d8-1cb1-3af3-36ad-ccd9b77d2cc6
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAE1A:22DB35:2F45535:3C550B3:6B01B4D3
html-safe-nonce48becaee49869901a360f382a759c0e1020c0a5d5ca68399c8ef05eb2ec7b2b7
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRTFBOjIyREIzNToyRjQ1NTM1OjNDNTUwQjM6NkIwMUI0RDMiLCJ2aXNpdG9yX2lkIjoiNTg5OTUwNzYyNDM0ODU5NTQxMSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacb804c394d54094f252fbfc0538e623e19ac36da0ecf7b3fa23b3e5e5aa056052
hovercard-subject-tagpull_request:87988127
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/Microsoft/TypeScript/11370/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/98203b99343142c7d37aa605b3b5d6a7623e10205e422d10983b9260c4eae19b/microsoft/TypeScript/pull/11370
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/98203b99343142c7d37aa605b3b5d6a7623e10205e422d10983b9260c4eae19b/microsoft/TypeScript/pull/11370
og:image:altBind the source file as external module only if not already done Return type of require call is from external module resolution only if it doesn't resolve to local module Fixes #10931 Note tha...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamesheetalkamat
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/Microsoft/TypeScript/pull/11370#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FMicrosoft%2FTypeScript%2Fpull%2F11370
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FMicrosoft%2FTypeScript%2Fpull%2F11370
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/Microsoft/TypeScript/pull/11370
Reloadhttps://github.com/Microsoft/TypeScript/pull/11370
Reloadhttps://github.com/Microsoft/TypeScript/pull/11370
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests312 (312)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
https://github.com/microsoft/TypeScript
Sheetal Nandi (sheetalkamat)https://github.com/sheetalkamat
masterhttps://github.com/microsoft/TypeScript/tree/master
requireAsFunctionInExternalModulehttps://github.com/microsoft/TypeScript/tree/requireAsFunctionInExternalModule
Conversationhttps://github.com/microsoft/TypeScript/pull/11370
Commits4 (4)https://github.com/microsoft/TypeScript/pull/11370/commits
Checkshttps://github.com/microsoft/TypeScript/pull/11370/checks
Files changedhttps://github.com/microsoft/TypeScript/pull/11370/files
Do not treat local resolution of require call as external modulehttps://github.com/Microsoft/TypeScript/pull/11370#top
Sheetal Nandi (sheetalkamat)https://github.com/sheetalkamat
masterhttps://github.com/microsoft/TypeScript/tree/master
requireAsFunctionInExternalModulehttps://github.com/microsoft/TypeScript/tree/requireAsFunctionInExternalModule
https://github.com/sheetalkamat
Sheetal Nandi (sheetalkamat)https://github.com/sheetalkamat
Oct 4, 2016https://github.com/Microsoft/TypeScript/pull/11370#issue-181023609
#10931https://github.com/microsoft/TypeScript/issues/10931
#10931https://github.com/microsoft/TypeScript/issues/10931
Please reload this pagehttps://github.com/Microsoft/TypeScript/pull/11370
Sheetal Nandi (sheetalkamat)https://github.com/sheetalkamat
October 4, 2016 12:17https://github.com/Microsoft/TypeScript/pull/11370#commits-pushed-a70624d
https://github.com/sheetalkamat
Add test when require is just a function in external modulehttps://github.com/microsoft/TypeScript/pull/11370/commits/a70624d4159e9de3f2c497d2f7ec52082fee7bf6
a70624dhttps://github.com/microsoft/TypeScript/pull/11370/commits/a70624d4159e9de3f2c497d2f7ec52082fee7bf6
https://github.com/sheetalkamat
Bind the source file as external module only if not already donehttps://github.com/microsoft/TypeScript/pull/11370/commits/a830c844b7846f56a785d0ed8a2e75d4bec7a14f
a830c84https://github.com/microsoft/TypeScript/pull/11370/commits/a830c844b7846f56a785d0ed8a2e75d4bec7a14f
#10931https://github.com/microsoft/TypeScript/issues/10931
https://github.com/msftclas
Microsoft Contribution License Agreements (msftclas)https://github.com/msftclas
cla-not-required https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3Acla-not-required
Oct 4, 2016https://github.com/Microsoft/TypeScript/pull/11370#event-812522200
https://github.com/mhegazy
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
Oct 13, 2016 https://github.com/Microsoft/TypeScript/pull/11370#pullrequestreview-4180996
View reviewed changes https://github.com/microsoft/TypeScript/pull/11370/files/a830c844b7846f56a785d0ed8a2e75d4bec7a14f
src/compiler/checker.tshttps://github.com/microsoft/TypeScript/pull/11370/files/a830c844b7846f56a785d0ed8a2e75d4bec7a14f#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
Oct 13, 2016https://github.com/Microsoft/TypeScript/pull/11370#discussion_r83329220
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/Microsoft/TypeScript/pull/11370
Sheetal Nandi (sheetalkamat)https://github.com/sheetalkamat
Oct 13, 2016https://github.com/Microsoft/TypeScript/pull/11370#discussion_r83335143
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/Microsoft/TypeScript/pull/11370
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
Oct 13, 2016https://github.com/Microsoft/TypeScript/pull/11370#discussion_r83335373
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/Microsoft/TypeScript/pull/11370
Sheetal Nandi (sheetalkamat)https://github.com/sheetalkamat
October 17, 2016 16:08https://github.com/Microsoft/TypeScript/pull/11370#commits-pushed-28899f3
https://github.com/sheetalkamat
Update the resolveName symbol flags for 'require' resolutionhttps://github.com/microsoft/TypeScript/pull/11370/commits/28899f386011353aeee3ccb17accab03a927f444
28899f3https://github.com/microsoft/TypeScript/pull/11370/commits/28899f386011353aeee3ccb17accab03a927f444
https://github.com/sheetalkamat
Merge branch 'master' into requireAsFunctionInExternalModulehttps://github.com/microsoft/TypeScript/pull/11370/commits/e72414ecabf717fadfdcbeec27e52f4e89dc347a
e72414ehttps://github.com/microsoft/TypeScript/pull/11370/commits/e72414ecabf717fadfdcbeec27e52f4e89dc347a
https://github.com/mhegazy
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
Oct 17, 2016 https://github.com/Microsoft/TypeScript/pull/11370#pullrequestreview-4577625
View reviewed changes https://github.com/microsoft/TypeScript/pull/11370/files/e72414ecabf717fadfdcbeec27e52f4e89dc347a
https://github.com/sheetalkamat
Sheetal Nandi (sheetalkamat)https://github.com/sheetalkamat
28452d5https://github.com/microsoft/TypeScript/commit/28452d5a7b7aebaa5eb280a86135e037d7bf4561
Oct 17, 2016https://github.com/microsoft/TypeScript/pull/11370#event-826737090
https://github.com/sheetalkamat
Sheetal Nandi (sheetalkamat)https://github.com/sheetalkamat
October 17, 2016 23:37https://github.com/Microsoft/TypeScript/pull/11370#event-826737117
Code editing sequence matters for typing acquisition #11744 https://github.com/microsoft/TypeScript/issues/11744
commonjs module functionality is broken when project externally defined ambient require function #11752 https://github.com/microsoft/TypeScript/issues/11752
https://github.com/vojtechhabarta
Vojtěch Habarta (vojtechhabarta)https://github.com/vojtechhabarta
Oct 24, 2016 https://github.com/Microsoft/TypeScript/pull/11370#ref-pullrequest-160772057
Completion list for JSON files imported using CommonJS require #9221 https://github.com/microsoft/TypeScript/pull/9221
https://github.com/microsoft
Microsoft (microsoft)https://github.com/microsoft
Jun 19, 2018https://github.com/Microsoft/TypeScript/pull/11370#event-1689915878
https://github.co/hiddenchars
https://github.com/Microsoft/TypeScript/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FMicrosoft%2FTypeScript%2Fpull%2F11370
https://github.com/mhegazy
Mohamed Hegazy (mhegazy) https://github.com/mhegazy
https://github.com/microsoft/TypeScript/pull/11370/files/e72414ecabf717fadfdcbeec27e52f4e89dc347a
Please reload this pagehttps://github.com/Microsoft/TypeScript/pull/11370
A require call that isn't the global require will clobber bindings https://github.com/microsoft/TypeScript/issues/10931
Please reload this pagehttps://github.com/Microsoft/TypeScript/pull/11370
https://github.com/sheetalkamat
https://github.com/mhegazy
https://github.com/msftclas
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.