Title: test(nostr): gate live-relay integration test behind MPOS_RUN_NETWORK_TESTS by jnuyens · Pull Request #183 · MicroPythonOS/MicroPythonOS · GitHub
Open Graph Title: test(nostr): gate live-relay integration test behind MPOS_RUN_NETWORK_TESTS by jnuyens · Pull Request #183 · MicroPythonOS/MicroPythonOS
X Title: test(nostr): gate live-relay integration test behind MPOS_RUN_NETWORK_TESTS by jnuyens · Pull Request #183 · MicroPythonOS/MicroPythonOS
Description: test_self_send_nip17_over_real_relays opens live WebSocket connections to public relays (relay.damus.io, relay.primal.net, relay.0xchat.com) and waits for them to echo a NIP-17 gift-wrap back. So it fails whenever a relay has a transient outage — and that's been reddening unrelated PRs' CI. Recent runs (e.g. #182, which changes only download_manager.py): wss://relay.damus.io -> HTTP/1.1 520 (Cloudflare: origin unreachable) wss://relay.0xchat.com -> HTTP/1.1 500 -> AssertionError: No kind-14 rumor … received within 45s I re-checked both live afterward — back to HTTP 200 (healthy). So these were momentary relay-side outages (5xx), not a client/code problem. Change Gate the test class behind MPOS_RUN_NETWORK_TESTS via @unittest.skipUnless: CI (env unset): the class is skipped → deterministic, no more flakiness from third-party relay uptime. On demand: MPOS_RUN_NETWORK_TESTS=1 ./tests/unittest.sh tests/test_nostr_nip17_self_send_real_relays.py runs it as before — handy for a dedicated/nightly network job. Verified through ./tests/unittest.sh: with the var unset the gated class reports skipped and the suite exits OK (skipped=1) (exit 0); the harness still reports real failures for un-gated tests, so nothing is masked. Minimal diff (import os one decorator). Context: this is the test that was failing on #177 — it's environmental, not the DNS change.
Open Graph Description: test_self_send_nip17_over_real_relays opens live WebSocket connections to public relays (relay.damus.io, relay.primal.net, relay.0xchat.com) and waits for them to echo a NIP-17 gift-wrap back. So i...
X Description: test_self_send_nip17_over_real_relays opens live WebSocket connections to public relays (relay.damus.io, relay.primal.net, relay.0xchat.com) and waits for them to echo a NIP-17 gift-wrap back. So i...
Opengraph URL: https://github.com/MicroPythonOS/MicroPythonOS/pull/183
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:6a55b292-4703-e25b-833e-bb9147753fec |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 81D0:1F264A:2C28D:4B0C7:6A514192 |
| html-safe-nonce | d5f07529a794ffe3ed18d55d64ea8a9372d85169a1f66f8bd5b69074849ffa70 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MUQwOjFGMjY0QToyQzI4RDo0QjBDNzo2QTUxNDE5MiIsInZpc2l0b3JfaWQiOiI4NTY2NTE1MTU1MDI1ODcxMjUwIiwicmVnaW9uX2VkZ2UiOiJ3ZXN0dXMyIiwicmVnaW9uX3JlbmRlciI6Indlc3R1czIifQ== |
| visitor-hmac | e1878b0e6d1a4f8db15af5dda6dcaaeed6cfaa25b6fe8ba3bc0eb946196e8e2b |
| hovercard-subject-tag | pull_request:3959294164 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/MicroPythonOS/MicroPythonOS/pull/183/files |
| twitter:image | https://avatars.githubusercontent.com/u/3696148?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/3696148?s=400&v=4 |
| og:image:alt | test_self_send_nip17_over_real_relays opens live WebSocket connections to public relays (relay.damus.io, relay.primal.net, relay.0xchat.com) and waits for them to echo a NIP-17 gift-wrap back. So i... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | e840f405b2718e8f2d55aafa9ff27dbce17e29d0c253011d05ea0fea3c78baff |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/MicroPythonOS/MicroPythonOS git https://github.com/MicroPythonOS/MicroPythonOS.git |
| octolytics-dimension-user_id | 213598128 |
| octolytics-dimension-user_login | MicroPythonOS |
| octolytics-dimension-repository_id | 975472483 |
| octolytics-dimension-repository_nwo | MicroPythonOS/MicroPythonOS |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 975472483 |
| octolytics-dimension-repository_network_root_nwo | MicroPythonOS/MicroPythonOS |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | e876f00c5723f6080b9d294e4958fd4d506e6faf |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width