René's URL Explorer Experiment


Title: fix(audio): stop desktop player by PID, not pkill -f (no cross-kill) by jnuyens · Pull Request #178 · MicroPythonOS/MicroPythonOS · GitHub

Open Graph Title: fix(audio): stop desktop player by PID, not pkill -f (no cross-kill) by jnuyens · Pull Request #178 · MicroPythonOS/MicroPythonOS

X Title: fix(audio): stop desktop player by PID, not pkill -f (no cross-kill) by jnuyens · Pull Request #178 · MicroPythonOS/MicroPythonOS

Description: Follow-up to the desktop-audio player (#175). Problem The desktop (non-ESP32) WAVStream branch backgrounded an external player (afplay/ffplay/aplay/paplay) and stopped it with: os.system("pkill -f %s" % _shell_quote(self.file_path)) pkill -f matches any process whose command line contains that path, so it can kill unrelated processes, or cross-kill a second player of the same file. Fix Record the backgrounded player's PID via the shell's $! into a per-stream pid file at launch, and stop it by that exact PID: cmd = "... >/dev/null 2>&1 & echo $! > " ... _stop_desktop_player(pid_file, not self._keep_running) # kill on explicit stop Kill happens only on an explicit stop(); on natural completion the player has already exited (so we just remove the pid file — which also avoids PID reuse). Testing Verified on the macOS sim binary: a bystander process sharing the same file path survives the stop (it would have been killed by the old pkill -f), the real player is killed by PID, and the pid file is cleaned up. ESP32 I2S path untouched; mpy-cross compiles; ASCII-only.

Open Graph Description: Follow-up to the desktop-audio player (#175). Problem The desktop (non-ESP32) WAVStream branch backgrounded an external player (afplay/ffplay/aplay/paplay) and stopped it with: os.system("pkil...

X Description: Follow-up to the desktop-audio player (#175). Problem The desktop (non-ESP32) WAVStream branch backgrounded an external player (afplay/ffplay/aplay/paplay) and stopped it with: os.system("...

Opengraph URL: https://github.com/MicroPythonOS/MicroPythonOS/pull/178

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:8c86f646-e308-3e9c-31f2-0d932fecb126
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8FDC:73358:1CBD5A:2848D1:6A50F2AC
html-safe-noncef5c5f4b3672ced7e3e718c75c8a28fff43f26a665f66de1670139e613fc2493b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4RkRDOjczMzU4OjFDQkQ1QToyODQ4RDE6NkE1MEYyQUMiLCJ2aXNpdG9yX2lkIjoiMTk1ODIzMjQ3ODU5NTQ3ODE4OCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacbbf21e70de6f3bc4b592a18c8231ac3423d8a0ceb4824f4168b9bfd798f52aac
hovercard-subject-tagpull_request:3951815194
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/MicroPythonOS/MicroPythonOS/pull/178/files
twitter:imagehttps://avatars.githubusercontent.com/u/3696148?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/3696148?s=400&v=4
og:image:altFollow-up to the desktop-audio player (#175). Problem The desktop (non-ESP32) WAVStream branch backgrounded an external player (afplay/ffplay/aplay/paplay) and stopped it with: os.system("pkil...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None5266e58c17a510c403505cc811606465e90a881d2007ee7df1c4800d5c659838
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/MicroPythonOS/MicroPythonOS git https://github.com/MicroPythonOS/MicroPythonOS.git
octolytics-dimension-user_id213598128
octolytics-dimension-user_loginMicroPythonOS
octolytics-dimension-repository_id975472483
octolytics-dimension-repository_nwoMicroPythonOS/MicroPythonOS
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id975472483
octolytics-dimension-repository_network_root_nwoMicroPythonOS/MicroPythonOS
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release5ec60191a48933536a90c8a19f47142fcd0d4739
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/MicroPythonOS/MicroPythonOS/pull/178/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FMicroPythonOS%2FMicroPythonOS%2Fpull%2F178%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FMicroPythonOS%2FMicroPythonOS%2Fpull%2F178%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=MicroPythonOS%2FMicroPythonOS
Reloadhttps://github.com/MicroPythonOS/MicroPythonOS/pull/178/files
Reloadhttps://github.com/MicroPythonOS/MicroPythonOS/pull/178/files
Reloadhttps://github.com/MicroPythonOS/MicroPythonOS/pull/178/files
Please reload this pagehttps://github.com/MicroPythonOS/MicroPythonOS/pull/178/files
MicroPythonOS https://github.com/MicroPythonOS
MicroPythonOShttps://github.com/MicroPythonOS/MicroPythonOS
Notifications https://github.com/login?return_to=%2FMicroPythonOS%2FMicroPythonOS
Fork 82 https://github.com/login?return_to=%2FMicroPythonOS%2FMicroPythonOS
Star 737 https://github.com/login?return_to=%2FMicroPythonOS%2FMicroPythonOS
Code https://github.com/MicroPythonOS/MicroPythonOS
Issues 24 https://github.com/MicroPythonOS/MicroPythonOS/issues
Pull requests 7 https://github.com/MicroPythonOS/MicroPythonOS/pulls
Discussions https://github.com/MicroPythonOS/MicroPythonOS/discussions
Actions https://github.com/MicroPythonOS/MicroPythonOS/actions
Projects https://github.com/MicroPythonOS/MicroPythonOS/projects
Security and quality 0 https://github.com/MicroPythonOS/MicroPythonOS/security
Insights https://github.com/MicroPythonOS/MicroPythonOS/pulse
Code https://github.com/MicroPythonOS/MicroPythonOS
Issues https://github.com/MicroPythonOS/MicroPythonOS/issues
Pull requests https://github.com/MicroPythonOS/MicroPythonOS/pulls
Discussions https://github.com/MicroPythonOS/MicroPythonOS/discussions
Actions https://github.com/MicroPythonOS/MicroPythonOS/actions
Projects https://github.com/MicroPythonOS/MicroPythonOS/projects
Security and quality https://github.com/MicroPythonOS/MicroPythonOS/security
Insights https://github.com/MicroPythonOS/MicroPythonOS/pulse
Sign up for GitHub https://github.com/signup?return_to=%2FMicroPythonOS%2FMicroPythonOS%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FMicroPythonOS%2FMicroPythonOS%2Fissues%2Fnew%2Fchoose
ThomasFarstrikehttps://github.com/ThomasFarstrike
MicroPythonOS:mainhttps://github.com/MicroPythonOS/MicroPythonOS/tree/main
jnuyens:audio-kill-by-pidhttps://github.com/jnuyens/MicroPythonOS/tree/audio-kill-by-pid
Conversation 1 https://github.com/MicroPythonOS/MicroPythonOS/pull/178
Commits 1 https://github.com/MicroPythonOS/MicroPythonOS/pull/178/commits
Checks 6 https://github.com/MicroPythonOS/MicroPythonOS/pull/178/checks
Files changed https://github.com/MicroPythonOS/MicroPythonOS/pull/178/files
Please reload this pagehttps://github.com/MicroPythonOS/MicroPythonOS/pull/178/files
fix(audio): stop desktop player by PID, not pkill -f (no cross-kill) https://github.com/MicroPythonOS/MicroPythonOS/pull/178/files#top
Show all changes 1 commit https://github.com/MicroPythonOS/MicroPythonOS/pull/178/files
6bd6f52 fix(audio): kill desktop player by PID instead of pkill -f (no cross-… jnuyens Jun 28, 2026 https://github.com/MicroPythonOS/MicroPythonOS/pull/178/commits/6bd6f5293e22812a174d9b8f05056b7d39a2d861
Clear filters https://github.com/MicroPythonOS/MicroPythonOS/pull/178/files
Please reload this pagehttps://github.com/MicroPythonOS/MicroPythonOS/pull/178/files
Please reload this pagehttps://github.com/MicroPythonOS/MicroPythonOS/pull/178/files
internal_filesystem/lib/mpos/audio/stream_wav.pyhttps://github.com/MicroPythonOS/MicroPythonOS/pull/178/files#diff-5823196f5124b9a2d3cae91820dce8f64861ddf170e270944966543dd890b64e
View file https://github.com/jnuyens/MicroPythonOS/blob/6bd6f5293e22812a174d9b8f05056b7d39a2d861/internal_filesystem/lib/mpos/audio/stream_wav.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/MicroPythonOS/MicroPythonOS/pull/178/{{ revealButtonHref }}
https://github.com/MicroPythonOS/MicroPythonOS/pull/178/files#diff-5823196f5124b9a2d3cae91820dce8f64861ddf170e270944966543dd890b64e
https://github.com/MicroPythonOS/MicroPythonOS/pull/178/files#diff-5823196f5124b9a2d3cae91820dce8f64861ddf170e270944966543dd890b64e
https://github.com/MicroPythonOS/MicroPythonOS/pull/178/files#diff-5823196f5124b9a2d3cae91820dce8f64861ddf170e270944966543dd890b64e
https://github.com/MicroPythonOS/MicroPythonOS/pull/178/files#diff-5823196f5124b9a2d3cae91820dce8f64861ddf170e270944966543dd890b64e
https://github.com/MicroPythonOS/MicroPythonOS/pull/178/files#diff-5823196f5124b9a2d3cae91820dce8f64861ddf170e270944966543dd890b64e
https://github.com/MicroPythonOS/MicroPythonOS/pull/178/files#diff-5823196f5124b9a2d3cae91820dce8f64861ddf170e270944966543dd890b64e
Please reload this pagehttps://github.com/MicroPythonOS/MicroPythonOS/pull/178/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.