René's URL Explorer Experiment


Title: Generator: Fix condition on which shell classes are generated by usiems · Pull Request #374 · MeVisLab/pythonqt · GitHub

Open Graph Title: Generator: Fix condition on which shell classes are generated by usiems · Pull Request #374 · MeVisLab/pythonqt

X Title: Generator: Fix condition on which shell classes are generated by usiems · Pull Request #374 · MeVisLab/pythonqt

Description: Shell classes are a mechanism in generated wrapper code by which Python code can override virtual methods of wrapped classes. They are derived from the wrapped classes and override all virtual methods to first look for a Python implementation. We have now noticed that these shell classes are also generated for classes that are not virtual at all. This has the big problem that the destructor of such an overridden class also is not virtual, so that that the destructor of such a shell class is never called, just the destructor of the base class. Also the shell classes didn't serve any purpose, since there were no virtual functions. (This is not the whole truth, the shell classes were also needed if there were protected constructors one wanted to use in a derived class, but a virtual destructor is still a hard requirement for a shell class to work correctly.) The fix is to change the condition on which shell classes are generated to include a check if the destructor is virtual, and some other condition fixes. The PR also contains some minor related clean-ups. I compared the generated wrappers for Qt 6.11.2 with the previous state, and didn't notice any problematic omissions of shell classes.

Open Graph Description: Shell classes are a mechanism in generated wrapper code by which Python code can override virtual methods of wrapped classes. They are derived from the wrapped classes and override all virtual meth...

X Description: Shell classes are a mechanism in generated wrapper code by which Python code can override virtual methods of wrapped classes. They are derived from the wrapped classes and override all virtual meth...

Opengraph URL: https://github.com/MeVisLab/pythonqt/pull/374

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:12c42fe0-9f03-d008-3039-9fcfb42b48aa
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCB74:5875E:53646C:7132A8:6AFF84FD
html-safe-nonceaa2a7b3fd8e25c2b84f9e1ffdfe0d32e4236cfd32025f32ab13b4bb914a91d75
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQjc0OjU4NzVFOjUzNjQ2Qzo3MTMyQTg6NkFGRjg0RkQiLCJ2aXNpdG9yX2lkIjoiODkxMzI3ODA0MTI4MzU5MzQ2OSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacbbdbd3b6f77a58780affeb68c2100891ca7744d1e8094f10ec1fe24739e59aa1
hovercard-subject-tagpull_request:5297695296
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/MeVisLab/pythonqt/pull/374/files
twitter:imagehttps://avatars.githubusercontent.com/u/52000888?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/52000888?s=400&v=4
og:image:altShell classes are a mechanism in generated wrapper code by which Python code can override virtual methods of wrapped classes. They are derived from the wrapped classes and override all virtual meth...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None19488db4031f00b04ea79b4c70b5dd32cfa873a8d20b3877f3896b8e2d195946
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/MeVisLab/pythonqt git https://github.com/MeVisLab/pythonqt.git
octolytics-dimension-user_id15028021
octolytics-dimension-user_loginMeVisLab
octolytics-dimension-repository_id193056137
octolytics-dimension-repository_nwoMeVisLab/pythonqt
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id193056137
octolytics-dimension-repository_network_root_nwoMeVisLab/pythonqt
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7952f5285f4ba685d70c4c7540ad3cc9dc9746b8
ui-targetcanary-2
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/MeVisLab/pythonqt/pull/374/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FMeVisLab%2Fpythonqt%2Fpull%2F374%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FMeVisLab%2Fpythonqt%2Fpull%2F374%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=MeVisLab%2Fpythonqt
Reloadhttps://github.com/MeVisLab/pythonqt/pull/374/files
Reloadhttps://github.com/MeVisLab/pythonqt/pull/374/files
Reloadhttps://github.com/MeVisLab/pythonqt/pull/374/files
MeVisLabhttps://github.com/MeVisLab
pythonqthttps://github.com/MeVisLab/pythonqt
Codehttps://github.com/MeVisLab/pythonqt
Issues19 (19)https://github.com/MeVisLab/pythonqt/issues
Pull requests3 (3)https://github.com/MeVisLab/pythonqt/pulls
Discussionshttps://github.com/MeVisLab/pythonqt/discussions
Actionshttps://github.com/MeVisLab/pythonqt/actions
Security and qualityhttps://github.com/MeVisLab/pythonqt/security
Insightshttps://github.com/MeVisLab/pythonqt/insights
Sign up for GitHub https://github.com/signup?return_to=%2FMeVisLab%2Fpythonqt%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FMeVisLab%2Fpythonqt%2Fissues%2Fnew%2Fchoose
usiemshttps://github.com/usiems
mainhttps://github.com/MeVisLab/pythonqt/tree/main
fix_shell_class_generationhttps://github.com/MeVisLab/pythonqt/tree/fix_shell_class_generation
Conversation 5 https://github.com/MeVisLab/pythonqt/pull/374
Commits 4 https://github.com/MeVisLab/pythonqt/pull/374/commits
Checks 16 https://github.com/MeVisLab/pythonqt/pull/374/checks
Files changed https://github.com/MeVisLab/pythonqt/pull/374/files
Please reload this pagehttps://github.com/MeVisLab/pythonqt/pull/374/files
Generator: Fix condition on which shell classes are generated https://github.com/MeVisLab/pythonqt/pull/374/files#top
Show all changes 4 commits https://github.com/MeVisLab/pythonqt/pull/374/files
1f63396 Do not create shell classes because of protected functions usiems Nov 12, 2026 https://github.com/MeVisLab/pythonqt/pull/374/commits/1f6339626a414a03a7637a598648f21bce2cf7a9
3655a2f Field accessors are only generated for public members usiems Nov 12, 2026 https://github.com/MeVisLab/pythonqt/pull/374/commits/3655a2fa99395d00f25f7f0d6acc9b8f2b6ea529
e6e29ec Remember/re-use the result of AbstractMetaClass::generateShellClass() usiems Nov 12, 2026 https://github.com/MeVisLab/pythonqt/pull/374/commits/e6e29ec9699b052b3bc68d87ebbf06508e25dde3
b3f319d Remove a bunch of unused methods usiems Nov 16, 2026 https://github.com/MeVisLab/pythonqt/pull/374/commits/b3f319d724a6c6325b2139490a299bbccced5ebf
Clear filters https://github.com/MeVisLab/pythonqt/pull/374/files
Please reload this pagehttps://github.com/MeVisLab/pythonqt/pull/374/files
Please reload this pagehttps://github.com/MeVisLab/pythonqt/pull/374/files
abstractmetalang.cpp https://github.com/MeVisLab/pythonqt/pull/374/files#diff-6f7c57ed3b5f624b009b279aade162714a921c8f6ac8a8b8ab2b99e610e30b56
abstractmetalang.h https://github.com/MeVisLab/pythonqt/pull/374/files#diff-947682d223c1ba279e69a5f86161fa828332ed242ed4eee38717a65520d6cf2c
shellheadergenerator.cpp https://github.com/MeVisLab/pythonqt/pull/374/files#diff-9985d229d0855acccbea2a291b229d84eb0e1b4ac8a9debd6066483c7027a47b
shellimplgenerator.cpp https://github.com/MeVisLab/pythonqt/pull/374/files#diff-feaaa9d83cb088e0f3f39cdba7f210610bd17c4ce28cd5fa9ecc47a4b8a7f13a
generator/abstractmetalang.cpphttps://github.com/MeVisLab/pythonqt/pull/374/files#diff-6f7c57ed3b5f624b009b279aade162714a921c8f6ac8a8b8ab2b99e610e30b56
View file https://github.com/MeVisLab/pythonqt/blob/b3f319d724a6c6325b2139490a299bbccced5ebf/generator/abstractmetalang.cpp
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/MeVisLab/pythonqt/pull/374/{{ revealButtonHref }}
https://github.com/MeVisLab/pythonqt/pull/374/files#diff-6f7c57ed3b5f624b009b279aade162714a921c8f6ac8a8b8ab2b99e610e30b56
https://github.com/MeVisLab/pythonqt/pull/374/files#diff-6f7c57ed3b5f624b009b279aade162714a921c8f6ac8a8b8ab2b99e610e30b56
https://github.com/MeVisLab/pythonqt/pull/374/files#diff-6f7c57ed3b5f624b009b279aade162714a921c8f6ac8a8b8ab2b99e610e30b56
https://github.com/MeVisLab/pythonqt/pull/374/files#diff-6f7c57ed3b5f624b009b279aade162714a921c8f6ac8a8b8ab2b99e610e30b56
https://github.com/MeVisLab/pythonqt/pull/374/files#diff-6f7c57ed3b5f624b009b279aade162714a921c8f6ac8a8b8ab2b99e610e30b56
https://github.com/MeVisLab/pythonqt/pull/374/files#diff-6f7c57ed3b5f624b009b279aade162714a921c8f6ac8a8b8ab2b99e610e30b56
https://github.com/MeVisLab/pythonqt/pull/374/files#diff-6f7c57ed3b5f624b009b279aade162714a921c8f6ac8a8b8ab2b99e610e30b56
https://github.com/MeVisLab/pythonqt/pull/374/files#diff-6f7c57ed3b5f624b009b279aade162714a921c8f6ac8a8b8ab2b99e610e30b56
https://github.com/MeVisLab/pythonqt/pull/374/files#diff-6f7c57ed3b5f624b009b279aade162714a921c8f6ac8a8b8ab2b99e610e30b56
https://github.com/MeVisLab/pythonqt/pull/374/files#diff-6f7c57ed3b5f624b009b279aade162714a921c8f6ac8a8b8ab2b99e610e30b56
generator/abstractmetalang.hhttps://github.com/MeVisLab/pythonqt/pull/374/files#diff-947682d223c1ba279e69a5f86161fa828332ed242ed4eee38717a65520d6cf2c
View file https://github.com/MeVisLab/pythonqt/blob/b3f319d724a6c6325b2139490a299bbccced5ebf/generator/abstractmetalang.h
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/MeVisLab/pythonqt/pull/374/{{ revealButtonHref }}
https://github.com/MeVisLab/pythonqt/pull/374/files#diff-947682d223c1ba279e69a5f86161fa828332ed242ed4eee38717a65520d6cf2c
https://github.com/MeVisLab/pythonqt/pull/374/files#diff-947682d223c1ba279e69a5f86161fa828332ed242ed4eee38717a65520d6cf2c
https://github.com/MeVisLab/pythonqt/pull/374/files#diff-947682d223c1ba279e69a5f86161fa828332ed242ed4eee38717a65520d6cf2c
https://github.com/MeVisLab/pythonqt/pull/374/files#diff-947682d223c1ba279e69a5f86161fa828332ed242ed4eee38717a65520d6cf2c
https://github.com/MeVisLab/pythonqt/pull/374/files#diff-947682d223c1ba279e69a5f86161fa828332ed242ed4eee38717a65520d6cf2c
https://github.com/MeVisLab/pythonqt/pull/374/files#diff-947682d223c1ba279e69a5f86161fa828332ed242ed4eee38717a65520d6cf2c
generator/shellheadergenerator.cpphttps://github.com/MeVisLab/pythonqt/pull/374/files#diff-9985d229d0855acccbea2a291b229d84eb0e1b4ac8a9debd6066483c7027a47b
View file https://github.com/MeVisLab/pythonqt/blob/b3f319d724a6c6325b2139490a299bbccced5ebf/generator/shellheadergenerator.cpp
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/MeVisLab/pythonqt/pull/374/{{ revealButtonHref }}
https://github.com/MeVisLab/pythonqt/pull/374/files#diff-9985d229d0855acccbea2a291b229d84eb0e1b4ac8a9debd6066483c7027a47b
https://github.com/MeVisLab/pythonqt/pull/374/files#diff-9985d229d0855acccbea2a291b229d84eb0e1b4ac8a9debd6066483c7027a47b
https://github.com/MeVisLab/pythonqt/pull/374/files#diff-9985d229d0855acccbea2a291b229d84eb0e1b4ac8a9debd6066483c7027a47b
https://github.com/MeVisLab/pythonqt/pull/374/files#diff-9985d229d0855acccbea2a291b229d84eb0e1b4ac8a9debd6066483c7027a47b
https://github.com/MeVisLab/pythonqt/pull/374/files#diff-9985d229d0855acccbea2a291b229d84eb0e1b4ac8a9debd6066483c7027a47b
generator/shellimplgenerator.cpphttps://github.com/MeVisLab/pythonqt/pull/374/files#diff-feaaa9d83cb088e0f3f39cdba7f210610bd17c4ce28cd5fa9ecc47a4b8a7f13a
View file https://github.com/MeVisLab/pythonqt/blob/b3f319d724a6c6325b2139490a299bbccced5ebf/generator/shellimplgenerator.cpp
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/MeVisLab/pythonqt/pull/374/{{ revealButtonHref }}
https://github.com/MeVisLab/pythonqt/pull/374/files#diff-feaaa9d83cb088e0f3f39cdba7f210610bd17c4ce28cd5fa9ecc47a4b8a7f13a
https://github.com/MeVisLab/pythonqt/pull/374/files#diff-feaaa9d83cb088e0f3f39cdba7f210610bd17c4ce28cd5fa9ecc47a4b8a7f13a
https://github.com/MeVisLab/pythonqt/pull/374/files#diff-feaaa9d83cb088e0f3f39cdba7f210610bd17c4ce28cd5fa9ecc47a4b8a7f13a
https://github.com/MeVisLab/pythonqt/pull/374/files#diff-feaaa9d83cb088e0f3f39cdba7f210610bd17c4ce28cd5fa9ecc47a4b8a7f13a
https://github.com/MeVisLab/pythonqt/pull/374/files#diff-feaaa9d83cb088e0f3f39cdba7f210610bd17c4ce28cd5fa9ecc47a4b8a7f13a
Please reload this pagehttps://github.com/MeVisLab/pythonqt/pull/374/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.