René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Exception on timeout from connection pool acquire","articleBody":"\u003c!--\r\nThank you for reporting an issue/feature request.\r\n\r\nIf this is a feature request, please disregard this template.  If this is\r\na bug report, please answer to the questions below.\r\n\r\nIt will be much easier for us to fix the issue if a test case that reproduces\r\nthe problem is provided, with clear instructions on how to run it.\r\n\r\nThank you!\r\n--\u003e\r\n\r\n* **asyncpg version**: v0.20.0\r\n* **PostgreSQL version**: 11\r\n* **Do you use a PostgreSQL SaaS?  If so, which?  Can you reproduce\r\n  the issue with a local PostgreSQL install?**:\r\n* **Python version**: 3.7\r\n* **Platform**: Ubuntu\r\n* **Do you use pgbouncer?**: No\r\n* **Did you install asyncpg with pip?**: Yes\r\n* **If you built asyncpg locally, which version of Cython did you use?**:\r\n* **Can the issue be reproduced under both asyncio and\r\n  [uvloop](https://github.com/magicstack/uvloop)?**: Idk, probably.\r\n\r\nThis one fixes timeout error\r\nhttps://github.com/MagicStack/asyncpg/pull/468\r\n\r\nThis one line breaks it.\r\n\r\nhttps://github.com/MagicStack/asyncpg/commit/bdba7ce73324a7a87a8c854de7b5e881ea029744#diff-8424be9bb2792628343ee98369a5cf74L529\r\n\r\n\r\n\r\n```\r\n22:13:29 ERROR [/usr/lib/python3.7/asyncio/base_events.py:1608] Task exception was never retrieved\r\nfuture: \u003cTask finished coro=\u003cPool._acquire.\u003clocals\u003e._acquire_impl() done, defined at .venv/lib/python3.7/site-packages/asyncpg/pool.py:595\u003e exception=AttributeError(\"'coroutine' object has no attribute 'add_done_callback'\")\u003e\r\nTraceback (most recent call last):\r\n  File \".venv/lib/python3.7/site-packages/asyncpg/connect_utils.py\", line 621, in _connect_addr\r\n    connector, timeout=timeout)\r\n  File \"/usr/lib/python3.7/asyncio/tasks.py\", line 409, in wait_for\r\n    await waiter\r\nconcurrent.futures._base.CancelledError\r\n\r\nDuring handling of the above exception, another exception occurred:\r\n\r\nTraceback (most recent call last):\r\n  File \".venv/lib/python3.7/site-packages/asyncpg/pool.py\", line 598, in _acquire_impl\r\n    proxy = await ch.acquire()  # type: PoolConnectionProxy\r\n  File \".venv/lib/python3.7/site-packages/asyncpg/pool.py\", line 133, in acquire\r\n    await self.connect()\r\n  File \".venv/lib/python3.7/site-packages/asyncpg/pool.py\", line 125, in connect\r\n    self._con = await self._pool._get_new_connection()\r\n  File \".venv/lib/python3.7/site-packages/asyncpg/pool.py\", line 472, in _get_new_connection\r\n    **self._connect_kwargs)\r\n  File \".venv/lib/python3.7/site-packages/asyncpg/connection.py\", line 1677, in connect\r\n    max_cacheable_statement_size=max_cacheable_statement_size)\r\n  File \".venv/lib/python3.7/site-packages/asyncpg/connect_utils.py\", line 654, in _connect\r\n    connection_class=connection_class)\r\n  File \".venv/lib/python3.7/site-packages/asyncpg/connect_utils.py\", line 623, in _connect_addr\r\n    connector.add_done_callback(_close_leaked_connection)\r\nAttributeError: 'coroutine' object has no attribute 'add_done_callback'\r\n```","author":{"url":"https://github.com/masell","@type":"Person","name":"masell"},"datePublished":"2019-11-28T22:22:18.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":0},"url":"https://github.com/509/asyncpg/issues/509"}