Title: Please revert to VS2017-compatible build for Numpy · Issue #145 · MacPython/numpy-wheels · GitHub
Open Graph Title: Please revert to VS2017-compatible build for Numpy · Issue #145 · MacPython/numpy-wheels
X Title: Please revert to VS2017-compatible build for Numpy · Issue #145 · MacPython/numpy-wheels
Description: Summary The 1.22 series are using the latest VS2019 toolchain (version 142). This makes the built objects and static libraries incompatible with software built with older toolchains. Would you accept a PR to use the older VS2017 version ...
Open Graph Description: Summary The 1.22 series are using the latest VS2019 toolchain (version 142). This makes the built objects and static libraries incompatible with software built with older toolchains. Would you acce...
X Description: Summary The 1.22 series are using the latest VS2019 toolchain (version 142). This makes the built objects and static libraries incompatible with software built with older toolchains. Would you acce...
Opengraph URL: https://github.com/MacPython/numpy-wheels/issues/145
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Please revert to VS2017-compatible build for Numpy","articleBody":"## Summary\r\n\r\nThe 1.22 series are using the latest VS2019 toolchain (version 142). This makes the built objects and static libraries incompatible with software built with older toolchains. Would you accept a PR to use the older VS2017 version 141 toolchain instead?\r\n\r\n## Detail\r\n\r\nThe Numpy 1.22 series wheels are breaking the Scipy MinGW-w64 builds.\r\n\r\nI believe this is because y'all have updated from the previous VS2017 toolchain (version 141) to the latest VS2019 toolchain (version 142). \r\n\r\nAs [MS point out](https://docs.microsoft.com/en-us/cpp/porting/binary-compat-2015-2017?view=msvc-170), using version 142 to build the static libraries means that anyone linking against those libraries must also be using (at least) this toolchain.\r\n\r\nThis means that projects like Scipy can't link to Numpy without also updating to version 142.\r\n\r\nIn fact, for Scipy, it also, and presumably for similar reasons, breaks our ability to link using MinGW-w64:\r\n\r\nhttps://github.com/matthew-brett/dll_investigation/issues/1\r\n\r\nI believe, for these reasons, conda-forge has standardized to version 141 for their builds.\r\n\r\nWould y'all consider following conda-forge, and using the 141 toolchain for builds, so that more of us can safely\r\nlink to Numpy - particularly - npymath?\r\n\r\n@isuruf tells me that this just requires the following lines for a Visual Studio 2019 image:\r\n\r\n```\r\ncall \"C:\\Program Files (x86)\\Microsoft Visual Studio\\2019\\Enterprise\\VC\\Auxiliary\\Build\\vcvars64.bat\" -vcvars_ver=14.16\r\nset DISTUTILS_USE_SDK=1\r\n```\r\n\r\n@isuruf points out that\r\n\r\n\u003e Last part is to make sure that distutils doesn't try to override that if you are using distutils.\r\n\r\n@rgommers @carlkl","author":{"url":"https://github.com/matthew-brett","@type":"Person","name":"matthew-brett"},"datePublished":"2022-01-22T18:52:02.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":26},"url":"https://github.com/145/numpy-wheels/issues/145"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:02d783a7-1ead-e892-72b8-971d810c4365 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | CC36:5B712:B95E36:108A360:6A579A71 |
| html-safe-nonce | 19e725baee47306a9e93b94b6cde059e0dbc62f32535985f640a12f747ab0136 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQzM2OjVCNzEyOkI5NUUzNjoxMDhBMzYwOjZBNTc5QTcxIiwidmlzaXRvcl9pZCI6IjEwNjk0NjI1NjA4ODg1NjAyNDEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 7f1bf474a63169836cf2bfbe1813aa68133d19c15ded8f9dcf59dbbe18fb7417 |
| hovercard-subject-tag | issue:1111656568 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/MacPython/numpy-wheels/145/issue_layout |
| twitter:image | https://opengraph.githubassets.com/d534a8440924b43daa3dcf5c0bc4dfdd944f58e3f82d257b2ce603a9ee51ea6b/MacPython/numpy-wheels/issues/145 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/d534a8440924b43daa3dcf5c0bc4dfdd944f58e3f82d257b2ce603a9ee51ea6b/MacPython/numpy-wheels/issues/145 |
| og:image:alt | Summary The 1.22 series are using the latest VS2019 toolchain (version 142). This makes the built objects and static libraries incompatible with software built with older toolchains. Would you acce... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | matthew-brett |
| hostname | github.com |
| expected-hostname | github.com |
| None | 017a07c29bdd8a37b5907fc9a689338deb7103b5af7f56714193b2700229b3df |
| turbo-cache-control | no-preview |
| go-import | github.com/MacPython/numpy-wheels git https://github.com/MacPython/numpy-wheels.git |
| octolytics-dimension-user_id | 5271335 |
| octolytics-dimension-user_login | MacPython |
| octolytics-dimension-repository_id | 22896588 |
| octolytics-dimension-repository_nwo | MacPython/numpy-wheels |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 22896588 |
| octolytics-dimension-repository_network_root_nwo | MacPython/numpy-wheels |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 0dd6847d644323df8f8c1368c065f9f630095e3b |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width