Title: Throttled Handler doesn't delete failed handle connections · Issue #88 · Ktt-Development/simplehttpserver · GitHub
Open Graph Title: Throttled Handler doesn't delete failed handle connections · Issue #88 · Ktt-Development/simplehttpserver
X Title: Throttled Handler doesn't delete failed handle connections · Issue #88 · Ktt-Development/simplehttpserver
Description: Prerequisites If all checks are not passed then the issue will be closed I have checked that no other similar issue already exists Operating System: Operating system name and version Windows 10 Release Version: Release version or branch ...
Open Graph Description: Prerequisites If all checks are not passed then the issue will be closed I have checked that no other similar issue already exists Operating System: Operating system name and version Windows 10 Rel...
X Description: Prerequisites If all checks are not passed then the issue will be closed I have checked that no other similar issue already exists Operating System: Operating system name and version Windows 10 Rel...
Opengraph URL: https://github.com/Ktt-Development/simplehttpserver/issues/88
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Throttled Handler doesn't delete failed handle connections","articleBody":"### Prerequisites\r\n*If **all** checks are not passed then the issue will be closed*\r\n- [x] I have checked that no other similar issue already exists\r\n\r\n\r\n**Operating System:** *Operating system name and version*\r\nWindows 10\r\n\r\n**Release Version:** *Release version or branch where the issue occurred*\r\n03.05.06\r\n\r\n### Issue\r\n*Explain your issue. Add any screenshots here*\r\n\r\nIf an exception is thrown in `#handle` the connection will not be deleted, despite being handled. This can cause ghost connections.\r\n\r\nhttps://github.com/Ktt-Development/simplehttpserver/blob/77e9449d6cc75729bd9d4b0eb8128fe9541de676/src/main/java/com/kttdevelopment/simplehttpserver/handler/ThrottledHandler.java#L43-L51\r\n\r\n### Expected Behavior\r\n*Explain what was supposed to happen*\r\n\r\nConnections should be deleted after handle (use a try finally).\r\n\r\n### Steps To Reproduce\r\n*Explain how and/or when the error occurred*\r\n\r\nThrow an exception in throttled handler.\r\n","author":{"url":"https://github.com/Katsute","@type":"Person","name":"Katsute"},"datePublished":"2020-08-11T14:57:35.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":0},"url":"https://github.com/88/simplehttpserver/issues/88"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:b1f179e5-609c-c98f-5d7a-cd627307c853 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | DC6E:2764F4:185C795:20782CE:69704114 |
| html-safe-nonce | 55bd1c2b046a6bf10dde62e1f7f1637ee1b31c57dc8efb7a56f0529a08cd2c5b |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQzZFOjI3NjRGNDoxODVDNzk1OjIwNzgyQ0U6Njk3MDQxMTQiLCJ2aXNpdG9yX2lkIjoiODUyNDMyODY1NDc4OTk1MTc2NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 2da4f00c576b3834402f87576b179eba416f6cd3d6d930aba0bc7daec4cc1540 |
| hovercard-subject-tag | issue:676947478 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/Ktt-Development/simplehttpserver/88/issue_layout |
| twitter:image | https://opengraph.githubassets.com/ed279cf224c91fe85f4e68d85f5b9f9f435a669f370993f4b11156595c918316/Ktt-Development/simplehttpserver/issues/88 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/ed279cf224c91fe85f4e68d85f5b9f9f435a669f370993f4b11156595c918316/Ktt-Development/simplehttpserver/issues/88 |
| og:image:alt | Prerequisites If all checks are not passed then the issue will be closed I have checked that no other similar issue already exists Operating System: Operating system name and version Windows 10 Rel... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | Katsute |
| hostname | github.com |
| expected-hostname | github.com |
| None | 9920a62ba22d06470388e2904804fb7e5ec51c9e35f81784e9191394c74b2bd2 |
| turbo-cache-control | no-preview |
| go-import | github.com/Ktt-Development/simplehttpserver git https://github.com/Ktt-Development/simplehttpserver.git |
| octolytics-dimension-user_id | 58783525 |
| octolytics-dimension-user_login | Ktt-Development |
| octolytics-dimension-repository_id | 227455248 |
| octolytics-dimension-repository_nwo | Ktt-Development/simplehttpserver |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 227455248 |
| octolytics-dimension-repository_network_root_nwo | Ktt-Development/simplehttpserver |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | f643964067a552f02067066d6a910b2f90a5721f |
| ui-target | canary-2 |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width