René's URL Explorer Experiment


Title: fix: handle comments at the end of sql without a trailing newline by mlilius · Pull Request #38 · JavaScriptor/js-sql-parser · GitHub

Open Graph Title: fix: handle comments at the end of sql without a trailing newline by mlilius · Pull Request #38 · JavaScriptor/js-sql-parser

X Title: fix: handle comments at the end of sql without a trailing newline by mlilius · Pull Request #38 · JavaScriptor/js-sql-parser

Description: If the sql string ends with a comment without a trailing newline it fails. This change make it handle this case. I included a test for this as well.

Open Graph Description: If the sql string ends with a comment without a trailing newline it fails. This change make it handle this case. I included a test for this as well.

X Description: If the sql string ends with a comment without a trailing newline it fails. This change make it handle this case. I included a test for this as well.

Opengraph URL: https://github.com/JavaScriptor/js-sql-parser/pull/38

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:22521e65-e4ed-2d0b-7dae-76485e47efb7
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC026:211079:11B2F77:1803D72:696E9D6C
html-safe-nonceca650c9478e2af31039107fea322303e32e297f3ae066f76417bd910b3b63ce0
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMDI2OjIxMTA3OToxMUIyRjc3OjE4MDNENzI6Njk2RTlENkMiLCJ2aXNpdG9yX2lkIjoiMzkwNDkwNDkwMDU5MTM5NDE1NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac55bbed3e116abbca6e833d796988e78260b6e30709fe20f18450f0fc5b50ba47
hovercard-subject-tagpull_request:420433311
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/JavaScriptor/js-sql-parser/38/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/78d4556da790dab3c26038dd0ba764d97b4a4bbe2be248def043cae34e593575/JavaScriptor/js-sql-parser/pull/38
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/78d4556da790dab3c26038dd0ba764d97b4a4bbe2be248def043cae34e593575/JavaScriptor/js-sql-parser/pull/38
og:image:altIf the sql string ends with a comment without a trailing newline it fails. This change make it handle this case. I included a test for this as well.
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemlilius
hostnamegithub.com
expected-hostnamegithub.com
Nonefdad15fd2ad43212aa8b8be5f2c2725550f8374ceeeb154a999ad9145b43f3f7
turbo-cache-controlno-preview
go-importgithub.com/JavaScriptor/js-sql-parser git https://github.com/JavaScriptor/js-sql-parser.git
octolytics-dimension-user_id14047812
octolytics-dimension-user_loginJavaScriptor
octolytics-dimension-repository_id71266724
octolytics-dimension-repository_nwoJavaScriptor/js-sql-parser
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id71266724
octolytics-dimension-repository_network_root_nwoJavaScriptor/js-sql-parser
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release27b23bc056eb973d350fc95afc848757edb9e7a9
ui-targetcanary-1
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/JavaScriptor/js-sql-parser/pull/38#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FJavaScriptor%2Fjs-sql-parser%2Fpull%2F38
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FJavaScriptor%2Fjs-sql-parser%2Fpull%2F38
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=JavaScriptor%2Fjs-sql-parser
Reloadhttps://github.com/JavaScriptor/js-sql-parser/pull/38
Reloadhttps://github.com/JavaScriptor/js-sql-parser/pull/38
Reloadhttps://github.com/JavaScriptor/js-sql-parser/pull/38
JavaScriptor https://github.com/JavaScriptor
js-sql-parserhttps://github.com/JavaScriptor/js-sql-parser
Notifications https://github.com/login?return_to=%2FJavaScriptor%2Fjs-sql-parser
Fork 46 https://github.com/login?return_to=%2FJavaScriptor%2Fjs-sql-parser
Star 256 https://github.com/login?return_to=%2FJavaScriptor%2Fjs-sql-parser
Code https://github.com/JavaScriptor/js-sql-parser
Issues 11 https://github.com/JavaScriptor/js-sql-parser/issues
Pull requests 7 https://github.com/JavaScriptor/js-sql-parser/pulls
Discussions https://github.com/JavaScriptor/js-sql-parser/discussions
Actions https://github.com/JavaScriptor/js-sql-parser/actions
Projects 0 https://github.com/JavaScriptor/js-sql-parser/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/JavaScriptor/js-sql-parser/security
Please reload this pagehttps://github.com/JavaScriptor/js-sql-parser/pull/38
Insights https://github.com/JavaScriptor/js-sql-parser/pulse
Code https://github.com/JavaScriptor/js-sql-parser
Issues https://github.com/JavaScriptor/js-sql-parser/issues
Pull requests https://github.com/JavaScriptor/js-sql-parser/pulls
Discussions https://github.com/JavaScriptor/js-sql-parser/discussions
Actions https://github.com/JavaScriptor/js-sql-parser/actions
Projects https://github.com/JavaScriptor/js-sql-parser/projects
Security https://github.com/JavaScriptor/js-sql-parser/security
Insights https://github.com/JavaScriptor/js-sql-parser/pulse
Sign up for GitHub https://github.com/signup?return_to=%2FJavaScriptor%2Fjs-sql-parser%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FJavaScriptor%2Fjs-sql-parser%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/JavaScriptor/js-sql-parser/pull/38#issue-comment-box
mliliushttps://github.com/mlilius
JavaScriptor:masterhttps://github.com/JavaScriptor/js-sql-parser/tree/master
mlilius:comment-wo-newlinehttps://github.com/mlilius/js-sql-parser/tree/comment-wo-newline
fix: handle comments at the end of sql without a trailing newline https://github.com/JavaScriptor/js-sql-parser/pull/38#top
mliliushttps://github.com/mlilius
JavaScriptor:masterhttps://github.com/JavaScriptor/js-sql-parser/tree/master
mlilius:comment-wo-newlinehttps://github.com/mlilius/js-sql-parser/tree/comment-wo-newline
Conversation 0 https://github.com/JavaScriptor/js-sql-parser/pull/38
Commits 4 https://github.com/JavaScriptor/js-sql-parser/pull/38/commits
Checks 0 https://github.com/JavaScriptor/js-sql-parser/pull/38/checks
Files changed https://github.com/JavaScriptor/js-sql-parser/pull/38/files
Please reload this pagehttps://github.com/JavaScriptor/js-sql-parser/pull/38
https://github.co/hiddenchars
https://github.com/JavaScriptor/js-sql-parser/pull/{{ revealButtonHref }}
https://github.com/mlilius
mliliushttps://github.com/mlilius
May 20, 2020https://github.com/JavaScriptor/js-sql-parser/pull/38#issue-621366793
Please reload this pagehttps://github.com/JavaScriptor/js-sql-parser/pull/38
mliliushttps://github.com/mlilius
May 19, 2020 17:17https://github.com/JavaScriptor/js-sql-parser/pull/38#commits-pushed-82c7393
https://github.com/mlilius
Handle comments at the end without a trailing newlinehttps://github.com/JavaScriptor/js-sql-parser/pull/38/commits/82c73931eb70295f8e30ad2ac2e3118bd4d4c500
82c7393https://github.com/JavaScriptor/js-sql-parser/pull/38/commits/82c73931eb70295f8e30ad2ac2e3118bd4d4c500
https://github.com/mlilius
fixed testhttps://github.com/JavaScriptor/js-sql-parser/pull/38/commits/f8549eaf8b3901e0b514136f7a29b4aafc5f6de8
f8549eahttps://github.com/JavaScriptor/js-sql-parser/pull/38/commits/f8549eaf8b3901e0b514136f7a29b4aafc5f6de8
https://github.com/mlilius
Simplified testhttps://github.com/JavaScriptor/js-sql-parser/pull/38/commits/cf272f4f96c76b8619f21869dde29ab811505f5a
cf272f4https://github.com/JavaScriptor/js-sql-parser/pull/38/commits/cf272f4f96c76b8619f21869dde29ab811505f5a
https://github.com/mlilius
Fixed a typohttps://github.com/JavaScriptor/js-sql-parser/pull/38/commits/00def87f53d60c1c6715a86b3b884c668d70dd02
00def87https://github.com/JavaScriptor/js-sql-parser/pull/38/commits/00def87f53d60c1c6715a86b3b884c668d70dd02
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FJavaScriptor%2Fjs-sql-parser%2Fpull%2F38
Please reload this pagehttps://github.com/JavaScriptor/js-sql-parser/pull/38
https://github.com/mlilius
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.