Title: Fix relative URI resolution for acl:agent by melvincarvalho · Pull Request #65 · JavaScriptSolidServer/JavaScriptSolidServer · GitHub
Open Graph Title: Fix relative URI resolution for acl:agent by melvincarvalho · Pull Request #65 · JavaScriptSolidServer/JavaScriptSolidServer
X Title: Fix relative URI resolution for acl:agent by melvincarvalho · Pull Request #65 · JavaScriptSolidServer/JavaScriptSolidServer
Description: Summary Resolve agent URIs against the ACL URL so that relative references like ./#me correctly match the authenticated WebID Problem When using a relative URI like ./#me in an ACL file to reference the owner's WebID, it wasn't matching the authenticated user's WebID during authorization checks, resulting in 403 Forbidden. The issue was that accessTo and default URIs were being resolved against the base URL, but agents were not: // These were resolved: auth.accessTo = parseUriArray(...).map(uri => resolveUri(uri, baseUrl)); auth.default = parseUriArray(...).map(uri => resolveUri(uri, baseUrl)); // But agents were NOT resolved: auth.agents = parseUriArray(node['acl:agent'] || node['agent']); // Bug! Fix One-line change to resolve agent URIs against the ACL URL: auth.agents = parseUriArray(node['acl:agent'] || node['agent']) .map(uri => resolveUri(uri, aclUrl)); Note: We resolve against aclUrl (not baseUrl) because ./#me in /.acl should resolve to https://example.com/#me. Test plan Tested on live server (melvincarvalho.com) Verify ./#me in ACL matches authenticated WebID Verify absolute URIs still work unchanged Fixes #64
Open Graph Description: Summary Resolve agent URIs against the ACL URL so that relative references like ./#me correctly match the authenticated WebID Problem When using a relative URI like ./#me in an ACL file to refere...
X Description: Summary Resolve agent URIs against the ACL URL so that relative references like ./#me correctly match the authenticated WebID Problem When using a relative URI like ./#me in an ACL file to refere...
Opengraph URL: https://github.com/JavaScriptSolidServer/JavaScriptSolidServer/pull/65
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/checks(.:format) |
| route-controller | pull_requests |
| route-action | checks |
| fetch-nonce | v2:4d672a18-1915-2c43-7cfb-f617ee81840e |
| current-catalog-service-hash | 87dc3bc62d9b466312751bfd5f889726f4f1337bdff4e8be7da7c93d6c00a25a |
| request-id | DB54:1E0AAF:4678DD:60D460:69774DFA |
| html-safe-nonce | 5bbf8b2dfbbb4dfe430ed4b604eb4abc1855dc7e8f2f47e0535400e6a30735dc |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQjU0OjFFMEFBRjo0Njc4REQ6NjBENDYwOjY5Nzc0REZBIiwidmlzaXRvcl9pZCI6IjU2NjQxODAxNTU2NTIxOTc4ODIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 68ebddffc4e9929d3715ed5a948353bfa7fd512f928ef0bab4b7d90abdb246a3 |
| hovercard-subject-tag | pull_request:3152387206 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,checks,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/JavaScriptSolidServer/JavaScriptSolidServer/pull/65/checks |
| twitter:image | https://avatars.githubusercontent.com/u/65864?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/65864?s=400&v=4 |
| og:image:alt | Summary Resolve agent URIs against the ACL URL so that relative references like ./#me correctly match the authenticated WebID Problem When using a relative URI like ./#me in an ACL file to refere... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 3310064f35a62c06a4024ba37f41c06836f39376a095c2dfd2c4b693c34965be |
| turbo-cache-control | no-preview |
| go-import | github.com/JavaScriptSolidServer/JavaScriptSolidServer git https://github.com/JavaScriptSolidServer/JavaScriptSolidServer.git |
| octolytics-dimension-user_id | 205442424 |
| octolytics-dimension-user_login | JavaScriptSolidServer |
| octolytics-dimension-repository_id | 958025407 |
| octolytics-dimension-repository_nwo | JavaScriptSolidServer/JavaScriptSolidServer |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 958025407 |
| octolytics-dimension-repository_network_root_nwo | JavaScriptSolidServer/JavaScriptSolidServer |
| turbo-body-classes | logged-out env-production page-responsive full-width full-width-p-0 |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 67d5f8d1d53c3cc4f49fc3bb8029933c3dc219e6 |
| ui-target | canary-1 |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width