René's URL Explorer Experiment

Title: fix(parser): pass modifier to ExceptOp/MinusOp constructors (#2419) by queelius · Pull Request #2420 · JSQLParser/JSqlParser · GitHub

Open Graph Title: fix(parser): pass modifier to ExceptOp/MinusOp constructors (#2419) by queelius · Pull Request #2420 · JSQLParser/JSqlParser

X Title: fix(parser): pass modifier to ExceptOp/MinusOp constructors (#2419) by queelius · Pull Request #2420 · JSQLParser/JSqlParser

Description: Summary Fix EXCEPT ALL/DISTINCT and MINUS ALL/DISTINCT modifiers being silently dropped during parsing Reset the modifier variable between set-operation loop iterations to prevent modifier leaking from one operator to the next Problem The grammar in JSqlParserCC.jjt captures the set operation modifier via SetOperationModifier() but constructs ExceptOp and MinusOp with their no-arg constructors (which default to empty string), discarding the captured modifier. UnionOp and IntersectOp correctly receive modifier as a constructor argument. // CORRECT: modifier passed to constructor [ modifier=SetOperationModifier() ] { UnionOp union = new UnionOp(modifier); ... } [ modifier=SetOperationModifier() ] { IntersectOp intersect = new IntersectOp(modifier); ... } // BUG: modifier NOT passed to constructor [ modifier=SetOperationModifier() ] { MinusOp minus = new MinusOp(); ... } [ modifier=SetOperationModifier() ] { ExceptOp except = new ExceptOp(); ... } Additionally, the modifier variable was not reset between iterations of the (LOOKAHEAD(2) ...)+ loop, so a UNION ALL ... EXCEPT would incorrectly leak the ALL modifier to the EXCEPT. Fix Pass modifier to MinusOp(modifier) and ExceptOp(modifier) constructors Add { modifier = null; } at the start of each loop iteration Test plan testExceptAllRoundTrip - verifies EXCEPT ALL round-trips correctly testExceptDistinctRoundTrip - verifies EXCEPT DISTINCT round-trips correctly testMinusAllRoundTrip - verifies MINUS ALL round-trips correctly testMinusDistinctRoundTrip - verifies MINUS DISTINCT round-trips correctly testModifierDoesNotLeakFromUnionAllToExcept - verifies modifier doesn't leak across operators testModifierDoesNotLeakFromIntersectAllToUnion - verifies modifier doesn't leak across operators testMixedModifiersPreserved - verifies mixed modifiers in chained set ops testExceptAllSetOperationObject / testMinusAllSetOperationObject - verifies SetOperation state Full test suite passes (4671+ tests, 0 failures) Fixes #2419 🤖 Generated with Claude Code

Open Graph Description: Summary Fix EXCEPT ALL/DISTINCT and MINUS ALL/DISTINCT modifiers being silently dropped during parsing Reset the modifier variable between set-operation loop iterations to prevent modifier leaking...

X Description: Summary Fix EXCEPT ALL/DISTINCT and MINUS ALL/DISTINCT modifiers being silently dropped during parsing Reset the modifier variable between set-operation loop iterations to prevent modifier leaking...

Opengraph URL: https://github.com/JSQLParser/JSqlParser/pull/2420

X: @github

direct link

Domain: github.com

Links:

Viewport: width=device-width