René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"`:unprocessable_entity` deprecated in newest Rack, and causing a `0` response","articleBody":"## This issue is a (choose one):\r\n\r\n- [x] Problem/bug report.\r\n- [ ] Feature request.\r\n- [ ] Request for support. **Note: Please try to avoid submitting issues for support requests. Use [Gitter](https://gitter.im/cerebris/jsonapi-resources) instead.** \r\n\r\n## Checklist before submitting:\r\n\r\n- [x] I've searched for an existing issue.\r\n- [ ] I've asked my question on [Gitter](https://gitter.im/cerebris/jsonapi-resources) and have not received a satisfactory answer.\r\n- [x] I've included a complete [bug report template](https://github.com/cerebris/jsonapi-resources/blob/master/lib/bug_report_templates/rails_5_master.rb). This step helps us and allows us to see the bug without trying to reproduce the problem from your description. It helps you because you will frequently detect if it's a problem specific to your project.\r\n- [ ] The feature I'm asking for is compliant with the [JSON:API](http://jsonapi.org/) spec.\r\n\r\n## Description\r\n\r\nA [change introduced to Rack](https://github.com/rack/rack/pull/2137) deprecates the status `: unprocessable_entity ` in favour of `:unprocessable_content`. They have handled this deprecation internally, however `jsonapi-resources` retrieves the status code by directly accessing the `Rack::Utils::SYMBOL_TO_STATUS_CODE` hash. Due to the deprecation, no status is found which results in `jsonapi-resources` returning a `0` status when there are validation errors.\r\n\r\nShort term this can be fixed by using the Rack methods for status retrieval rather than accessing the hash directly. Longer term, `jsonapi-resources` will need to stop using `:unprocessable_entity` in favour of `: unprocessable_entity ` but it would have to be done in a way that checks the version of Rack.\r\n\r\n### Reproducible code:\r\n\r\n```ruby\r\nbegin\r\n  require 'bundler/inline'\r\n  require 'bundler'\r\nrescue LoadError =\u003e e\r\n  STDERR.puts 'Bundler version 1.10 or later is required. Please update your Bundler'\r\n  raise e\r\nend\r\n\r\ngemfile(true, ui: ENV['SILENT'] ? Bundler::UI::Silent.new : Bundler::UI::Shell.new) do\r\n  source 'https://rubygems.org'\r\n\r\n  gem 'rails', '7.1.3.4', require: false\r\n  gem 'sqlite3', '~\u003e 1.4'\r\n  \r\n  if ENV['JSONAPI_RESOURCES_PATH']\r\n    gem 'jsonapi-resources', path: ENV['JSONAPI_RESOURCES_PATH'], require: false\r\n  else\r\n    gem 'jsonapi-resources', git: 'https://github.com/cerebris/jsonapi-resources', require: false\r\n  end\r\n\r\nend\r\n\r\n# prepare active_record database\r\nrequire 'active_record'\r\n\r\nclass NullLogger \u003c Logger\r\n  def initialize(*_args)\r\n  end\r\n\r\n  def add(*_args, \u0026_block)\r\n  end\r\nend\r\n\r\nActiveRecord::Base.establish_connection(adapter: 'sqlite3', database: ':memory:')\r\nActiveRecord::Base.logger = ENV['SILENT'] ? NullLogger.new : Logger.new(STDOUT)\r\nActiveRecord::Migration.verbose = !ENV['SILENT']\r\n\r\nActiveRecord::Schema.define do\r\n  # Add your schema here\r\n  create_table :your_models, force: true do |t|\r\n    t.string :name\r\n  end\r\nend\r\n\r\n# create models\r\nclass YourModel \u003c ActiveRecord::Base\r\n  validates :name, presence: true\r\nend\r\n\r\n# prepare rails app\r\nrequire 'action_controller/railtie'\r\n# require 'action_view/railtie'\r\nrequire 'jsonapi-resources'\r\n\r\nclass ApplicationController \u003c ActionController::Base\r\nend\r\n\r\n# prepare jsonapi resources and controllers\r\nclass YourModelsController \u003c ApplicationController\r\n  include JSONAPI::ActsAsResourceController\r\nend\r\n\r\nclass YourModelResource \u003c JSONAPI::Resource\r\n  attribute :name\r\n  filter :name\r\nend\r\n\r\nclass TestApp \u003c Rails::Application\r\n  config.root = File.dirname(__FILE__)\r\n  config.logger = ENV['SILENT'] ? NullLogger.new : Logger.new(STDOUT)\r\n  Rails.logger = config.logger\r\n\r\n  secrets.secret_token = 'secret_token'\r\n  secrets.secret_key_base = 'secret_key_base'\r\n\r\n  config.eager_load = false\r\n\r\n  config.hosts \u003c\u003c 'example.org'\r\nend\r\n\r\n# initialize app\r\nRails.application.initialize!\r\n\r\nJSONAPI.configure do |config|\r\n  config.json_key_format = :underscored_key\r\n  config.route_format = :underscored_key\r\nend\r\n\r\n# draw routes\r\nRails.application.routes.draw do\r\n  jsonapi_resources :your_models, only: [:index, :create]\r\nend\r\n\r\n# prepare tests\r\nrequire 'minitest/autorun'\r\nrequire 'rack/test'\r\n\r\n# Replace this with the code necessary to make your test fail.\r\nclass BugTest \u003c Minitest::Test\r\n  include Rack::Test::Methods\r\n\r\n  def json_api_headers\r\n    {'Accept' =\u003e JSONAPI::MEDIA_TYPE, 'CONTENT_TYPE' =\u003e JSONAPI::MEDIA_TYPE}\r\n  end\r\n\r\n  def test_index_your_models\r\n    record = YourModel.create! name: 'John Doe'\r\n    get '/your_models', nil, json_api_headers\r\n    assert last_response.ok?\r\n    json_response = JSON.parse(last_response.body)\r\n    refute_nil json_response['data']\r\n    refute_empty json_response['data']\r\n    refute_empty json_response['data'].first \r\n    assert record.id.to_s, json_response['data'].first['id']\r\n    assert 'your_models', json_response['data'].first['type']\r\n    assert({'name' =\u003e 'John Doe'}, json_response['data'].first['attributes'])\r\n  end\r\n\r\n  def test_create_your_models\r\n    json_request = {\r\n        'data' =\u003e {\r\n            type: 'your_models',\r\n            attributes: {\r\n                name: nil\r\n            }\r\n        }\r\n    }\r\n    post '/your_models', json_request.to_json, json_api_headers\r\n    puts last_response.status\r\n    assert last_response.status == 422\r\n    refute_nil YourModel.find_by(name: 'Jane Doe')\r\n  end\r\n\r\n  private\r\n\r\n  def app\r\n    Rails.application\r\n  end\r\nend\r\n```","author":{"url":"https://github.com/pareeohnos","@type":"Person","name":"pareeohnos"},"datePublished":"2024-06-21T11:10:16.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":5},"url":"https://github.com/1456/jsonapi-resources/issues/1456"}